For tunnels, TOS ECN bits are never wildcard for the reason that they
are always inherited. OVS will create a rewrite action if we add rule
to modify other IP headers. But it also adds an extra ECN rewrite for
the action because of this ECN un-wildcarding.
It seems no error because the ECN bits to
It's dash
root@test3:~# ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Feb 17 2016 /bin/sh -> dash
Regards,
On Wed, Apr 25, 2018 at 6:24 PM, Ben Pfaff wrote:
> On April 25, 2018 8:51:01 PM EDT, aginwala wrote:
>>
>> The root cause is ovn-ctl is using sh instead of bash. Parsing works fine
>> if we
On April 25, 2018 8:51:01 PM EDT, aginwala wrote:
>The root cause is ovn-ctl is using sh instead of bash. Parsing works
>fine
>if we use bash
>
>e.g below is the comparision:
>root@test3:~# cat test.sh
>#!/bin/bash
>aaa="-vconsole:off -vfile:info"
>test(){
>c="a"
>eval local x=\$a${c}a
>echo 'log
The root cause is ovn-ctl is using sh instead of bash. Parsing works fine
if we use bash
e.g below is the comparision:
root@test3:~# cat test.sh
#!/bin/bash
aaa="-vconsole:off -vfile:info"
test(){
c="a"
eval local x=\$a${c}a
echo 'log values are '$x
}
root@test3:~# ./test.sh
log values are -vconso
On 25 April 2018 at 13:16, Ansis Atteka wrote:
> I also sent out a patch for this:
>
> Acked-by: Ansis Atteka
FYI: I pushed this to master branch.
>
> On 25 April 2018 at 12:48, Ben Pfaff wrote:
>> This fixes a broken build.
>>
>> CC: Ansis Atteka
>> Fixes: 3a2ceb01c81b ("poc: Automate buildin
物流微信联盟咱物流人的微信联盟平台微信号：lamp8023加微信可以免费发布一次物流专线资讯，物流招聘，物流求职，还可以打广告做推广，尽在物流微信联盟我们物流人的联盟平台，总有用的到的地方
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 4/25/2018 11:41 AM, Ansis Atteka wrote:
This commit fixes following error introduced by
3a2ceb01 (poc: Automate building of Fedora rpm packages):
The following files are in git but not the distribution:
poc/playbook-fedora-builder.yml
Signed-off-by: Ansis Atteka
---
Makefile.am | 1 +
1
On Wed, Apr 25, 2018 at 12:54 PM, Ben Pfaff wrote:
> On Thu, Apr 12, 2018 at 03:40:33PM -0700, aginwala wrote:
> > eval doesn't understand white spaces which was introduced in commit
> > 79c7961b8b3c4b7ea0251dea2ffacfa84c84fecb for starting clustered ovn dbs
> >
> > Hence, we need to explicitely
I also sent out a patch for this:
Acked-by: Ansis Atteka
On 25 April 2018 at 12:48, Ben Pfaff wrote:
> This fixes a broken build.
>
> CC: Ansis Atteka
> Fixes: 3a2ceb01c81b ("poc: Automate building of Fedora rpm packages")
> Signed-off-by: Ben Pfaff
> ---
> Makefile.am | 1 +
> 1 file change
The function inet_parse_active() is an external API and used
as one stop shopping for parsing ip address and L4 port
combinations from many other modules. Hence, the function
header is extended to describe the special cases that it
handles.
Signed-off-by: Darrell Ball
---
lib/socket-util.c | 6
When ct lookup returns a matching ct entry, increment ct stats
even if the zone information in conntrack entry does not match with
flowkey.
Signed-off-by: Anand Kumar
---
datapath-windows/ovsext/Conntrack.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/datapath-windo
On Thu, Apr 12, 2018 at 03:40:33PM -0700, aginwala wrote:
> eval doesn't understand white spaces which was introduced in commit
> 79c7961b8b3c4b7ea0251dea2ffacfa84c84fecb for starting clustered ovn dbs
>
> Hence, we need to explicitely handle it.
> e.g. /usr/share/openvswitch/scripts/ovn-ctl --db-
This fixes a broken build.
CC: Ansis Atteka
Fixes: 3a2ceb01c81b ("poc: Automate building of Fedora rpm packages")
Signed-off-by: Ben Pfaff
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.am b/Makefile.am
index be4de00a8be0..e34fb3455e3a 100644
--- a/Makefile.am
+++
On Fri, Apr 20, 2018 at 03:28:38PM -0700, Ashish Varma wrote:
> In case where "use_names" is set (e.g. in an interactive session) to show
> the port and table names when ovs-ofctl is run with snoop command,
> ovs-ofctl would get stuck in an endless loop inside "table_iterator_next"
> function's whi
On Wed, Apr 25, 2018 at 06:12:03PM +0200, Eelco Chaudron wrote:
> Hi All,
>
> I could not find any GDB macros or commands in the OVS project, and as I was
> debugging some vague crash I started to create some.
>
> As I was trying to do this while debugging I copied some code from the Linux
> debu
On 04/25/2018 06:05 PM, Aaron Conole wrote:
> Kevin Traynor writes:
>
> Thanks for the review, Kevin!
>
>> On 04/18/2018 07:30 PM, Aaron Conole wrote:
>>> The normal way of retrieving the running DPDK status involves parsing
>>> log files and issuing various incantations of ovs-vsctl and ovs-app
This commit fixes following error introduced by
3a2ceb01 (poc: Automate building of Fedora rpm packages):
The following files are in git but not the distribution:
poc/playbook-fedora-builder.yml
Signed-off-by: Ansis Atteka
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/Make
On 25 April 2018 at 06:49, Aaron Conole wrote:
> Ansis Atteka writes:
>
>> This patch automates building of Fedora rpm packages (Just
>> like we are already doing this for for CentOS and Ubuntu).
>>
>> Signed-off-by: Ansis Atteka
>> ---
>
> Super cool!
>
> Acked-by: Aaron Conole
Thanks, I push
Aaron Conole writes:
> Ansis Atteka writes:
>
>> On 20 March 2018 at 14:05, Aaron Conole wrote:
>>> The rpm doesn't invoke all of the required selinux helpers to enact labeling
>>> or relabeling on all versions of Fedora/RHEL. According to:
>>> https://fedoraproject.org/wiki/SELinux/Independ
Kevin Traynor writes:
Thanks, Kevin!
> On 04/18/2018 07:30 PM, Aaron Conole wrote:
>> It's possible for dpdk initialization to fail either due to an internal
>> error or an invalid configuration. When that happens, it's rather
>> impolite to immediately abort without any details.
>>
>> With th
Kevin Traynor writes:
Thanks for the review, Kevin!
> On 04/18/2018 07:30 PM, Aaron Conole wrote:
>> The normal way of retrieving the running DPDK status involves parsing
>> log files and issuing various incantations of ovs-vsctl and ovs-appctl
>> commands to determine whether the rte_eal_init s
On 04/18/2018 07:30 PM, Aaron Conole wrote:
> The normal way of retrieving the running DPDK status involves parsing
> log files and issuing various incantations of ovs-vsctl and ovs-appctl
> commands to determine whether the rte_eal_init successfully started.
>
> This commit adds two new records t
On 04/18/2018 07:30 PM, Aaron Conole wrote:
> It's possible for dpdk initialization to fail either due to an internal
> error or an invalid configuration. When that happens, it's rather
> impolite to immediately abort without any details.
>
> With this change, a failed dpdk initialization attempt
From: William Tu
Upstream commit:
commit 1d7e2ed22f8d9171fa8b629754022f22115b3f03
Author: William Tu
Date: Wed Dec 13 16:38:55 2017 -0800
net: erspan: refactor existing erspan code
The patch refactors the existing erspan implementation in order
to support erspan versi
From: William Tu
Upstream commit:
commit a3222dc95ca751cdc5f6ac3c9b092b160b73ed9f
Author: William Tu
Date: Thu Nov 30 11:51:27 2017 -0800
ip_gre: Refector the erpsan tunnel code.
Move two erspan functions to header file, erspan.h, so ipv6
erspan implementation can use
From: Xin Long
Upstream commit:
commit c84bed440e4e11a973e8c0254d0dfaccfca41fb0
Author: Xin Long
Date: Sun Oct 1 22:00:56 2017 +0800
ip_gre: erspan device should keep dst
The patch 'ip_gre: ipgre_tap device should keep dst' fixed
the issue ipgre_tap dev mtu couldn't b
From: Xin Long
Upstream commit:
commit c122fda271717f4fc618e0a31e833941fd5f1efd
Author: Xin Long
Date: Sun Oct 1 22:00:55 2017 +0800
ip_gre: set tunnel hlen properly in erspan_tunnel_init
According to __gre_tunnel_init, tunnel->hlen should be set as the
headers' lengt
From: William Tu
Upstream commit:
commit 84e54fe0a5eaed696dee4019c396f8396f5a908b
Author: William Tu
Date: Tue Aug 22 09:40:28 2017 -0700
gre: introduce native tunnel support for ERSPAN
The patch adds ERSPAN type II tunnel support. The implementation
is based on the
From: Xin Long
Upstream commit:
commit 935a9749a36828af0e8be224a5cd4bc758112c34
Author: Xin Long
Date: Sun Oct 1 22:00:53 2017 +0800
ip_gre: get key from session_id correctly in erspan_rcv
erspan only uses the first 10 bits of session_id as the key to look
up the tunn
From: William Tu
Upstream commit:
commit f192970de860d3ab90aa9e2a22853201a57bde78
Author: William Tu
Date: Thu Oct 5 12:07:12 2017 -0700
ip_gre: check packet length and mtu correctly in erspan tx
Similarly to early patch for erspan_xmit(), the ARPHDR_ETHER device
is t
From: William Tu
commit 1a66a836da630cd70f3639208da549b549ce576b
Author: William Tu
Date: Fri Aug 25 09:21:28 2017 -0700
gre: add collect_md mode to ERSPAN tunnel
Similar to gre, vxlan, geneve, ipip tunnels, allow ERSPAN tunnels to
operate in 'collect metadata' mode.
From: William Tu
Upstream commit:
commit 862a03c35ed76c50a562f7406ad23315f7862642
Author: William Tu
Date: Fri Aug 25 09:21:27 2017 -0700
gre: refactor the gre_fb_xmit
The patch refactors the gre_fb_xmit function, by creating
prepare_fb_xmit function for later ERSPAN
From: William Tu
Upstream commit:
commit e3d0328c76dde0b957f62f8c407b79f1d8fe3ef8
Author: William Tu
Date: Tue Aug 22 17:04:05 2017 -0700
gre: fix goto statement typo
Fix typo: pnet_tap_faied.
Signed-off-by: William Tu
Signed-off-by: David S. Miller
Cc: Willia
Anything less than 3.10 isn't supported since a couple of releases ago
so remove the dead code.
Signed-off-by: Greg Rose
---
datapath/linux/compat/include/linux/etherdevice.h | 30 --
datapath/linux/compat/include/linux/if_vlan.h | 11 ---
datapath/linux/compat/include/linux/kconfig.
This series of patches is the first half of the backport of the
Linux kernel upstream ERSPAN feature support.
The first patch does some cleanup of unsupported kernel code. The
remaining patches in the series begin the backport of the actual
ERSPAN code.
As part of the ERSPAN backport it was nece
Hi All,
I could not find any GDB macros or commands in the OVS project, and as I
was debugging some vague crash I started to create some.
As I was trying to do this while debugging I copied some code from the
Linux debug commands, so I had to use the same GPL2 license.
You can find the comm
On Tue, Apr 24, 2018 at 03:44:55PM -0400, Aaron Conole wrote:
> Ben Pfaff writes:
>
> > debian/rules is a Makefile with a funny name.
> >
> > Signed-off-by: Ben Pfaff
> > ---
>
> Reviewed-by: Aaron Conole
Thanks, applied to master.
___
dev mailing l
Thanks for the patch.
On Wed, Apr 25, 2018 at 8:43 AM, Ben Pfaff wrote:
> At startup time, ovn-controller connects to the OVS database and retrieves
> a pointer to the southbound database, then connects to the southbound
> database and retrieves a snapshot. Until now, however, it didn't pay
> a
Currently, the code tells us we have 4 pad bytes left in cacheline0
while actually we are 8 bytes short:
struct netdev_dpdk {
union {
OVS_CACHE_LINE_MARKER cacheline0;/* 1 */
struct {
dpdk_port_t port_id;
On Mon, Apr 23, 2018 at 07:02:57AM +, Zang MingJie wrote:
> I found that in struct ofputil_meter_band, rate and burst are all 32 bits,
> the max burst is:
>
> for bandwidth: 4GB = 32Gb
> for pps: 4G packets/1000 = 4M packets
>
> In our high performance setup, 4M packets burst is easily achiev
At startup time, ovn-controller connects to the OVS database and retrieves
a pointer to the southbound database, then connects to the southbound
database and retrieves a snapshot. Until now, however, it didn't pay
attention to changes in the OVS database while trying to retrieve the
southbound dat
This new function makes it possible to create an instance of the IDL
without connecting it to a remote OVSDB server. The caller can then
connect and disconnect using ovsdb_idl_set_remote(); the ability to
disconnect is a new feature.
With this patch, the ovsdb_idl 'session' member can be null whe
There's not much value in making this a global since it's really just
parsed in one function and used in another.
Signed-off-by: Ben Pfaff
---
ovn/controller/ovn-controller.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ovn/controller/ovn-controller.c b/ovn/cont
Ansis Atteka writes:
> This patch automates building of Fedora rpm packages (Just
> like we are already doing this for for CentOS and Ubuntu).
>
> Signed-off-by: Ansis Atteka
> ---
Super cool!
Acked-by: Aaron Conole
___
dev mailing list
d...@openvsw
Hi Ian,
Thanks for checking this. I suggest to address Clang's compliant by the
following incremental:
diff --git a/lib/dpif-netdev-perf.c b/lib/dpif-netdev-perf.c
index 47ce2c2..c7b8e7b 100644
--- a/lib/dpif-netdev-perf.c
+++ b/lib/dpif-netdev-perf.c
@@ -442,6 +442,7 @@ pmd_perf_stats_clear(str
> On 04/25/2018 10:17 AM, Stokes, Ian wrote:
> >> Modify travis linux build script to use the latest DPDK stable
> >> release 17.11.2. Update docs for latest DPDK stable releases.
> >>
> >
> > Thanks for this Kevin, I'm lining this up for the next pull request.
> >
>
> Thanks - note, this is relev
> The faq already shows the DPDK versions that were used with each OVS
> version. Give information about DPDK stable and LTS releases, so the user
> can understand if those versions are maintained.
>
LGTM. Will apply to next pull request + backport.
Ian
> Signed-off-by: Kevin Traynor
> ---
> D
On 04/25/2018 10:17 AM, Stokes, Ian wrote:
>> Modify travis linux build script to use the latest DPDK stable release
>> 17.11.2. Update docs for latest DPDK stable releases.
>>
>
> Thanks for this Kevin, I'm lining this up for the next pull request.
>
Thanks - note, this is relevant for master a
The faq already shows the DPDK versions that were
used with each OVS version. Give information about
DPDK stable and LTS releases, so the user can understand
if those versions are maintained.
Signed-off-by: Kevin Traynor
---
Documentation/faq/releases.rst | 16
1 file changed, 1
> This patch instruments the dpif-netdev datapath to record detailed
> statistics of what is happening in every iteration of a PMD thread.
>
> The collection of detailed statistics can be controlled by a new
> Open_vSwitch configuration parameter "other_config:pmd-perf-metrics".
> By default it is
On 25 April 2018 at 10:09, Jianbo Liu wrote:
> ICMP checksum is calculated from ICMP headers and data, so hardware doesn't
> need to calculate it again because we only rewrite IP headers.
>
> Signed-off-by: Jianbo Liu
> Reviewed-by: Paul Blakey
> Reviewed-by: Roi Dayan
Thanks, applied to mas
> Modify travis linux build script to use the latest DPDK stable release
> 16.11.6. Update docs for latest DPDK stable releases.
>
> Signed-off-by: Kevin Traynor
Thanks, will apply this to the next pull request being prepped.
Ian
> ---
> .travis/linux-build.sh | 2 +-
> Docum
> Modify travis linux build script to use the latest DPDK stable release
> 17.11.2. Update docs for latest DPDK stable releases.
>
Thanks for this Kevin, I'm lining this up for the next pull request.
Minor comments inline.
> Signed-off-by: Kevin Traynor
> ---
> .travis/linux-build.sh
ICMP checksum is calculated from ICMP headers and data, so hardware doesn't
need to calculate it again because we only rewrite IP headers.
Signed-off-by: Jianbo Liu
Reviewed-by: Paul Blakey
Reviewed-by: Roi Dayan
---
lib/tc.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff -
54 matches
Mail list logo
