Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2018-06-04 Thread Anju Thomas
Hi , Any suggestions ? Will it be ok if we merge the tunnel push change that we have discussed below while I can work on the other changes in parallel? Regards & thanks Anju -Original Message- From: Anju Thomas Sent: Thursday, May 17, 2018 3:52 PM To: 'Ben Pfaff' Cc:

[ovs-dev] Generar valor añadido

2018-06-04 Thread Project Management
--- Este correo electrónico ha sido comprobado en busca de virus por AVG. http://www.avg.com ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v3 11/16] ovsdb-idl: Tracking - preserve data for deleted rows.

2018-06-04 Thread Han Zhou
On Mon, Jun 4, 2018 at 3:48 PM, Ben Pfaff wrote: > > On Fri, Jun 01, 2018 at 10:42:01AM -0700, Han Zhou wrote: > > OVSDB IDL can track changes, but for deleted rows, the data is > > destroyed and only uuid is tracked. In some cases we need to > > check the data of the deleted rows. This patch

Re: [ovs-dev] [PATCH v3 09/16] ovn-controller: Avoid forced recompute when not needed

2018-06-04 Thread Han Zhou
On Mon, Jun 4, 2018 at 3:50 PM, Ben Pfaff wrote: > > On Fri, Jun 01, 2018 at 10:41:59AM -0700, Han Zhou wrote: > > Signed-off-by: Han Zhou > > This seems like a refinement of the incremental processing engine > mainly. Is there a reason it can only happen in this point in the > series? In

Re: [ovs-dev] [PATCH] compat: Fix compile warning

2018-06-04 Thread Gregory Rose
On 6/4/2018 3:59 PM, Ben Pfaff wrote: On Mon, Jun 04, 2018 at 01:33:30PM -0700, Greg Rose wrote: Fix compile warning about redefined symbol Fixes: 10f242363d ("compat: Add skb_checksum_simple_complete()") Signed-off-by: Greg Rose Applied to master, thanks! Thank you!

Re: [ovs-dev] [PATCH] compat: Fix compile warning

2018-06-04 Thread Ben Pfaff
On Mon, Jun 04, 2018 at 01:33:30PM -0700, Greg Rose wrote: > Fix compile warning about redefined symbol > > Fixes: 10f242363d ("compat: Add skb_checksum_simple_complete()") > > Signed-off-by: Greg Rose Applied to master, thanks! ___ dev mailing list

Re: [ovs-dev] [PATCH v3 09/16] ovn-controller: Avoid forced recompute when not needed

2018-06-04 Thread Ben Pfaff
On Fri, Jun 01, 2018 at 10:41:59AM -0700, Han Zhou wrote: > Signed-off-by: Han Zhou This seems like a refinement of the incremental processing engine mainly. Is there a reason it can only happen in this point in the series? In other words, can this be folded into patch 1?

Re: [ovs-dev] [PATCH v3 11/16] ovsdb-idl: Tracking - preserve data for deleted rows.

2018-06-04 Thread Ben Pfaff
On Fri, Jun 01, 2018 at 10:42:01AM -0700, Han Zhou wrote: > OVSDB IDL can track changes, but for deleted rows, the data is > destroyed and only uuid is tracked. In some cases we need to > check the data of the deleted rows. This patch preserves data > for deleted rows until track clear is called.

Re: [ovs-dev] [PATCH 1/3] tests/sendpkt.py: Fix to work with Python3

2018-06-04 Thread Ashish Varma
Acked-by: Ashish Varma > On Thu, May 31, 2018 at 7:52 AM, Timothy Redaelli wrote: > CC: Ashish Varma > Fixes: 296251ca0c82 ("tests: Added NSH related unit test cases for > datapath") > Signed-off-by: Timothy Redaelli > --- > tests/sendpkt.py | 5 - > 1 file changed, 4 insertions(+), 1

Re: [ovs-dev] [PATCH] Fix typo in database commands documentation.

2018-06-04 Thread Ben Pfaff
On Mon, Jun 04, 2018 at 10:36:31AM -0400, Mark Michelson wrote: > s/remov/remove/ > > Signed-off-by: Mark Michelson Applied to master, thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 13/13] Makefile: Add build-time check for files with initial tabs.

2018-06-04 Thread Ben Pfaff
This should make it harder to reintroduce inappropriate indentation. Signed-off-by: Ben Pfaff --- Makefile.am | 15 +++ build-aux/automake.mk | 1 + build-aux/initial-tab-whitelist | 16 3 files changed, 32 insertions(+) create mode

[ovs-dev] [PATCH 11/13] ofproto-dpif: Remove tabs from output.

2018-06-04 Thread Ben Pfaff
OVS uses spaces for indentation in source code and it makes sense for it to also use spaces for indentation in output. Spaces also consume less horizontal space in output, which often makes it easier to read. This commit transitions one part of output from tabs to spaces and updates appropriate

[ovs-dev] [PATCH 10/13] ofproto-dpif-upcall: Remove tabs from output.

2018-06-04 Thread Ben Pfaff
OVS uses spaces for indentation in source code and it makes sense for it to also use spaces for indentation in output. Spaces also consume less horizontal space in output, which often makes it easier to read. This commit transitions one part of output from tabs to spaces and updates appropriate

[ovs-dev] [PATCH 09/13] ofproto-dpif-trace: Remove tabs from output.

2018-06-04 Thread Ben Pfaff
OVS uses spaces for indentation in source code and it makes sense for it to also use spaces for indentation in output. Spaces also consume less horizontal space in output, which often makes it easier to read. This commit transitions one part of output from tabs to spaces and updates appropriate

[ovs-dev] [PATCH 08/13] bond: Remove tabs from output.

2018-06-04 Thread Ben Pfaff
OVS uses spaces for indentation in source code and it makes sense for it to also use spaces for indentation in output. Spaces also consume less horizontal space in output, which often makes it easier to read. This commit transitions one part of output from tabs to spaces and updates appropriate

[ovs-dev] [PATCH 07/13] stopwatch: Remove tabs from output.

2018-06-04 Thread Ben Pfaff
OVS uses spaces for indentation in source code and it makes sense for it to also use spaces for indentation in output. Spaces also consume less horizontal space in output, which often makes it easier to read. This commit transitions one part of output from tabs to spaces and updates appropriate

[ovs-dev] [PATCH 06/13] rstp, stp: Remove tabs from output.

2018-06-04 Thread Ben Pfaff
OVS uses spaces for indentation in source code and it makes sense for it to also use spaces for indentation in output. Spaces also consume less horizontal space in output, which often makes it easier to read. This commit transitions one part of output from tabs to spaces and updates appropriate

[ovs-dev] [PATCH 04/13] lacp: Remove tabs from output.

2018-06-04 Thread Ben Pfaff
OVS uses spaces for indentation in source code and it makes sense for it to also use spaces for indentation in output. Spaces also consume less horizontal space in output, which often makes it easier to read. This commit transitions one part of output from tabs to spaces and updates appropriate

[ovs-dev] [PATCH 05/13] ovs-lldp: Remove tabs from output.

2018-06-04 Thread Ben Pfaff
OVS uses spaces for indentation in source code and it makes sense for it to also use spaces for indentation in output. Spaces also consume less horizontal space in output, which often makes it easier to read. This commit transitions one part of output from tabs to spaces and updates appropriate

[ovs-dev] [PATCH 03/13] dpctl: Remove tabs from output.

2018-06-04 Thread Ben Pfaff
OVS uses spaces for indentation in source code and it makes sense for it to also use spaces for indentation in output. Spaces also consume less horizontal space in output, which often makes it easier to read. This commit transitions one part of output from tabs to spaces and updates appropriate

[ovs-dev] [PATCH 02/13] cfm: Remove tabs from output.

2018-06-04 Thread Ben Pfaff
OVS uses spaces for indentation in source code and it makes sense for it to also use spaces for indentation in output. Spaces also consume less horizontal space in output, which often makes it easier to read. This commit transitions one part of output from tabs to spaces and updates appropriate

[ovs-dev] [PATCH 01/13] bfd: Remove leading tabs from output.

2018-06-04 Thread Ben Pfaff
OVS uses spaces for indentation in source code and it makes sense for it to also use spaces for indentation in output. Spaces also consume less horizontal space in output, which often makes it easier to read. This commit transitions one part of output from tabs to spaces and updates appropriate

[ovs-dev] [PATCH] rstp: Eliminate BPDU padding and uninitialized bytes.

2018-06-04 Thread Ben Pfaff
When the RSTP implementation sent BPDUs, it failed to initialize some of their bytes. None of the code initialized an array of 7 padding bytes, and some of it also failed to initialize the version1_length field. In addition, the padding bytes confused some implementations that did not correctly

[ovs-dev] [PATCH] compat: Fix compile warning

2018-06-04 Thread Greg Rose
Fix compile warning about redefined symbol Fixes: 10f242363d ("compat: Add skb_checksum_simple_complete()") Signed-off-by: Greg Rose --- datapath/linux/compat/include/linux/skbuff.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH 2/3] Revert "utilities/ovs-ctl: Force removal of ip_gre/gre"

2018-06-04 Thread Greg Rose
This reverts commit 2bdd1f3d96a86bea6bdb8788f23ec7dd99b289e3. Rather than attempting to force the removal of the ip_gre/gre kernel modules, which often fails because they're in use, we will add a patch that does not cause the openvswitch kernel module to fail to load when the ip_gre/gre protocol

[ovs-dev] [PATCH 3/3] datapath: Do not fail to load on gre protocol conflict

2018-06-04 Thread Greg Rose
The ERSPAN feature depends on the gre kernel module so on systems where the ERSPAN feature isn't supported the openvswitch kernel module would attempt to grab the ipv4 GRE protocol entry point and would fail to load if it could not. This patch modifies openvswitch to not fail to load when the gre

[ovs-dev] [PATCH 1/3] Revert "dpif: Ensure ERSPAN GRE support"

2018-06-04 Thread Greg Rose
This reverts commit 8929c55287abae37efeac1e8876e6b3c2ccad0b9. This is the wrong direction for the solution to the ip_gre/gre kernel module conflicts. Signed-off-by: Greg Rose --- lib/dpif-netlink-rtnl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [ovs-dev] [PATCH] compat: Add skb_checksum_simple_complete()

2018-06-04 Thread Gregory Rose
On 6/4/2018 12:57 PM, Ben Pfaff wrote: On Fri, Jun 01, 2018 at 05:57:44PM -0700, William Tu wrote: On Fri, Jun 1, 2018 at 1:07 PM, Greg Rose wrote: A recent patch to gre.c added a call to skb_checksum_simple_complete() which is not present in kernels before 3.16. Fix up the compatability

Re: [ovs-dev] [PATCH] compat: Add skb_checksum_simple_complete()

2018-06-04 Thread Gregory Rose
On 6/1/2018 1:07 PM, Greg Rose wrote: A recent patch to gre.c added a call to skb_checksum_simple_complete() which is not present in kernels before 3.16. Fix up the compatability layer to allow compile on older kernels that do not have it. Signed-off-by: Greg Rose NACK - I'll send a V2

Re: [ovs-dev] [PATCH] compat: Add skb_checksum_simple_complete()

2018-06-04 Thread Ben Pfaff
On Fri, Jun 01, 2018 at 05:57:44PM -0700, William Tu wrote: > On Fri, Jun 1, 2018 at 1:07 PM, Greg Rose wrote: > > A recent patch to gre.c added a call to skb_checksum_simple_complete() > > which is not present in kernels before 3.16. Fix up the compatability > > layer to allow compile on older

Re: [ovs-dev] Fwd: unable to start openvswitch daemon !!

2018-06-04 Thread Flavio Leitner
On Mon, Jun 04, 2018 at 11:07:39PM +0530, rakesh kumar wrote: > Please give your suggestions for the below issue! Please follow the documentation: https://github.com/openvswitch/ovs/blob/master/Documentation/intro/install/index.rst

[ovs-dev] [PATCH] python:updated docstring

2018-06-04 Thread Toms Atteka
Adjusted docstring and variable names according to previous code changes; Fixed grammar "a attribute" > "an attribute". Fixes: bf42f674 (idl: Convert python daemons to utilize SchemaHelper) Signed-off-by: Toms Atteka --- python/ovs/db/idl.py | 23 --- 1 file changed, 12

[ovs-dev] Fwd: unable to start openvswitch daemon !!

2018-06-04 Thread rakesh kumar
Please give your suggestions for the below issue! Regards Rakesh Kumar Begin forwarded message: > From: rakesh kumar > Date: 4 June 2018 at 4:51:35 PM IST > To: ovs-dev@openvswitch.org > Subject: unable to start openvswitch daemon !! > > Team, > > After doing sudo install in Linux, I am not

[ovs-dev] Analizar la necesidad y ventajas

2018-06-04 Thread RH y rendimiento corporativo
El participante será capaz de: - Analizar la necesidad y ventajas de conocer la misión, visión y valores corporativos. - Conocer cuáles son las cuatro barreras fundamentales que impiden el establecimiento de una estrategia en nuestras organizaciones. -Saber que variables posibilitan una

[ovs-dev] [PATCH] Fix typo in database commands documentation.

2018-06-04 Thread Mark Michelson
s/remov/remove/ Signed-off-by: Mark Michelson --- lib/db-ctl-base.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/db-ctl-base.xml b/lib/db-ctl-base.xml index 6ff08e52c..a5fcc901c 100644 --- a/lib/db-ctl-base.xml +++ b/lib/db-ctl-base.xml @@ -252,7 +252,7 @@

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-06-04 Thread Eric Garver
On Fri, Jun 01, 2018 at 11:23:12AM -0700, William Tu wrote: > On Fri, Jun 1, 2018 at 9:38 AM, Jiri Benc wrote: > > On Fri, 1 Jun 2018 09:15:33 -0700, Gregory Rose wrote: > >> Since ERSPAN over gre/ip_gre was added to the Linux 4.16 kernel the > >> compat interface is needed > >> for kernels up to

Re: [ovs-dev] [ovs-dev, 2/2] ovs-vswitchd: Do not use system routing table with --disable-system.

2018-06-04 Thread Ilya Maximets
On 01.04.2018 03:12, Ben Pfaff wrote: > The --disable-system option indicates that the user wants to avoid using > the host's datapath. This is also a good indication that the user does > not want to use other host resources such as the routing table, so this > commit implements that. > > This

Re: [ovs-dev] [PATCH v4 1/1] ovs-thread: Fix thread id for threads not started with ovs_thread_create()

2018-06-04 Thread Ilya Maximets
On 04.06.2018 11:07, Eelco Chaudron wrote: > When ping-pong'in a live VM migration between two machines running > OVS-DPDK every now and then the ping misses would increase > dramatically. For example: > > ===Stream Rate: 3Mpps=== > No Stream_Rate Downtime Totaltime Ping_Loss

[ovs-dev] unable to start openvswitch daemon !!

2018-06-04 Thread rakesh kumar
Team, After doing *sudo install* in Linux, I am not seeing openvswitch-switch at /etc/init.d and unable to start the daemon or check the status. Can some one help me out here ? Regards Rakesh Kumar ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v3 1/1] ovs-thread: Fix thread id for threads not started with ovs_thread_create()

2018-06-04 Thread Eelco Chaudron
Thanks Ilya for the comments below! I've send out a v4. //Eelco On 01/06/18 18:07, Ilya Maximets wrote: On 01.06.2018 16:18, Eelco Chaudron wrote: When ping-pong'in a live VM migration between two machines running OVS-DPDK every now and then the ping misses would increase dramatically. For

[ovs-dev] [PATCH v4 1/1] ovs-thread: Fix thread id for threads not started with ovs_thread_create()

2018-06-04 Thread Eelco Chaudron
When ping-pong'in a live VM migration between two machines running OVS-DPDK every now and then the ping misses would increase dramatically. For example: ===Stream Rate: 3Mpps=== No Stream_Rate Downtime Totaltime Ping_Loss Moongen_Loss 0 3Mpps 128 13974 115