Hi Greg,
Thanks for the review.
I still think separating GRE and ERSPAN is a reasonable idea. Maybe need to
fix some bugs after doing that.
Sure, I will do more survey and talk to you later.
Best,
Yifeng
On Fri, Jun 29, 2018 at 10:06 AM, Gregory Rose wrote:
> On 6/28/2018 6:40 AM, Yifeng Su
This patch adds a signature match cache (SMC) after exact match
cache (EMC). The difference between SMC and EMC is SMC only stores
a signature of a flow thus it is much more memory efficient. With
same memory space, EMC can store 8k flows while SMC can store 1M
flows. It is generally beneficial to
Test 1024 PMD - stats reported different stats data during tests because of
the SMC data. This commit fix the test.
Signed-off-by: Yipeng Wang
---
tests/pmd.at | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/pmd.at b/tests/pmd.at
index 60452f5..4cae6c8 100644
---
This patch set is the V4 implementation to combine the CD and DFC design.
Both patches intend to refactor datapath to avoid costly sequential subtable
search.
We rename the CD/DFC as signature match cache (SMC) to be more clear since the
proposed cache structure stores signatures of flows. SMC wor
> On Jun 29, 2018, at 1:15 PM, Gregory Rose wrote:
>
> On 6/29/2018 11:32 AM, Justin Pettit wrote:
>>> On Jun 29, 2018, at 11:18 AM, Greg Rose wrote:
>> You don't need to respin it, but do you mind if I add the following text to
>> the actions? Or do you have better suggestions?
>
> Your su
--
for personal & biz finance, write us.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
--
for personal & biz finance, write us.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 6/29/2018 11:32 AM, Justin Pettit wrote:
On Jun 29, 2018, at 11:18 AM, Greg Rose wrote:
You don't need to respin it, but do you mind if I add the following text to the
actions? Or do you have better suggestions?
Your suggestions below are fine.
Thanks!
- Greg
+# Older releases
Greg Rose writes:
> This patch fixes two problems.
>
> 1) The 'action "ovs-appctl dpctl/flush-conntrack"' does not do
> anything because a command does not follow it.
>
> 2) Even after adding the command it still doesn't work - it must be
> done before the stop_forwarding command.
>
> In addition
Greg Rose writes:
> When upgrading from older versions of OVS that used the built-in geneve
> kernel module on RHEL 7 systems to newer versions that use the 'compat'
> vport_geneve and vport_vxlan drivers we need to clean up some cruft
> that might have been left over after the upgrade.
>
> Remov
Gregory Rose writes:
> On 6/29/2018 10:48 AM, Aaron Conole wrote:
>> Justin Pettit writes:
>>
On Jun 26, 2018, at 10:19 AM, Greg Rose wrote:
When upgrading from older versions of OVS that used the built-in geneve
kernel module on RHEL 7 systems to newer versions that use the
Previously to delete or dump the meter table, separate commands had to
be used depending on whether one wanted to operate on a single or all
meters. This change makes it so that the "meter" argument is always
optional regardless of the command. This is a bit more consistent with
other OVS command
Signed-off-by: Justin Pettit
---
lib/dpif-netdev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 9390fff68dac..1e204a8d3b72 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -4375,7 +4375,8 @@ dpif_netdev_meter_get_
This also correct an error that indicated that the burst size is kbps,
when it should be kb.
Signed-off-by: Justin Pettit
---
ovn/northd/ovn-northd.8.xml | 37 -
ovn/ovn-nb.xml | 37 ++---
2 files changed, 42 insert
This also correct an error that indicated that the burst size is kbps,
when it should be kb.
Signed-off-by: Justin Pettit
---
utilities/ovs-ofctl.8.in | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
Support was added in commit 9e638f223feb ("ofproto: Support action
upcall meters").
Signed-off-by: Justin Pettit
---
Documentation/topics/openflow.rst | 8
utilities/ovs-ofctl.8.in | 15 +--
2 files changed, 9 insertions(+), 14 deletions(-)
diff --git a/Documentat
It occured in OVS 2.9.0, not OVS 2.8.0.
Signed-off-by: Justin Pettit
---
NEWS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index cd15a332c47e..2fcb3c1f86a3 100644
--- a/NEWS
+++ b/NEWS
@@ -23,7 +23,7 @@ Post-v2.9.0
* Add support for compiling OVS with
> On Jun 29, 2018, at 11:18 AM, Greg Rose wrote:
You don't need to respin it, but do you mind if I add the following text to the
actions? Or do you have better suggestions?
> +# Older releases may be using the rtnetlink interface while a
> +# newer release will want to use the intern
On 6/29/2018 10:48 AM, Aaron Conole wrote:
Justin Pettit writes:
On Jun 26, 2018, at 10:19 AM, Greg Rose wrote:
When upgrading from older versions of OVS that used the built-in geneve
kernel module on RHEL 7 systems to newer versions that use the 'compat'
vport_geneve and vport_vxlan drivers
This patch fixes two problems.
1) The 'action "ovs-appctl dpctl/flush-conntrack"' does not do
anything because a command does not follow it.
2) Even after adding the command it still doesn't work - it must be
done before the stop_forwarding command.
In addition, make the message more human frien
When upgrading from older versions of OVS that used the built-in geneve
kernel module on RHEL 7 systems to newer versions that use the 'compat'
vport_geneve and vport_vxlan drivers we need to clean up some cruft
that might have been left over after the upgrade.
Remove any genev_sys_6081 and vxlan_
From: Andy Zhou
To work with kernel datapath that supports meter.
Signed-off-by: Andy Zhou
Co-authored-by: Justin Pettit
Signed-off-by: Justin Pettit
---
Documentation/faq/releases.rst | 1 +
lib/dpif-netlink.c | 302 ++---
2 files changed, 283 inser
Thanks for looking at it. I'll respin it as a v3 and send that version out.
--Justin
> On Jun 29, 2018, at 11:06 AM, Alin Serdean
> wrote:
>
> The incremental looks good.
>
> Thanks,
> Alin.
>
> Sent from phone
>
>> On 29 Jun 2018, at 20:32, Justin Pettit wrote:
>>
>>
On Jun 29,
The incremental looks good.
Thanks,
Alin.
Sent from phone
> On 29 Jun 2018, at 20:32, Justin Pettit wrote:
>
>
>>> On Jun 29, 2018, at 7:23 AM, Alin Serdean
>>> wrote:
>>>
>>> On 29 Jun 2018, at 07:02, Justin Pettit wrote:
>>>
>>> @@ -3040,6 +3297,9 @@ dpif_netlink_init(void)
>>>
Justin Pettit writes:
>> On Jun 26, 2018, at 10:19 AM, Greg Rose wrote:
>>
>> When upgrading from older versions of OVS that used the built-in geneve
>> kernel module on RHEL 7 systems to newer versions that use the 'compat'
>> vport_geneve and vport_vxlan drivers we need to clean up some cruft
> On Jun 29, 2018, at 7:23 AM, Alin Serdean
> wrote:
>
>> On 29 Jun 2018, at 07:02, Justin Pettit wrote:
>>
>> @@ -3040,6 +3297,9 @@ dpif_netlink_init(void)
>> error = nl_lookup_genl_mcgroup(OVS_VPORT_FAMILY,
>> OVS_VPORT_MCGROUP,
>>&o
On 6/28/2018 6:40 AM, Yifeng Sun wrote:
On kernel versions (for example, 3.10) where upstream provides GRE
functionality but no ERSPAN, GRE can fail to initialize. Because
there is no ERSPAN feature in kernel, openvswitch kernel module will
try to register its own IPPROTO_GRE, instead of using th
On 6/29/2018 9:23 AM, Justin Pettit wrote:
On Jun 26, 2018, at 10:19 AM, Greg Rose wrote:
When upgrading from older versions of OVS that used the built-in geneve
kernel module on RHEL 7 systems to newer versions that use the 'compat'
vport_geneve and vport_vxlan drivers we need to clean up so
> On Jun 26, 2018, at 10:19 AM, Greg Rose wrote:
>
> When upgrading from older versions of OVS that used the built-in geneve
> kernel module on RHEL 7 systems to newer versions that use the 'compat'
> vport_geneve and vport_vxlan drivers we need to clean up some cruft
> that might have been le
> On Jun 29, 2018, at 5:09 AM, William Tu wrote:
>
> On Thu, Jun 28, 2018 at 8:31 PM, Greg Rose wrote:
>> The compat rpl_ip_tunnel_lookup() function was missing some code added
>> in Linux kernel release 4.3 but not backported in the initial commit.
>>
>> This also allows us to remove an old
On 1 June 2018 at 04:05, Lorenzo Bianconi
wrote:
> Do not send Neighbor Discovery packets to conntrack module if
> load balancing rules have been added to NB db since otherwise
> Neighbor Advertisement frames will be discarded by OVN.
> In order to reproduce the issue it is enough to add 2 logica
On 27 June 2018 at 18:49, Darrell Ball wrote:
> Non-distributed and distributed gateway load balancing is broken.
> Recent changes for port unreachable handling broke the associated
> unsnat functionality.
>
> Fixes: 86558ac2e476 ("OVN: add UDP port unreachable support to OVN
> logical router.")
On Fri, Jun 29, 2018 at 3:31 AM, Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> > On Thu, Jun 28, 2018 at 11:55 AM, Han Zhou wrote:
> >
> > > Thanks Darrell! These tests weren't even listed in make check
> > > TESTSUITEFLAGS="--list". What's the best way to run them? I'd like to
> run
>
A couple of notes:
1) This is actually v3 of the patch, but I messed up the subject line. Oops.
2) Justin was asking for patches that should be considered for 2.10. I
would like to have this patch considered.
Thanks
On 06/25/2018 04:09 PM, Mark Michelson wrote:
OVN offers a method of IP addr
On 29 Jun 2018, at 07:02, Justin Pettit
mailto:jpet...@ovn.org>> wrote:
From: Andy Zhou mailto:az...@ovn.org>>
To work with kernel datapath that supports meter.
Signed-off-by: Andy Zhou mailto:az...@ovn.org>>
Signed-off-by: Justin Pettit mailto:jpet...@ovn.org>>
---
v1->v2: D'oh. Stupid typo
Yes, let's hope we can get it in soon... expecting an v3 from Darrell
apparently.
Thanks!
On Fri, Jun 29, 2018 at 2:15 PM Lucas Alvares Gomes
wrote:
> Hi,
>
> > this should be the same issue reported by Darrell ('ovn: Fix gateway
> > load balancing')
> > Regards,
> >
>
> Yeah that's right, I ha
On Thu, Jun 28, 2018 at 05:03:01PM +0100, John Hurley wrote:
> This patchset extends OvS TC and the linux-netdev implementation to
> support the offloading of Linux Link Aggregation devices (LAG) and their
> slaves. TC blocks are used to provide this offload. Blocks, in TC, group
> together a serie
Hi,
> this should be the same issue reported by Darrell ('ovn: Fix gateway
> load balancing')
> Regards,
>
Yeah that's right, I have applied Darrell's patch [0] and re-run the
same test that myself and Daniel were debugging [1] and I can confirm
that it works now.
Thanks for the pointers!
[0]
>
> Hi all,
Hi Daniel,
>
> We are hitting issues with this patch on OpenStack CI in this particular test
> [0].
> The scenario is one VM trying to ping the router interface; replies are sent
> by
> the router interface but never reached the instance back as the last NAT
> action
> doesn't happ
On Thu, Jun 28, 2018 at 8:31 PM, Greg Rose wrote:
> The compat rpl_ip_tunnel_lookup() function was missing some code added
> in Linux kernel release 4.3 but not backported in the initial commit.
>
> This also allows us to remove an old hack in erspan_rcv() that was
> zeroing out the key parameter
On Thu, Jun 28, 2018 at 8:31 PM, Greg Rose wrote:
> Commit 436d36db introduced a bug into the gre header build for gre and
> ip gre type tunnels. __vlan_hwaccel_push_inside does not check whether
> the vlan tag is even present. So check first and avoid padding space
> for a vlan tag that isn't p
> On Thu, Jun 28, 2018 at 11:55 AM, Han Zhou wrote:
>
> > Thanks Darrell! These tests weren't even listed in make check
> > TESTSUITEFLAGS="--list". What's the best way to run them? I'd like to run
> > them for each of my patch to make sure there is no regression.
> >
>
>
> sudo make check-kmo
On 6/28/2018 6:39 PM, Flavio Leitner wrote:
On Thu, Jun 28, 2018 at 11:22:49AM +, Shahaf Shuler wrote:
Hi Ian, Flavio,
Hi!
Thursday, June 28, 2018 12:14 PM, Ian Stokes:
Subject: Re: [PATCH v11 0/7] OVS-DPDK flow offload with rte_flow
On 6/25/2018 2:21 PM, Shahaf Shuler wrote:
Hi,
Her
Hi all,
We are hitting issues with this patch on OpenStack CI in this particular
test [0].
The scenario is one VM trying to ping the router interface; replies are
sent by
the router interface but never reached the instance back as the last NAT
action
doesn't happen. Stopping northd and deleting ma
Hi,
The performance of OVS 2.8 (with DPDK 17.05.02) with conntrack configuration
has dropped significantly (especially for single flow case) as compared to OVS
2.6 (with DPDK 16.11.4).
Following is the comparison between 2.6.2 and 2.8.2.
PKT Size # of Flows MPPS (OVS 2.6) MPP
Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: patch failed: tests/system-traffic.at:2235
error: tests/system-traffic.at: patch does not ap
this patch is withdrawn
Darrell
On Thu, Jun 28, 2018 at 3:39 PM, Darrell Ball wrote:
> Line continuations are useful for specifying big packets in
> hex form in tests. Allow the hex packet to include '\'s to
> specify continuations. Also line length is limited to 998
> in patches because of S
yep, test file long line corruption again
On Thu, Jun 28, 2018 at 3:55 PM, 0-day Robot wrote:
> Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out
> your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
Tests are added to cover out of order fragments, overlapping fragments
and multiple extension headers in the case of IPv6.
Signed-off-by: Darrell Ball
---
tests/system-kmod-macros.at | 16
tests/system-traffic.at | 200 +++
tests/system-use
Signed-off-by: Darrell Ball
---
NEWS| 2 +
lib/conntrack.c | 114 +---
lib/conntrack.h | 13 ++
lib/ct-dpif.c | 24 +++
lib/ct-dpif.h | 13 ++
lib/dpctl.c | 62 +++
The ipv4 fragmentation check is broken and allows fragments through.
There were fragile and poorly maintainable checks in extract_l3_ipv*
designed to save a few cycles. The checks make assumptions about what
sanity checks may have been done and could be skipped based on inferring
from the value of
51 matches
Mail list logo
