Re: [ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

On 8/7/2018 8:31 PM, Justin Pettit wrote: Thanks, Greg. I actually have this queued up with another patch that will disable meters entirely on broken kernels. I plan to send that out tomorrow. --Justin Oops - perhaps I was a bit hasty.  I was just trying to get caught up with upstream.

Re: [ovs-dev] [patch v5] dpctl: Make opt_dpif_open() more general.

On Tue, Aug 7, 2018 at 4:20 PM, Ben Pfaff wrote: > On Mon, Aug 06, 2018 at 07:24:39PM -0700, Darrell Ball wrote: > > By making opt_dpif_open() more general, it can be used effectively > > by all potential callers and avoids trying to open potentially bogus > > datapaths provided by the user.

Re: [ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

Thanks, Greg. I actually have this queued up with another patch that will disable meters entirely on broken kernels. I plan to send that out tomorrow. --Justin > On Aug 7, 2018, at 4:45 PM, Greg Rose wrote: > > From: Justin Pettit > > Upstream commit: >From: Justin Pettit >Date:

[ovs-dev] [PATCH v2 2/2] table: fix html buffer output

Prior to this commit, html output exhibiits a doppler effect for content by continually printing strings passed from table_print_html_cell. Fixes: cb139fa8b3a1 ("table: New function table_format() for formatting a table as a string.") Cc: Ben Pfaff Cc: Jakub Sitnicki Signed-off-by: Aaron

[ovs-dev] [PATCH v2 1/2] table: append newline when printing tables

With commit cb139fa8b3a1 ("table: New function table_format() for formatting a table as a string.") a new mechanism for formatting tables was introduced, and the table_print method was refactored to use this. During that refactor, calls to 'puts' were replaced with 'ds_put_cstr', and table print

Re: [ovs-dev] [PATCH] table: append newline when printing tables

Ben Pfaff writes: > On Tue, Aug 07, 2018 at 06:23:12PM -0400, Aaron Conole wrote: >> With commit cb139fa8b3a1 ("table: New function table_format() for >> formatting a table as a string.") a new mechanism for formatting >> tables was introduced, and the table_print method was refactored to >> use

Re: [ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

On 8/7/2018 4:55 PM, Ben Pfaff wrote: On Tue, Aug 07, 2018 at 04:45:26PM -0700, Greg Rose wrote: From: Justin Pettit Upstream commit: From: Justin Pettit Date: Sat, 28 Jul 2018 15:26:01 -0700 Subject: [PATCH] openvswitch: meter: Fix setting meter id for new entries The

Re: [ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

On Tue, Aug 07, 2018 at 04:45:26PM -0700, Greg Rose wrote: > From: Justin Pettit > > Upstream commit: > From: Justin Pettit > Date: Sat, 28 Jul 2018 15:26:01 -0700 > Subject: [PATCH] openvswitch: meter: Fix setting meter id for new entries > > The meter code would create an

[ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

From: Justin Pettit Upstream commit: From: Justin Pettit Date: Sat, 28 Jul 2018 15:26:01 -0700 Subject: [PATCH] openvswitch: meter: Fix setting meter id for new entries The meter code would create an entry for each new meter. However, it would not set the meter id in the

Re: [ovs-dev] [patch v5] dpctl: Make opt_dpif_open() more general.

On Mon, Aug 06, 2018 at 07:24:39PM -0700, Darrell Ball wrote: > By making opt_dpif_open() more general, it can be used effectively > by all potential callers and avoids trying to open potentially bogus > datapaths provided by the user. Also, the error handling is improved by > having more specific

Re: [ovs-dev] [PATCH v1] ovs-testcontroller: Added section for runtime managment commands

On Mon, Aug 06, 2018 at 05:21:37PM -0700, Ashish Varma wrote: > Even though there are no runtime management commands supported by > ovs-testcontroller, the '--unixctl' section of the man page refers to > 'RUNTIME MANAGEMENT COMMANDS'. This message which refers to the runtime > management commands

Re: [ovs-dev] [PATCH] ovn-controller: Use ovsdb index for mac-binding update.

On Wed, Jul 11, 2018 at 11:05:44AM -0700, Han Zhou wrote: > Signed-off-by: Han Zhou Applied to master and branch-2.10, thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] table: append newline when printing tables

On Tue, Aug 07, 2018 at 06:23:12PM -0400, Aaron Conole wrote: > With commit cb139fa8b3a1 ("table: New function table_format() for > formatting a table as a string.") a new mechanism for formatting > tables was introduced, and the table_print method was refactored to > use this. > > During that

Re: [ovs-dev] [ovs-dev, 2 of 2] ip_gre: remove redundant variables t_hlen

Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Too many signoffs; are you missing Co-authored-by lines? Lines checked: 55, Warnings: 0,

Re: [ovs-dev] [ovs-dev, 1 of 2] ip_gre: fix IFLA_MTU ignored on NEWLINK

Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Too many signoffs; are you missing Co-authored-by lines? Lines checked: 55, Warnings: 0,

[ovs-dev] [PATCH] table: append newline when printing tables

With commit cb139fa8b3a1 ("table: New function table_format() for formatting a table as a string.") a new mechanism for formatting tables was introduced, and the table_print method was refactored to use this. During that refactor, calls to 'puts' were replaced with 'ds_put_cstr', and table print

Re: [ovs-dev] [PATCH 0/3] Port group related enhancements.

On Mon, Aug 06, 2018 at 07:43:59PM -0700, Han Zhou wrote: > These patches are related to port groups, but the patch 3/3 is > independent from the others. > > Han Zhou (3): > ovn-northd: Simplify struct ovn_port_group. > ovn-northd: Improve efficiency of stateful checking for ACLs on port >

Re: [ovs-dev] infiniband (IPoIB) support

I don't know how many people on this list know anything about IPoIB. I know that I don't. You might not be getting an answer simply because it's such a specialty topic. Maybe there is a place where people talk about IPoIB software; maybe they would know something. On Wed, Aug 08, 2018 at

Re: [ovs-dev] [PATCH 2/2] ip_gre: remove redundant variables t_hlen

On 8/7/2018 3:05 PM, Ben Pfaff wrote: On Tue, Aug 07, 2018 at 02:48:53PM -0700, Greg Rose wrote: From: YueHaibing Upstream commit: From: YueHaibing Date: Wed, 1 Aug 2018 10:04:02 +0800 Subject: [PATCH] ip_gre: remove redundant variables t_hlen After commit ffc2b6ee4174

Re: [ovs-dev] [PATCH v3] datapath: support upstream ndo_udp_tunnel_add in net_device_ops

On 8/7/2018 3:08 PM, Ben Pfaff wrote: On Tue, Aug 07, 2018 at 01:53:15PM -0700, Gregory Rose wrote: On 8/4/2018 1:31 AM, we...@ucloud.cn wrote: From: wenxu It makes datapath can support both ndo_add_udp_tunnel_port and ndo_add_vxlan/geneve_port. The newer kernels don't support vxlan/geneve

Re: [ovs-dev] [PATCH v3] datapath: support upstream ndo_udp_tunnel_add in net_device_ops

On Tue, Aug 07, 2018 at 01:53:15PM -0700, Gregory Rose wrote: > On 8/4/2018 1:31 AM, we...@ucloud.cn wrote: > >From: wenxu > > > >It makes datapath can support both ndo_add_udp_tunnel_port and > >ndo_add_vxlan/geneve_port. The newer kernels don't support vxlan/geneve > >specific NDO's anymore > >

Re: [ovs-dev] [PATCH 2/2] ip_gre: remove redundant variables t_hlen

On Tue, Aug 07, 2018 at 02:48:53PM -0700, Greg Rose wrote: > From: YueHaibing > > Upstream commit: > From: YueHaibing > Date: Wed, 1 Aug 2018 10:04:02 +0800 > Subject: [PATCH] ip_gre: remove redundant variables t_hlen > > After commit ffc2b6ee4174 ("ip_gre: fix IFLA_MTU ignored

Re: [ovs-dev] [PATCH] tests: Ignore recirc_id in "MPLS xlate action" test.

On Tue, Aug 07, 2018 at 06:19:52PM -0300, Flavio Leitner wrote: > On Thu, Jul 12, 2018 at 02:55:31PM -0700, Ben Pfaff wrote: > > When I run this test with DPDK enabled, it fails because it ends up using > > a different recirculation ID when DPDK is not enabled. I guess that's a > > little weird

Re: [ovs-dev] [PATCH] tests: Ignore recirc_id in "MPLS xlate action" test.

On Fri, Jul 13, 2018 at 09:11:54AM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > When I run this test with DPDK enabled, it fails because it ends up using > > a different recirculation ID when DPDK is not enabled. I guess that's a > > little weird but the recirculation IDs are not

Re: [ovs-dev] infiniband (IPoIB) support

Does anybody can helps me and say, how to do connectivity from ovn network to physical? if ovn network and phisical have the same subnet. пн, 6 авг. 2018 г. в 23:35, Vasiliy Tolstov : > > пн, 6 авг. 2018 г. в 17:34, Vasiliy Tolstov : > > > > And if IPoIB device cant't be added to openvswitch

[ovs-dev] [PATCH 2/2] ip_gre: remove redundant variables t_hlen

From: YueHaibing Upstream commit: From: YueHaibing Date: Wed, 1 Aug 2018 10:04:02 +0800 Subject: [PATCH] ip_gre: remove redundant variables t_hlen After commit ffc2b6ee4174 ("ip_gre: fix IFLA_MTU ignored on NEWLINK") variable t_hlen is assigned values that are never read,

[ovs-dev] [PATCH 1/2] ip_gre: fix IFLA_MTU ignored on NEWLINK

From: Xin Long Upstream commit: From: Xin Long Date: Tue, 27 Feb 2018 19:19:39 +0800 Subject: [PATCH] ip_gre: fix IFLA_MTU ignored on NEWLINK It's safe to remove the setting of dev's needed_headroom and mtu in __gre_tunnel_init, as discussed in [1], ip_tunnel_newlink can do

Re: [ovs-dev] DNS async resolve breaks testsuite if no resolv.conf

On Tue, Aug 07, 2018 at 05:39:31PM -0300, Flavio Leitner wrote: > On Tue, Aug 07, 2018 at 12:41:03PM -0700, Ben Pfaff wrote: > > On Tue, Aug 07, 2018 at 03:36:45PM -0300, Flavio Leitner wrote: > > > My test system and build system doesn't have /etc/resolv.conf file > > > and then a warning is

Re: [ovs-dev] [PATCH] dns-resolve: Only ask unbound to read /etc/resolv.conf if it exists.

On Tue, Aug 07, 2018 at 05:41:24PM -0300, Flavio Leitner wrote: > On Tue, Aug 07, 2018 at 12:40:13PM -0700, Ben Pfaff wrote: > > The unbound library complains if we ask it to read /etc/resolv.conf but > > that file doesn't exist. It's better to just skip reading it in that case. > > > >

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: use new info-level logging helper when sending out an in_port

On Tue, Aug 07, 2018 at 02:13:17PM -0700, Zak Whittington wrote: > Added new helper function similar to xlate_report_error called > xlate_report_info that logs info-level messages, and used that > function to add an extra log message when attempting to send > out an in-port. > > VMware-BZ:

Re: [ovs-dev] [PATCH v4 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

On Tue, Aug 07, 2018 at 05:12:32PM -0400, Mark Michelson wrote: > On 08/07/2018 07:37 AM, nusid...@redhat.com wrote: > >From: Numan Siddique > > > >The python function ovs.socket_util.check_connection_completion() uses > >select() > >(provided by python) to monitor the socket file descriptor.

Re: [ovs-dev] [PATCH] tests: Ignore recirc_id in "MPLS xlate action" test.

On Thu, Jul 12, 2018 at 02:55:31PM -0700, Ben Pfaff wrote: > When I run this test with DPDK enabled, it fails because it ends up using > a different recirculation ID when DPDK is not enabled. I guess that's a > little weird but the recirculation IDs are not supposed to be significant, > so this

[ovs-dev] [PATCH] ofproto-dpif-xlate: use new info-level logging helper when sending out an in_port

Added new helper function similar to xlate_report_error called xlate_report_info that logs info-level messages, and used that function to add an extra log message when attempting to send out an in-port. VMware-BZ: 2158607 Signed-off-by: Zak Whittington --- ofproto/ofproto-dpif-xlate.c | 32

Re: [ovs-dev] [PATCH v4 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

Hi Numan, See below. On 08/07/2018 07:37 AM, nusid...@redhat.com wrote: From: Numan Siddique The python function ovs.socket_util.check_connection_completion() uses select() (provided by python) to monitor the socket file descriptor. The select() returns 1 when the file descriptor becomes

Re: [ovs-dev] [PATCH v3] datapath: support upstream ndo_udp_tunnel_add in net_device_ops

On 8/4/2018 1:31 AM, we...@ucloud.cn wrote: From: wenxu It makes datapath can support both ndo_add_udp_tunnel_port and ndo_add_vxlan/geneve_port. The newer kernels don't support vxlan/geneve specific NDO's anymore Signed-off-by: wenxu LGTM Reviewed-by: Greg Rose Tested-by: Greg Rose

Re: [ovs-dev] [PATCH 3/3] ovn-trace: Fix warnings when port is found but not in current datapath.

Acked-by: Mark Michelson With a patch like this, I like to look at it and ask myself "What will this break?" In this case, I believe nothing will actually be broken. On 08/06/2018 10:44 PM, Han Zhou wrote: When port group is used, ovn-trace may print warnings like this: $ ovn-trace ls1

Re: [ovs-dev] [PATCH 2/3] ovn-northd: Improve efficiency of stateful checking for ACLs on port groups.

Nice find, Han! Acked-by: Mark Michelson On 08/06/2018 10:44 PM, Han Zhou wrote: Currently in has_stateful_acl(), to check if a datapath has stateful ACLs, it needs to iterate all port groups and check if the current datapath is related to each port group, and then iterate the ACLs on the

Re: [ovs-dev] [PATCH 1/3] ovn-northd: Simplify struct ovn_port_group.

Acked-by: Mark Michelson On 08/06/2018 10:44 PM, Han Zhou wrote: Remove the redundant members that's already in nb_pg. Signed-off-by: Han Zhou --- ovn/northd/ovn-northd.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/ovn/northd/ovn-northd.c

Re: [ovs-dev] [PATCH] dns-resolve: Only ask unbound to read /etc/resolv.conf if it exists.

On Tue, Aug 07, 2018 at 12:40:13PM -0700, Ben Pfaff wrote: > The unbound library complains if we ask it to read /etc/resolv.conf but > that file doesn't exist. It's better to just skip reading it in that case. > > Reported-by: Flavio Leitner > Reporetd-at: >

Re: [ovs-dev] DNS async resolve breaks testsuite if no resolv.conf

On Tue, Aug 07, 2018 at 12:41:03PM -0700, Ben Pfaff wrote: > On Tue, Aug 07, 2018 at 03:36:45PM -0300, Flavio Leitner wrote: > > My test system and build system doesn't have /etc/resolv.conf file > > and then a warning is printed which breaks a number of tests in > > master and branch-2.10. > > >

Re: [ovs-dev] DNS async resolve breaks testsuite if no resolv.conf

On Tue, Aug 07, 2018 at 03:36:45PM -0300, Flavio Leitner wrote: > My test system and build system doesn't have /etc/resolv.conf file > and then a warning is printed which breaks a number of tests in > master and branch-2.10. > > Looks like unbound comes with hardcoded root servers list which

[ovs-dev] [PATCH] dns-resolve: Only ask unbound to read /etc/resolv.conf if it exists.

The unbound library complains if we ask it to read /etc/resolv.conf but that file doesn't exist. It's better to just skip reading it in that case. Reported-by: Flavio Leitner Reporetd-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/350751.html Signed-off-by: Ben Pfaff ---

Re: [ovs-dev] [PATCH v3 0/3] Transparent use of daemon for ovn-nbctl

Thanks, series applied to master and branch-2.10. On Tue, Aug 07, 2018 at 02:39:21PM -0400, Mark Michelson wrote: > Acked-by: Mark Michelson > > On 08/06/2018 05:45 PM, Ben Pfaff wrote: > >v1->v2: > > - Applied patches 1 and 2; added ack for patch 3 (thanks Alin!) > > - Polished up the

Re: [ovs-dev] DNS async resolve breaks testsuite if no resolv.conf

Bleep bloop. Greetings Flavio Leitner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: No signatures found. WARNING: Line is 95 characters long (recommended limit is 79)

Re: [ovs-dev] [PATCH] raft: Fix use-after-free error in raft_store_snapshot().

Thanks, applied to master, branch-2.10, branch-2.9. On Tue, Aug 07, 2018 at 02:26:11PM -0400, Mark Michelson wrote: > Looks good to me. > > Acked-by: Mark Michelson > > On 08/06/2018 05:35 PM, Ben Pfaff wrote: > >raft_store_snapshot() constructs a new snapshot in a local variable then >

Re: [ovs-dev] [ovs-dev,v3] tests: Test for ovs-ofctl snoop command

Thanks for clarifying. On Tue, Aug 7, 2018 at 12:07 PM, Aaron Conole wrote: > Ashish Varma writes: > > > Hi Aaron, > > > > My patch is already committed by Ben. Not sure what is wrong here. > > Thanks for the heads up. > > This happens - usually if the patch is committed before the bot has run

Re: [ovs-dev] [ovs-dev,v3] tests: Test for ovs-ofctl snoop command

Ashish Varma writes: > Hi Aaron, > > My patch is already committed by Ben. Not sure what is wrong here. Thanks for the heads up. This happens - usually if the patch is committed before the bot has run against it. I have it on my list of TODOs, so as soon as my next 'work on the bot' time

Re: [ovs-dev] [PATCH v3 0/3] Transparent use of daemon for ovn-nbctl

Acked-by: Mark Michelson On 08/06/2018 05:45 PM, Ben Pfaff wrote: v1->v2: - Applied patches 1 and 2; added ack for patch 3 (thanks Alin!) - Polished up the daemon mode so that it works actually quite well and added tests that show that it behaves equivalently. v2->v3: - Fix bug

[ovs-dev] DNS async resolve breaks testsuite if no resolv.conf

Hi, My test system and build system doesn't have /etc/resolv.conf file and then a warning is printed which breaks a number of tests in master and branch-2.10. Looks like unbound comes with hardcoded root servers list which could be the fallback in case of no /etc/resolv.conf, so that message

Re: [ovs-dev] [PATCH] raft: Fix use-after-free error in raft_store_snapshot().

Looks good to me. Acked-by: Mark Michelson On 08/06/2018 05:35 PM, Ben Pfaff wrote: raft_store_snapshot() constructs a new snapshot in a local variable then destroys the current snapshot and replaces it by the new one. Until now, it has not cloned the data in the new snapshot until it did

Re: [ovs-dev] [PATCH] json: Use unnamed embedded union.

On Mon, Aug 06, 2018 at 04:47:22PM -0700, Ben Pfaff wrote: > On Thu, Aug 02, 2018 at 06:52:55PM -0300, Flavio Leitner wrote: > > On Thu, Aug 02, 2018 at 06:44:10PM -0300, Flavio Leitner wrote: > > > Otherwise the code does not build. > > > > > > Fixes: fa37affad362 ("Embrace anonymous unions.") >

[ovs-dev] [PATCH] ofproto-dpif-xlate: Improve log message.

Until now, the bridge name was at the end of the log message, after the flow, which made it easy to miss. This commit moves it before the flow where it is easier to spot. Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-xlate.c | 4 ++-- tests/ofproto-dpif.at| 2 +- 2 files changed, 3

Re: [ovs-dev] [PATCH] utilities: Install ovs-tcp{dump, undump} also when only Python3 is enabled

On Tue, Aug 07, 2018 at 08:08:32PM +0200, Timothy Redaelli wrote: > On Sat, 4 Aug 2018 19:19:53 -0700 > Ben Pfaff wrote: > [...] > > > > Thanks for the explanation. I applied this to master; let me know if > > you want backports. > > I'd like a backport on branch-2.10, since commit

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Added logging for when sending out an in port

On Tue, Aug 07, 2018 at 10:37:35AM -0700, Zak Whittington wrote: > VMware-BZ: 2158607 > Signed-off-by: Zak Whittington > --- > ofproto/ofproto-dpif-xlate.c | 24 > 1 file changed, 24 insertions(+) > > diff --git a/ofproto/ofproto-dpif-xlate.c

Re: [ovs-dev] [PATCH] utilities: Install ovs-tcp{dump, undump} also when only Python3 is enabled

On Sat, 4 Aug 2018 19:19:53 -0700 Ben Pfaff wrote: [...] > > Thanks for the explanation. I applied this to master; let me know if > you want backports. I'd like a backport on branch-2.10, since commit 793bdb6c0500 and commit 227abb77d3d1 are included in the branch. Thank you

Re: [ovs-dev] [PATCH] rhel: Use openvswitch user in the logrotate configuration file

On Tue, 7 Aug 2018 16:18:13 +0300 Markos Chandras wrote: > The /var/log/openvswitch directory is owned by the openvswitch user > but logrotate could be running as root or as another user. As a > result of which, rpmlint prints the following warning when building > the spec file on SUSE Linux

[ovs-dev] [PATCH] ofproto-dpif-xlate: Added logging for when sending out an in port

VMware-BZ: 2158607 Signed-off-by: Zak Whittington --- ofproto/ofproto-dpif-xlate.c | 24 1 file changed, 24 insertions(+) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 01f1faf..9b36536 100644 --- a/ofproto/ofproto-dpif-xlate.c +++

Re: [ovs-dev] [PATCH v7 07/13] dp-packet: Handle multi-seg mubfs in shift() func.

On Tue, Aug 7, 2018 at 5:08 AM, Stokes, Ian wrote: > > In its current implementation dp_packet_shift() is also unaware of multi- > > seg mbufs (that holds data in memory non-contiguously) and assumes that > > data exists contiguously in memory, memmove'ing data to perform the > shift. > > > > To

Re: [ovs-dev] [PATCH v5 08/14] dp-packet: Handle multi-seg mbufs in resize__().

On Tue, Jul 24, 2018 at 12:36 AM, Lam, Tiago wrote: > On 23/07/2018 23:48, Darrell Ball wrote: > > > > > > On Fri, Jul 20, 2018 at 10:10 AM, Lam, Tiago > > wrote: > > > > On 19/07/2018 00:02, Darrell Ball wrote: > > > > > > > > > On Tue, Jul 17, 2018

[ovs-dev] [PATCH] rhel: Install the network scripts in a new subpackage

Starting from Fedora 29, the legacy network scripts are installed in the "network-scripts" package and so the network scripts ("ifup-ovs", "ifdown-ovs") should be installed only when the "network-scripts" package is installed. This commit introduces (on Fedora 29+) a new subpackage

[ovs-dev] [PATCH v5 6/6] Documentation: OVN RBAC and IPsec tutorial

This patch adds step-by-step guide for configuring OVN Role-Based Access Control and IPsec. Signed-off-by: Qiuyu Xiao --- Documentation/automake.mk | 2 + Documentation/index.rst | 4 +- Documentation/tutorials/index.rst | 2 +

[ovs-dev] [PATCH v5 5/6] OVN: native support for tunnel encryption

This patch adds IPsec support for OVN tunnel. Basically, OVN offers a binary option to its user for encryption configuration. If the IPsec option is turned on, all tunnels will be encrypted. Otherwise, no tunnel will be encrypted. The changes are summarized as below: 1) Added a ipsec column on

[ovs-dev] [PATCH v5 4/6] Documentation: IPsec tunnel tutorial and documentation.

tutorials/index.rst gives a step-by-setp guide to set up OVS IPsec tunnel. tutorials/ipsec.rst gives detailed explanation on the IPsec tunnel configuration methods and forwarding modes. Signed-off-by: Qiuyu Xiao Signed-off-by: Ansis Atteka Co-authored-by: Ansis Atteka ---

[ovs-dev] [PATCH v5 3/6] debian and rhel: Create IPsec package.

Added rules and files to create debian and rpm ovs-ipsec packages. Signed-off-by: Qiuyu Xiao Signed-off-by: Ansis Atteka Co-authored-by: Ansis Atteka --- debian/automake.mk| 3 + debian/control| 21 ++

[ovs-dev] [PATCH v5 1/6] datapath: add transport ports in route lookup for geneve

This patch adds transport ports information for route lookup so that IPsec can select geneve tunnel traffic to do encryption. Signed-off-by: Qiuyu Xiao Reviewed-by: Greg Rose Tested-by: Greg Rose --- datapath/linux/compat/geneve.c | 29 +++-- 1 file changed, 19

[ovs-dev] [PATCH v5 0/6] IPsec support for tunneling

This patch series reintroduce IPsec support for OVS tunneling and enable OVN to use IPsec tunnels. GRE, VXLAN, GENEVE, and STT IPsec tunnels are supported. StrongSwan and LibreSwan IKE daemons are supported. Changes from v1 to v2 - 1. Merge the ovs-monitor-ipsec code to a

Re: [ovs-dev] [PATCH v5 08/14] dp-packet: Handle multi-seg mbufs in resize__().

On Tue, Jul 24, 2018 at 12:06 AM, Lam, Tiago wrote: > On 23/07/2018 23:55, Darrell Ball wrote: > > > > > > On Fri, Jul 20, 2018 at 10:09 AM, Lam, Tiago > > wrote: > > > > On 18/07/2018 23:53, Darrell Ball wrote: > > > sorry, several distractions delayed

Re: [ovs-dev] [PATCH] ofctl: Fixup compare_flows function

Signed-off-by: Ben Pfaff On Tue, Aug 07, 2018 at 03:59:59PM +0300, aserd...@ovn.org wrote: > Can you also provide a Signed-off-by pls? > > > -Mesaj original- > > De la: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> În numele Ben Pfaff > > Trimis: Tuesday, August 7, 2018

Re: [ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

On Tue, Aug 7, 2018 at 2:03 AM, Justin Pettit wrote: > > > > On Aug 6, 2018, at 1:27 PM, Han Zhou wrote: > > > > Thanks Justin for the great work!! > > Sorry that I didn't get time to review the series, just some quick questions regarding the kernel bug you mentioned. > > Yes, I think you were

Re: [ovs-dev] [PATCH v7 07/13] dp-packet: Handle multi-seg mubfs in shift() func.

> Hi Ian, > > On 07/08/2018 13:08, Stokes, Ian wrote: > >> In its current implementation dp_packet_shift() is also unaware of > >> multi- seg mbufs (that holds data in memory non-contiguously) and > >> assumes that data exists contiguously in memory, memmove'ing data to > perform the shift. > >>

Re: [ovs-dev] [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

On Tue, 7 Aug 2018 15:31:11 +0200 Stefano Brivio wrote: > I would instead try to address the concerns that you had about the > original patch adding fairness in the kernel, rather than trying to > make the issue appear less severe in ovs-vswitchd. And, by the way, if we introduce a way to

Re: [ovs-dev] [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

Hi Pravin, On Tue, 31 Jul 2018 16:12:03 -0700 Pravin Shelar wrote: > Rather than reducing number of thread down to 1, we could find better > number of FDs per port. > How about this simple solution: > 1. Allocate (N * P) FDs as long as it is under FD limit. > 2. If FD limit (-EMFILE) is hit

[ovs-dev] [PATCH] rhel: Use openvswitch user in the logrotate configuration file

The /var/log/openvswitch directory is owned by the openvswitch user but logrotate could be running as root or as another user. As a result of which, rpmlint prints the following warning when building the spec file on SUSE Linux Enterprise: openvswitch.x86_64: W:

Re: [ovs-dev] [PATCH] ofctl: Fixup compare_flows function

Can you also provide a Signed-off-by pls? > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Tuesday, August 7, 2018 12:40 AM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] ofctl:

Re: [ovs-dev] [PATCH v7 07/13] dp-packet: Handle multi-seg mubfs in shift() func.

Hi Ian, On 07/08/2018 13:08, Stokes, Ian wrote: >> In its current implementation dp_packet_shift() is also unaware of multi- >> seg mbufs (that holds data in memory non-contiguously) and assumes that >> data exists contiguously in memory, memmove'ing data to perform the shift. >> >> To add

Re: [ovs-dev] [PATCH v7 07/13] dp-packet: Handle multi-seg mubfs in shift() func.

> In its current implementation dp_packet_shift() is also unaware of multi- > seg mbufs (that holds data in memory non-contiguously) and assumes that > data exists contiguously in memory, memmove'ing data to perform the shift. > > To add support for multi-seg mbuds a new set of functions was

Re: [ovs-dev] [PATCH 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

On Sat, Aug 4, 2018 at 3:20 AM Ben Pfaff wrote: > On Thu, Jul 12, 2018 at 01:37:33AM +0530, Numan Siddique wrote: > > On Wed, Jul 11, 2018 at 10:26 PM Ben Pfaff wrote: > > > > > On Wed, Jul 11, 2018 at 12:37:28PM +0530, Numan Siddique wrote: > > > > On Wed, Jul 11, 2018 at 2:08 AM Ben Pfaff

[ovs-dev] [PATCH v4 2/2] python jsonrpc: Allow jsonrpc_session to have more than one remote.

From: Numan Siddique Python IDL implementation doesn't have the support to connect to the cluster dbs. This patch adds this support. We are still missing the support in python idl class to connect to the cluster master. That support will be added in an upcoming patch. This patch is similar to

[ovs-dev] [PATCH v4 0/2] Partial cluster support in Python IDL client

From: Numan Siddique Python IDL library is lacking the functionality to connect to the clustered db servers by providing multiple remotes (like - "tcp:10.0.0.1:6641, tcp:10.0.0.2:6641, tcp:10.0.0.3:6641") in the connection string. This patch adds this functionality to the python idl library. It

[ovs-dev] [PATCH v4 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

From: Numan Siddique The python function ovs.socket_util.check_connection_completion() uses select() (provided by python) to monitor the socket file descriptor. The select() returns 1 when the file descriptor becomes ready. For error cases like - 111 (Connection refused) and 113 (No route to

Re: [ovs-dev] [PATCH v2] stream-ssl: Define SSL_OP_NO_SSL_MASK for OpenSSL versions that lack it.

On Mon, 6 Aug 2018 15:39:44 -0700 Ben Pfaff wrote: > 10 of the travis builds are failing such as > TESTSUITE=1 KERNEL=3.16.54 for gcc and clang. > > Fixes: ab16d2c2871b ("stream-ssl: Don't enable new TLS versions by > default") CC: Timothy Redaelli > Signed-off-by: Darrell Ball >

Re: [ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

> On Aug 6, 2018, at 1:27 PM, Han Zhou wrote: > > Thanks Justin for the great work!! > Sorry that I didn't get time to review the series, just some quick questions > regarding the kernel bug you mentioned. Yes, I think you were on vacation, and I was running up against my own, so it all