Re: [ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

> On Aug 7, 2018, at 10:19 PM, Gregory Rose wrote: > > > On 8/7/2018 8:31 PM, Justin Pettit wrote: >> Thanks, Greg. I actually have this queued up with another patch that will >> disable meters entirely on broken kernels. I plan to send that out tomorrow. >> >> --Justin > > Oops - perhaps

Re: [ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

That's fine. I had just been holding off because I thought you'd wanted the probe to disable meters on kernels with a broken implementation. Regardless, I did get that patch out earlier today: https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/350885.html Thanks, --Justin

Re: [ovs-dev] [PATCH] releases: Add 2.10 entry for supported DPDK versions.

On Wed, Aug 08, 2018 at 12:00:30PM +0100, Ian Stokes wrote: > This commit adds an entry for OVS 2.10 and the supported DPDK version in > releases.rst. > > Signed-off-by: Ian Stokes > --- Acked-by: Flavio Leitner ___ dev mailing list

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Improve log message.

On Tue, Aug 07, 2018 at 11:18:56AM -0700, Ben Pfaff wrote: > Until now, the bridge name was at the end of the log message, after the > flow, which made it easy to miss. This commit moves it before the flow > where it is easier to spot. > > Signed-off-by: Ben Pfaff > --- Acked-by: Flavio

Re: [ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits

thanks for the fix. On Wed, Aug 8, 2018 at 11:32 AM, Yifeng Sun wrote: > In compatable gre module, skb->cb is used as ovs_gso_cb. > This bug clears the 16-23 bit in the address of ovs_gso_cb.tun_dst. > can you explain more about ovs_gso_cb? > > Signed-off-by: Yifeng Sun > --- >

[ovs-dev] [PATCH 1/2] dpif: Don't pass in '*meter_id' to meter_set commands.

The original intent of the API appears to be that the underlying DPIF implementaion would choose a local meter id. However, neither of the existing datapath meter implementations (userspace or Linux) implemented that; they expected a valid meter id to be passed in, otherwise they returned an

[ovs-dev] [PATCH 2/2] dpif-netlink: Probe for broken Linux meter implementations.

Meter support was introduced in Linux 4.15. In some versions of Linux 4.15, 4.16, and 4.17, there was a bug that never set the id when the meter was created, so all meters essentially had an id of zero. This commit adds a probe to check for that condition and disable meters on those kernels.

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.10

Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Too many signoffs; are you missing Co-authored-by lines? Lines checked: 101, Warnings: 0,

[ovs-dev] [PATCH 8/8] system-traffic.at: Add ip6erspan v2 tunnel test that doesn't depend on upstream gre module

Introduce a new test that doesn't setup native ip6erspan v2 tunnels but sends simulated raw packets. This test is supposed to only run for kernel version from 4.4.x to 4.15.x. Signed-off-by: Yifeng Sun --- tests/system-traffic.at | 47 +++ 1 file

[ovs-dev] [PATCH 7/8] system-traffic.at: Add ip6erspan v1 tunnel test that doesn't depend on upstream gre module

Introduce a new test that doesn't setup native ip6erspan v1 tunnels but sends simulated raw packets. This test is supposed to only run for kernel version from 4.4.x to 4.15.x. Signed-off-by: Yifeng Sun --- tests/system-traffic.at | 51 + 1 file

[ovs-dev] [PATCH 6/8] system-traffic.at: Add erspan v2 tunnel test that doesn't depend on upstream gre module

Introduce a new test that doesn't setup native erspan v2 tunnels but sends simulated raw packets. This test is supposed to only run for kernel version from 4.4.x to 4.15.x. Signed-off-by: Yifeng Sun --- tests/system-traffic.at | 44 1 file changed,

[ovs-dev] [PATCH 5/8] system-traffic.at: Add erspan v1 tunnel test that doesn't depend on upstream gre module

Introduce a new test that doesn't setup native erspan v1 tunnels but sends simulated raw packets. This test is supposed to only run for kernel version from 4.4.x to 4.15.x. Signed-off-by: Yifeng Sun --- tests/system-traffic.at | 48 1 file

[ovs-dev] [PATCH 4/8] system-traffic.at: Add gre tunnel test that doesn't depend on upstream gre module

Introduce a new test that doesn't setup native gre tunnels but sends simulated raw packets. This test is supposed to only run for kernel version from 4.4.x to 4.15.x. Signed-off-by: Yifeng Sun --- tests/system-traffic.at | 47 +++ 1 file changed, 47

[ovs-dev] [PATCH 2/8] system-common-macros.at: Skip tests for certain kernel versions

Some tests depend on upstream gre modules to setup testing environments. However, some kernel versions require compatable gre modules being used. This patch helps to skip tests that fail due to this reason. The new m4 functions will be used by later patches. Signed-off-by: Yifeng Sun ---

[ovs-dev] [PATCH 3/8] system-traffic.at: Skip gre-related failed tests on kernel version from 4.4 to 4.15

Skip gre, erspan and ip6erspan related tests on kernel version from 4.4.x to 4.15.x because these tests will always fail. Signed-off-by: Yifeng Sun --- tests/system-traffic.at | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index

[ovs-dev] [PATCH 1/8] ip6_gre: Fix a bug that clears address bits

In compatable gre module, skb->cb is used as ovs_gso_cb. This bug clears the 16-23 bit in the address of ovs_gso_cb.tun_dst. Signed-off-by: Yifeng Sun --- datapath/linux/compat/ip6_gre.c | 1 - 1 file changed, 1 deletion(-) diff --git a/datapath/linux/compat/ip6_gre.c

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.10

On Wed, Aug 08, 2018 at 11:30:33PM +0100, Ian Stokes wrote: > Hi Ben, > > The following changes since commit faf64fb8861f312aca86a1d2b8fcb30d0504b09b: > > table: fix html buffer output (2018-08-08 11:19:15 -0700) > > are available in the git repository at: > >

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for master

On Wed, Aug 08, 2018 at 11:30:02PM +0100, Ian Stokes wrote: > Hi Ben, > > The following changes since commit c3cc694b93dd523176d2131a4b1b3b3170644638: > > table: fix html buffer output (2018-08-08 11:18:07 -0700) > > are available in the git repository at: > >

Re: [ovs-dev] [PATCH v3 0/9] tests: Clean up syslog.

On Wed, Aug 08, 2018 at 03:35:31PM +0300, Ilya Maximets wrote: > Each run of the testsuite produces millions lines in a system > log. This is completely unnecessary and makes it difficult to > use system logs on test / build servers. > > This series is aimed to disable most of the syslog

[ovs-dev] [PATCH] tests: Don't log to syslog during tests.

Until now, "make check" generated a huge amount of output to syslog. This commit suppresses it. CC: Ilya Maximets Signed-off-by: Ben Pfaff --- NEWS | 2 ++ lib/automake.mk | 2 ++ lib/syslog-null.c | 60 +++

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.7

Hi Ben, The following changes since commit e1619a1e7a8dded3c7da9ab40bd62a3628478711: ofctl: Fixup compare_flows function (2018-08-08 21:11:14 +0300) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_7 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.6

Hi Ben, The following changes since commit a9e21a1b9134090a3a12b1760daffba7f2777472: pcap-file: Fix formatting of log message. (2018-08-03 16:55:51 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_6 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.8

Hi Ben, The following changes since commit 59c0ba2990b7149ba42bb34b76cbe27b9cbed0e9: ofctl: Fixup compare_flows function (2018-08-08 21:09:55 +0300) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_8 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.9

Hi Ben, The following changes since commit c3a91ed557b7765c907ee5597ae8e68b1181869a: ofctl: Fixup compare_flows function (2018-08-08 21:03:17 +0300) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_9 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.10

Hi Ben, The following changes since commit faf64fb8861f312aca86a1d2b8fcb30d0504b09b: table: fix html buffer output (2018-08-08 11:19:15 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_10 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for master

Hi Ben, The following changes since commit c3cc694b93dd523176d2131a4b1b3b3170644638: table: fix html buffer output (2018-08-08 11:18:07 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge for you to fetch changes up to

Re: [ovs-dev] [PATCH] unixctl: Style fix.

On Wed, Aug 08, 2018 at 05:19:40PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > Reported-by: Aaron Conole > > Signed-off-by: Ben Pfaff > > --- > > Acked-by: Aaron Conole Thanks, applied. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] s/rhel/rpm/?

On Thu, Aug 09, 2018 at 12:29:20AM +0300, Markos Chandras wrote: > On 08/08/2018 09:01 PM, Ben Pfaff wrote: > > [asking some random SuSE and Red Hat people] > > > > It had somehow slipped past my notice before that the spec files we have > > are useful for SuSE as well as Red Hat. Should we make

Re: [ovs-dev] s/rhel/rpm/?

On 08/08/2018 09:01 PM, Ben Pfaff wrote: > [asking some random SuSE and Red Hat people] > > It had somehow slipped past my notice before that the spec files we have > are useful for SuSE as well as Red Hat. Should we make the directory or > file names more generic? > > Thanks, > > Ben. >

Re: [ovs-dev] [PATCH] unixctl: Style fix.

Ben Pfaff writes: > Reported-by: Aaron Conole > Signed-off-by: Ben Pfaff > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] unixctl: Style fix.

> On Aug 8, 2018, at 1:31 PM, Ben Pfaff wrote: > > Reported-by: Aaron Conole > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [patch v7] dpctl: Make opt_dpif_open() more general.

Ben If you apply this, I have one line to delete inline. Darrell On Wed, Aug 8, 2018 at 2:09 PM, Darrell Ball wrote: > By making opt_dpif_open() more general, it can be used effectively > by all potential callers and avoids trying to open potentially bogus > datapaths provided by the user.

[ovs-dev] [patch v7] dpctl: Make opt_dpif_open() more general.

By making opt_dpif_open() more general, it can be used effectively by all potential callers and avoids trying to open potentially bogus datapaths provided by the user. Also, the error handling is improved by reducing bogus errors and having more specific real errors. Signed-off-by: Darrell Ball

Re: [ovs-dev] [patch v6] dpctl: Make opt_dpif_open() more general.

hold off on this version I can save a couple lines of code, so I'll send a V7 Darrell On Wed, Aug 8, 2018 at 1:05 PM, Darrell Ball wrote: > By making opt_dpif_open() more general, it can be used effectively > by all potential callers and avoids trying to open potentially bogus > datapaths

Re: [ovs-dev] [PATCH v2 1/3] unixctl: Make path to unixctl_server socket available to the client.

On Wed, Aug 08, 2018 at 04:13:39PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > @@ -429,10 +426,17 @@ unixctl_server_destroy(struct unixctl_server *server) > > kill_connection(conn); > > } > > > > +free (server->path); > > Just a small nit, this looks like

[ovs-dev] [PATCH] unixctl: Style fix.

Reported-by: Aaron Conole Signed-off-by: Ben Pfaff --- lib/unixctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/unixctl.c b/lib/unixctl.c index 9b3b0671f33c..730bd043a9ff 100644 --- a/lib/unixctl.c +++ b/lib/unixctl.c @@ -426,7 +426,7 @@

Re: [ovs-dev] [PATCH 1/2] ofp-port: Fix buffer overread parsing Intel custom statistics.

On 8/8/2018 7:11 PM, Ben Pfaff wrote: On Wed, Aug 08, 2018 at 09:24:30AM +0100, Ian Stokes wrote: On 8/7/2018 1:00 AM, Ben Pfaff wrote: On Fri, Jul 27, 2018 at 11:14:43AM -0700, Ben Pfaff wrote: CC: Michal Weglicki Fixes: 971f4b394c6e ("netdev: Custom statistics.") Reported-at:

Re: [ovs-dev] [PATCH v2 1/3] unixctl: Make path to unixctl_server socket available to the client.

Ben Pfaff writes: > Acked-by: Alin Gabriel Serdean > Signed-off-by: Ben Pfaff > --- > lib/unixctl.c | 52 > lib/unixctl.h | 2 ++ > tests/daemon.at | 4 ++-- > 3 files changed, 32 insertions(+), 26 deletions(-) > > diff --git

Re: [ovs-dev] [patch v5] dpctl: Make opt_dpif_open() more general.

On 8/8/18, 11:14 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: On Tue, Aug 07, 2018 at 09:49:38PM -0700, Darrell Ball wrote: > On Tue, Aug 7, 2018 at 4:20 PM, Ben Pfaff wrote: > > > On Mon, Aug 06, 2018 at 07:24:39PM -0700, Darrell Ball wrote: > > >

[ovs-dev] [patch v6] dpctl: Make opt_dpif_open() more general.

By making opt_dpif_open() more general, it can be used effectively by all potential callers and avoids trying to open potentially bogus datapaths provided by the user. Also, the error handling is improved by having more specific errors. Signed-off-by: Darrell Ball --- lib/dpctl.c |

Re: [ovs-dev] [PATCH] ofctl: Fixup compare_flows function

On 7 Aug 2018, at 19:36, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > On Tue, Aug 07, 2018 at 03:59:59PM +0300, aserd...@ovn.org wrote: >> Can you also provide a Signed-off-by pls? >> >>> -Mesaj original- >>> De la: ovs-dev-boun...@openvswitch.org >> boun...@openvswitch.org> În

Re: [ovs-dev] [PATCH v2 0/9] tests: Clean up syslog.

On Wed, Aug 08, 2018 at 03:07:04PM +0300, Ilya Maximets wrote: > On 07.08.2018 00:12, Ben Pfaff wrote: > > On Mon, Aug 06, 2018 at 06:18:19PM +0300, Ilya Maximets wrote: > >> On 04.08.2018 03:17, Ben Pfaff wrote: > >>> On Wed, Aug 01, 2018 at 05:00:09PM +0300, Ilya Maximets wrote: > Each run

Re: [ovs-dev] [PATCH v2 2/2] table: fix html buffer output

On Wed, Aug 08, 2018 at 09:59:40AM -0400, Aaron Conole wrote: > Aaron Conole writes: > > > Prior to this commit, html output exhibiits a doppler effect for > > Ironically, I duplicated an 'i' in the word exhibits here. Let me know > if you want a respin or if it can be fixed while applying.

Re: [ovs-dev] [PATCH v2 1/2] table: append newline when printing tables

On Wed, Aug 08, 2018 at 10:15:35AM -0500, Terry Wilson wrote: > On Tue, Aug 7, 2018 at 7:34 PM, Aaron Conole wrote: > > With commit cb139fa8b3a1 ("table: New function table_format() for > > formatting a table as a string.") a new mechanism for formatting > > tables was introduced, and the

Re: [ovs-dev] [patch v5] dpctl: Make opt_dpif_open() more general.

On Tue, Aug 07, 2018 at 09:49:38PM -0700, Darrell Ball wrote: > On Tue, Aug 7, 2018 at 4:20 PM, Ben Pfaff wrote: > > > On Mon, Aug 06, 2018 at 07:24:39PM -0700, Darrell Ball wrote: > > > By making opt_dpif_open() more general, it can be used effectively > > > by all potential callers and avoids

Re: [ovs-dev] [PATCH 2/2] ofp-port: Drop of useless indirection in ofputil_pull_ofp14_port_stats().

On Wed, Aug 08, 2018 at 09:26:11AM +0100, Ian Stokes wrote: > On 7/27/2018 7:14 PM, Ben Pfaff wrote: > >Signed-off-by: Ben Pfaff > > Seems straight forward enough. LGTM. I can add this to this weeks pull > request. Thanks. This is just refactoring, so I would expect it to go to master only.

[ovs-dev] s/rhel/rpm/?

[asking some random SuSE and Red Hat people] It had somehow slipped past my notice before that the spec files we have are useful for SuSE as well as Red Hat. Should we make the directory or file names more generic? Thanks, Ben. ___ dev mailing list

Re: [ovs-dev] [PATCH v3] rhel: Use correct user in the logrotate configuration file

On Wed, Aug 08, 2018 at 05:52:55PM +0200, Timothy Redaelli wrote: > On Wed, 8 Aug 2018 17:27:25 +0300 > Markos Chandras wrote: > > > The /var/log/openvswitch directory is owned by the openvswitch user > > but logrotate could be running as root or as another user. As a > > result of which,

Re: [ovs-dev] infiniband (IPoIB) support

On Wed, Aug 08, 2018 at 09:16:11AM -0700, Gregory Rose wrote: > On 8/7/2018 3:18 PM, Ben Pfaff wrote: > >I don't know how many people on this list know anything about IPoIB. I > >know that I don't. You might not be getting an answer simply because > >it's such a specialty topic. Maybe there is

Re: [ovs-dev] [PATCH v7 07/13] dp-packet: Handle multi-seg mubfs in shift() func.

On 8/8/2018 5:06 PM, Darrell Ball wrote: On Wed, Aug 8, 2018 at 3:17 AM, Ian Stokes > wrote: On 8/7/2018 6:13 PM, Darrell Ball wrote: On Tue, Aug 7, 2018 at 5:08 AM, Stokes, Ian mailto:ian.sto...@intel.com>

Re: [ovs-dev] [PATCH] rhel: Install the network scripts in a new subpackage

Actually, we also have dependencies in the systemd service to the network service: [Unit] Description=Open vSwitch Forwarding Unit After=ovsdb-server.service network-pre.target

Re: [ovs-dev] [PATCH] rhel: Install the network scripts in a new subpackage

On Tue, Aug 07, 2018 at 06:52:10PM +0200, Timothy Redaelli wrote: > Starting from Fedora 29, the legacy network scripts are installed in > the "network-scripts" package and so the network scripts ("ifup-ovs", > "ifdown-ovs") should be installed only when the "network-scripts" package > is

Re: [ovs-dev] infiniband (IPoIB) support

On 8/7/2018 3:18 PM, Ben Pfaff wrote: I don't know how many people on this list know anything about IPoIB. I know that I don't. You might not be getting an answer simply because it's such a specialty topic. Maybe there is a place where people talk about IPoIB software; maybe they would know

Re: [ovs-dev] [PATCH v7 07/13] dp-packet: Handle multi-seg mubfs in shift() func.

On Wed, Aug 8, 2018 at 3:17 AM, Ian Stokes wrote: > On 8/7/2018 6:13 PM, Darrell Ball wrote: > > >> >> On Tue, Aug 7, 2018 at 5:08 AM, Stokes, Ian > > wrote: >> >> > In its current implementation dp_packet_shift() is also unaware of >> multi- >> > seg mbufs

Re: [ovs-dev] [PATCH v3] rhel: Use correct user in the logrotate configuration file

On Wed, 8 Aug 2018 17:27:25 +0300 Markos Chandras wrote: > The /var/log/openvswitch directory is owned by the openvswitch user > but logrotate could be running as root or as another user. As a > result of which, rpmlint prints the following warning when building > the spec file on SUSE Linux

[ovs-dev] [RFC 2/2] netdev-dpdk: Enable TSO when using multi-seg mbufs

TCP Segmentation Offload (TSO) is a feature which enables the TCP/IP network stack to delegate segmentation of a TCP segment to the hardware NIC, thus saving compute resources. This may improve performance significantly for TCP workload in virtualized environments. While a previous commit already

[ovs-dev] [RFC 1/2] netdev-dpdk: Consider packets marked for TSO.

Previously, TSO was being explicity disabled on vhost interfaces, meaning the guests wouldn't have TSO support negotiated in. With TSO negotiated and enabled, packets are now marked for TSO, through the PKT_TX_TCP_SEG flag. In order to deal with this type of packets, a new function,

[ovs-dev] [RFC 0/2] dpdk: Add support for TSO

Enabling TSO offload allows a host stack to delegate the segmentation of oversized TCP packets to the underlying physical NIC, if supported. In the case of a VM this means that the segmentation of the packets is not performed by the guest kernel, but by the host NIC itself. In turn, since the TSO

Re: [ovs-dev] [PATCH v2 1/2] table: append newline when printing tables

On Tue, Aug 7, 2018 at 7:34 PM, Aaron Conole wrote: > With commit cb139fa8b3a1 ("table: New function table_format() for > formatting a table as a string.") a new mechanism for formatting > tables was introduced, and the table_print method was refactored to > use this. > > During that refactor,

Re: [ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

Justin, I already applied this as a straightforward backport. Hope it doesn't disrupt your work. On Tue, Aug 07, 2018 at 08:31:35PM -0700, Justin Pettit wrote: > Thanks, Greg. I actually have this queued up with another patch that will > disable meters entirely on broken kernels. I plan to send

Re: [ovs-dev] [ovs-dev, v3] rhel: Use correct user in the logrotate configuration file

Bleep bloop. Greetings Markos Chandras, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 84 characters long (recommended limit is 79) #82 FILE:

Re: [ovs-dev] [PATCH v6] dpif-netdev: Avoid reordering of packets in a batch with same megaflow

On 08.08.2018 12:06, Ian Stokes wrote: > On 7/27/2018 7:26 PM, Vishal Deep Ajmera wrote: >> OVS reads packets in batches from a given port and packets in the >> batch are subjected to potentially 3 levels of lookups to identify >> the datapath megaflow entry (or flow) associated with the packet.

[ovs-dev] [PATCH] ovn-ctl: allow configuring user:group for daemons

Add two options, one for controlling the ovs daemon user/group, and the other for controlling the ovn daemon user/group. This allows a fine-grained split between OVN and OVS daemons, and keeps the syntax and user/group separation from ovs-ctl when running ovn-ctl. Signed-off-by: Aaron Conole

[ovs-dev] [PATCH v3] rhel: Use correct user in the logrotate configuration file

The /var/log/openvswitch directory is owned by the openvswitch user but logrotate could be running as root or as another user. As a result of which, rpmlint prints the following warning when building the spec file on SUSE Linux Enterprise: openvswitch.x86_64: W:

Re: [ovs-dev] [PATCH v2 2/2] table: fix html buffer output

Aaron Conole writes: > Prior to this commit, html output exhibiits a doppler effect for Ironically, I duplicated an 'i' in the word exhibits here. Let me know if you want a respin or if it can be fixed while applying. :-x > content by continually printing strings passed from >

Re: [ovs-dev] [PATCHv3] netdev-dpdk: Fix failure to configure flow control at netdev-init.

> Configuring flow control at ixgbe netdev-init is throwing error in port > start. > > For eg: without this fix, user cannot configure flow control on ixgbe dpdk > port as below, > > " > ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk \ >

Re: [ovs-dev] [PATCH v4 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

On 08/08/2018 03:24 AM, Numan Siddique wrote: On Wed, Aug 8, 2018 at 2:58 AM Ben Pfaff > wrote: On Tue, Aug 07, 2018 at 05:12:32PM -0400, Mark Michelson wrote: > On 08/07/2018 07:37 AM, nusid...@redhat.com wrote: > >From:

[ovs-dev] [PATCH v3 9/9] tests: Disable syslog for ovsdb-tool.

This is the only place where ovsdb-tool produces some logs. Also, it does not support '--timeout' option thus we can't just add it to the utils list. Let's add syslog option inplace. Signed-off-by: Ilya Maximets Acked-by: Aaron Conole --- tests/ovsdb-cluster.at | 2 +- 1 file changed, 1

[ovs-dev] [PATCH v3 7/9] tests: Disable syslog for test utils.

This disables syslog logging for: * ovs-testcontroller * test-netflow * test-ovsdb * test-sflow * test-unixctl (for cases where it's not needed) Signed-off-by: Ilya Maximets Acked-by: Aaron Conole --- tests/bridge.at | 3 ++- tests/ofproto-dpif.at

[ovs-dev] [PATCH v3 8/9] tests: Reorder logging args for ovn-sbctl in a subshell.

'--log-file' should go after '-v' arguments to avoid unwanted 'opened log file' messages. Execution is in a subshell and not covered by aliases. Signed-off-by: Ilya Maximets Acked-by: Aaron Conole --- tests/ovsdb-cluster.at | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH v3 5/9] tests: Enable only file logging by vlog/set appctl.

Logs enabled by 'appctl vlog/set' are commonly only used for 'check_logs' at the end of the test. No need to enable any other logs except for file. Patch made automatically by sed replace. Signed-off-by: Ilya Maximets Acked-by: Aaron Conole --- tests/dpif-netdev.at | 10 ++--

[ovs-dev] [PATCH v3 6/9] tests: Drop full logging for ovs-ofctl.

'-v' option removed. Found no reason to have fully verbose output from these ovs-ofctl calls. Signed-off-by: Ilya Maximets Acked-by: Aaron Conole --- tests/ofproto.at | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/ofproto.at b/tests/ofproto.at index

[ovs-dev] [PATCH v3 4/9] tests: Disable syslog for daemons.

We can not just make an alias for daemons because many of them has logging options in their command lines. Let's handle them one by one. Additionally, it's a good chance to wrap all the very long lines for better readability. Signed-off-by: Ilya Maximets Acked-by: Aaron Conole ---

[ovs-dev] [PATCH v3 3/9] tests: Disable syslog by default for control utils.

syslog messages from unit tests are not useful and only litter the system logs on build / test machines. Signed-off-by: Ilya Maximets Acked-by: Aaron Conole --- tests/ofproto-macros.at | 2 +- tests/ovs-macros.at | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

[ovs-dev] [PATCH v3 2/9] tests: Set default timeout for utils in subshell.

Aliases are not inheritable. To add a default options for utils executed in subshell we may try to catch them here and append options explicitly. There are still few cases with utils invocation in subshell inside the functions that we can not track this way, but they are not very frequent.

[ovs-dev] [PATCH v3 1/9] tests: Simplify the setting of aliases.

There is no need to create a separate function for each alias. This will simplify adding new default options and utils. Signed-off-by: Ilya Maximets Acked-by: Aaron Conole --- tests/ovs-macros.at | 35 +-- 1 file changed, 5 insertions(+), 30 deletions(-) diff

[ovs-dev] [PATCH v3 0/9] tests: Clean up syslog.

Each run of the testsuite produces millions lines in a system log. This is completely unnecessary and makes it difficult to use system logs on test / build servers. This series is aimed to disable most of the syslog messages. There are still few logs that requires significant changes in tests or

Re: [ovs-dev] [PATCH v2 0/9] tests: Clean up syslog.

On 07.08.2018 00:12, Ben Pfaff wrote: > On Mon, Aug 06, 2018 at 06:18:19PM +0300, Ilya Maximets wrote: >> On 04.08.2018 03:17, Ben Pfaff wrote: >>> On Wed, Aug 01, 2018 at 05:00:09PM +0300, Ilya Maximets wrote: Each run of the testsuite produces millions lines in a system log. This is

[ovs-dev] [PATCH] releases: Add 2.10 entry for supported DPDK versions.

This commit adds an entry for OVS 2.10 and the supported DPDK version in releases.rst. Signed-off-by: Ian Stokes --- Documentation/faq/releases.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 0f3bf0c..50ca5f6 100644

Re: [ovs-dev] [PATCH] netdev-dpdk: Use hex for PCI vendor ID.

On 8/3/2018 8:03 PM, Kevin Traynor wrote: Match the prefix and formatting. Fixes: 8a9562d21a40 ("dpif-netdev: Add DPDK netdev.") Cc: pshe...@ovn.org Signed-off-by: Kevin Traynor Thanks Kevin, I'll add this to the pull request, I think it can be backported from 2.10 -> 2.6 also. Ian ---

Re: [ovs-dev] [PATCH v7 07/13] dp-packet: Handle multi-seg mubfs in shift() func.

On 8/7/2018 6:13 PM, Darrell Ball wrote: On Tue, Aug 7, 2018 at 5:08 AM, Stokes, Ian > wrote: > In its current implementation dp_packet_shift() is also unaware of multi- > seg mbufs (that holds data in memory non-contiguously) and assumes that > data

Re: [ovs-dev] infiniband (IPoIB) support

ср, 8 авг. 2018 г. в 1:18, Ben Pfaff : > > I don't know how many people on this list know anything about IPoIB. I > know that I don't. You might not be getting an answer simply because > it's such a specialty topic. Maybe there is a place where people talk > about IPoIB software; maybe they

Re: [ovs-dev] [PATCH v6] dpif-netdev: Avoid reordering of packets in a batch with same megaflow

On 7/27/2018 7:26 PM, Vishal Deep Ajmera wrote: OVS reads packets in batches from a given port and packets in the batch are subjected to potentially 3 levels of lookups to identify the datapath megaflow entry (or flow) associated with the packet. Each megaflow entry has a dedicated buffer in

[ovs-dev] [PATCH v2] rhel: Use correct user in the logrotate configuration file

The /var/log/openvswitch directory is owned by the openvswitch user but logrotate could be running as root or as another user. As a result of which, rpmlint prints the following warning when building the spec file on SUSE Linux Enterprise: openvswitch.x86_64: W:

Re: [ovs-dev] [PATCH 2/2] ofp-port: Drop of useless indirection in ofputil_pull_ofp14_port_stats().

On 7/27/2018 7:14 PM, Ben Pfaff wrote: Signed-off-by: Ben Pfaff Seems straight forward enough. LGTM. I can add this to this weeks pull request. Thanks Ian --- lib/ofp-port.c | 30 ++ 1 file changed, 2 insertions(+), 28 deletions(-) diff --git

Re: [ovs-dev] [PATCH 1/2] ofp-port: Fix buffer overread parsing Intel custom statistics.

On 8/7/2018 1:00 AM, Ben Pfaff wrote: On Fri, Jul 27, 2018 at 11:14:43AM -0700, Ben Pfaff wrote: CC: Michal Weglicki Fixes: 971f4b394c6e ("netdev: Custom statistics.") Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9445 Signed-off-by: Ben Pfaff Still needs a review.

Re: [ovs-dev] [PATCH v4 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

On Wed, Aug 8, 2018 at 2:58 AM Ben Pfaff wrote: > On Tue, Aug 07, 2018 at 05:12:32PM -0400, Mark Michelson wrote: > > On 08/07/2018 07:37 AM, nusid...@redhat.com wrote: > > >From: Numan Siddique > > > > > >The python function ovs.socket_util.check_connection_completion() uses > select() > >

Re: [ovs-dev] [PATCH] rhel: Use openvswitch user in the logrotate configuration file

Hi Timothy, On 08/07/2018 09:01 PM, Timothy Redaelli wrote: > > Hi Markos, > I agree with you that running logrotate as root is probably bad. > > The problem is that, for backward compatibility, we keep OVS as "root" > user if you upgrade OVS from an old version (older than the non-root > user