Re: [ovs-dev] [PATCH] ofp-port: Don't leak on error in ofputil_pull_ofp14_port_stats().

2018-09-14 Thread Justin Pettit
Thanks! I pushed this to master and branch-2.10. --Justin > On Sep 14, 2018, at 3:21 PM, Yifeng Sun wrote: > > Looks good, thanks for the fix. > > Reviewed-by: Yifeng Sun > > On Fri, Sep 14, 2018 at 2:44 PM Justin Pettit wrote: > With this change, we can remove a case of free done in the

Re: [ovs-dev] [PATCH v3] gre: Rename fallback devices to avoid udev's interference

2018-09-14 Thread Justin Pettit
> On Sep 14, 2018, at 1:20 PM, Yifeng Sun wrote: > > @@ -1710,9 +1710,14 @@ static void ip6gre_destroy_tunnels(struct net *net, > struct list_head *head) > static int __net_init ip6gre_init_net(struct net *net) > { > struct ip6gre_net *ign = net_generic(net, ip6gre_net_id); > +

Re: [ovs-dev] [PATCH] ofp-port: Don't leak on error in ofputil_pull_ofp14_port_stats().

2018-09-14 Thread Yifeng Sun
Looks good, thanks for the fix. Reviewed-by: Yifeng Sun On Fri, Sep 14, 2018 at 2:44 PM Justin Pettit wrote: > With this change, we can remove a case of free done in the error code > path. > > Signed-off-by: Justin Pettit > --- > lib/ofp-port.c | 1 + > lib/ofp-print.c | 1 - > 2 files

[ovs-dev] [PATCH] ofp-port: Don't leak on error in ofputil_pull_ofp14_port_stats().

2018-09-14 Thread Justin Pettit
With this change, we can remove a case of free done in the error code path. Signed-off-by: Justin Pettit --- lib/ofp-port.c | 1 + lib/ofp-print.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ofp-port.c b/lib/ofp-port.c index ec70f46e96bb..3d1ada9ceb99 100644 ---

[ovs-dev] Re-confirm

2018-09-14 Thread DAVE Russell
Hello Sir, Am here to inform you that a package containing ATM Cards with some documents have just arrived our customs office at JFK Airport NY. Are you aware of the shipment to your address? We need your response to permit the package move. Thanks, From: DAVE Russell Supervisor U.S. Customs

Re: [ovs-dev] [PATCH] ofp-print: Fix a memory leak reported by fuzz

2018-09-14 Thread Yifeng Sun
Thanks Justin. Your attached fix is better. Yifeng On Fri, Sep 14, 2018 at 1:14 PM Justin Pettit wrote: > Thanks for the fix, Yifeng. I pushed this to master and branch-2.10. > However, after I pushed it, I noticed a couple of issues: > > - There is at least one more code path that

[ovs-dev] [PATCH v3] gre: Rename fallback devices to avoid udev's interference

2018-09-14 Thread Yifeng Sun
On certain kernel versions, when openvswitch kernel module creates a gre0 interface, the kernel’s gre module will jump out and compete to control the gre0 interface. This will cause the failure of openvswitch kernel module loading. This fix renames fallback devices by adding a prefix "ovs-".

Re: [ovs-dev] [PATCH] ofp-print: Fix a memory leak reported by fuzz

2018-09-14 Thread Justin Pettit
Thanks for the fix, Yifeng. I pushed this to master and branch-2.10. However, after I pushed it, I noticed a couple of issues: - There is at least one more code path that would have a similar issue. - The description of ofputil_decode_port_stats() states that it only needs to

Re: [ovs-dev] Revert "Revert "utilities/ovs-ctl: Force removal of ip_gre/gre""

2018-09-14 Thread Gregory Rose
Thanks Justin! -Original Message- From: Justin Pettit Sent: Friday, September 14, 2018 12:44 PM To: Yifeng Sun Cc: Gregory Rose ; ovs dev ; Gregory Rose Subject: Re: [ovs-dev] Revert "Revert "utilities/ovs-ctl: Force removal of ip_gre/gre"" Thanks, guys. I pushed this to master

[ovs-dev] [PATCH v1] rhel: retain OVS_CTL_OPTS for systemd service files

2018-09-14 Thread Martin Xu
OVS init.d script calls ovs-ctl with $OVS_CTL_OPTS defined in the config file. This variable is replaced by OPTIONS in systemd service files. This patch addes $OVS_CTL_OPTS back to be passed along with $OPTIONS for backward compatibility. VMware-BZ: #2036847 Signed-off-by: Martin Xu CC: Aaron

Re: [ovs-dev] Revert "Revert "utilities/ovs-ctl: Force removal of ip_gre/gre""

2018-09-14 Thread Justin Pettit
Thanks, guys. I pushed this to master and branch-2.10. --Justin > On Sep 13, 2018, at 10:04 AM, Yifeng Sun wrote: > > Looks good to me and testing shows no problem. Thanks Greg. > > Tested-by: Yifeng Sun > Reviewed-by: Yifeng Sun > > On Thu, Sep 13, 2018 at 9:42 AM Gregory Rose wrote: >

[ovs-dev] [PATCH v2] gre: Rename fallback devices to avoid udev's interference

2018-09-14 Thread Yifeng Sun
On certain kernel versions, when openvswitch kernel module creates a gre0 interface, the kernel’s gre module will jump out and compete to control the gre0 interface. This will cause the failure of openvswitch kernel module loading. This fix renames fallback devices by adding a prefix "ovs-".

[ovs-dev] Rackspace Users Email List

2018-09-14 Thread patricia . moore
class="gmail-m6382477193107547766gmail-msonospacing" style="background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial">style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,78,121)">Hi, 

[ovs-dev] [PATCH 2/2] OVN: add buffering support for ipv6 packets

2018-09-14 Thread Lorenzo Bianconi
Add buffering support for IPv6 packets that will be processed by nd_ns {} action when L2 address is not discovered yet since otherwise the packet will be substituted with a Neighbor Solicitation frame and this will result in the lost of the first packet of the connection Signed-off-by: Lorenzo

[ovs-dev] [PATCH 1/2] OVN: add buffering support for ipv4 packets

2018-09-14 Thread Lorenzo Bianconi
Add buffering support for IPv4 packets that will be processed by arp {} action when L2 address is not discovered yet since otherwise the packet will be substituted with an ARP frame and this will result in the lost of the first packet of the connection Signed-off-by: Lorenzo Bianconi ---

[ovs-dev] [PATCH 0/2] add buffering support for IP packets

2018-09-14 Thread Lorenzo Bianconi
Add buffering support for IP traffic that will be processed by neighboring subsystem (arp{} or nd_ns{} actions) since this will result in the lost of the first packet of the connection Lorenzo Bianconi (2): OVN: add buffering support for ipv4 packets OVN: add buffering support for ipv6

Re: [ovs-dev] [PATCH v4 6/6] system-dpdk: Connect network namespaces via dpdkvhostuser ports

2018-09-14 Thread Bala Sankaran
- Original Message - > From: "Tiago Lam" > To: "Bala Sankaran" > Cc: d...@openvswitch.org, "Aaron Conole" , "Ian Stokes" > , "Ciara Loftus" > , "anatoly burakov" > Sent: Tuesday, 11 September, 2018 6:56:00 PM > Subject: Re: [PATCH v4 6/6] system-dpdk: Connect network namespaces via >

[ovs-dev] [PATCH v5 4/6] system-dpdk: Use a different character marker for sed commands

2018-09-14 Thread Bala Sankaran
From: Aaron Conole The default marker for sed commands according to the manual is /, but this is inconvenient when working with paths. The solution is either to escape all instances of / or use sed's \cREGEXc feature. Signed-off-by: Aaron Conole --- tests/system-dpdk.at | 14 +++---

[ovs-dev] [PATCH v5 6/6] system-dpdk: Connect network namespaces via dpdkvhostuser ports

2018-09-14 Thread Bala Sankaran
This adds a few unit tests to the 'check-dpdk' subsystem that will exercise allocations of two network namespaces, PMDs, and the vhost-user and vhost-user-client code path(separate tests). As part of the tests, userspace bridge is added and attached to OVS. Also, the tap devices created are added

[ovs-dev] [PATCH v5 5/6] system-dpdk: Convert /tmp to use OVS_RUNDIR

2018-09-14 Thread Bala Sankaran
When multiple users run the DPDK testsuite their dependence on /tmp will cause conflicts. Use the RUNDIR as a dynamic path to overcome this. NOTE: This still doesn't solve the dependency on /var/run that DPDK requires. Signed-off-by: Bala Sankaran Co-authored-by: Aaron Conole Signed-off-by:

[ovs-dev] [PATCH v5 3/6] system-dpdk: Allow running the dpdk tests from a VM

2018-09-14 Thread Bala Sankaran
From: Aaron Conole Some VM configurations result in CPU flags that cause warnings to be issued by the DPDK libraries. When these warnings are issued, the tests will fail. This commit adds the unreliable tsc warning to the list of ignored warnings. Signed-off-by: Aaron Conole ---

[ovs-dev] [PATCH v5 2/6] system-dpdk: Skip all tests if there are no hugepages

2018-09-14 Thread Bala Sankaran
A failure is quite harsh in this scenario. It's better to simply skip all the tests and let the user look at the logs to understand the missing hugepages. Signed-off-by: Bala Sankaran Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole --- Documentation/topics/testing.rst | 6 ++

[ovs-dev] [PATCH v5 1/6] system-dpdk: Update test suite for non-phy testing

2018-09-14 Thread Bala Sankaran
From: Aaron Conole This allows a system that doesn't have a dedicated DPDK nic to execute some DPDK tests. In this fashion, tests that operate on virtual ports (such as dpdkvhostuserclient) can be executed in a wider set of environments. Signed-off-by: Aaron Conole Co-authored-by: Bala

[ovs-dev] [PATCH v5 0/6] Add support to connect two namespaces

2018-09-14 Thread Bala Sankaran
This allows system-dpdk test suite to ping two namespaces via a veth and dpdkvhostuser port, using testpmd as a forwarding agent. For the initial test, testpmd included with 18.11-rc0 is used, while ovs is linked against DPDK 17.11 LTS. Some additional enhancements are added to the dpdk

[ovs-dev] OVS DPDK: dpdk_merge pull request for master

2018-09-14 Thread Ian Stokes
Hi Ben, The following changes since commit 949758946767ff79b4c3eb5eca755c6cf21643e3: ovs-save: Don't always include the default flow during restore (2018-09-13 05:19:54 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge for you to fetch changes up

Re: [ovs-dev] [PATCH] conntrack: invalid packet should not modify ct state

2018-09-14 Thread Zang MingJie
>> > Did you notice this check ? >> > >> > if (src->state < CT_DPIF_TCPS_SYN_SENT) { >> > /* First packet from this end. Set its state */ >> >> Yes, this is exactly where we found the problem. If first reply packet >> is invalid, it masses all following packets. > > > > Based on your

Re: [ovs-dev] [PATCH] conntrack: invalid packet should not modify ct state

2018-09-14 Thread Darrell Ball
On Thu, Sep 13, 2018 at 1:55 AM, Zang MingJie wrote: > On Thu, Sep 13, 2018 at 2:55 AM Darrell Ball wrote: > > > > Thanks for looking MingJie > > > > > > On Wed, Sep 12, 2018 at 2:16 AM, Zang MingJie > wrote: > >> > >> When encounter an invalid packet, all changes made by the packet should >