Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-10-19 Thread Ankur Sharma
Hi Han, Appreciate your feedback. Please find the reply inline. Thanks Regards, Ankur From: Han Zhou Sent: Friday, October 19, 2018 5:17 PM To: Ankur Sharma Cc: Mark Michelson ; ovs-dev@openvswitch.org Subject: Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-10-19 Thread Han Zhou
On Fri, Oct 19, 2018 at 3:09 PM Ankur Sharma wrote: > > Hi Han, > > Thanks a lot for review. > Please find my replies inline. > > Please feel free to put forth more points for discussion. > > Thanks > > Regards, > Ankur > > > > From: Han Zhou > Sent: Thursday, October 18, 2018 11:55 PM > To:

Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-10-19 Thread Ankur Sharma
Hi Guru, Thanks for taking a look. Please find the detailed explanation of problem statement inline. Thanks Regards, Ankur From: Guru Shetty Sent: Friday, October 19, 2018 9:35 AM To: Ankur Sharma Cc: ovs-dev Subject: Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed

Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-10-19 Thread Ankur Sharma
Hi Han, Thanks a lot for review. Please find my replies inline. Please feel free to put forth more points for discussion. Thanks Regards, Ankur From: Han Zhou Sent: Thursday, October 18, 2018 11:55 PM To: Ankur Sharma Cc: Mark Michelson ; ovs-dev@openvswitch.org Subject: Re: [ovs-dev] OVN

Re: [ovs-dev] Happy to work with you.

2018-10-19 Thread Mr. Kofi Adomakoh.
- This mail is in HTML. Some elements may be ommited in plain text. - Good day, Firstly, I apologize for sending you this sensitive information via e-mail instead of a Certified/Post-mail. It is understandable that you might be a little bit apprehensive because you do not know me, But I have a

Re: [ovs-dev] [RFC PATCH v1 3/3] windows: Allow add/delete ports via HNS API

2018-10-19 Thread Sairam Venugopal
Can't you use CreateProcess or _popen to trigger the script/function directly? Thanks, Sairam On 10/8/18, 4:28 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: On Windows 2016 LTSC(RTM) the Container feature and Hyper-V feature both had DCOM API to add

Re: [ovs-dev] [RFC PATCH v1 1/3] datapath-windows: Introduce HNS OVS calls

2018-10-19 Thread Sairam Venugopal
Hi Alin, Since the hns.psm1 isn't officially supported by Microsoft, is it safe to use the script as part of the OVS repo? Also, "Invoke-HNSRequest" isn't officially documented at this time. I understand that this is an RFC, but do you know if Microsoft plans to finalize this api? If not, I

Re: [ovs-dev] [RFC PATCH v1 2/3] windows, installer: Add a new module file to the installer

2018-10-19 Thread Sairam Venugopal
Hi Alin, Thanks for the patch. Can't we have the HNSHelper.psm1 be part of the OVS.psm1 directory? Thanks, Sairam On 10/8/18, 4:27 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: This patch adds the new powershell module HNSHelper.psm1 to the OVS windows

Re: [ovs-dev] Bug open vswitch 2.10.9

2018-10-19 Thread Ben Pfaff
[adding the list back] I don't see this error on master: blp@sigabrt:~/nicira/ovs/_build(0)$ make -j10 check-oftest OFTFLAGS='-T actions.ForwardAll' make all-recursive make[1]: Entering directory '/home/blp/nicira/ovs/_build' Making all in datapath make[2]: Entering directory

Re: [ovs-dev] [PATCH v8 0/3] Support dynamic rebalancing of offloaded flows

2018-10-19 Thread Sriharsha Basavapatna via dev
Hi Eelco, Thanks for your review comments. Please see my response below. The patch-set got merged earlier today. We will address your comments in subsequent bug-fix patches. On Fri, Oct 19, 2018 at 1:27 AM Eelco Chaudron wrote: > > > > On 18 Oct 2018, at 18:13, Sriharsha Basavapatna via dev

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.10

2018-10-19 Thread Ben Pfaff
On Fri, Oct 19, 2018 at 04:07:42PM +, Stokes, Ian wrote: > Hi Ben, > > The following changes since commit 22595b3b763b9eaaf661eec40cc6926557c8696b: > > Revert "Work around Python/C JSON unicode differences" (2018-10-15 14:44:18 > -0700) > > are available in the git repository at: > >

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for master

2018-10-19 Thread Ben Pfaff
On Fri, Oct 19, 2018 at 04:07:28PM +, Stokes, Ian wrote: > Hi Ben, > > The following changes since commit 57924fc91c899ee955e30b36fed92a27a73b2ac1: > > revalidator: Rebalance offloaded flows based on the pps rate (2018-10-19 > 11:27:52 +0200) > > are available in the git repository at: >

Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-10-19 Thread Guru Shetty
On Tue, 16 Oct 2018 at 15:43, Ankur Sharma wrote: > Hi, > > We have done some effort in evaluating usage of OVN for > Distributed Virtual Routing (DVR) for vlan backed networks. > Would you mind explaining the above statement with a lot of details? I would like to understand the problem well

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.6

2018-10-19 Thread Stokes, Ian
Hi Ben, The following changes since commit 1dea6844708fb4b14024ff7dbdf78c9aa090db80: test-hash: Fix unaligned pointer value error. (2018-10-16 15:21:06 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_6 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.7

2018-10-19 Thread Stokes, Ian
Hi Ben, The following changes since commit da5fe1070e8083bf98f688cf0368540e592bed1d: test-hash: Fix unaligned pointer value error. (2018-10-16 15:21:38 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_7 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.8

2018-10-19 Thread Stokes, Ian
Hi Ben, The following changes since commit 597df6459f3b114905773c4f4dcf7e5f511cb808: tests: Fix conntrack tests expected results. (2018-10-15 15:25:31 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_8 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.9

2018-10-19 Thread Stokes, Ian
Hi Ben, The following changes since commit bcd2fa997da2173fa4075af50474d1278e7d4396: Revert "Work around Python/C JSON unicode differences" (2018-10-15 14:44:37 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_9 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.10

2018-10-19 Thread Stokes, Ian
Hi Ben, The following changes since commit 22595b3b763b9eaaf661eec40cc6926557c8696b: Revert "Work around Python/C JSON unicode differences" (2018-10-15 14:44:18 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_10 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for master

2018-10-19 Thread Stokes, Ian
Hi Ben, The following changes since commit 57924fc91c899ee955e30b36fed92a27a73b2ac1: revalidator: Rebalance offloaded flows based on the pps rate (2018-10-19 11:27:52 +0200) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge for you to fetch changes up to

Re: [ovs-dev] [PATCH v8 0/3] Support dynamic rebalancing of offloaded flows

2018-10-19 Thread Eelco Chaudron
Hi Simon, You might have missed my general comments email before you committed the patchset to master. Just now I also sent my full review, and it looks like there is one nasty memory trashing one in 3/3 which need fixing. It’s the x2nrealloc() always allocating 1 entry, but we write to

Re: [ovs-dev] [PATCH v8 3/3] revalidator: Rebalance offloaded flows based on the pps rate

2018-10-19 Thread Eelco Chaudron
On 18 Oct 2018, at 18:13, Sriharsha Basavapatna via dev wrote: This is the third patch in the patch-set to support dynamic rebalancing of offloaded flows. The dynamic rebalancing functionality is implemented in this patch. The ukeys that are not scheduled for deletion are obtained and passed

Re: [ovs-dev] [PATCH v8 2/3] revalidator: Gather packets-per-second rate of flows

2018-10-19 Thread Eelco Chaudron
On 18 Oct 2018, at 18:13, Sriharsha Basavapatna via dev wrote: This is the second patch in the patch-set to support dynamic rebalancing of offloaded flows. The packets-per-second (pps) rate for each flow is computed in the context of revalidator threads when the flow stats are retrieved. The

Re: [ovs-dev] [PATCH v8 1/3] dpif-netlink: Detect Out-Of-Resource condition on a netdev

2018-10-19 Thread Eelco Chaudron
On 18 Oct 2018, at 18:13, Sriharsha Basavapatna via dev wrote: This is the first patch in the patch-set to support dynamic rebalancing of offloaded flows. The patch detects OOR condition on a netdev port when ENOSPC error is returned by TC-Flower while adding a flow rule. A new structure is

[ovs-dev] [PATCH 3/3] netdev-dpdk: Dump flow patterns only if debug enabled.

2018-10-19 Thread Ilya Maximets
No need to waste time for fields checking in case DBG disabled. Additionally sequence of prints replaced with single print to avoid output interrupting by other log messages. Signed-off-by: Ilya Maximets --- lib/netdev-dpdk.c | 95 ++- 1 file changed,

[ovs-dev] [PATCH 2/3] netdev-dpdk: Print port name in offload API messages.

2018-10-19 Thread Ilya Maximets
This is useful for understanding which flows offloaded to which ports. Code refactored a bit to reduce number of casts. Signed-off-by: Ilya Maximets --- lib/netdev-dpdk.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/lib/netdev-dpdk.c

[ovs-dev] [PATCH 1/3] dpif-netdev: Fix cmap node use after free on flow disassociation.

2018-10-19 Thread Ilya Maximets
Data pointed by cmap node must not be freed while iterating. ovsrcu_postpone should be used instead. CC: Finn Christensen Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow") Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c | 2 +- lib/netdev-dpdk.c | 2 +- 2 files

[ovs-dev] [PATCH 0/3] Few more fixes/enhancements for rte_flow offloading.

2018-10-19 Thread Ilya Maximets
Ilya Maximets (3): dpif-netdev: Fix cmap node use after free on flow disassociation. netdev-dpdk: Print port name in offload API messages. netdev-dpdk: Dump flow patterns only if debug enabled. lib/dpif-netdev.c | 2 +- lib/netdev-dpdk.c | 123

Re: [ovs-dev] [PATCH branch-2.9] dpdk: Use DPDK 17.11.4 release.

2018-10-19 Thread Stokes, Ian
> On 10/19/2018 12:40 PM, Ian Stokes wrote: > > Modify travis linux build script to use the latest DPDK stable release > > 17.11.4. Update docs for latest DPDK stable releases. > > > > Acked-by: Kevin Traynor > Thanks Kevin. Ian ___ dev mailing list

[ovs-dev] [PATCH v1] Docs: Remove zero-copy QEMU limitation.

2018-10-19 Thread Ian Stokes
Remove note regarding zero-copy compatibility with QEMU >= 2.7. When zero-copy was introduced to OVS it was incompatible with QEMU >= 2.7. This issue has since been fixed in DPDK with commit 803aeecef123 ("vhost: fix dequeue zero copy with virtio1") and backported to DPDK LTS branches. Remove the

Re: [ovs-dev] [PATCH 1/1] dpdk: Use DPDK 17.11.4 release.

2018-10-19 Thread Kevin Traynor
On 10/19/2018 12:03 PM, Stokes, Ian wrote: >> On 09/13/2018 01:43 PM, Ian Stokes wrote: >>> Modify travis linux build script to use the latest DPDK stable release >>> 17.11.4. Update docs for latest DPDK stable releases. >>> >> >> I didn't see a specific branch-2.9 patch, and it doesn't apply due

Re: [ovs-dev] [PATCH branch-2.9] dpdk: Use DPDK 17.11.4 release.

2018-10-19 Thread Kevin Traynor
On 10/19/2018 12:40 PM, Ian Stokes wrote: > Modify travis linux build script to use the latest > DPDK stable release 17.11.4. Update docs for latest > DPDK stable releases. > Acked-by: Kevin Traynor > Signed-off-by: Ian Stokes > --- > .travis/linux-build.sh | 2 +- >

Re: [ovs-dev] Suggestion for 0-day robot.

2018-10-19 Thread Aaron Conole
Ilya Maximets writes: > Hi Aaron. > > What do you think about adding BSD build check to 0-day robot? > It'll be cool to run, for example, FreeBSD VM for checking to > cover bugs like this: > https://patchwork.ozlabs.org/patch/984844/ > > netdev-bsd and many other BSD related code is not

Re: [ovs-dev] [PATCH 1/1] dpdk: Use DPDK 17.11.4 release.

2018-10-19 Thread Stokes, Ian
> > On 09/13/2018 01:43 PM, Ian Stokes wrote: > > > Modify travis linux build script to use the latest DPDK stable > > > release 17.11.4. Update docs for latest DPDK stable releases. > > > > > > > I didn't see a specific branch-2.9 patch, and it doesn't apply due to > > the docs having moved. If

[ovs-dev] [PATCH branch-2.9] dpdk: Use DPDK 17.11.4 release.

2018-10-19 Thread Ian Stokes
Modify travis linux build script to use the latest DPDK stable release 17.11.4. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 4 ++-- Documentation/intro/install/dpdk.rst

Re: [ovs-dev] [PATCH branch-2.7] dpdk: Use DPDK 16.11.8 release.

2018-10-19 Thread Stokes, Ian
> On 09/13/2018 02:29 PM, Ian Stokes wrote: > > Modify travis linux build script to use the latest DPDK stable release > > 16.11.8. Update docs for latest DPDK stable releases. > > > > Acked-by: Kevin Traynor > Thanks Kevin. Ian ___ dev mailing list

Re: [ovs-dev] [PATCH 1/1] dpdk: Use DPDK 17.11.4 release.

2018-10-19 Thread Stokes, Ian
> On 09/13/2018 01:43 PM, Ian Stokes wrote: > > Modify travis linux build script to use the latest DPDK stable release > > 17.11.4. Update docs for latest DPDK stable releases. > > > > I didn't see a specific branch-2.9 patch, and it doesn't apply due to > the docs having moved. If you are

Re: [ovs-dev] [PATCH 1/1] dpdk: Use DPDK 17.11.4 release.

2018-10-19 Thread Kevin Traynor
On 09/13/2018 01:43 PM, Ian Stokes wrote: > Modify travis linux build script to use the latest > DPDK stable release 17.11.4. Update docs for latest > DPDK stable releases. > I didn't see a specific branch-2.9 patch, and it doesn't apply due to the docs having moved. If you are intending it for

Re: [ovs-dev] [PATCH branch-2.7] dpdk: Use DPDK 16.11.8 release.

2018-10-19 Thread Kevin Traynor
On 09/13/2018 02:29 PM, Ian Stokes wrote: > Modify travis linux build script to use the latest > DPDK stable release 16.11.8. Update docs for latest > DPDK stable releases. > Acked-by: Kevin Traynor > Signed-off-by: Ian Stokes > --- > .travis/linux-build.sh | 2 +- >

Re: [ovs-dev] [PATCH v11 0/7] OVS-DPDK flow offload with rte_flow

2018-10-19 Thread Ilya Maximets
> On Thu, Jun 28, 2018 at 02:39:32PM -0300, Flavio Leitner wrote: >> Ian, I am afraid that the issue might be local and we most probably can >> fix with a follow up patch later, so if others are happy with the patchset, >> please go ahead. I can see this only in the mid of next week. > > The

Re: [ovs-dev] [PATCH v8 0/3] Support dynamic rebalancing of offloaded flows

2018-10-19 Thread Simon Horman
On Thu, Oct 18, 2018 at 09:43:11PM +0530, Sriharsha Basavapatna via dev wrote: > With the current OVS offload design, when an offload-device fails to add a > flow rule and returns an error, OVS adds the rule to the kernel datapath. > The flow gets processed by the kernel datapath for the entire

[ovs-dev] Crypto BOOM{Doubling/Increase Your Bitcoin}

2018-10-19 Thread Quin Edena
Unsubscribe Here Do you wish to get your Bitcoin Doubled, Are you a Bitcoin Miner, Bitcoin Investor OR Want to invest in Bitcoin???. Here is a reliable profit making Bitcoin Investment/Mining

Re: [ovs-dev] [PATCH v2] connmgr: Fix vswitchd abort when a port is added and the controller is down

2018-10-19 Thread Eelco Chaudron
On 18 Oct 2018, at 13:17, nusid...@redhat.com wrote: From: Numan Siddique We see the below trace when a port is added to a bridge and the configured controller is down 0x7fb002f8b207 in raise () from /lib64/libc.so.6 0x7fb002f8c8f8 in abort () from /lib64/libc.so.6

Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-10-19 Thread Han Zhou
Hi Ankur, Mark, Please find my comments inline below. (I will spend more time to understand the change for the NAT case. ) Thanks, Han On Thu, Oct 18, 2018 at 4:40 PM Ankur Sharma wrote: > > Hi, > > As per our discussion in the IRC meeting today, i have added all the diagrams in following