Thanks Ben for code review. I will leave explanation here for later
reference.
When md2 context is a string of size 248, the headers's total length would
be 256
bytes. Because there is only 6 bits in ver_flags_ttl_len for length value,
the value of ver_flags_ttl_len is a wrong value of 0.
In
On Tue, Oct 23, 2018 at 02:59:08PM -0700, Justin Pettit wrote:
>
> > On Aug 30, 2018, at 1:00 PM, Ben Pfaff wrote:
> >
> > Table features should indicate the table number as well as the table
> > name. Before this, the first line for each table looked like this:
> > table myname ("myname"):
On Fri, Oct 26, 2018 at 03:06:28PM -0700, Zak Whittington wrote:
> Backported OFPT14_REQUESTFORWARD to OF1.0-1.3.
> OF 1.0-1.2 use an NXT Nicira extension while OF 1.3
> uses an ONF extension (ONF version is specified in a
> previously published ONF spec sheet).
>
> Includes ofp-print tests for
Backported OFPT14_REQUESTFORWARD to OF1.0-1.3.
OF 1.0-1.2 use an NXT Nicira extension while OF 1.3
uses an ONF extension (ONF version is specified in a
previously published ONF spec sheet).
Includes ofp-print tests for multiple inner message
types, and multiple OF versions including the NXT and
On Tue, Oct 23, 2018 at 02:00:20PM -0700, Justin Pettit wrote:
>
> > On Oct 23, 2018, at 9:26 AM, Ben Pfaff wrote:
> >
> > Reported-by: lidejun
> > Signed-off-by: Ben Pfaff
>
> Acked-by: Justin Pettit
Thanks, applied to master.
___
dev mailing
On Fri, Oct 26, 2018 at 02:55:55PM -0700, Ben Pfaff wrote:
> On Thu, Oct 25, 2018 at 02:41:50PM -0700, Yifeng Sun wrote:
> > In the filed of ver_flags_ttl_len of struct nshhdr, there are only 6
> > bits that are used to indicate header's total length in 4-byte words.
> > Therefore, the max value
On Thu, Oct 25, 2018 at 02:41:50PM -0700, Yifeng Sun wrote:
> In the filed of ver_flags_ttl_len of struct nshhdr, there are only 6
> bits that are used to indicate header's total length in 4-byte words.
> Therefore, the max value for total is 252 (63x4), instead of 256 used
> in present code base.
On Thu, Oct 25, 2018 at 04:17:23PM -0700, Yifeng Sun wrote:
> When parse_ofp_flow_mod_str returns error, `fm` is incomplete and pointers
> in it may be null, e.g. fm.match.flow. In this case, passing it to
> ofctl_parse_flows__ may cause pointer errors because ofctl_parse_flows__
> expects a valid
Looks good, Lorenzo,
Just to reaaffirm my previous ack:
Acked-by: Mark Michelson
On 10/26/2018 12:20 PM, Lorenzo Bianconi wrote:
Add the possibility to specify a given mac address prefix for
dynamically generated mac address. Mac address prefix can be
specified in nbdb NB_Global table,
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
fatal: sha1 information is lacking or useless (ovn/northd/ovn-northd.c).
Repository lacks
Hi Ansis. Do you plan to further review this series or should I take a
look at it in hopes of merging it?
Thanks,
Ben.
On Wed, Sep 19, 2018 at 05:15:52PM -0400, Qiuyu Xiao wrote:
> This patch series reintroduce IPsec support for OVS tunneling and enable
> OVN to
> use IPsec tunnels. GRE,
Configure L2 dynamic address according to used IPv4 address.
This patch allows to define a deterministic relationship between
L2 and L3 addresses when dynamic IPAM is used.
This patch allows to fix a possible L2/L3 address mismatch than can
occur when pods are created and destroyed at high rate
Visit all ovn datapaths before adding new dynamic addresses to the
system in order to avoid possible L2 address duplication when
the same MAC address is configured on different ovn logical switches.
Current implementation can miss the duplicated address since macam
is cleared at each ovn run and
When dynamic IPAM is used configure L2 address according to the used
IPv4 address.
Moreover visit all ovn datapaths before adding new dynamic addresses to the
system in order to avoid possible L2 address duplication
This patchset is based on top of 'OVN: introduce mac_prefix support to IPAM'
Add the possibility to specify a given mac address prefix for
dynamically generated mac address. Mac address prefix can be
specified in nbdb NB_Global table, options:mac_prefix=
This patch fix a possible issue of L2 address duplication if
multiple OVN deployments share a single broadcast domain
>
> Hi Lorenzo,
>
> I think for the patch, I'm willing to ack it, so:
>
> Acked-by: Mark Michelson
>
> However, I have some minor suggestions below that might be worth making
> a second version of the patch for.
Thx for the review Mark, I will address your comments and send a v2
Regards,
Hi Lorenzo,
I think for the patch, I'm willing to ack it, so:
Acked-by: Mark Michelson
However, I have some minor suggestions below that might be worth making
a second version of the patch for.
On 10/23/2018 06:01 AM, Lorenzo Bianconi wrote:
Add the possibility to specify a given mac
dear...@openvswitch.org ___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> Report the link speed of the device in netdev_dpdk_get_status()
> function.
>
> Link speed is already reported as part of the netdev_get_features()
> function. However only link speeds defined in the OpenFlow specs are
> supported so speeds such as 25 Gbps etc. are not shown. The link
> speed
> This commit fixes netdev_dpdk_get_features() by initializing a bitmap
> that represents current features to zero and accounting for non defined
> link speed values in the OpenFlow spec.
>
> The current approach for retrieving netdev dpdk features uses a
> pointer allocated in the stack without
Hi Nitin,
Thanks for your work on this and sharing the RFC. Initial comments below.
On 10/11/2018 08:59 PM, Nitin Katiyar wrote:
> Port rx queues that have not been statically assigned to PMDs are currently
> assigned based on periodically sampled load measurements.
> The assignment is performed
On 26 Oct 2018, at 11:53, Simon Horman wrote:
> On Fri, 26 Oct 2018 at 08:58, Eelco Chaudron wrote:
>
I have a general comment, don't know where to put it, so I put it
here.
Some hardware might have multiple tables. If one type of table is
full
the ENOSPC might be
On Fri, 26 Oct 2018 at 08:58, Eelco Chaudron wrote:
>
>
> On 25 Oct 2018, at 16:00, Sriharsha Basavapatna wrote:
>
> > Hi Eelco,
> >
> > Thanks for your comments, please see my response below.
> > On Fri, Oct 19, 2018 at 7:52 PM Eelco Chaudron
> > wrote:
> >>
> >> On 18 Oct 2018, at 18:13,
On 25 Oct 2018, at 16:02, Sriharsha Basavapatna wrote:
Hi Eelco,
Thanks for your review comments. Please see my response below.
On Fri, Oct 19, 2018 at 7:53 PM Eelco Chaudron
wrote:
On 18 Oct 2018, at 18:13, Sriharsha Basavapatna via dev wrote:
This is the third patch in the patch-set
On 25 Oct 2018, at 16:01, Sriharsha Basavapatna wrote:
Hi Eelco,
Thanks for your comments, please see my response below.
On Fri, Oct 19, 2018 at 7:52 PM Eelco Chaudron
wrote:
On 18 Oct 2018, at 18:13, Sriharsha Basavapatna via dev wrote:
This is the second patch in the patch-set to
On 25 Oct 2018, at 16:00, Sriharsha Basavapatna wrote:
Hi Eelco,
Thanks for your comments, please see my response below.
On Fri, Oct 19, 2018 at 7:52 PM Eelco Chaudron
wrote:
On 18 Oct 2018, at 18:13, Sriharsha Basavapatna via dev wrote:
This is the first patch in the patch-set to
26 matches
Mail list logo