Re: [ovs-dev] dpif: Restore a few lines with form feed characters

2018-10-28 Thread 0-day Robot
Bleep bloop. Greetings Sriharsha Basavapatna via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Sriharsha Basavapatna via dev needs to sign off. WARNING:

[ovs-dev] [PATCH] dpif: Restore a few lines with form feed characters

2018-10-28 Thread Sriharsha Basavapatna via dev
A few lines with form feed characters (ASCII: ^L) were accidentally deleted by a recent commit to support rebalancing of offloaded flows. This patch reverts those lines. Fixes: 57924fc91c ("revalidator: Rebalance offloaded flows") Signed-off-by: Sriharsha Basavapatna --- lib/dpif.c

Re: [ovs-dev] [PATCH] RFC for support of PMD Auto load balancing

2018-10-28 Thread Nitin Katiyar
Thanks Kevin for reviewing it. I will look into your comments and send the new version for review. I would like to clarify that it samples load every 10 seconds and if the criterion for triggering dry run (i.e load threshold and/or drops) is met for consecutive 6 iterations then only it will

Re: [ovs-dev] 8021q module is not loaded when adding vlan through ovs (ovs-vsctl)

2018-10-28 Thread Jiri Pirko
Sun, Oct 28, 2018 at 03:03:42PM CET, michaels...@gmail.com wrote: >Jiri, >I am not sure it would be simple to move the add_offload to vlan_Core.c as >the add_offload should happen once. Just call it from net_dev_init() >in vlan.c it's done as part of module init but in vlan_core.c we are not

Re: [ovs-dev] 8021q module is not loaded when adding vlan through ovs (ovs-vsctl)

2018-10-28 Thread Michael Shteinbok
Jiri, I am not sure it would be simple to move the add_offload to vlan_Core.c as the add_offload should happen once. in vlan.c it's done as part of module init but in vlan_core.c we are not initializing any model and making some logic for doing that once looks awkward to me. Why can't we just load