[ovs-dev] [branch 2.10][PATCH] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-11-05 Thread nusiddiq
From: Numan Siddique When 'make check' is called by the mock rpm build (which disables networking), the test "ovn-nbctl: LBs - daemon" fails when it runs the command "ovn-nbctl lb-add lb0 30.0.0.1a 192.168.10.10:80,192.168.10.20:80". ovn-nbctl extracts the vip by calling the socket util function

Re: [ovs-dev] [PATCH] dns-resolve: Stop dns resolving when dns servers are configured.

2018-11-05 Thread Ben Pfaff
[CCing Alin for his opinion on Windows issue] On Mon, Nov 05, 2018 at 04:20:18PM -0800, Yifeng Sun wrote: > DNS resolution should fail if no DNS servers are available. This > patch fixes it and also enables users to use environment variable > OVS_RESOLV_CONF to specify the path for DNS server

Re: [ovs-dev] OvS 2.10 MTU greater than 1518 - not working

2018-11-05 Thread Shahaji Bhosle via dev
Hi Ben/Ilya, Sorry for the delay, we are not able to reproduce this issue :( Thanks for the help. Shahaji On Wed, Oct 17, 2018 at 4:04 PM Shahaji Bhosle wrote: > Thanks Ben/Ilya, > Will give that a shot and update, I had to roll back to 2.9. But will > update. Thanks again and appreciate the

[ovs-dev] Error at ovsdb-cluster.at:204

2018-11-05 Thread Ashish Varma
Not sure if this is reported before. I am seeing failure (not always) at the following line when running the test ten times in the main branch: i=10;while [ $i -gt 0 ]; do make check TESTSUITEFLAGS='2485' | grep "2485: OVSDB 3-server torture test"; i=$((i-1)); done 2485: OVSDB 3-server torture

[ovs-dev] [PATCH] dns-resolve: Stop dns resolving when dns servers are configured.

2018-11-05 Thread Yifeng Sun
DNS resolution should fail if no DNS servers are available. This patch fixes it and also enables users to use environment variable OVS_RESOLV_CONF to specify the path for DNS server configuration file. Suggested-by: Ben Pfaff Suggested-by: Mark Michelson Signed-off-by: Yifeng Sun ---

Re: [ovs-dev] [PATCH v1 3/3] Vlan Support in ovn, northd changes to read logical switch network type.

2018-11-05 Thread Ben Pfaff
I don't see where this series actually changes behavior on the hypervisors. Can you help me see it? It's not clear to me that these are really three independent patches. Usually, for example, there is no reason to separate a change to the northbound schema and ovn-nbctl changes to enable use of

Re: [ovs-dev] [PATCH v1 2/3] Vlan Support in ovn, add nbctl commands to set network type

2018-11-05 Thread Ben Pfaff
On Fri, Oct 26, 2018 at 01:39:43AM +, Ankur Sharma wrote: > As a part of proposal for distributed virtual routing > for VLAN networks through OVN, this series has code changes > for Layer 2. > > [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html > [2] >

Re: [ovs-dev] [PATCH v1 1/3] Vlan Support in ovn, add network type in northbound schema

2018-11-05 Thread Ben Pfaff
On Fri, Oct 26, 2018 at 01:39:35AM +, Ankur Sharma wrote: > This Patch: > a. Add 1 more column to the Logical_Switch table in north bound >schema, to indicate if a logical switch is of type "vlan" or "overlay". >We will support NULL value in this table as well, to keep it backward >

Re: [ovs-dev] [PATCH] [RFC] Add a new OVS action check_pkt_larger

2018-11-05 Thread Ben Pfaff
On Mon, Nov 05, 2018 at 09:45:10PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This patch adds a new action 'check_pkt_larger' which checks if the > packet is larger than the given size and stores the result in the > destination register. > > Usage:

Re: [ovs-dev] [PATCH V2] erspan: fix error handling for erspan tunnel

2018-11-05 Thread Ben Pfaff
On Mon, Nov 05, 2018 at 11:53:33AM -0800, Gregory Rose wrote: > > On 11/5/2018 11:38 AM, Ben Pfaff wrote: > >On Mon, Nov 05, 2018 at 11:07:17AM -0800, Gregory Rose wrote: > >>On 11/5/2018 7:52 AM, Ben Pfaff wrote: > >>>Where can I find this patch? It is not in patchwork, nor in my personal >

Re: [ovs-dev] [PATCH -v2] checkpatch: fix typographical error

2018-11-05 Thread Bala Sankaran
- Original Message - > From: "Ben Pfaff" > To: "Bala Sankaran" > Cc: ovs-dev@openvswitch.org > Sent: Monday, November 5, 2018 2:45:09 PM > Subject: Re: [ovs-dev] [PATCH -v2] checkpatch: fix typographical error > > On Mon, Nov 05, 2018 at 01:37:32PM -0500, Bala Sankaran wrote: > > A

Re: [ovs-dev] [PATCH v2] OVN: introduce mac_prefix support to IPAM

2018-11-05 Thread Ben Pfaff
On Mon, Nov 05, 2018 at 06:17:54PM +0100, Lorenzo Bianconi wrote: > > > > Thanks for the patch. > > Hi Ben, > > thx for the review. Few comments inline. > > Regards, > Lorenzo > > > > > I'm not sure in what circumstances a broadcast domain would be shared > > among deployments. I tend to

Re: [ovs-dev] [PATCH V2] erspan: fix error handling for erspan tunnel

2018-11-05 Thread Ben Pfaff
On Mon, Nov 05, 2018 at 11:07:17AM -0800, Gregory Rose wrote: > On 11/5/2018 7:52 AM, Ben Pfaff wrote: > >Where can I find this patch? It is not in patchwork, nor in my personal > >email archive. > > > >Thanks, > > > >Ben. > > Here: > > From: Haishuang Yan > > Upstream commit: > commit

Re: [ovs-dev] OVN/OVS Split amended proposal

2018-11-05 Thread Ben Pfaff
On Mon, Nov 05, 2018 at 12:49:31PM -0500, Mark Michelson wrote: > On 11/02/2018 03:59 PM, Ben Pfaff wrote: > >On Fri, Nov 02, 2018 at 03:13:35PM -0400, Mark Michelson wrote: > >>With this in mind, we'd like to propose an amended plan. > > > >[...] > > > >>In order to facilitate this, OVS will need

Re: [ovs-dev] [PATCH V2] erspan: fix error handling for erspan tunnel

2018-11-05 Thread Gregory Rose
On 11/5/2018 7:52 AM, Ben Pfaff wrote: Where can I find this patch? It is not in patchwork, nor in my personal email archive. Thanks, Ben. Here: From: Haishuang Yan Upstream commit: commit 51dc63e3911fbb1f0a7a32da2fe56253e2040ea4 Author: Haishuang Yan Date: Mon Sep 10

[ovs-dev] [PATCH -v2] checkpatch: fix typographical error

2018-11-05 Thread Bala Sankaran
A typographical error in a prompt for missing python enchant library is identified and fixed. v2: * Rebasing done to resolve previous conflicts Signed-off-by: Bala Sankaran --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/checkpatch.py

Re: [ovs-dev] OVN/OVS Split amended proposal

2018-11-05 Thread Mark Michelson
On 11/02/2018 03:59 PM, Ben Pfaff wrote: On Fri, Nov 02, 2018 at 03:13:35PM -0400, Mark Michelson wrote: With this in mind, we'd like to propose an amended plan. [...] In order to facilitate this, OVS will need to be outfitted with ways for OVN to probe for the existence of features at

Re: [ovs-dev] [PATCH v2] OVN: introduce mac_prefix support to IPAM

2018-11-05 Thread Lorenzo Bianconi
> > Thanks for the patch. Hi Ben, thx for the review. Few comments inline. Regards, Lorenzo > > I'm not sure in what circumstances a broadcast domain would be shared > among deployments. I tend to think of OVN L2 networks as contained. > But I guess this patch was written for a reason, so it

Re: [ovs-dev] [PATCH v2] OVN: introduce mac_prefix support to IPAM

2018-11-05 Thread Ben Pfaff
Thanks for the patch. I'm not sure in what circumstances a broadcast domain would be shared among deployments. I tend to think of OVN L2 networks as contained. But I guess this patch was written for a reason, so it must be common enough. I can see at least two possible routes here: - The

[ovs-dev] [PATCH] [RFC] Add a new OVS action check_pkt_larger

2018-11-05 Thread nusiddiq
From: Numan Siddique This patch adds a new action 'check_pkt_larger' which checks if the packet is larger than the given size and stores the result in the destination register. Usage: check_pkt_larger:len->REGISTER Eg. match=...,actions=check_pkt_larger:1442->NXM_NX_REG0[0],next; When

Re: [ovs-dev] [PATCH] checkpatch: fix a typographical error

2018-11-05 Thread Bala Sankaran
- Original Message - > From: "Ben Pfaff" > To: "Bala Sankaran" > Cc: ovs-dev@openvswitch.org > Sent: Monday, November 5, 2018 10:10:07 AM > Subject: Re: [ovs-dev] [PATCH] checkpatch: fix a typographical error > > On Mon, Nov 05, 2018 at 09:38:23AM -0500, Bala Sankaran wrote: > > A

Re: [ovs-dev] [PATCH V2] erspan: fix error handling for erspan tunnel

2018-11-05 Thread Ben Pfaff
Where can I find this patch? It is not in patchwork, nor in my personal email archive. Thanks, Ben. On Thu, Nov 01, 2018 at 09:29:54AM -0700, Gregory Rose wrote: > On 11/1/2018 9:04 AM, William Tu wrote: > >Looks good to me, sorry for my late reply! > > No worries, it sort of fell off my

Re: [ovs-dev] [PATCH] ovn-northd: Always set nat_addresses and options in Port_Binding.

2018-11-05 Thread Ben Pfaff
On Mon, Nov 05, 2018 at 08:55:51PM +0530, Numan Siddique wrote: > On Fri, Nov 2, 2018 at 10:40 PM Ben Pfaff wrote: > > > In some cases the code didn't set these columns. > > > > Found by inspection. > > > > Signed-off-by: Ben Pfaff > > > > Acked-by: Numan Siddique Thanks, applied to master.

Re: [ovs-dev] [PATCH v2] odp-util: Validate close-brace in scan_geneve and fix return values of san_xxx functions

2018-11-05 Thread Ben Pfaff
On Thu, Nov 01, 2018 at 10:33:03AM -0700, Yifeng Sun wrote: > This patch adds validation of close-braces in scan_geneve. An simple > example is "set(encap(tunnel(geneve({{". When scan_geneve returns, > (struct geneve_scan *key)->len equals to 2*sizeof(struct geneve_opt). > That seems not

Re: [ovs-dev] [PATCH] ovn-northd: Always set nat_addresses and options in Port_Binding.

2018-11-05 Thread Numan Siddique
On Fri, Nov 2, 2018 at 10:40 PM Ben Pfaff wrote: > In some cases the code didn't set these columns. > > Found by inspection. > > Signed-off-by: Ben Pfaff > Acked-by: Numan Siddique > --- > ovn/northd/ovn-northd.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [ovs-dev] [PATCH v4] ovn-nbctl: Fix the ovn-nbctl test "LBs - daemon" which fails during rpm build

2018-11-05 Thread Ben Pfaff
On Fri, Nov 02, 2018 at 05:11:01PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > When 'make check' is called by the mock rpm build (which disables networking), > the test "ovn-nbctl: LBs - daemon" fails when it runs the command > "ovn-nbctl lb-add lb0 30.0.0.1a

Re: [ovs-dev] [PATCH] checkpatch: fix a typographical error

2018-11-05 Thread Ben Pfaff
On Mon, Nov 05, 2018 at 09:38:23AM -0500, Bala Sankaran wrote: > A typographical error in a prompt for missing > python enchant library is identified and fixed. > > Signed-off-by: Bala Sankaran Thanks for the fix. This patch doesn't apply, probably because of a recent change in the same area.

Re: [ovs-dev] checkpatch: fix a typographical error

2018-11-05 Thread 0-day Robot
Bleep bloop. Greetings Bala Sankaran, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 checkpatch: fix a typographical error The

[ovs-dev] [PATCH] checkpatch: fix a typographical error

2018-11-05 Thread Bala Sankaran
A typographical error in a prompt for missing python enchant library is identified and fixed. Signed-off-by: Bala Sankaran --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 5f5dd8318..22f168409

[ovs-dev] b2b executives leads

2018-11-05 Thread Janessa Glory
Hi, Hope you are doing well! We are global data base vendors and we do maintain *42 million records from all industry globally.* Please let me know if you would like to reach any of your target criteria, will get back to you with the *counts and cost information*. The major industries that

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for master

2018-11-05 Thread Stokes, Ian
> On Fri, Nov 02, 2018 at 05:33:39PM +, Stokes, Ian wrote: > > Hi Ben, > > > > The following changes since commit > af26093ab197c309dc0cfa83c5a2db34706f6021: > > > > connmgr: Improve interface for setting controllers. (2018-10-31 > 16:04:36 -0700) > > > > are available in the git repository