Re: [ovs-dev] [PATCH v5] :Improved Packet Drop Statistics in OVS

2019-01-07 Thread Gowrishankar Muthukrishnan
Ignore below comment as I slightly overlooked it. invalid port is right drop reason. Thanks, Gowrishankar On Mon, Jan 7, 2019 at 6:12 PM Gowrishankar Muthukrishnan < gmuth...@redhat.com> wrote: > Hi Anju, > > On Mon, Jan 7, 2019 at 3:30 PM Anju Thomas > wrote: > >> >> switch ((enum ovs_act

Re: [ovs-dev] [PATCH v2 1/2] conntrack: fix tcp seq adjustments when mangling commands

2019-01-07 Thread Darrell Ball
Thanks for the multiple seq_skew changes David. Its easy enough to support although I wonder if it is standard and the added usefulness seems minimal. comments inline On Thu, Dec 20, 2018 at 5:33 AM David Marchand wrote: > The ftp alg deals with packets in two ways for the command connection: >

Re: [ovs-dev] [PATCH v2 2/2] conntrack: fix expectations nat configuration for ftp+DNAT

2019-01-07 Thread Darrell Ball
Thanks for the fix David. On Thu, Dec 20, 2018 at 5:33 AM David Marchand wrote: > When configuring the nat part of an expectation, care must be taken to > look at the master nat action and direction to properly reproduce it. > > The FTP passive mode test is switched to DNAT since the alg only ma

Re: [ovs-dev] OVN/OVS split: code splitting strategies

2019-01-07 Thread Justin Pettit
> On Dec 13, 2018, at 2:06 PM, Mark Michelson wrote: Thanks for pulling this together, Mark. Here are some of my initial thoughts: > To get the ball rolling, here are some ideas I thought of, with some pros and > cons for each one. > > 1) Separate components in separate repos > In this appr

Re: [ovs-dev] [PATCH v2 1/1] utilities: Update gdb script so it works with all python versions

2019-01-07 Thread Eelco Chaudron
Thanks for reporting this. I sent out a v3, and also tested all commands on Python2 and 3. We should be good to go now ;) //Eelco On 6 Jan 2019, at 9:36, solomon wrote: Eelco Chaudron wrote: Newer versions of Python require a different iterator function. This change will make the iterator c

[ovs-dev] [PATCH v3 1/1] utilities: Update gdb script so it works with all python versions

2019-01-07 Thread Eelco Chaudron
Newer versions of Python require a different iterator function. This change will make the iterator classes work with all Python versions. Adds a fix for python3 as it does not support the long() type. The fix guaranties the script still works on Python 2.7. The uKey walker is rather slow on pytho

Re: [ovs-dev] Adding support for PMD auto load balancing

2019-01-07 Thread 0-day Robot
Bleep bloop. Greetings Nitin Katiyar, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: reading sources... [ 87%] topics/ovsdb-replication reading sources... [ 88%] topics/porting reading

[ovs-dev] [PATCH] selinux: Add missing permissions for ovs-kmod-ctl

2019-01-07 Thread Yi-Hung Wei
Starting from OVS 2.10, ovs-vswitchd may fail to run after system reboot since it fails to load ovs kernel module. It is because the conntrack zone limit feature introduced in OVS 2.10 now depends on nf_conntrack_ipv4/6 kernel module, and the SELinux prevents it to load the two kernel modules. Ex

[ovs-dev] Servicio Tecnico de Aire Acondicionado

2019-01-07 Thread Central Frio via dev
SERVICIO TECNICO Split y Centrales ( http://bit.ly/2vyTuYf ) - Brindamos mantenimiento en todas las marcas. - Limpieza de filtros. - Mantenimiento preventivos para empresas. - Instalacion ( http://bit.ly/2vyTuYf ) CONSULTAS - CLICK ACA ( mailto:i...@centralfrio.com.ar ) . Urgencias: Tel: 011-4766-9

[ovs-dev] [PATCH v3] Adding support for PMD auto load balancing

2019-01-07 Thread Nitin Katiyar
Port rx queues that have not been statically assigned to PMDs are currently assigned based on periodically sampled load measurements. The assignment is performed at specific instances – port addition, port deletion, upon reassignment request via CLI etc. Due to change in traffic pattern over time

Re: [ovs-dev] [PATCH v5] :Improved Packet Drop Statistics in OVS

2019-01-07 Thread Gowrishankar Muthukrishnan
Hi Anju, On Mon, Jan 7, 2019 at 3:30 PM Anju Thomas wrote: > > switch ((enum ovs_action_attr)type) { > case OVS_ACTION_ATTR_OUTPUT: > @@ -6548,6 +6625,8 @@ dp_execute_cb(void *aux_, struct dp_packet_batch > *packets_, > dp_packet_batch_add(&p->output_pkts, packet); >

Re: [ovs-dev] Improved Packet Drop Statistics in OVS

2019-01-07 Thread 0-day Robot
Bleep bloop. Greetings Anju Thomas, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: :416: new blank line at EOF. + warning: 1 line adds whitespace errors. Please check this out. If

[ovs-dev] [PATCH v5] :Improved Packet Drop Statistics in OVS

2019-01-07 Thread Anju Thomas
Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by controllers that know the sema