Re: [ovs-dev] [PATCH v6 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-12 Thread Christian Ehrhardt
On Tue, Feb 12, 2019 at 11:47 PM Ben Pfaff wrote: > > On Tue, Feb 12, 2019 at 07:29:58AM +0100, Christian Ehrhardt wrote: > > DPDK 18.11 builds using the more modern meson build system no more > > provide the -ldpdk linker script. Instead it is expected to use > > pkgconfig for linker options as

Re: [ovs-dev] [patch v4 2/2] conntrack: Exclude l2 padding in 'conn_key_extract()'.

2019-02-12 Thread Nitin Katiyar
Hi, We would like to get it backported till OVS 2.6 at least. Regards, Nitin > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, February 12, 2019 9:13 AM > To: Darrell Ball > Cc: d...@openvswitch.org; Nitin Katiyar > Subject: Re: [ovs-dev] [patch v4 2/2]

Re: [ovs-dev] [patch v12 8/8] Userspace datapath: Add fragmentation handling.

2019-02-12 Thread Darrell Ball
Thanks very much Ben On Mon, Feb 11, 2019 at 5:33 PM Ben Pfaff wrote: > On Sun, Feb 10, 2019 at 06:56:30PM -0800, Darrell Ball wrote: > > Fragmentation handling is added for supporting conntrack. > > Both v4 and v6 are supported. > > > > After discussion with several people, I decided to not

[ovs-dev] dringende Antwort erforderlich

2019-02-12 Thread Global Reliance Credit® via dev
Schöne Grüße Ich bin Mr.Patrick William von einem globalen Kreditkreditunternehmen, bekannt als Global Reliance Credit®. Wir bieten alle Arten von Darlehen zu einem Zinssatz von 1% an. Wenn Sie einen Kredit benötigen, kontaktieren Sie uns bitte mit den untenstehenden Informationen.

Re: [ovs-dev] [PATCH] debian: Add libelf-dev dependency for dkms

2019-02-12 Thread Ben Pfaff
On Tue, Feb 12, 2019 at 02:49:40PM -0800, Gregory Rose wrote: > On 2/12/2019 2:22 PM, Ben Pfaff wrote: > > On Tue, Feb 12, 2019 at 12:37:03PM -0800, Greg Rose wrote: > > > Newer kernels define CONFIG_UNWINDER_ORC for their kernel configurations > > > and to build this the kernel compilation

Re: [ovs-dev] [PATCH v1] doc: Add "Representors" topic document

2019-02-12 Thread Ophir Munk
> -Original Message- > From: Ian Stokes > Sent: Tuesday, February 12, 2019 7:17 PM > To: Ilya Maximets ; Ophir Munk > ; ovs-dev@openvswitch.org > Cc: Olga Shern ; Kevin Traynor > ; Asaf Penso ; Thomas > Monjalon > Subject: Re: [PATCH v1] doc: Add "Representors" topic document > > On

Re: [ovs-dev] [PATCH] debian: Add libelf-dev dependency for dkms

2019-02-12 Thread Gregory Rose
On 2/12/2019 2:22 PM, Ben Pfaff wrote: On Tue, Feb 12, 2019 at 12:37:03PM -0800, Greg Rose wrote: Newer kernels define CONFIG_UNWINDER_ORC for their kernel configurations and to build this the kernel compilation requires the libelf-dev package. Add the dependency to the dkms build

Re: [ovs-dev] [PATCH v6 1/1] acinclude: Also use LIBS from dpkg pkg-config

2019-02-12 Thread Ben Pfaff
On Tue, Feb 12, 2019 at 07:29:58AM +0100, Christian Ehrhardt wrote: > DPDK 18.11 builds using the more modern meson build system no more > provide the -ldpdk linker script. Instead it is expected to use > pkgconfig for linker options as well. > > This change will set DPDK_LIB from pkg-config (if

Re: [ovs-dev] [PATCH] python: Fix E117 over-indented.

2019-02-12 Thread Ben Pfaff
On Tue, Feb 12, 2019 at 06:34:02PM +0300, Ilya Maximets wrote: > New check was added to recent pycodestyle-2.5.0 and flake8 > complains while building on Travis: > > ../utilities/bugtool/ovs-bugtool.in:767:17: E117 over-indented > ../utilities/bugtool/ovs-bugtool.in:771:17: E117 over-indented

Re: [ovs-dev] [PATCH] dpif-netdev: Fix unsafe accesses to pmd polling lists.

2019-02-12 Thread Ben Pfaff
On Tue, Feb 12, 2019 at 10:40:30AM +0300, Ilya Maximets wrote: > On 11.02.2019 22:15, Aaron Conole wrote: > > Ilya Maximets writes: > > > >> All accesses to 'pmd->poll_list' should be guarded by > >> 'pmd->port_mutex'. Additionally fixed inappropriate usage > >> of 'HMAP_FOR_EACH_SAFE' (hmap

Re: [ovs-dev] [PATCH] debian: Add libelf-dev dependency for dkms

2019-02-12 Thread Ben Pfaff
On Tue, Feb 12, 2019 at 12:37:03PM -0800, Greg Rose wrote: > Newer kernels define CONFIG_UNWINDER_ORC for their kernel configurations > and to build this the kernel compilation requires the libelf-dev > package. Add the dependency to the dkms build requirements. > > VMware-BZ: #2287968 >

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

2019-02-12 Thread Gregory Rose
On 2/11/2019 6:27 PM, Ben Pfaff wrote: Greg, I recommend that you take a look at this one. My apologies but I haven't been feeling well the last few days. I'll have a look at this one. Thanks, (More commentary below.) On Thu, Jan 10, 2019 at 11:29:48PM +0530, nusid...@redhat.com

Re: [ovs-dev] debian: Add libelf-dev dependency for dkms

2019-02-12 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 88 characters long (recommended limit is 79) #26 FILE: debian/control:44:

Re: [ovs-dev] [PATCH] debian: Add libelf-dev dependency for dkms

2019-02-12 Thread Yifeng Sun
Looks good to me, thanks. Reviewed-by: Yifeng Sun On Tue, Feb 12, 2019 at 12:37 PM Greg Rose wrote: > Newer kernels define CONFIG_UNWINDER_ORC for their kernel configurations > and to build this the kernel compilation requires the libelf-dev > package. Add the dependency to the dkms build

[ovs-dev] [PATCH] debian: Add libelf-dev dependency for dkms

2019-02-12 Thread Greg Rose
Newer kernels define CONFIG_UNWINDER_ORC for their kernel configurations and to build this the kernel compilation requires the libelf-dev package. Add the dependency to the dkms build requirements. VMware-BZ: #2287968 Signed-off-by: Greg Rose --- debian/control | 2 +- 1 file changed, 1

Re: [ovs-dev] Openvswitch| RSA Conference 2019 -Leads

2019-02-12 Thread Stacy Brown
Hi, Any thoughts on below email ? Thanks, Stacy Brown From: Stacy Brown [mailto:stacy.br...@epaxis.com] Sent: Thursday, February 7, 2019 11:15 PM To: 'd...@openvswitch.org' Subject: Openvswitch| RSA Conference 2019 -Leads Hi, Attendees-list of RSA Conference 2019 (March 4th

Re: [ovs-dev] [PATCH 0/3] gcc-plugins: Introduce stackinit plugin

2019-02-12 Thread Kees Cook
On Mon, Jan 28, 2019 at 4:12 PM Alexander Popov wrote: > > On 23.01.2019 14:03, Kees Cook wrote: > > This adds a new plugin "stackinit" that attempts to perform unconditional > > initialization of all stack variables > > Hello Kees! Hello everyone! > > I was curious about the performance impact

[ovs-dev] Capacitación a tu Medida Guía paso a paso

2019-02-12 Thread STPS - Trámites de capacitación
Cursos esenciales - Webinar Interactivo – Martes 05 de Marzo Capacitación a tu Medida Guía paso a paso: Trámites de capacitación ante la S.T.P.S. En este webinar te presentamos una guía práctica paso a paso del proceso que debemos seguir ante este organismo para registrar la capacitación de

[ovs-dev] Excel - webinar

2019-02-12 Thread Asegure su lugar / 3 lugares disponibles
Cursos escenciales - Webinar Interactivo – Viernes 22 de Febrero Bases de datos y tablas dinámicas en Excel Nuestro curso está diseñado para enseñarte a importar o construir bases de datos correctamente estructuradas para la creación de tablas dinámicas y todas las herramientas que la

Re: [ovs-dev] [ovs-dev, v12, 8/8] Userspace datapath: Add fragmentation handling.

2019-02-12 Thread Darrell Ball
On Tue, Feb 12, 2019 at 7:50 AM Ilya Maximets wrote: > Not a full review. Just a few notes about docs. > See inline. > > Best regards, Ilya Maximets. > > On 11.02.2019 5:56, Darrell Ball wrote: > > Fragmentation handling is added for supporting conntrack. > > Both v4 and v6 are supported. > > >

Re: [ovs-dev] [PATCH V3 0/2] Do not rewrite fields with the same values as matched

2019-02-12 Thread Eli Britstein
ping On 2/7/2019 6:44 PM, Eli Britstein wrote: > Hi > > This patch set avoids unnecessary rewrite actions to fields with the > same values as matched on. > > Patch 1 is a pre-step of generating ovs key fields macros > > Patch 2 avoids the unnecessary rewrites and adapts the tests accordingly > >

Re: [ovs-dev] [PATCH v1] doc: Add "Representors" topic document

2019-02-12 Thread Ian Stokes
On 2/12/2019 1:15 PM, Ilya Maximets wrote: On 11.02.2019 3:01, Ophir Munk wrote: This details how to configure representors ports. Signed-off-by: Ophir Munk --- Documentation/topics/dpdk/phy.rst | 80 +++ 1 file changed, 80 insertions(+) diff --git

Re: [ovs-dev] [PATCH] acinclude: Check for rte_config.h before checking dependencies.

2019-02-12 Thread Ian Stokes
On 2/12/2019 1:19 PM, Ilya Maximets wrote: Current ./configure script shows misleading errors in case of wrong DPDK path: # ./configure --with-dpdk=/wrong/path ... checking whether dpdk datapath is enabled... yes checking for library containing get_mempolicy... -lnuma checking

Re: [ovs-dev] [ovs-dev, PATCHv8, 1/3] Improved Packet Drop Statistics in OVS

2019-02-12 Thread Aaron Conole
Ilya Maximets writes: > On 12.02.2019 18:55, Aaron Conole wrote: >> Ilya Maximets writes: >> >>> Aaron, ovsrobot doesn't check this patch for some reason. >>> I suspect, it's because "PATCH" and "v8" are glued together. >>> Could you, please, take a look. >> >> It won't. But not for that

Re: [ovs-dev] [ovs-dev, PATCHv8, 1/3] Improved Packet Drop Statistics in OVS

2019-02-12 Thread Ilya Maximets
On 12.02.2019 18:55, Aaron Conole wrote: > Ilya Maximets writes: > >> Aaron, ovsrobot doesn't check this patch for some reason. >> I suspect, it's because "PATCH" and "v8" are glued together. >> Could you, please, take a look. > > It won't. But not for that reason. The patch info says that

Re: [ovs-dev] [ovs-dev, PATCHv8, 1/3] Improved Packet Drop Statistics in OVS

2019-02-12 Thread Aaron Conole
Ilya Maximets writes: > Aaron, ovsrobot doesn't check this patch for some reason. > I suspect, it's because "PATCH" and "v8" are glued together. > Could you, please, take a look. It won't. But not for that reason. The patch info says that this is patch 1 of 3. But 2/3 and 3/3 haven't been

Re: [ovs-dev] [PATCH 1/8] travis: Fix building datapath instead of userspace with DPDK_SHARED.

2019-02-12 Thread Ian Stokes
On 2/8/2019 4:48 PM, Ilya Maximets wrote: Current script does not check build of OVS with DPDK. It builds datapath instead. CC: Ian Stokes Fixes: edfe8d263d2e ("travis: Add dpdk shared library build.") Signed-off-by: Ilya Maximets Acked-by: Aaron Conole Ben has applied this to master

Re: [ovs-dev] [ovs-dev, v12, 8/8] Userspace datapath: Add fragmentation handling.

2019-02-12 Thread Ilya Maximets
Not a full review. Just a few notes about docs. See inline. Best regards, Ilya Maximets. On 11.02.2019 5:56, Darrell Ball wrote: > Fragmentation handling is added for supporting conntrack. > Both v4 and v6 are supported. > > After discussion with several people, I decided to not store >

[ovs-dev] ABOUT YOUR PARCEL,,

2019-02-12 Thread DHL Regional headquarters
-- Attention: We wish to draw your attention concerning your unclaimed parcel registered and deposited with our regional headquarters in London. You are to re-confirm your correct names,receiving address and a valid telephone number to avoid sending the consignment to a wrong designate because

[ovs-dev] [PATCH] python: Fix E117 over-indented.

2019-02-12 Thread Ilya Maximets
New check was added to recent pycodestyle-2.5.0 and flake8 complains while building on Travis: ../utilities/bugtool/ovs-bugtool.in:767:17: E117 over-indented ../utilities/bugtool/ovs-bugtool.in:771:17: E117 over-indented ../utilities/bugtool/ovs-bugtool.in:774:17: E117 over-indented

Re: [ovs-dev] [ovs-dev, PATCHv8, 1/3] Improved Packet Drop Statistics in OVS

2019-02-12 Thread Ilya Maximets
Aaron, ovsrobot doesn't check this patch for some reason. I suspect, it's because "PATCH" and "v8" are glued together. Could you, please, take a look. Anju, patch breaks a lot of unit tests. ovs-vswitchd crashes with traces like this: ==21473== ==21473== Thread 13 monitor11: ==21473== Invalid

Re: [ovs-dev] [PATCH] dpif-netdev: Add thread safety annotation to sorted_poll_list.

2019-02-12 Thread Ian Stokes
On 2/11/2019 6:32 PM, Kevin Traynor wrote: On 02/11/2019 05:35 PM, Ilya Maximets wrote: 'sorted_poll_list()' uses the 'pmd->poll_list' that should be guarded by 'pmd->port_mutex'. Signed-off-by: Ilya Maximets --- LGTM Acked-by: Kevin Traynor Thanks, applied to master and backported

[ovs-dev] [PATCH] acinclude: Check for rte_config.h before checking dependencies.

2019-02-12 Thread Ilya Maximets
Current ./configure script shows misleading errors in case of wrong DPDK path: # ./configure --with-dpdk=/wrong/path ... checking whether dpdk datapath is enabled... yes checking for library containing get_mempolicy... -lnuma checking for library containing pcap_dump... -lpcap

Re: [ovs-dev] [PATCH v1] doc: Add "Representors" topic document

2019-02-12 Thread Ilya Maximets
On 11.02.2019 3:01, Ophir Munk wrote: > This details how to configure representors ports. > > Signed-off-by: Ophir Munk > --- > Documentation/topics/dpdk/phy.rst | 80 > +++ > 1 file changed, 80 insertions(+) > > diff --git

[ovs-dev] ORDER CONFIRMATION REF. N0. QP214.R8/PO 18-049 dated 12th march 2018

2019-02-12 Thread Asti Swastiani
Date : 12th Feb 2019 Ref. No.: 190159 / QP214.R8/PO /PO 12-03-2018 Order Confirmation Dear Sir, Good day from PT Mignon Sista International We refer to your email dated 12th oct, 2018. Please find attached our

Re: [ovs-dev] [PATCH] acinclude: Use NUMA_AWARE_HUGEPAGES too for libnuma check.

2019-02-12 Thread Ian Stokes
On 2/8/2019 2:28 PM, Ilya Maximets wrote: On 07.02.2019 19:26, Ilya Maximets wrote: On 07.02.2019 19:18, Ian Stokes wrote: On 2/7/2019 1:00 PM, Ilya Maximets wrote: This fixes build with NUMA_AWARE_HUGEPAGES enabled and VHOST_NUMA disabled. This should not be a usual case. But it's possible

Re: [ovs-dev] [RFC v3 1/5] datapath: Add a new action check_pkt_len

2019-02-12 Thread Numan Siddique
Thanks Ben and Lorenzo for the review and comments. Few comments inline. On Tue, Feb 12, 2019 at 7:57 AM Ben Pfaff wrote: > Greg, I recommend that you take a look at this one. > > (More commentary below.) > > On Thu, Jan 10, 2019 at 11:29:48PM +0530, nusid...@redhat.com wrote: > > From: Numan