Re: [ovs-dev] [PATCH v2 1/2] Avoid packet drop on LACP bond after link up

Hi Ben, Thanks for checking it. I will send the new patch. Regards, Nitin > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Monday, February 25, 2019 11:23 PM > To: Nitin Katiyar > Cc: ovs-dev@openvswitch.org; Manohar Krishnappa Chidambaraswamy > > Subject: Re:

Re: [ovs-dev] What does the ‘ovs-dpctl show’ command means?

On Tue, Feb 26, 2019 at 10:18:28AM +0800, 舒fishu wrote: > Hi. > > When I execute the 'ovs-dpctl show' command, I got: > ``` > $ ovs-dpctl show > system@ovs-system: > lookups: hit:37994604 missed:218759 lost:0 > flows: 5 > masks: hit:39862430 total:5 hit/pkt:1.04 > port 0:

Re: [ovs-dev] [PATCH] ovs: skip ephemeral port for icmp and SNAT in which port range is specified

Darrell Ball wrote: > Thanks for the report > > I think there are two separate issues: > 1/ Fallback to ephemeral ports for SNAT being less restrictive than in > kernel > 2/ Wasted local variable port incrementing work for ICMPv4/v6 > > I sent an alternative series here: >

[ovs-dev] What does the ‘ovs-dpctl show’ command means?

Hi. When I execute the 'ovs-dpctl show' command, I got: ``` $ ovs-dpctl show system@ovs-system: lookups: hit:37994604 missed:218759 lost:0 flows: 5 masks: hit:39862430 total:5 hit/pkt:1.04 port 0: ovs-system (internal) port 1: vbr0 (internal) port

Re: [ovs-dev] conntrack: Fix wasted work for ICMP NAT.

Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 conntrack: Fix wasted work for ICMP NAT. The

Re: [ovs-dev] [patch v1] conntrack: Consolidate 2 selection statements.

On Mon, Feb 25, 2019 at 04:37:50PM -0800, Darrell Ball wrote: > No functional change. > > Signed-off-by: Darrell Ball Applied, thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] packets: Change return type of 'packet_csum_upperlayer6'.

This warning could be considered a bit confusing bcoz this patch does not modify the file being reported. On Mon, Feb 25, 2019 at 4:48 PM 0-day Robot wrote: > Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered

Re: [ovs-dev] conntrack: Fix L4 csum for V6 extension hdr pkts.

Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Empty return followed by brace, consider omitting #78 FILE: lib/conntrack.c:3101: }

Re: [ovs-dev] packets: Change return type of 'packet_csum_upperlayer6'.

Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Empty return followed by brace, consider omitting #78 FILE: lib/conntrack.c:3101: }

[ovs-dev] [patch v1] conntrack: Consolidate 2 selection statements.

No functional change. Signed-off-by: Darrell Ball --- lib/conntrack.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 7ead3ad..691782c 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -2187,12 +2187,9 @@

Re: [ovs-dev] [patch v1 1/2] conntrack: Fix wasted work for ICMP NAT.

I applied this series already, so you'll need to send a patch to fix up what's there, I guess. On Mon, Feb 25, 2019 at 04:01:31PM -0800, Darrell Ball wrote: > I sent a V2 for the series as I changed patch 1 slightly. > > On Mon, Feb 25, 2019 at 3:36 PM Darrell Ball wrote: > > > ICMPv4 and

Re: [ovs-dev] [PATCH] ovs: skip ephemeral port for icmp and SNAT in which port range is specified

Thanks for the report I think there are two separate issues: 1/ Fallback to ephemeral ports for SNAT being less restrictive than in kernel 2/ Wasted local variable port incrementing work for ICMPv4/v6 I sent an alternative series here:

Re: [ovs-dev] [RFC PATCH v1 2/6] Vlan Support in ovn, northd changes to read logical switch network type.

Hi Ben, Sure, will merged 1,2 and 3 in a single patch. V2 will have this change. Regards, Ankur -Original Message- From: Ben Pfaff Sent: Monday, February 25, 2019 9:43 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [RFC PATCH v1 2/6] Vlan Support in ovn,

Re: [ovs-dev] [patch v1 1/2] conntrack: Fix wasted work for ICMP NAT.

I sent a V2 for the series as I changed patch 1 slightly. On Mon, Feb 25, 2019 at 3:36 PM Darrell Ball wrote: > ICMPv4 and ICMPv6 are not subject to port address translation (PAT), > however, a loop increments a local variable unnecessarily for > ephemeral ports, resulting in wasted work for

Re: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac.

Hi Ben, Yes, I am aware of these failures. I mentioned about them in Cover Letter as well. Yes, V2 will have fix for them as well, I am actively working on it. Thanks Regards, Ankur -Original Message- From: Ben Pfaff Sent: Monday, February 25, 2019 9:31 AM To: Ankur Sharma Cc:

Re: [ovs-dev] [PATCH v3 0/5] Fast OVSDB resync after restart or fail-over.

It didn't get caught in any filters for a different -dev list that I happen to also moderate. Doh! Anyway, I released it now. On Mon, Feb 25, 2019 at 11:24:21AM -0800, Ben Pfaff wrote: > It didn't get caught in any filters this time. > > I see all the patches, although maybe I was CCed. > >

Re: [ovs-dev] [RFC PATCH v1 0/6] OVN: Distributed Virtual Router for Vlan Backed Networks

Hi Ben, Thanks a lot for review. Sure, I will update Architecture documentation as well in V2. Thanks Regards, Ankur -Original Message- From: Ben Pfaff Sent: Monday, February 25, 2019 9:00 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [RFC PATCH v1 0/6] OVN:

[ovs-dev] [patch v2 1/2] conntrack: Fix wasted work for ICMP NAT.

ICMPv4 and ICMPv6 are not subject to port address translation (PAT), however, a loop increments a local variable unnecessarily for ephemeral ports, resulting in wasted work for ICMPv4 and ICMPv6 packets subject to NAT. Fix this by checking for PAT being enabled before incrementing the local port

[ovs-dev] [patch v2 2/2] conntrack: Skip ephemeral ports with specified port range.

This patch removes the fallback to ephemeral ports when a SNAT port range is specified; DNAT already does not fallback to ephemeral ports, in general. This is not restrictive to the user and makes it easier to limit NAT L4 port selection. The documentation is updated and a new test is added to

Re: [ovs-dev] [branch-2.6 1/2] packets: Change return type of 'packet_csum_upperlayer6()'.

On Mon, Feb 25, 2019 at 03:04:49PM -0800, Darrell Ball wrote: > Signed-off-by: Darrell Ball Applied, thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.7 1/2] packets: Change return type for 'packet_csum_upperlayer6()'.

On Mon, Feb 25, 2019 at 03:06:59PM -0800, Darrell Ball wrote: > Signed-off-by: Darrell Ball Series applied, thanks for the backport! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.8 1/2] packets: Change return type of 'packet_csum_upperlayer6'.

On Mon, Feb 25, 2019 at 03:08:49PM -0800, Darrell Ball wrote: > Signed-off-by: Darrell Ball I applied this series, thanks for the backport! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/3] odp-util: Improve log messages and error reporting for Netlink parsing.

On Sat, Feb 02, 2019 at 03:25:45PM -0800, Justin Pettit wrote: > > > On Dec 14, 2018, at 6:16 PM, Ben Pfaff wrote: > > > > diff --git a/lib/dpctl.c b/lib/dpctl.c > > index 59071cdba83d..1632fad89a57 100644 > > --- a/lib/dpctl.c > > +++ b/lib/dpctl.c > > @@ -2076,9 +2080,11 @@

[ovs-dev] [patch v1 1/2] conntrack: Fix wasted work for ICMP NAT.

ICMPv4 and ICMPv6 are not subject to port address translation (PAT), however, a loop increments a local variable unnecessarily for ephemeral ports, resulting in wasted work for ICMPv4 and ICMPv6 packets subject to NAT. Fix this by checking for PAT being enabled before incrementing the local port

[ovs-dev] [patch v1 2/2] conntrack: Skip ephemeral ports with specified port range.

This patch removes the fallback to ephemeral ports when a SNAT port range is specified; DNAT already does not fallback to ephemeral ports, in general. This is not restrictive to the user and makes it easier to limit NAT L4 port selection. The documentation is updated and a new test is added to

[ovs-dev] [PATCH v3 0/5] Fast OVSDB resync after restart or failover.

In scalability test with ovn-scale-test, ovsdb-server SB load is not a problem at least with 1k HVs. However, if we restart the ovsdb-server, depending on the number of HVs and scale of logical objects, e.g. the number of logical ports, ovsdb-server of SB become an obvious bottleneck. In our test

[ovs-dev] Facebook Inc.

FACEBOOK INC 1601 WILLOW ROAD MENLO PARK, CA 94025 www.facebook.com directorate.faceb...@gmail.com https://mail.google.com/mail/u/0/h/1h1hfa8l41ji/?=wh=b=directorate.faceb...@gmail.com> Beste

[ovs-dev] [branch-2.8 2/2] conntrack: Fix L4 csum for V6 extension hdr pkts.

It is a day one issue that got copied to subsequent code. Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.") Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") CC: Daniele Di Proietto Signed-off-by: Darrell Ball --- lib/conntrack.c | 29

[ovs-dev] [branch-2.8 1/2] packets: Change return type of 'packet_csum_upperlayer6'.

Signed-off-by: Darrell Ball --- lib/packets.c | 2 +- lib/packets.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/packets.c b/lib/packets.c index 5f57030..a9893ea 100644 --- a/lib/packets.c +++ b/lib/packets.c @@ -1668,7 +1668,7 @@ packet_csum_pseudoheader6(const

[ovs-dev] [branch-2.7 2/2] conntrack: Fix L4 csum for V6 extension hdr pkts.

It is a day one issue that got copied to subsequent code. Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.") CC: Daniele Di Proietto Signed-off-by: Darrell Ball --- lib/conntrack.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/lib/conntrack.c

[ovs-dev] [branch-2.7 1/2] packets: Change return type for 'packet_csum_upperlayer6()'.

Signed-off-by: Darrell Ball --- lib/packets.c | 2 +- lib/packets.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/packets.c b/lib/packets.c index fa70df6..3a0c432 100644 --- a/lib/packets.c +++ b/lib/packets.c @@ -1459,7 +1459,7 @@ packet_csum_pseudoheader6(const

[ovs-dev] [branch-2.6 2/2] conntrack: Fix L4 csum for V6 extension hdr pkts.

It is a day one issue that got copied to subsequent code. Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.") Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") CC: Daniele Di Proietto Signed-off-by: Darrell Ball --- lib/conntrack.c | 11 +++ 1 file

[ovs-dev] [branch-2.6 1/2] packets: Change return type of 'packet_csum_upperlayer6()'.

Signed-off-by: Darrell Ball --- lib/packets.c | 2 +- lib/packets.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/packets.c b/lib/packets.c index 72a118c..8e1e2af 100644 --- a/lib/packets.c +++ b/lib/packets.c @@ -1458,7 +1458,7 @@ packet_csum_pseudoheader6(const

Re: [ovs-dev] [RFC] OVS robot discussion - check API integration

> On Feb 25, 2019, at 10:42 AM, Aaron Conole wrote: > > Thomas Monjalon writes: > >> The best is to have a hook in the mail archiving system, >> so you can reference the report in the mail archives >> as soon as it is published. > > I'm not sure whether anyone can run such a script on the

[ovs-dev] [PATCH net-next V3 1/1] net: sched: act_csum: Fix csum calc for tagged packets

The csum calculation is different for IPv4/6. For VLAN packets, tc_skb_protocol returns the VLAN protocol rather than the packet's one (e.g. IPv4/6), so csum is not calculated. Furthermore, VLAN may not be stripped so csum is not calculated in this case too. Calculate the csum for those cases.

Re: [ovs-dev] [PATCH V5 0/2] Do not rewrite fields with the same values as matched

On 2/25/2019 7:31 PM, Ben Pfaff wrote: > On Sun, Feb 24, 2019 at 09:45:21AM +, Eli Britstein wrote: >> On 2/22/2019 6:42 PM, Ben Pfaff wrote: >>> On Sun, Feb 17, 2019 at 09:18:46AM +, Eli Britstein wrote: This patch set avoids unnecessary rewrite actions to fields with the same

Re: [ovs-dev] [PATCH v3 0/5] Fast OVSDB resync after restart or fail-over.

It didn't get caught in any filters this time. I see all the patches, although maybe I was CCed. On Mon, Feb 25, 2019 at 11:08:40AM -0800, Han Zhou wrote: > This seems not showing up in the mailing list. Retry sending using > different words in title. > On Mon, Feb 25, 2019 at 9:25 AM Han Zhou

Re: [ovs-dev] [PATCH v3 0/5] Fast OVSDB resync after restart or fail-over.

This seems not showing up in the mailing list. Retry sending using different words in title. On Mon, Feb 25, 2019 at 9:25 AM Han Zhou wrote: > > In scalability test with ovn-scale-test, ovsdb-server SB load is not a > problem at least with 1k HVs. However, if we restart the ovsdb-server, >

Re: [ovs-dev] [PATCH] vlog: Better handle syslog handler exceptions.

On Mon, Feb 25, 2019 at 08:43:36PM +0300, Ilya Maximets wrote: > 'set_levels_from_string' doesn't check for exceptions that could > happen while opening syslog files or connecting to syslog sockets. Thanks, applied to master. This could be considered a bug fix. Let me know if you'd like it

Re: [ovs-dev] [RFC] OVS robot discussion - check API integration

Thomas Monjalon writes: > 13/02/2019 17:56, Aaron Conole: >> Ilya Maximets writes: >> > And we, actually, already have special ovs-build mail-list. It could >> > be used if you'll decide to choose DPDK way of working with patchwork. >> >> It looks intriguing. I like the idea that anyone could

[ovs-dev] Planes de carrera y sucesión

Cursos TOP - Webinar Interactivo – Miércoles 06 de Marzo Planes de carrera y sucesión Desarrollaremos planes de carrera y sucesión que aseguren el funcionamiento óptimo de una empresa. Ejes Temáticos: • Competencias organizacionales complejas. • Desarrollo de plan de vida y carrera. •

Re: [ovs-dev] ovsdb-monitor: Support monitor_cond_since.

Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 98 characters long (recommended limit is 79) #595 FILE: ovsdb/ovsdb-client.c:433:

Re: [ovs-dev] [PATCH v2 2/2] Avoid packet drop on LACP bond after link up

Thanks! This patch also adds a new warning that I'd like to see fixed: ../lib/lacp.c:360:47: error: passing 'const void *' to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] ../ofproto/bond.h:83:60: note: passing argument to parameter

Re: [ovs-dev] [PATCH v2 1/2] Avoid packet drop on LACP bond after link up

Thanks for working to make OVS better! This sounds like a useful improvement to me. This patch causes a new warning: ../lib/lacp.c:329:52: error: unused parameter 'bond' [-Werror,-Wunused-parameter] Will you please fix that and resubmit? ___ dev

Re: [ovs-dev] ovsdb-monitor: Refactor ovsdb monitor implementation.

On Mon, Feb 25, 2019 at 8:45 AM Ben Pfaff wrote: > > On Fri, Feb 22, 2019 at 10:59:00PM -0800, Han Zhou wrote: > > On Fri, Feb 22, 2019 at 8:36 PM Ben Pfaff wrote: > > > > > > On Fri, Feb 22, 2019 at 07:31:59PM -0800, Han Zhou wrote: > > > > On Fri, Feb 22, 2019 at 5:27 PM Ben Pfaff wrote: > >

[ovs-dev] [PATCH] vlog: Better handle syslog handler exceptions.

'set_levels_from_string' doesn't check for exceptions that could happen while opening syslog files or connecting to syslog sockets. For example, if rsyslog stopped on a system: $ test-unixctl.py -vFACILITY:daemon --detach Traceback (most recent call last): File

Re: [ovs-dev] [RFC PATCH v1 2/6] Vlan Support in ovn, northd changes to read logical switch network type.

On Wed, Feb 20, 2019 at 10:34:54PM +, Ankur Sharma wrote: > Background: > [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html > [2] > https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing > > This Series: > Layer 2, Layer 3

Re: [ovs-dev] [patch v2] ipf: More cleanup.

On Fri, Feb 22, 2019 at 06:48:46PM -0800, Darrell Ball wrote: > No functional changes here. > > Signed-off-by: Darrell Ball Thanks, applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V5 0/2] Do not rewrite fields with the same values as matched

On Sun, Feb 24, 2019 at 09:45:21AM +, Eli Britstein wrote: > > On 2/22/2019 6:42 PM, Ben Pfaff wrote: > > On Sun, Feb 17, 2019 at 09:18:46AM +, Eli Britstein wrote: > >> This patch set avoids unnecessary rewrite actions to fields with the > >> same values as matched on. > >> > >> Patch 1

Re: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac.

On Wed, Feb 20, 2019 at 10:34:56PM +, Ankur Sharma wrote: > Background: > [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html > [2] > https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing > > This Series: > Layer 2, Layer 3

[ovs-dev] [PATCH v3 3/5] ovsdb-monitor: Support monitor_cond_since.

From: Han Zhou Support the new monitor method monitor_cond_since so that a client can request monitoring start from a specific point instead of always from beginning. This will reduce the cost at scenarios when server is restarted/failed-over but client still has all existing data. In these

[ovs-dev] [PATCH v3 5/5] ovsdb-idl.c: Fast resync from server when connection reset.

From: Han Zhou Use monitor_cond_since to request changes after last version of local data when connection to server is reset, without clearing the local data. It falls back to clearing and repopulating all the data when the requested id cannot be fulfilled by the server. Test result at

[ovs-dev] [PATCH v3 4/5] ovsdb-idl.c: Support monitor_cond_since method in C IDL.

From: Han Zhou Use monitor_cond_since in C IDL. If it is not supported by server, fall back to old method (monitor_cond, or monitor). Signed-off-by: Han Zhou --- lib/ovsdb-idl.c | 203 ++-- 1 file changed, 155 insertions(+), 48 deletions(-)

[ovs-dev] [PATCH v3 1/5] ovsdb-monitor: Refactor ovsdb monitor implementation.

From: Han Zhou Current ovsdb monitor maintains its own transaction version through an incremental integer and use it to identify changes starting from different version, and also use it to figure out if each set of changes should be flushed. In particular, it uses number 0 to represent that the

[ovs-dev] [PATCH v3 2/5] ovsdb-server: Transaction history tracking.

From: Han Zhou Maintaining last N (n = 100) transactions in memory, which will be used for future patches for generating monitor data from any point in this N transactions. Signed-off-by: Han Zhou --- ovsdb/ovsdb-server.c | 11 + ovsdb/ovsdb.c| 3 ++ ovsdb/ovsdb.h| 10

Re: [ovs-dev] dpif-netdev: split out generic lookup function

Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Improper whitespace around control block #77 FILE:

Re: [ovs-dev] dpif-netdev: implement function pointers/subtable

Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: C99 style comment #110 FILE: lib/dpif-netdev.c:7870:

Re: [ovs-dev] [RFC PATCH v1 0/6] OVN: Distributed Virtual Router for Vlan Backed Networks

On Wed, Feb 20, 2019 at 10:34:50PM +, Ankur Sharma wrote: > This series is about enhancing the logical router functionality in OVN to work > with vlan backed logical switches. > > Intial proposal was discused here: > [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html

Re: [ovs-dev] ovsdb-monitor: Refactor ovsdb monitor implementation.

On Fri, Feb 22, 2019 at 10:59:00PM -0800, Han Zhou wrote: > On Fri, Feb 22, 2019 at 8:36 PM Ben Pfaff wrote: > > > > On Fri, Feb 22, 2019 at 07:31:59PM -0800, Han Zhou wrote: > > > On Fri, Feb 22, 2019 at 5:27 PM Ben Pfaff wrote: > > > > > > > > On Fri, Feb 22, 2019 at 05:21:51PM -0800, Han Zhou

[ovs-dev] [PATCH v5 3/3] dpif-netdev: split out generic lookup function

This commit splits the generic hash-lookup-verify function to its own file. In doing so, we must move some MACRO definitions to dpif-netdev.h Signed-off-by: Harry van Haaren --- lib/automake.mk | 1 + lib/dpif-netdev-lookup-generic.c | 95

[ovs-dev] [PATCH v5 2/3] dpif-netdev: move dpcls lookup structures to .h

This commit moves some data-structures to be available in the dpif-netdev.h header. This allows specific implementations of the subtable lookup function to include just that header file, and not require that the code exists in dpif-netdev.c Signed-off-by: Harry van Haaren --- lib/dpif-netdev.c

[ovs-dev] [PATCH v5 1/3] dpif-netdev: implement function pointers/subtable

This allows plugging-in of different subtable hash-lookup-verify routines, and allows special casing of those functions based on known context (eg: # of bits set) of the specific subtable. Signed-off-by: Harry van Haaren --- lib/dpif-netdev.c | 127 +++---

[ovs-dev] [PATCH 0/3] dpcls subtable func pointers

Hi Folks, TL;DR: Dropped optimized dpcls_rule_match_key() to simplify this patchset, optimization patches will depend on this patchset's functionality once it is integrated. I've run with make check, and its showing good here now. This patchset makes the following changes; Patch 1: Refactor

Re: [ovs-dev] ovs: skip ephemeral port for icmp and SNAT in which port range is specified

Bleep bloop. Greetings solomon, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author solomon needs to sign off. WARNING: Unexpected sign-offs from developers who are not

[ovs-dev] [PATCH] ovs: skip ephemeral port for icmp and SNAT in which port range is specified

If setting the port range in SNAT, we expect that the selected port is in the range we set. At the same time, this behavior is consistent with the kernel-datapath. The port has no meaning for the icmp/icmpv6 protocol. If no key is available, it will exit early. Signed-off-by: LiWei ---

Re: [ovs-dev] [PATCH v2] rstp: add ability to receive VLAN-tagged BPDUs

On 23/02/2019 00:12, Ben Pfaff wrote: > On Fri, Feb 15, 2019 at 12:16:14AM +0100, Matthias May via dev wrote: >> There are switches which allow to transmit their BPDUs VLAN-tagged. >> With this change OVS is able to receive VLAN-tagged BPDUs, but still >> transmits its own BPDUs untagged. >> This