Re: [ovs-dev] [PATCH v3 1/3] netdev-dpdk: Expose flow creation/destruction calls

2019-02-27 Thread Ilya Maximets
On 28.02.2019 1:37, Ophir Munk wrote: > From: Roni Bar Yanai > > Before offloading code was added to the netdev-dpdk.c file (MARK and > RSS actions) the only DPDK RTE calls in use were rte_flow_create() and > rte_flow_destroy(). In preparation for splitting the offloading code > from the

Re: [ovs-dev] [PATCH v3 0/5] Fast OVSDB resync after restart or failover.

2019-02-27 Thread Han Zhou
On Wed, Feb 27, 2019 at 5:26 PM Ben Pfaff wrote: > > On Mon, Feb 25, 2019 at 09:25:03AM -0800, Han Zhou wrote: > > In scalability test with ovn-scale-test, ovsdb-server SB load is not a > > problem at least with 1k HVs. However, if we restart the ovsdb-server, > > depending on the number of HVs

Re: [ovs-dev] [PATCH v3 0/5] Fast OVSDB resync after restart or failover.

2019-02-27 Thread Han Zhou
On Wed, Feb 27, 2019 at 8:04 PM Han Zhou wrote: > > On Wed, Feb 27, 2019 at 6:01 PM Ben Pfaff wrote: > > > > I spent a bunch of time looking through this series. The actual support > > for fast resync is really simple and clean. > > > > The first patch is the one that I have the most trouble

Re: [ovs-dev] [PATCH v3 0/5] Fast OVSDB resync after restart or failover.

2019-02-27 Thread Han Zhou
On Wed, Feb 27, 2019 at 6:01 PM Ben Pfaff wrote: > > I spent a bunch of time looking through this series. The actual support > for fast resync is really simple and clean. > > The first patch is the one that I have the most trouble with. I think > it's probably because I don't understand the

Re: [ovs-dev] [PATCH v3 0/5] Fast OVSDB resync after restart or failover.

2019-02-27 Thread Ben Pfaff
I spent a bunch of time looking through this series. The actual support for fast resync is really simple and clean. The first patch is the one that I have the most trouble with. I think it's probably because I don't understand the existing code all that well. I wrote the original monitor

Re: [ovs-dev] [PATCH v3 0/5] Fast OVSDB resync after restart or failover.

2019-02-27 Thread Ben Pfaff
On Mon, Feb 25, 2019 at 09:25:03AM -0800, Han Zhou wrote: > In scalability test with ovn-scale-test, ovsdb-server SB load is not a > problem at least with 1k HVs. However, if we restart the ovsdb-server, > depending on the number of HVs and scale of logical objects, e.g. the > number of logical

Re: [ovs-dev] [PATCH] oss: Fix oss build errors because of ovs API change

2019-02-27 Thread Ben Pfaff
On Wed, Feb 27, 2019 at 02:21:00PM -0800, Yifeng Sun wrote: > Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13432 > Signed-off-by: Yifeng Sun Thanks, applied to master. ___ dev mailing list d...@openvswitch.org

[ovs-dev] OVS mailing lists *sometimes* replace the From: address by the list address

2019-02-27 Thread Ben Pfaff
Hi Linux Foundation folks, We're seeing a recurring problem on the ovs-dev mailing list where, for some people, mailman is replacing the poster's own email address in mailing list messages by the list address, in the From: header. Can you help us figure out what's going on? Here is the latest

Re: [ovs-dev] [PATCH v7 2/9] dp-packet: Constantify offloading APIs.

2019-02-27 Thread Ian Stokes
On 2/26/2019 10:38 AM, Ilya Maximets wrote: Getters should have const arguments. > Acked-by: Flavio Leitner Signed-off-by: Ilya Maximets Thanks applied, applied to master. Ian ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v7 1/9] dpif-netdev: Reduce log level for not found mark id.

2019-02-27 Thread Ian Stokes
On 2/26/2019 10:38 AM, Ilya Maximets wrote: It's a normal case for 'find' function, especially because this happens for every first packet of flow that was not offloaded yet. Should not warn about this. Dropped to DBG to avoid log trashing in case of big number of new flows. Makes sense,

[ovs-dev] [PATCH v3 2/3] netdev-dpdk: Move offloading code to a new file

2019-02-27 Thread Ophir Munk
From: Roni Bar Yanai Hardware offloading code is moved to a new file called netdev-rte-offloads.c. The original offloading code is copied from the netdev-dpdk.c file to the new file, where future offloading code should be added as well. The copied code was refactored based on coding style. The

[ovs-dev] [PATCH v3 3/3] netdev-rte-offloads: Rename netdev_dpdk_* functions

2019-02-27 Thread Ophir Munk
Rename all the netdev_dpdk_* functions names (originated from the file netdev-dpdk.c) into the netdev_rte_offloads_* functions names. Signed-off-by: Ophir Munk --- lib/netdev-rte-offloads.c | 39 --- lib/netdev-rte-offloads.h | 17 + 2 files

[ovs-dev] [PATCH v3 1/3] netdev-dpdk: Expose flow creation/destruction calls

2019-02-27 Thread Ophir Munk
From: Roni Bar Yanai Before offloading code was added to the netdev-dpdk.c file (MARK and RSS actions) the only DPDK RTE calls in use were rte_flow_create() and rte_flow_destroy(). In preparation for splitting the offloading code from the netdev-dpdk.c file to a separate file, it is required to

[ovs-dev] [PATCH v3 0/3] Move offloading code into a new file

2019-02-27 Thread Ophir Munk
Hardware offloading code is moved to a new file called netdev-rte-offloads.c. The original offloading code is copied as is from the netdev-dpdk.c file to the new file where future offloading code should be added as well. The new code is refactored based on code styling. This series is essential

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Use single struct/union for flow offload items.

2019-02-27 Thread Ian Stokes
On 2/19/2019 11:27 AM, Asaf Penso wrote: I see that now, thanks. I agree with you and I'm fine with this v2. Regards, Asaf Penso LGTM also, applied to master. Thanks Ian ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH] oss: Fix oss build errors because of ovs API change

2019-02-27 Thread Yifeng Sun
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13432 Signed-off-by: Yifeng Sun --- tests/oss-fuzz/odp_target.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/oss-fuzz/odp_target.c b/tests/oss-fuzz/odp_target.c index a7a8bbffcaa7..ae61cdca322f

Re: [ovs-dev] Author should not be mailing list

2019-02-27 Thread Sairam Venugopal via dev
Not really. I subscribed using my regular work email. This was the last patch that was delivered properly - https://patchwork.ozlabs.org/patch/997861/ Were there any changes done to the mailing list in the past 3 - 4 months? Thanks, Sairam On 2/27/19, 12:25 PM, "Aaron Conole" wrote:

[ovs-dev] Descuento de $200 en compra de calzado

2019-02-27 Thread SANTANA Shoes via dev
( https://www.facebook.com/SantanaShoess/ ) Con la compra de 2 pares cualquier modelo $200 de descuento ( https://www.facebook.com/SantanaShoess/ )   ( https://www.facebook.com/SantanaShoess/ )   Río Grande 5566, Rosario, Santa Fe, ARG Tel: +54 (0341) 156 473213 Whatsapp: +543416473213

Re: [ovs-dev] Author should not be mailing list

2019-02-27 Thread Aaron Conole
Sairam Venugopal writes: > Hey Ben/Aaron, > > > > Is there a known fix for this issue? I sent my commit to d...@openvswitch.org > and ran into this. Currently all > patches from the mailing list on patchwork show up under my name - >

Re: [ovs-dev] [PATCH v2 2/5] ovn: Add generic HA chassis group

2019-02-27 Thread Han Zhou
On Wed, Feb 27, 2019 at 2:45 AM wrote: > > From: Numan Siddique > > This patch adds the tables - 'HA_Chassis_Group' and 'HA_Chassis' in > both OVN Northbound and Southbound DBs to support generic HA Chassis > groups in OVN. CMS can create a group of HA chassis with the priorities > assigned to

Re: [ovs-dev] [PATCH v2 1/5] ovn-northd: Reuse the hmaps - datapaths and ports in ovnsb_db_run()

2019-02-27 Thread Han Zhou
On Wed, Feb 27, 2019 at 2:45 AM wrote: > > From: Numan Siddique > > We can reuse the datapaths and ports built during ovnnb_db_run() > in ovnsb_db_run(). This way we avoid creating the logical ports hash nodes > during the ovnsb_db_run(). > > An upcoming patch will make further use of these

Re: [ovs-dev] Author should not be mailing list

2019-02-27 Thread Sairam Venugopal via dev
This is in regards to “Author should not be mailing list” issue where the from field in the email gets replaced with ovs-dev@openvswitch.org. Thanks, Sairam From: Sairam Venugopal Date: Wednesday, February 27, 2019 at 11:43 AM To: Ben Pfaff , Aaron Conole Cc:

[ovs-dev] Author should not be mailing list

2019-02-27 Thread Sairam Venugopal via dev
Hey Ben/Aaron, Is there a known fix for this issue? I sent my commit to d...@openvswitch.org and ran into this. Currently all patches from the mailing list on patchwork show up under my name -

Re: [ovs-dev] [branch-2.10 1/2] Set release date for 2.10.2.

2019-02-27 Thread Flavio Leitner
On Wed, Feb 27, 2019 at 09:31:27AM -0800, Ben Pfaff wrote: > On Fri, Feb 22, 2019 at 05:26:30PM -0300, Flavio Leitner wrote: > > On Wed, Feb 20, 2019 at 04:47:14PM -0800, Justin Pettit wrote: > > > Signed-off-by: Justin Pettit > > > --- > > > > Your patches are okay, but unfortunately while

Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

2019-02-27 Thread Sairam Venugopal via dev
Do we need to keep the dispatchLock for reading vport structures? If that's the case, then we will need to fix it in other areas of the code too. It would be better to move the locking inside the relevant vport.c functions instead of taking out global ones. Thanks, Sairam On 2/27/19, 6:10

Re: [ovs-dev] OVN/OVS code split: POC

2019-02-27 Thread Han Zhou
On Wed, Feb 27, 2019 at 10:32 AM Ben Pfaff wrote: > > On Tue, Feb 26, 2019 at 04:03:20PM -0500, Mark Michelson wrote: > > On 2/22/19 4:45 PM, Ben Pfaff wrote: > > > Are you more concerned about OVN or OVS for testing? It's easy for OVN > > > to accidentally add a dependency on some

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Expose flow creation/destruction calls

2019-02-27 Thread Ophir Munk
> -Original Message- > From: Ilya Maximets > Sent: Friday, February 22, 2019 1:26 PM > To: Roni Bar Yanai ; Ophir Munk > ; ovs-dev@openvswitch.org > Cc: Ian Stokes ; Olga Shern ; > Kevin Traynor ; Asaf Penso ; > Flavio Leitner > Subject: Re: [PATCH v2 1/3] netdev-dpdk: Expose flow

Re: [ovs-dev] OVN/OVS code split: POC

2019-02-27 Thread Aaron Conole
Mark Michelson writes: > On 2/27/19 10:14 AM, Aaron Conole wrote: >> Hi Mark, >> >> Mark Michelson writes: >> >>> Hi everyone, >>> >>> I have completed a *rough* POC of an OVN/OVS code split. You can find it >>> at https://github.com/putnopvut/ovn.git >>> >>> Please take a look at the README

Re: [ovs-dev] [PATCH v2 2/3] netdev-dpdk: Move offloading-code to a new file

2019-02-27 Thread Ophir Munk
Hi Ilya, all styling issues of this commit were addressed per your review. They will be updated in v3 > -Original Message- > From: Ilya Maximets > Sent: Tuesday, February 26, 2019 4:38 PM > To: Roni Bar Yanai ; Ophir Munk > ; ovs-dev@openvswitch.org > Cc: Ian Stokes ; Olga Shern ; >

Re: [ovs-dev] OVN/OVS code split: POC

2019-02-27 Thread Mark Michelson
On 2/27/19 10:14 AM, Aaron Conole wrote: Hi Mark, Mark Michelson writes: Hi everyone, I have completed a *rough* POC of an OVN/OVS code split. You can find it at https://github.com/putnopvut/ovn.git Please take a look at the README file since that highlights how the split was done, as well

Re: [ovs-dev] [BUILD branch-2.6-8, 11] Failure when executing 'make check'

2019-02-27 Thread Ben Pfaff
On Tue, Feb 26, 2019 at 03:26:01PM -0500, Michael Santana Francisco wrote: > On each I got these results: > branch-2.6    Build hung forever. I started build Monday afternoon, came > in the following morning and realized the build never finished. >   It hung for 16 hours. I

[ovs-dev] [RFC OVS 2/2] ovs-tc: offload datapath rules matching on internal ports

2019-02-27 Thread John Hurley
Rules applied to OvS internal ports are not represented in TC datapaths. However, it is possible to support rules matching on internal ports in TC. The start_xmit ndo of OvS internal ports directs packets back into the OvS kernel datapath where they are rematched with the ingress port now being

[ovs-dev] [RFC OVS 1/2] ovs-tc: allow offloading TC rules to egress qdiscs

2019-02-27 Thread John Hurley
Offloading rules to a TC datapath only allows the creating of ingress hook qdiscs and the application of filters to these. However, there may be certain situations where an egress qdisc is more applicable (e.g. when offloading to TC rules applied to OvS internal ports). Extend the TC API in OvS

[ovs-dev] [RFC OVS 0/2] ovs-tc: support OvS internal port offload

2019-02-27 Thread John Hurley
Common use-cases in OvS can produce datapath rules that match on OvS internal ports. For example, when the endpoint IP address of a VXLAN tunnel is on the OvS bridge itself, datapath rules may take the form: 1. in_port(eth1),actions:set(tunnel(...)),vxlan_sys_4789 2.

Re: [ovs-dev] [PATCH v1 1/1] hash: Enable hash_bytes128 optimization for aarch64.

2019-02-27 Thread Ben Pfaff
On Wed, Feb 27, 2019 at 05:44:06PM +0800, Yanqin Wei wrote: > "hash_bytes128" has two versions for 64 bits and 32 bits system. This > should be common optimization for their respective platforms. But 64 bits > version was only enabled in x86-64. This patch enable it for aarch64 > platform. > Micro

Re: [ovs-dev] OVN/OVS code split: POC

2019-02-27 Thread Ben Pfaff
On Tue, Feb 26, 2019 at 04:03:20PM -0500, Mark Michelson wrote: > On 2/22/19 4:45 PM, Ben Pfaff wrote: > > Are you more concerned about OVN or OVS for testing? It's easy for OVN > > to accidentally add a dependency on some later-than-intended version of > > OVS or OVSDB (although maybe just

Re: [ovs-dev] OVN/OVS code split: POC

2019-02-27 Thread Ben Pfaff
On Tue, Feb 26, 2019 at 11:38:59PM -0800, Han Zhou wrote: > Apart from this, I have just some trival problem/questions. I went > ahead to clone the repo and try to play with it to get some real > feelings. However, I encountered an error when doing make: > make[4]: *** No rule to make target

Re: [ovs-dev] ovn-nbctl: Add lsp-get-ls command

2019-02-27 Thread 0-day Robot
Bleep bloop. Greetings Lucas Alvares Gomes, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #44 FILE: ovn/utilities/ovn-nbctl.c:616:

Re: [ovs-dev] [PATCH 1/2] Avoid packet drop on LACP bond after link up

2019-02-27 Thread Ben Pfaff
This series adds a warning: ../lib/lacp.c:360:47: error: passing 'const void *' to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] ../ofproto/bond.h:83:60: note: passing argument to parameter 'slave_' here Please fix it.

Re: [ovs-dev] [PATCH] ovn-nbctl: Add lsp-get-ls command

2019-02-27 Thread Ben Pfaff
On Wed, Feb 27, 2019 at 05:28:53PM +, lucasago...@gmail.com wrote: > From: Lucas Alvares Gomes > > This commit adds the following command: > > lsp-get-ls: Get the logical switch which the port belongs to. > > This command is handy for scripting since there's no logical switch id > in the

Re: [ovs-dev] Fix crash due to multiple tnl push action

2019-02-27 Thread Ben Pfaff
Well, I guess ideally one would backport 2ce9e71bb960 with a clarification to the commit message and then un-revert the fix. That could be made easy for me by posting a 2-patch series, I guess. On Wed, Feb 27, 2019 at 05:26:30PM +0300, Ilya Maximets wrote: > Looks like I found the solution. >

Re: [ovs-dev] [branch-2.9] vagrant: fix merge conflict

2019-02-27 Thread Ben Pfaff
On Tue, Feb 26, 2019 at 11:12:47AM +0100, David Marchand wrote: > Fix merge conflict introduced when backporting the original commit > 253e4dc0683b ("conntrack: fix tcp seq adjustments when mangling > commands.") > > Fixes: addbb52274ae ("conntrack: fix tcp seq adjustments when mangling >

[ovs-dev] [PATCH v3] OVN: select a random mac_prefix if not provided

2019-02-27 Thread Lorenzo Bianconi
Select a random IPAM mac_prefix if it has not been provided by the user. With this patch the admin can avoid to configure mac_prefix in order to avoid L2 address collisions if multiple OVN deployments share the same broadcast domain. Remove MAC_ADDR_PREFIX definitions/occurrences since now

[ovs-dev] Ausentismo laboral y problemas de horarios

2019-02-27 Thread Aviso Importante
Cursos esenciales - Webinar Interactivo – Miércoles 13 de Marzo Disminución del ausentismo laboral y problemas de horarios: Workshop Innova Learn desarrolla este webinar para que aprendas a clasificar el ausentismo, a trabajar con tus empleados para erradicarlo y evitar que esta situación

[ovs-dev] [PATCH] ovn-nbctl: Add lsp-get-ls command

2019-02-27 Thread lucasagomes
From: Lucas Alvares Gomes This commit adds the following command: lsp-get-ls: Get the logical switch which the port belongs to. This command is handy for scripting since there's no logical switch id in the Logical_Switch_Port table. Signed-off-by: Lucas Alvares Gomes ---

Re: [ovs-dev] [branch-2.10 1/2] Set release date for 2.10.2.

2019-02-27 Thread Ben Pfaff
On Fri, Feb 22, 2019 at 05:26:30PM -0300, Flavio Leitner wrote: > On Wed, Feb 20, 2019 at 04:47:14PM -0800, Justin Pettit wrote: > > Signed-off-by: Justin Pettit > > --- > > Your patches are okay, but unfortunately while testing I found an > issue which is resolved by the commit below in

[ovs-dev] [PATCH] datapath-windows: Add annotations to find vport functions

2019-02-27 Thread Alin Gabriel Serdean
Add annotations to find vport functions to check if the dispatch lock is held. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Vport.c | 7 ++- datapath-windows/ovsext/Vport.h | 5 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git

Re: [ovs-dev] [PATCH v2] OVN: select a random mac_prefix if not provided

2019-02-27 Thread Lorenzo Bianconi
> On Tue, Feb 26, 2019 at 11:41 PM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: > > > Select a random IPAM mac_prefix if it has not been provided by the user. > > With this patch the admin can avoid to configure mac_prefix in order to > > avoid L2 address collisions if multiple OVN

[ovs-dev] Perspectiva económica, política y jurídica

2019-02-27 Thread Cómo ser un experto en compras
Cursos esenciales - Webinar Interactivo – Jueves 14 de Marzo Capacitación a tu Medida Experto en compras Internacionales Desarrollaremos capacidades para desenvolverse profesionalmente en mercados comerciales internacionales en el área de Compras y Aprovisionamiento. Ejes Temáticos: •

Re: [ovs-dev] OVN/OVS code split: POC

2019-02-27 Thread Aaron Conole
Hi Mark, Mark Michelson writes: > Hi everyone, > > I have completed a *rough* POC of an OVN/OVS code split. You can find it > at https://github.com/putnopvut/ovn.git > > Please take a look at the README file since that highlights how the > split was done, as well as some known issues. > > My

Re: [ovs-dev] FW: Avoid packet drop on LACP bond after link up

2019-02-27 Thread Aaron Conole
Nitin Katiyar writes: > Hi, > I got this mail reporting build failure. It complains for bond > variable not being used. I had sent patch earlier after correcting > this. So, I am not sure which patch version it is complaining for. In > my latest patch I see that it is being used. Am I missing

Re: [ovs-dev] ovn: Add generic HA chassis group

2019-02-27 Thread Aaron Conole
Numan Siddique writes: > On Wed, Feb 27, 2019 at 4:48 PM 0-day Robot wrote: > > Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > >

Re: [ovs-dev] Fix crash due to multiple tnl push action

2019-02-27 Thread Ilya Maximets
Looks like I found the solution. Following patch on branch-2.10 makes tests immune to the change: 2ce9e71bb960 ("tests: Inject ARP replies for snoop tests on different port") It's the test change only that makes tunnel_push to be not the last action. If we'll backport it to 2.9, we could

[ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

2019-02-27 Thread Alin Gabriel Serdean
When using a vport we need to guard its usage with the dispatch lock. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/User.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c index

Re: [ovs-dev] [RFC PATCH v1 3/6] L3 E-W Support in ovn, replace router port mac with chassis mac.

2019-02-27 Thread Numan Siddique
On Thu, Feb 21, 2019 at 4:10 AM Ankur Sharma wrote: > Background: > [1] > https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html > [2] > https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing > > This Series: > Layer 2, Layer 3 E-W and

Re: [ovs-dev] [PATCH v2] datapath-windows: Fix potential deadlock in event subscription

2019-02-27 Thread aserdean
> > Move the EventQueue lock acquisition after the dispatchLock to prevent a > potential deadlock in port creation pipeline. There could be a case where a > port event could try to take up the Dispatch Lock before the Event Queue > lock and the subscription queue event could take up the event

Re: [ovs-dev] OVN/OVS code split: POC

2019-02-27 Thread Mark Michelson
On 2/27/19 2:38 AM, Han Zhou wrote: On Tue, Feb 26, 2019 at 1:13 PM Mark Michelson wrote: On 2/22/19 4:45 PM, Ben Pfaff wrote: On Fri, Feb 22, 2019 at 04:15:27PM -0500, Mark Michelson wrote: On 2/22/19 4:01 PM, Ben Pfaff wrote: On Mon, Feb 18, 2019 at 09:50:56AM -0500, Mark Michelson

Re: [ovs-dev] Fix crash due to multiple tnl push action

2019-02-27 Thread Anju Thomas
So then should we refrain from adding this fix to 2.9 if it does not make sense or should I remove the cases altogether? Regards Anju -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Wednesday, February 27, 2019 6:55 PM To: Anju Thomas ; d...@openvswitch.org

Re: [ovs-dev] Fix crash due to multiple tnl push action

2019-02-27 Thread Ilya Maximets
Hi. Thanks for the patch. Few comments: 1. You may use --subject-prefix="PATCH branch-2.9". In this case ovsrobot will be able to apply patch to the right branch for checking. 2. This patch fixes tests (I didn't check), but it effectively makes them useless by replacing all the useful

Re: [ovs-dev] [RFC PATCH v1 2/6] Vlan Support in ovn, northd changes to read logical switch network type.

2019-02-27 Thread Numan Siddique
Hi Ankur, Few comments below. Thanks Numan On Thu, Feb 21, 2019 at 4:08 AM Ankur Sharma wrote: > Background: > [1] > https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html > [2] >

Re: [ovs-dev] [PATCH] datapath-windows: Fix race condition during port creation

2019-02-27 Thread aserdean
> > Hold the dispatch lock until port-add operations are completed. > > Found by inspection. > > Signed-off-by: Sairam Venugopal [Alin Serdean] Thanks a lot for the patch! For some reason the author seems to be ovs-dev@openvswitch.org, can you try to respin the patch? Acked-by: Alin Gabriel

Re: [ovs-dev] Fix crash due to multiple tnl push action

2019-02-27 Thread 0-day Robot
Bleep bloop. Greetings Anju Thomas, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 Fix crash due to multiple tnl push action The

Re: [ovs-dev] ovn: Add generic HA chassis group

2019-02-27 Thread Numan Siddique
On Wed, Feb 27, 2019 at 4:48 PM 0-day Robot wrote: > Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > WARNING: Line lacks

[ovs-dev] [PATCH] Fix crash due to multiple tnl push action

2019-02-27 Thread Anju Thomas
During slow path packet processing, if the action is to output to a tunnel port, the slow path processing of the encapsulated packet continues on the underlay bridge and additional actions (e.g. optional VLAN encapsulation, bond link selection and finally output to port) are collected there. To

Re: [ovs-dev] ovn: Add generic HA chassis group

2019-02-27 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #935 FILE: ovn/utilities/ovn-nbctl.c:697:

Re: [ovs-dev] [PATCH 0/5] ovn: Add HA chassis group and 'external' port support

2019-02-27 Thread Numan Siddique
On Wed, Feb 27, 2019 at 8:08 AM Han Zhou wrote: > On Mon, Feb 18, 2019 at 11:26 AM wrote: > > > > From: Numan Siddique > > > > This patch series adds a generic HA chassis group support in OVN > > deprecating the existing Gateway chassis support. The final patch > > of the series adds the

[ovs-dev] [PATCH v2 5/5] ovn: Support a new Logical_Switch_Port.type - 'external'

2019-02-27 Thread nusiddiq
From: Numan Siddique In the case of OpenStack + OVN, when the VMs are booted on hypervisors supporting SR-IOV nics, there are no OVS ports for these VMs. When these VMs sends DHCPv4, DHPCv6 or IPv6 Router Solicitation requests, the local ovn-controller cannot reply to these packets. OpenStack

Re: [ovs-dev] Personeels- / werknemersupdate

2019-02-27 Thread Bail, Hermann-Josef Prof. Dr.
Von: Bail, Hermann-Josef Prof. Dr. Gesendet: Mittwoch, 27. Februar 2019 11:08 An: Bail, Hermann-Josef Prof. Dr. Betreff: Personeels- / werknemersupdate Beste collega, Het e-mailadres van alle medewerkers / medewerkers wordt overgezet van de e-mail van Microsoft

[ovs-dev] [PATCH v2 4/5] ovn-northd: Delete the references to gateway_chasss in SB DB

2019-02-27 Thread nusiddiq
From: Numan Siddique Previous patch in the series added the support in ovn-controller to use ha_chassis_group table in SB DB to support HA chassis and establishing BFD tunnels instead of the gateway_chassis table. There is no need for ovn-northd to create any gateway_chassis rows in SB DB. This

[ovs-dev] [PATCH v2 3/5] ovn-controller: Make use of ha_chassis_group table to bind the chassisredirect ports

2019-02-27 Thread nusiddiq
From: Numan Siddique This patch uses the newly added ha_chassis_group table in Southbound DB - to bind the chassisredirect ports. - to establish BFD sessions with the required chassis. The previous patch in this series sets the list of chassis which references a ha chassis group in the

[ovs-dev] [PATCH v2 2/5] ovn: Add generic HA chassis group

2019-02-27 Thread nusiddiq
From: Numan Siddique This patch adds the tables - 'HA_Chassis_Group' and 'HA_Chassis' in both OVN Northbound and Southbound DBs to support generic HA Chassis groups in OVN. CMS can create a group of HA chassis with the priorities assigned to each chassis in the group. An HA chassis group can be

[ovs-dev] [PATCH v2 1/5] ovn-northd: Reuse the hmaps - datapaths and ports in ovnsb_db_run()

2019-02-27 Thread nusiddiq
From: Numan Siddique We can reuse the datapaths and ports built during ovnnb_db_run() in ovnsb_db_run(). This way we avoid creating the logical ports hash nodes during the ovnsb_db_run(). An upcoming patch will make further use of these hashmaps during ovnsb_db_run(). This patch refactors the

[ovs-dev] [PATCH v2 0/5] ovn: Add HA chassis group and 'external' port support

2019-02-27 Thread nusiddiq
From: Numan Siddique This patch series adds a generic HA chassis group support in OVN deprecating the existing Gateway chassis support. The final patch of the series adds the 'external' port support in OVN. The 'external' port patch addresses the review comments from Han Zhou which he provided

[ovs-dev] [PATCH v1 1/1] hash: Enable hash_bytes128 optimization for aarch64.

2019-02-27 Thread Yanqin Wei
"hash_bytes128" has two versions for 64 bits and 32 bits system. This should be common optimization for their respective platforms. But 64 bits version was only enabled in x86-64. This patch enable it for aarch64 platform. Micro benchmarking test was run in two kinds of arm platform. It was

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

2019-02-27 Thread Anju Thomas
Sure Ben. I will send a patch for 2.9 branch. Regards Anju -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Tuesday, February 26, 2019 8:55 PM To: Ilya Maximets Cc: ovs-dev@openvswitch.org; Anju Thomas ; Stokes, Ian Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to

[ovs-dev] [PATCH v9] Improved Packet Drop Statistics in OVS

2019-02-27 Thread Anju Thomas
Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by controllers that know the semantics of the

Re: [ovs-dev] Avoid packet drop on LACP bond after link up

2019-02-27 Thread 0-day Robot
Bleep bloop. Greetings Nitin Katiyar, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include

[ovs-dev] Products Inquiry

2019-02-27 Thread JOHN LEE(TRADING)LIMITED
Hello Supplier, We introduce ourselves as John lee trading Pvt. Ltd., A general merchandise company located in India. We are sourcing for new suppliers from your location Please let me know if you can accept new orders. I will forward our PO immediately to place a trial order. Thank you and

[ovs-dev] [PATCH 1/2] Avoid packet drop on LACP bond after link up

2019-02-27 Thread Nitin Katiyar
Problem: During port DOWN->UP of link (slave) in a LACP bond, after receiving the LACPDU with SYNC set for both actor and partner, the bond-slave remains "disabled" until OVS main thread runs LACP state machine and eventually "enables" the bond-slave. With this, we have observed delays in

[ovs-dev] [PATCH 2/2] Avoid packet drop on LACP bond after link up

2019-02-27 Thread Nitin Katiyar
Problem: On certain Fortville NICs it has been observed that PHY UP detection can get delayed (sometimes up to 4-5 secs). When the driver fails to fetch PHY status as UP even though its actually UP, LACP packets can get exchanged and LACP slave brought UP. In such a case, the remote end