Re: [ovs-dev] [PATCHv8] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-17 Thread William Tu
Hi Eelco, Thanks for all the feedbacks. There are some issues in driver, some in libbpf, and some in my implementation. I will work on it ASAP. On Fri, May 17, 2019 at 3:23 AM Eelco Chaudron wrote: > > Hi William, > > First a list of issues I found during some basic testing... > > - When I

[ovs-dev] [PATCH] rhel: Add 4.12 kernel support in ovs-kmod-manage.sh

2019-05-17 Thread Yi-Hung Wei
This patch extends c3570519ecaf ("rhel: add 4.4 kernel in kmod build with mulitple versions, fedora") that updates ovs-kmod-manage.sh to support SLES 12 SP4 kernel (4.12.x, x>=14). For some distros, openvswitch-kmod rpm package may contain multiple ovs kernel modules built against different

Re: [ovs-dev] [PATCH v6 15/17] ovn: Test for full logical flow processing in ovn-controller.

2019-05-17 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Han

Re: [ovs-dev] [PATCH v6 14/17] coverage: Add command for reading counter value.

2019-05-17 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Han

Re: [ovs-dev] [PATCH v6 13/17] ovn-controller: Incremental processing for port-group changes.

2019-05-17 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #123 FILE: ovn/controller/ovn-controller.c:1561: /*

Re: [ovs-dev] [PATCH v6 11/17] ovn-controller: Incremental processing for address-set changes.

2019-05-17 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #269 FILE: ovn/controller/ovn-controller.c:1404: /* XXX: The

[ovs-dev] [PATCH] datapath-windows: Copy mru information when cloning a nbl.

2019-05-17 Thread Anand Kumar via dev
When a nbl is cloned, mru value stored in the original nbl context is lost, which skips refragemting the cloned nbls. This patch fixes it. Signed-off-by: Anand Kumar --- datapath-windows/ovsext/BufferMgmt.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git

Re: [ovs-dev] [PATCH v6 06/17] ovn-controller: port-binding incremental processing for physical flows

2019-05-17 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #72 FILE: ovn/controller/ovn-controller.c:1184: /* XXX: now

Re: [ovs-dev] [PATCH v6 05/17] ovn-controller: runtime_data change handler for SB port-binding

2019-05-17 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #149 FILE: ovn/controller/binding.c:706: /* XXX:

[ovs-dev] [PATCH v6 15/17] ovn: Test for full logical flow processing in ovn-controller.

2019-05-17 Thread Han Zhou
From: Jakub Sitnicki From: Jakub Sitnicki Add a test that performs typical operations of creating & destroying logical routers, switches, ports, address sets and ACLs while checking if they trigger full logical flow processing in the ovn-controller. This way confirm that incremental processing

[ovs-dev] [PATCH v6 17/17] ovn-controller: mac_binding incremental processing.

2019-05-17 Thread Han Zhou
From: Han Zhou Even if mac_binding is not used for workload provisioning, the mac_binding table update will happen for gateway external ARP processing. This patch ensures ARP events on gateway nodes causing mac-binding changes do not trigger full recomputing on all chassises. Signed-off-by: Han

[ovs-dev] [PATCH v6 14/17] coverage: Add command for reading counter value.

2019-05-17 Thread Han Zhou
From: Jakub Sitnicki From: Jakub Sitnicki Facilitate checking coverage counters from scripts and tests with a new coverage/read-counter command that gets the total count for a counter. Same could be achieved by scraping the output of coverage/show command but the difficulties there are that

[ovs-dev] [PATCH v6 16/17] ovn-performance.at: Test port group incremental processing.

2019-05-17 Thread Han Zhou
From: Han Zhou Add tests to make sure port group change doesn't trigger recomputing. Signed-off-by: Han Zhou --- tests/ovn-performance.at | 43 +-- 1 file changed, 37 insertions(+), 6 deletions(-) diff --git a/tests/ovn-performance.at

[ovs-dev] [PATCH v6 12/17] ovn-controller: Split port_groups from runtime_data.

2019-05-17 Thread Han Zhou
From: Han Zhou Signed-off-by: Han Zhou --- ovn/controller/ovn-controller.c | 91 + 1 file changed, 73 insertions(+), 18 deletions(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index 27580f8..5ec9a5e 100644 ---

[ovs-dev] [PATCH v6 13/17] ovn-controller: Incremental processing for port-group changes.

2019-05-17 Thread Han Zhou
From: Han Zhou Signed-off-by: Han Zhou --- ovn/controller/lflow.h | 3 +- ovn/controller/ovn-controller.c | 112 ++-- 2 files changed, 99 insertions(+), 16 deletions(-) diff --git a/ovn/controller/lflow.h b/ovn/controller/lflow.h index

[ovs-dev] [PATCH v6 11/17] ovn-controller: Incremental processing for address-set changes.

2019-05-17 Thread Han Zhou
From: Han Zhou When the content of an address set changes, ovn-controller will not recompute all flows but only the ones related to the changed address-set. The performance test result is discussed at [1]. [1] https://mail.openvswitch.org/pipermail/ovs-discuss/2018-June/046880.html Tested-by:

[ovs-dev] [PATCH v6 10/17] ovn-controller: Maintain resource references for logical flows.

2019-05-17 Thread Han Zhou
From: Han Zhou This patch maintains the cross reference between logical flows and the resources such as address sets and port groups that are used by logical flows. This data will be needed in address set and port group incremental processing. Signed-off-by: Han Zhou --- include/ovn/expr.h

[ovs-dev] [PATCH v6 09/17] ovn-controller: Split addr_sets from runtime_data.

2019-05-17 Thread Han Zhou
From: Han Zhou Signed-off-by: Han Zhou --- ovn/controller/ovn-controller.c | 91 ++--- 1 file changed, 67 insertions(+), 24 deletions(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index 9b1dbab..02c4963 100644 ---

[ovs-dev] [PATCH v6 08/17] ovsdb-idl: Tracking - preserve data for deleted rows.

2019-05-17 Thread Han Zhou
From: Han Zhou OVSDB IDL can track changes, but for deleted rows, the data is destroyed and only uuid is tracked. In some cases we need to check the data of the deleted rows. This patch preserves data for deleted rows until track clear is called. Signed-off-by: Han Zhou ---

[ovs-dev] [PATCH v6 06/17] ovn-controller: port-binding incremental processing for physical flows

2019-05-17 Thread Han Zhou
From: Han Zhou This patch implements change handler for port-binding in flow_output for physical flows computing, so that physical flow computing will be incremental. Signed-off-by: Han Zhou --- ovn/controller/ovn-controller.c | 107 +++-

[ovs-dev] [PATCH v6 07/17] ovn-controller: incremental processing for multicast group changes

2019-05-17 Thread Han Zhou
From: Han Zhou This patch handles SB Multicast_Group table changes incrementally. The Multicast_Group table changes can be triggered by creating/deleting a lport of a lswitch. It can be also triggered indirectly by an updating of a port-binding which is referenced by the multicast group. This

[ovs-dev] [PATCH v6 03/17] ovn-controller: Initial use of incremental engine - quiet mode.

2019-05-17 Thread Han Zhou
From: Han Zhou Incremental proccessing engine is used to compute flows. In this patch we create below engine nodes: - Engine nodes for each OVSDB table in local OVS DB and SB DB. - runtime_data: compute and maintain intermediate result such as local_datapath, etc.

[ovs-dev] [PATCH v6 05/17] ovn-controller: runtime_data change handler for SB port-binding

2019-05-17 Thread Han Zhou
From: Han Zhou Evaluates change for SB port-binding in runtime_data node. If the port-binding change has no impact for the runtime_data it will not trigger runtime_data change. Signed-off-by: Han Zhou --- ovn/controller/binding.c| 100

[ovs-dev] [PATCH v6 04/17] ovn-controller: Incremental logical flow processing

2019-05-17 Thread Han Zhou
From: Han Zhou Implements change handler of flow_output for SB lflow changes. Signed-off-by: Han Zhou --- ovn/controller/lflow.c | 82 + ovn/controller/lflow.h | 17 + ovn/controller/ovn-controller.c | 77

[ovs-dev] [PATCH v6 02/17] ovn-controller: Track OVSDB changes

2019-05-17 Thread Han Zhou
From: Han Zhou Track OVSDB changes for future patches of incremental processing Signed-off-by: Han Zhou --- ovn/controller/bfd.c| 4 ++-- ovn/controller/binding.c| 16 ovn/controller/encaps.c | 12 ++-- ovn/controller/ovn-controller.c | 22

[ovs-dev] [PATCH v6 01/17] ovn-controller: Incremental processing engine

2019-05-17 Thread Han Zhou
From: Han Zhou This patch implements the engine which will be used in future patches for ovn-controller incremental processing. Signed-off-by: Han Zhou --- ovn/lib/automake.mk| 4 +- ovn/lib/inc-proc-eng.c | 201 ++ ovn/lib/inc-proc-eng.h | 234

[ovs-dev] [PATCH v6 00/17] ovn-controller incremental processing

2019-05-17 Thread Han Zhou
As discussed at last OVN meeting, I am reposting the patch series after rebasing on latest master branch. There has been a lot a discussion since last review. The reason it was hold on were: 1. The concern of long term maintenance effort, since the change handler implementation can be complex

[ovs-dev] [PATCH v2] conntrack: add display support for sctp

2019-05-17 Thread Aaron Conole
Currently, only the netlink datapath supports SCTP connection tracking, but at least this removes the warning message that will pop up when running something like: ovs-appctl dpctl/dump-conntrack This doesn't impact any conntrack functionality, just the display. Signed-off-by: Aaron Conole

Re: [ovs-dev] [PATCH 3/7 v3] datapath: Use new header file net/ipv6_frag.h

2019-05-17 Thread Yifeng Sun
Hi Ilya, Thanks for the checking. Present travis is using 4.9.171 and build passed. I will check out the reason why it breaks for 4.9.176. You patch for TravisCI is great, thank you for that! Thanks, Yifeng On Fri, May 17, 2019 at 3:08 AM Ilya Maximets wrote: > > On 10.05.2019 22:30, Yifeng

Re: [ovs-dev] [PATCH] conntrack: add display support for sctp

2019-05-17 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > build: > mv -f $depbase.Tpo $depbase.Plo > libtool: compile: gcc

Re: [ovs-dev] [PATCH] conntrack: add display support for sctp

2019-05-17 Thread 0-day Robot
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: mv -f $depbase.Tpo $depbase.Plo libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include

[ovs-dev] Logo printing on USB drives

2019-05-17 Thread Sabrina
Hi, I didn’t know if you had received my email from last week? Does your company have any upcoming events, conferences or promotional product needs? We manufacture ALL custom LOGO and branded products – over 300,000 to choose from. The most asked about product that we make, is the custom

[ovs-dev] [PATCH] conntrack: add display support for sctp

2019-05-17 Thread Aaron Conole
Currently, only the netlink datapath supports SCTP connection tracking, but at least this removes the warning message that will pop up when running something like: ovs-appctl dpctl/dump-conntrack This doesn't impact any conntrack functionality, just the display. Signed-off-by: Aaron Conole

Re: [ovs-dev] [PATCHv8] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-17 Thread Ilya Maximets
Hi. Just a few comments to the issues you're listed. Best regards, Ilya Maximets. On 17.05.2019 13:23, Eelco Chaudron wrote: > Hi William, > > First a list of issues I found during some basic testing... > > - When I restart or stop OVS (using the systemctl interface as found in RHEL) > it

Re: [ovs-dev] [PATCH 1/2] doc: Fix cropped what-is-ovs page.

2019-05-17 Thread Ilya Maximets
On 16.05.2019 16:58, Stephen Finucane wrote: > On Thu, 2019-05-16 at 16:40 +0300, Ilya Maximets wrote: >> Despite of comments in both files no-one ever adjusted start/end-line >> in 'what-is-ovs' document. As a result, current document contains >> truncated "tools" section. >> >> Let's replace

Re: [ovs-dev] [PATCH 2/2] doc: Add CirrusCI status badge to README.

2019-05-17 Thread Ilya Maximets
On 16.05.2019 20:12, Aaron Conole wrote: > Ilya Maximets writes: > >> Badge for CirrusCI just like for other CI systems. >> >> Signed-off-by: Ilya Maximets >> --- >> README.rst | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/README.rst b/README.rst >> index 54d06d04b..e06ddf267

Re: [ovs-dev] [PATCHv8] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-17 Thread Eelco Chaudron
Hi William, First a list of issues I found during some basic testing... - When I restart or stop OVS (using the systemctl interface as found in RHEL) it does not clean up the BFP program causing the restart to fail: 2019-05-10T09:12:11.384Z|00042|netdev_afxdp|ERR|AF_XDP device eno1

Re: [ovs-dev] [PATCH 3/7 v3] datapath: Use new header file net/ipv6_frag.h

2019-05-17 Thread Ilya Maximets
On 10.05.2019 22:30, Yifeng Sun wrote: > From: Florian Westphal > > Upstream commit: > commit 70b095c84326640eeacfd69a411db8fc36e8ab1a > Author: Florian Westphal > Date: Sat Jul 14 01:14:01 2018 +0200 > > ipv6: remove dependency of nf_defrag_ipv6 on ipv6 module > >

Re: [ovs-dev] [PATCH v3 1/3] dpif-netdev: Only poll enabled vhost queues.

2019-05-17 Thread David Marchand
Hello, On Wed, May 15, 2019 at 12:04 PM Ilya Maximets wrote: > On 25.04.2019 18:22, David Marchand wrote: > > We currently poll all available queues based on the max queue count > > exchanged with the vhost peer and rely on the vhost library in DPDK to > > check the vring status beneath. > >

[ovs-dev] Invitation

2019-05-17 Thread Thierry
Reconversion professionnelle un nouveau m?tier pour une nouvelle vie Hypnose m?dicale, hypnose th?rapeutique, cette nouvelle fa?on de soulager et r?tablir l?harmonie des personnes en passant par l?inconscient, int?resse les professionnels des th?rapies