Re: [ovs-dev] [patch v1] tests: Include ovn-macros for system testsuites.

2019-06-03 Thread Darrell Ball
On Mon, Jun 3, 2019 at 10:27 AM Ilya Maximets wrote: > On 03.06.2019 18:55, Darrell Ball wrote: > > > > > > On Mon, Jun 3, 2019 at 12:48 AM Ilya Maximets > wrote: > > > > On 25.05.2019 23:49, Darrell Ball wrote: > > > ovn-macros are needed to run the OVN

Re: [ovs-dev] [PATCH v9] Improved Packet Drop Statistics in OVS

2019-06-03 Thread Anju Thomas
Hi Eelco, Apart from Ilya's comments I have not received any comments for v8. I have addressed those comment in v9. Regards Anju -Original Message- From: Eelco Chaudron Sent: Monday, June 3, 2019 6:23 PM To: Anju Thomas Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v9]

[ovs-dev] 答复: [PATCH] conntrack: add tcp_in_liberal option in userspace conntrack

2019-06-03 Thread 姜立东
Hi Darrell, The “tighter checking” on TCP_RST in kernel, do you mean processes under “TCP_CONNTRACK_CLOSE” case? There is only one situation(when th->seq is less than peer td_maxack, as mentioned) may leads to explicitly –NF_ACCEPT, kernel implementation just lets most TCP_RST packets pass

[ovs-dev] $15.356.669 überweisen?

2019-06-03 Thread biuro
Schöner Tag, Ich bin Frau Yoanna Sik-ying für die Mitarbeiter der CITIBANK HONG KONG hier in Hongkong. Kann ich Geld von $ 15.356.669 überweisen? Vertrauen? Schöne Grüße --- This email has been checked for viruses by AVG. https://www.avg.com

Re: [ovs-dev] OVS compiling issue(gcc version 6.5.0 )

2019-06-03 Thread Ben Pfaff
On Mon, Jun 03, 2019 at 11:18:23AM +, Yanqin Wei (Arm Technology China) wrote: > I am trying to compile OVS(master branch) via gcc 6.5.0, but there is gcc > option error. > gcc: error: unrecognized command line option '-Wmultistatement-macros'; did > you mean '-Wunused-macros'? What's in

Re: [ovs-dev] [patch v1] tests: Include ovn-macros for system testsuites.

2019-06-03 Thread Ilya Maximets
On 25.05.2019 23:49, Darrell Ball wrote: > ovn-macros are needed to run the OVN system tests. > > Signed-off-by: Darrell Ball > Tested-by: Greg Rose > Reviewed-by: Greg Rose > --- > tests/system-kmod-testsuite.at | 1 + > tests/system-userspace-testsuite.at | 1 + > 2 files changed, 2

Re: [ovs-dev] [patch v1] tests: Include ovn-macros for system testsuites.

2019-06-03 Thread Ilya Maximets
On 03.06.2019 18:55, Darrell Ball wrote: > > > On Mon, Jun 3, 2019 at 12:48 AM Ilya Maximets > wrote: > > On 25.05.2019 23:49, Darrell Ball wrote: > > ovn-macros are needed to run the OVN system tests. > > > > Signed-off-by: Darrell Ball

Re: [ovs-dev] [patch v1] tests: Include ovn-macros for system testsuites.

2019-06-03 Thread Darrell Ball
On Mon, Jun 3, 2019 at 12:48 AM Ilya Maximets wrote: > On 25.05.2019 23:49, Darrell Ball wrote: > > ovn-macros are needed to run the OVN system tests. > > > > Signed-off-by: Darrell Ball > > Tested-by: Greg Rose > > Reviewed-by: Greg Rose > > --- > > Hi Darrell. > Thanks for the fix. It looks

Re: [ovs-dev] [PATCH] conntrack: add tcp_in_liberal option in userspace conntrack

2019-06-03 Thread Darrell Ball
On Mon, Jun 3, 2019 at 12:21 AM 姜立东 wrote: > Hi Darrell, > > > > By checking latest patch, we notice it has inconsistent behavior on > TCP_RST packet with > > kernel tcp_liberal option. > > In kernel, TCP_RST packet is only checked for TCP_CONNTRACK_CLOSE state, > TCP_CONNTRACK_CLOSE is the

Re: [ovs-dev] [PATCH v4 1/4] netdev: Dynamic per-port Flow API.

2019-06-03 Thread Ilya Maximets
Hi Ophir. I'm curious, what is the current status of your testing? I'd like to apply this series to not block further development. Best regards, Ilya Maximets. On 23.05.2019 16:54, Ilya Maximets wrote: > On 23.05.2019 16:53, Ilya Maximets wrote: >> On 23.05.2019 16:18, Ophir Munk wrote: >>> >>>

Re: [ovs-dev] [PATCHv10] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-03 Thread Ilya Maximets
On 02.06.2019 16:43, William Tu wrote: > Hi Ilya, > > Thanks for your review. > > On Thu, May 30, 2019 at 8:57 AM Ilya Maximets wrote: >> >> On 28.05.2019 22:01, William Tu wrote: >>> The patch introduces experimental AF_XDP support for OVS netdev. >>> diff --git a/lib/dpif-netdev-perf.h

Re: [ovs-dev] [PATCH 1/1] netdev-tc-offloads: Support match on priority tags

2019-06-03 Thread Simon Horman
On Fri, May 31, 2019 at 02:45:25PM +0200, Simon Horman wrote: > Sorry Eli, > > I had missed this but I have it now. > > On Fri, 31 May 2019 at 09:35, Eli Britstein wrote: > > > Ping > > -- > > *From:* Eli Britstein > > *Sent:* Tuesday, May 21, 2019 3:11:51 PM > >

Re: [ovs-dev] [PATCH v9] Improved Packet Drop Statistics in OVS

2019-06-03 Thread Eelco Chaudron
Hi Anju, Wondering if you got the email below… Cheers, Eelco On 24 May 2019, at 11:46, Eelco Chaudron wrote: Hi Anju, Was there ever a follow up on this patch? I only see one response from Ilya on this asking about his v8 comments. Thanks, Eelco On 27 Feb 2019, at 10:22, Anju Thomas

[ovs-dev] OVS compiling issue(gcc version 6.5.0 )

2019-06-03 Thread Yanqin Wei (Arm Technology China)
Hi, I am trying to compile OVS(master branch) via gcc 6.5.0, but there is gcc option error. gcc: error: unrecognized command line option '-Wmultistatement-macros'; did you mean '-Wunused-macros'? My question is which versions of GCC are supported by OVS. Is it a bug of OVS compiling? The

Re: [ovs-dev] [PATCH v9 2/2] OVN: Enable N-S Traffic, Vlan backed DVR

2019-06-03 Thread Numan Siddique
Hi Ankur, Please see some comments inline. Please note that I haven't got the chance to look into the code in detail. I am first trying to test out the patches. (I am in PTO. Expect some delay in my replies). On Thu, May 30, 2019 at 5:58 AM Ankur Sharma wrote: > Background: > [1] >

Re: [ovs-dev] [PATCH v4 1/2] dpif-netdev: add EMC entries counter

2019-06-03 Thread 0-day Robot
Bleep bloop. Greetings Yanqin Wei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Yanqin Wei needs to sign off. WARNING: Unexpected sign-offs from developers who

[ovs-dev] [PATCH v4 2/2] dpif-netdev: dfc_process performance optimization by prefetching EMC entry.

2019-06-03 Thread Yanqin Wei
It is observed that the throughput of medium number of flows(9-8191) is worse than low number of flows(1-8) in the EMC NIC2NIC test. It is because CPU cache-miss increasing in EMC lookup. Each flow need load at least one EMC entry to CPU L1 cache(several cache lines) and compare it with packet

[ovs-dev] [PATCH v4 1/2] dpif-netdev: add EMC entries counter

2019-06-03 Thread Yanqin Wei
Implement entries counter for EMC. It could be used for improvement for EMC lookup. Signed-off-by: Yanqin Wei Reviewed-by: Gavin Hu --- lib/dpif-netdev.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index

[ovs-dev] [PATCH v4 0/2] dfc_process optimization by prefetching EMC entry

2019-06-03 Thread Yanqin Wei
It is observed that the throughput of medium number of flows(9-8191) is worse than low number of flows(1-8) in the EMC NIC2NIC test. This patch improves it by prefetching EMC entry in advance. In order not to affect low and high number of flows scenario, an EMC counter is introduced to prefetch

Re: [ovs-dev] (no subject)

2019-06-03 Thread J KYONG
CAN YOU HANDLE ATTACHED PROJECT, PLEASE SEE ATTACHMENT FOR DETAILS. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] (no subject)

2019-06-03 Thread J KYONG
CAN YOU HANDLE ATTACHED PROJECT, PLEASE SEE ATTACHMENT FOR DETAILS. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [patch v1] tests: Include ovn-macros for system testsuites.

2019-06-03 Thread Ilya Maximets
On 25.05.2019 23:49, Darrell Ball wrote: > ovn-macros are needed to run the OVN system tests. > > Signed-off-by: Darrell Ball > Tested-by: Greg Rose > Reviewed-by: Greg Rose > --- Hi Darrell. Thanks for the fix. It looks good. BTW, I have a question. Are you able to run 'make

[ovs-dev] 答复: [PATCH] conntrack: add tcp_in_liberal option in userspace conntrack

2019-06-03 Thread 姜立东
Hi Darrell, By checking latest patch, we notice it has inconsistent behavior on TCP_RST packet with kernel tcp_liberal option. In kernel, TCP_RST packet is only checked for TCP_CONNTRACK_CLOSE state, TCP_RST packet is dropped if its seq is less than peer acked. In other cases, TCP_RST packets