[ovs-dev] [PATCH] ovn-controller: Fix flow installation latency caused by recompute.

2019-07-23 Thread Han Zhou
From: Han Zhou When there are in-flight flow-installations pending to ovs-vswitchd, current incremental processing logic prioritizes new change handling. However, in scenarios where frequent recomputes are triggered, the later recompute would block the flow-installation for previously computed

[ovs-dev] Re: Re:Question about ovs-tcpundump

2019-07-23 Thread txfh2007 via dev
Hi Ben: Got it ! So should we change the ofproto/trace cmd parameter from "dpname + odp_flow + packet" to "dpname + origin packet" or "dpname + in_port +origin packet" for convenience ? Timo -- Ben Pfaff txfh2007 Aaron

Re: [ovs-dev] Re:Question about ovs-tcpundump

2019-07-23 Thread Ben Pfaff
The packet is not needed for most purposes (a few exceptions are in the documentation), but if you supply it you don't have to specify all of the field values by hand. On Wed, Jul 24, 2019 at 09:57:31AM +0800, txfh2007 via dev wrote: > Hi Aaron: > Perfect Answer! Thanks very much !! > I

[ovs-dev] Re:Question about ovs-tcpundump

2019-07-23 Thread txfh2007 via dev
Hi Aaron: Perfect Answer! Thanks very much !! I have another question: how could the result of ovs-tcpundump get used in ofproto/trace ? From the document ovs-vswitchd I have found the ofproto/trace command shoud be formatted as "dpname + odp_flow + packet", but it seems the dpname +

[ovs-dev] [PATCH] netdev-afxdp: Error when no XDP program loaded.

2019-07-23 Thread William Tu
netdev-afxdp requires XDP program to be loaded. When prog_id == 0, it indicates no XDP program, so return error and free resources. Signed-off-by: William Tu --- lib/netdev-afxdp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/netdev-afxdp.c b/lib/netdev-afxdp.c index

Re: [ovs-dev] [PATCH] netdev-afxdp: Convert AFXDP_DEBUG to custom stats.

2019-07-23 Thread William Tu
On Tue, Jul 23, 2019 at 06:16:46PM +0300, Ilya Maximets wrote: > These are valid statistics of a network interface and should be > exposed via custom stats. > > The same MACRO trick as in vswitchd/bridge.c is used to reduce code > duplication and easily add new stats if necessary in the future. >

[ovs-dev] Советские ретро исполнители - большая коллекция в отличном качестве. 13_05_2019 02_03 198707

2019-07-23 Thread Роман Колунов via dev
ЗОЛОТАЯ КОЛЛЕКЦИЯ СОВЕТСКОГО РЕТРО Здравствуйте, предлагаем Вашему внимаю, пожалуй, самую большую из существующих коллекций подобного рода. Основные отличия нашей коллекции от других, это в первую очередь высокое качество записей, а также большое количество вошедших песен. Наша коллекция

[ovs-dev] [PATCH v2] ofp-monitor: Fixed the usage of 'usable_protocols' variable in 'parse_flow_monitor_request' function.

2019-07-23 Thread Ashish Varma
'usable_protocols' is now getting set to OFPUTIL_P_OF10_ANY on return from 'parse_flow_monitor_request' function. The calling function now checks for the value in this variable against the 'allowed_protocols' variable. Also a check is added for a match field which is not supported in OpenFlow 1.0

Re: [ovs-dev] [PATCH v9] ovn: Add a new logical switch port type - 'virtual'

2019-07-23 Thread Numan Siddique
Just a gentle ping on this patch. It would be great if it can be accepted for 2.12. Thanks Numan On Fri, Jul 19, 2019 at 12:53 AM Numan Siddique wrote: > > > On Thu, Jul 18, 2019 at 11:20 PM Guru Shetty wrote: > >> >> >> On Thu, 18 Jul 2019 at 07:58, wrote: >> >>> From: Numan Siddique >>>

Re: [ovs-dev] Building OVS DPDK debian package

2019-07-23 Thread Ben Pfaff
On Tue, Jul 23, 2019 at 09:40:42AM -0700, Ravi Kerur wrote: > On Mon, Jul 22, 2019 at 10:36 AM Ben Pfaff wrote: > > > On Sat, Jul 20, 2019 at 09:33:47AM -0700, Ravi Kerur wrote: > > > On Wed, Jul 17, 2019 at 4:47 PM Ben Pfaff wrote: > > > > > > > On Wed, Jul 17, 2019 at 04:15:06PM -0700, Ravi

Re: [ovs-dev] Building OVS DPDK debian package

2019-07-23 Thread Ravi Kerur
On Mon, Jul 22, 2019 at 10:36 AM Ben Pfaff wrote: > On Sat, Jul 20, 2019 at 09:33:47AM -0700, Ravi Kerur wrote: > > On Wed, Jul 17, 2019 at 4:47 PM Ben Pfaff wrote: > > > > > On Wed, Jul 17, 2019 at 04:15:06PM -0700, Ravi Kerur wrote: > > > > On Wed, Jul 17, 2019 at 11:06 AM Ben Pfaff wrote: >

Re: [ovs-dev] [PATCH RFC v2 0/8] Introduce connection tracking tc offload

2019-07-23 Thread Paul Blakey
On 7/23/2019 6:42 PM, Marcelo Ricardo Leitner wrote: > On Sat, Jul 20, 2019 at 08:26:59AM +, Paul Blakey wrote: >> Hi Marcelo, thanks for reporting this, can you dump the datapath rules via >> ovs-appctl dpctl/dump-flows -m --names >> Also running "tc filter show dev ns2-veth-ab ingress"

Re: [ovs-dev] [PATCH RFC v2 0/8] Introduce connection tracking tc offload

2019-07-23 Thread Marcelo Ricardo Leitner
On Sat, Jul 20, 2019 at 08:26:59AM +, Paul Blakey wrote: > Hi Marcelo, thanks for reporting this, can you dump the datapath rules via > ovs-appctl dpctl/dump-flows -m --names > Also running "tc filter show dev ns2-veth-ab ingress" while it happened can > show us more details. > > I'll try

[ovs-dev] [PATCH] netdev-afxdp: Convert AFXDP_DEBUG to custom stats.

2019-07-23 Thread Ilya Maximets
These are valid statistics of a network interface and should be exposed via custom stats. The same MACRO trick as in vswitchd/bridge.c is used to reduce code duplication and easily add new stats if necessary in the future. Signed-off-by: Ilya Maximets --- lib/netdev-afxdp.c | 64

Re: [ovs-dev] [PATCH] OVN: Fix learning of neighbors from ARP requests.

2019-07-23 Thread Dumitru Ceara
On Tue, Jul 23, 2019 at 4:26 PM Han Zhou wrote: > > > > On Tue, Jul 23, 2019 at 4:05 AM Dumitru Ceara wrote: > > > > Add a restriction on the target protocol address to match the configured > > subnet. All other ARP packets are invalid in this context. > > > > Reported-at:

Re: [ovs-dev] [PATCH] OVN: Fix learning of neighbors from ARP requests.

2019-07-23 Thread Han Zhou
On Tue, Jul 23, 2019 at 4:05 AM Dumitru Ceara wrote: > > Add a restriction on the target protocol address to match the configured > subnet. All other ARP packets are invalid in this context. > > Reported-at: https://bugzilla.redhat.com/1729846 > Reported-by: Haidong Li > CC: Han Zhou > Fixes:

Re: [ovs-dev] Question about ovs-tcpundump

2019-07-23 Thread Aaron Conole
"txfh2007" writes: > Hi Aaron: Hi Timo, > Sorry to bother, I have found your patch about > ovs-tcpundump(https://patchwork.ozlabs.org/patch/860190/), but I don't know > how to use this script. From the ovs-tcpundump -help I know this command > need a file as its arg(am i right?), but I

Re: [ovs-dev] OVS / OVN split - post 2.12

2019-07-23 Thread Numan Siddique
On Tue, Jul 23, 2019 at 6:03 PM Numan Siddique wrote: > > > On Tue, Jul 23, 2019 at 5:53 PM Mark Michelson > wrote: > >> On 7/22/19 3:43 PM, Mark Michelson wrote: >> > Hi Numan, >> > >> > On 7/22/19 2:35 PM, Numan Siddique wrote: >> >> Hi Ben, Mark and All, >> >> >> >> Now that branch 2.12 is

Re: [ovs-dev] OVS / OVN split - post 2.12

2019-07-23 Thread Numan Siddique
On Tue, Jul 23, 2019 at 5:53 PM Mark Michelson wrote: > On 7/22/19 3:43 PM, Mark Michelson wrote: > > Hi Numan, > > > > On 7/22/19 2:35 PM, Numan Siddique wrote: > >> Hi Ben, Mark and All, > >> > >> Now that branch 2.12 is created, shall we proceed with the OVS/OVN > >> split ? > >> > >> In

Re: [ovs-dev] OVS / OVN split - post 2.12

2019-07-23 Thread Mark Michelson
On 7/22/19 3:43 PM, Mark Michelson wrote: Hi Numan, On 7/22/19 2:35 PM, Numan Siddique wrote: Hi Ben, Mark and All, Now that branch 2.12 is created, shall we proceed with the OVS/OVN split ? In order to do the split we need to do the below tasks In ovn-org/ovn repo Step 1. Sync the ovs

[ovs-dev] [PATCH] dpif-netdev: Fail port addition if reconfiguration failed.

2019-07-23 Thread Ilya Maximets
If the port was destroyed during the initial reconfiguration, we should report an error to the upper layers. Otherwise, successful addition of the port will be logged and upper layers will continue to configure this port. For example, the 'dpif' layer will try to initilaize flow API for this

Re: [ovs-dev] [PATCH 1/1] Fixed memory leak in ovn-controller while handling port binding changes.

2019-07-23 Thread Dumitru Ceara
On Tue, Jul 23, 2019 at 12:33 PM Damijan Skvarc wrote: > > Signed-off-by: Damijan Skvarc Looks good to me. Thanks! Acked-by: Dumitru Ceara > --- > ovn/controller/physical.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovn/controller/physical.c

[ovs-dev] [PATCH] OVN: Fix learning of neighbors from ARP requests.

2019-07-23 Thread Dumitru Ceara
Add a restriction on the target protocol address to match the configured subnet. All other ARP packets are invalid in this context. Reported-at: https://bugzilla.redhat.com/1729846 Reported-by: Haidong Li CC: Han Zhou Fixes: b068454082f5 ("ovn-northd: Support learning neighbor from ARP

[ovs-dev] [PATCH 1/1] Fixed memory leak in ovn-controller while handling port binding changes.

2019-07-23 Thread Damijan Skvarc
Signed-off-by: Damijan Skvarc --- ovn/controller/physical.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c index 316d373..7ad3e6f 100644 --- a/ovn/controller/physical.c +++ b/ovn/controller/physical.c @@ -1091,7 +1091,7

Re: [ovs-dev] [PATCH] netdev-afxdp: Fix use of unconfigured device.

2019-07-23 Thread Ilya Maximets
On 22.07.2019 21:10, William Tu wrote: > On Mon, Jul 22, 2019 at 05:08:48PM +0300, Ilya Maximets wrote: >> In case of failure of 'xsk_configure_all()', 'n_rxq' and 'xdpmode' >> will remain in a new state. This will result in successful >> reconfiguration (immediate return, because configuration is

[ovs-dev] Православная видеоэнциклопедия - уникальное издание в отличном качестве. 13_05_2019 02_03 198707

2019-07-23 Thread Роман Колунов via dev
ПРАВОСЛАВНАЯ ВИДЕОЭНЦИКЛОПЕДИЯ Видеоэнциклопедия призвана ознакомить с основами христианского вероучения, наиболее полно осветить и объяснить догматы и каноны Православия, прикоснуться к священному смыслу Таинств и обрядов Церкви. Православная видеоэнциклопедия является специализированным