[ovs-dev] [PATCH RFC v1] OVS/OVN: Containerize components

1.Start OVS/OVN components in containers so that building and shipping of OVS/OVN components is easy. 2.Load OVS kernel modules on host from container to avoid installing ovs on host. Signed-off-by: aginwala --- utilities/automake.mk | 12 +- utilities/docker/Ma

Re: [ovs-dev] [PATCH 08/12] datapath-config: Consume datapath, CT_Zone, and CT_Timeout_Policy tables

Thanks for the patch; not a full review On Thu, Jul 25, 2019 at 4:29 PM Yi-Hung Wei wrote: > This patch reads the datapath, CT_Zone, and CT_Timeout_Policy tables > from ovsdb, stores the information in a per datapath internal datapath > structure, and pushes down the conntrack timeout policy int

Re: [ovs-dev] [PATCH 03/12] ovs-vsctl: Add datapath and CT zone commands.

added one more comment for now On Fri, Jul 26, 2019 at 11:13 AM Darrell Ball wrote: > Thanks for the patch > > Not a full review; just some initial testing > > > 1/ AT_CHECK([RUN_OVS_VSCTL([add-zone-tp netdev zone=2 icmp_first=2 > icmp_reply_blah=3])]) > > The above syntax is NOT flagged as an

Re: [ovs-dev] [PATCH 00/12] Support zone-based conntrack timeout policy

I did my first round of review by just reading through the code. I plan to test it next week. btw, can you update NEWS? Thanks William On Thu, Jul 25, 2019 at 04:24:02PM -0700, Yi-Hung Wei wrote: > This patch series enables zone-based conntrack timeout policy support in OVS. > Timeout policy i

Re: [ovs-dev] [PATCH 09/12] datapath: compat: Backport nf_conntrack_timeout support

On Thu, Jul 25, 2019 at 04:24:11PM -0700, Yi-Hung Wei wrote: > This patch brings in nf_ct_timeout_put() and nf_ct_set_timeout() > when it is not available in the kernel. > > Three symbols are created in acinclude.m4. > > * HAVE_NF_CT_SET_TIMEOUT is used to determine if upstream net-next commit >

Re: [ovs-dev] [PATCH 08/12] datapath-config: Consume datapath, CT_Zone, and CT_Timeout_Policy tables

I only have some minor comments inline below. On Thu, Jul 25, 2019 at 04:24:10PM -0700, Yi-Hung Wei wrote: > This patch reads the datapath, CT_Zone, and CT_Timeout_Policy tables > from ovsdb, stores the information in a per datapath internal datapath > structure, and pushes down the conntrack ti

Re: [ovs-dev] [PATCH] Remove OVN.

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 Remove OVN. The copy of the patch that faile

Re: [ovs-dev] [PATCH 05/12] ct-dpif: Add conntrack timeout policy support in dpif layer

Thanks for the patch I found this patch hard to review since it does not contain implementations The same comment applies to Patch 6 I think Patches 5-7 can be combined into one patch, which will make review easier. some other comments inline On Thu, Jul 25, 2019 at 4:27 PM Yi-Hung Wei wrote:

Re: [ovs-dev] [PATCH ovn] Include ovn header files from lib/ instead of ovn/lib/

Acked-by: Mark Michelson On 7/26/19 1:57 PM, nusid...@redhat.com wrote: From: Numan Siddique If we don't change this, we will be including the header files from ovs subtree - ovs/ovn/lib/ Signed-off-by: Numan Siddique --- controller-vtep/binding.c | 2 +- controller-vtep/gat

Re: [ovs-dev] [PATCH 03/12] ovs-vsctl: Add datapath and CT zone commands.

Thanks for the patch Not a full review; just some initial testing 1/ AT_CHECK([RUN_OVS_VSCTL([add-zone-tp netdev zone=2 icmp_first=2 icmp_reply_blah=3])]) The above syntax is NOT flagged as an error 2/ AT_CHECK([RUN_OVS_VSCTL([--may-exist add-zone-tp netdev zone=2 icmp_first=2 icmp_reply=3])]

[ovs-dev] [PATCH ovn] Include ovn header files from lib/ instead of ovn/lib/

From: Numan Siddique If we don't change this, we will be including the header files from ovs subtree - ovs/ovn/lib/ Signed-off-by: Numan Siddique --- controller-vtep/binding.c | 2 +- controller-vtep/gateway.c | 2 +- controller-vtep/ovn-controller-vtep.c | 4 ++-- c

[ovs-dev] OVS/OVN split complete in ovn-org/ovn repository

Hello everyone, We just completed the OVS/OVN split in the ovn-org/ovn [1] repository. Please start using the new repo for OVN development. If you have already cloned the ovn repo, after fetching the latest code, please run :./boot.sh", configure etc to compile properly. OVN code is still present

Re: [ovs-dev] [PATCH 07/12] dpif-netlink: Add conntrack timeout policy support

On Thu, Jul 25, 2019 at 04:24:09PM -0700, Yi-Hung Wei wrote: > This patch implements all the conntrack timeout policy related functions > defined in dpif_class for dpif-netlink class in Linux kernel datapath. > > In Linux kernel, the timeout policy is maintained per L3/L4 protocol, > and it is ide

Re: [ovs-dev] [PATCH 12/12] system-traffic: Add zone-based conntrack timeout policy test

Thanks for the patch Comments inline On Thu, Jul 25, 2019 at 4:31 PM Yi-Hung Wei wrote: > This patch adds a system traffic test to verify the zone-based conntrack > timeout feature. The test uses ovs-vsctl commands to configure > the customized ICMP and UDP timeout on zone 5 to a shorter perio

[ovs-dev] [PATCH] Update documentation to require sparse 0.6.0 or later.

The saturated math library uses the __has_builtin() macro, which sparse did not gain support for until version 0.6.0. Signed-off-by: Mark Michelson --- Documentation/intro/install/general.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/intro/install/general.

Re: [ovs-dev] [PATCH 06/12] ct-dpif: Add timeout policy related utility functions.

On Thu, Jul 25, 2019 at 04:24:08PM -0700, Yi-Hung Wei wrote: > These functions will be useful in the following patches. > > Signed-off-by: Yi-Hung Wei > --- > lib/ct-dpif.c | 53 + > lib/ct-dpif.h | 3 +++ > 2 files changed, 56 insertions(+) >

Re: [ovs-dev] [PATCH 02/12] vswitchd: Add datapath, CT_Zone, and CT_Timeout_Policy tables.

On Thu, Jul 25, 2019 at 04:24:04PM -0700, Yi-Hung Wei wrote: > From: Justin Pettit > > Signed-off-by: Justin Pettit > --- > vswitchd/vswitch.ovsschema | 44 +++- > vswitchd/vswitch.xml | 254 > - > 2 files changed, 249 insertions(+), 49 de

Re: [ovs-dev] [PATCH 01/12] simap: Add utility function to help compare two simaps.

On Thu, Jul 25, 2019 at 04:24:03PM -0700, Yi-Hung Wei wrote: > From: Ben Pfaff > > Signed-off-by: Ben Pfaff > --- LGTM Acked-by: William Tu > lib/simap.c | 15 ++- > lib/simap.h | 1 + > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/lib/simap.c b/lib/simap.c

Re: [ovs-dev] [PATCH 03/12] ovs-vsctl: Add datapath and CT zone commands.

On Thu, Jul 25, 2019 at 04:24:05PM -0700, Yi-Hung Wei wrote: > From: William Tu > > The patch adds the following commands > $ ovs-vsctl {add,del,list}-dp > for creating/deleting/listing the datapath, and > $ ovs-vsctl {add,del,list}-zone-tp > for conntrack zones and timeout policies. > > Sig

Re: [ovs-dev] OVS / OVN split - post 2.12

On 7/26/19 10:36 AM, Numan Siddique wrote: On Fri, Jul 26, 2019 at 8:04 PM Mark Michelson > wrote: On 7/26/19 8:52 AM, Numan Siddique wrote: > On Fri, Jul 26, 2019 at 5:51 PM Numan Siddique mailto:nusid...@redhat.com>> wrote: > >> >>

Re: [ovs-dev] OVS / OVN split - post 2.12

On Fri, Jul 26, 2019 at 8:04 PM Mark Michelson wrote: > On 7/26/19 8:52 AM, Numan Siddique wrote: > > On Fri, Jul 26, 2019 at 5:51 PM Numan Siddique > wrote: > > > >> > >> > >> On Fri, Jul 26, 2019 at 5:19 PM Damijan Skvarc > > >> wrote: > >> > >>> Dumitru, > >>> your issue was fixed in > >>> >

Re: [ovs-dev] OVS / OVN split - post 2.12

On 7/26/19 8:52 AM, Numan Siddique wrote: On Fri, Jul 26, 2019 at 5:51 PM Numan Siddique wrote: On Fri, Jul 26, 2019 at 5:19 PM Damijan Skvarc wrote: Dumitru, your issue was fixed in https://github.com/openvswitch/ovs/commit/6f6d19db05ca743d6f294618d2c36b6d0b15e2e2 as removed warning. How

Re: [ovs-dev] [PATCH] committer-responsibilities: Add guidelines for fixing up mistakes.

On 25.07.2019 23:25, Ben Pfaff wrote: > On Thu, Jul 25, 2019 at 08:39:21AM -0700, Ben Pfaff wrote: >> On Thu, Jul 25, 2019 at 11:21:25AM +0300, Ilya Maximets wrote: >>> On 25.07.2019 6:09, Ben Pfaff wrote: On Wed, Jul 24, 2019 at 08:25:54PM +0300, Ilya Maximets wrote: > On 24.07.2019 20:05

Re: [ovs-dev] OVS / OVN split - post 2.12

On Fri, Jul 26, 2019 at 5:51 PM Numan Siddique wrote: > > > On Fri, Jul 26, 2019 at 5:19 PM Damijan Skvarc > wrote: > >> Dumitru, >> your issue was fixed in >> https://github.com/openvswitch/ovs/commit/6f6d19db05ca743d6f294618d2c36b6d0b15e2e2 >> as removed warning. However fix is not merged yet

[ovs-dev] Tr: CONFIRMATION D'ENVOI -- DE VOTRE GAIN

Monsieur / Madame, Nous vous contactons pour vous informer que vous venez de gagner 150.000 Euros au tirage au sort organisé par notre compagnie MICROSOFT WINDOWS. (Vous trouverez sur le document en fichier joint des renseignements détaillés sur le gain.) Pour entrer en possession du gain, veu

Re: [ovs-dev] OVS / OVN split - post 2.12

On Fri, Jul 26, 2019 at 5:19 PM Damijan Skvarc wrote: > Dumitru, > your issue was fixed in > https://github.com/openvswitch/ovs/commit/6f6d19db05ca743d6f294618d2c36b6d0b15e2e2 > as removed warning. However fix is not merged yet on > https://github.com/ovn-org/ovn.git. Unfortunatelly even merging

[ovs-dev] [PATCH] ofproto-dpif-xlate: Check mirror port before do terminate_native_tunnel

From: Wang Li The problem is the ovs-tcpdump can not capture the ingress vxlan traffics when it listens on the dpdk port, and the following dump-flows described the details: ovs-tcpdump stopped: recirc_id(0),in_port(2),packet_type(ns=0,id=0),eth(),eth_type(0x0800),ipv4(), udp(dst=4789), packets:

Re: [ovs-dev] OVS / OVN split - post 2.12

Dumitru, your issue was fixed in https://github.com/openvswitch/ovs/commit/6f6d19db05ca743d6f294618d2c36b6d0b15e2e2 as removed warning. However fix is not merged yet on https://github.com/ovn-org/ovn.git. Unfortunatelly even merging this fix to ovn-org/ovn.git will not help, since (saying from memo

Re: [ovs-dev] OVS / OVN split - post 2.12

On 26.07.2019 12:49, Numan Siddique wrote: > > > On Fri, Jul 26, 2019 at 2:00 PM Dumitru Ceara > wrote: > > On Fri, Jul 26, 2019 at 8:21 AM Numan Siddique > wrote: > > > > Hello All, > > > > The split work is almost done

Re: [ovs-dev] OVS / OVN split - post 2.12

On Fri, Jul 26, 2019 at 2:00 PM Dumitru Ceara wrote: > On Fri, Jul 26, 2019 at 8:21 AM Numan Siddique > wrote: > > > > Hello All, > > > > The split work is almost done and we have pushed it to the ovn repo > branch > > for now - https://github.com/ovn-org/ovn/commits/ovs_ovn_split > > If some on

Re: [ovs-dev] [PATCH RFC v2 3/8] tc: Introduce tc_id to specify a tc filter

Hi Paul, On Thu, Jul 04, 2019 at 05:28:22PM +0300, Paul Blakey wrote: > Move all that is needed to identify a tc filter to a > new structure, tc_id. This removes a lot of duplication > in accessing/creating tc filters. > > Signed-off-by: Paul Blakey This is a rather large patch. I'm wondering i

Re: [ovs-dev] [PATCH RFC v2 1/8] match: Add match_set_ct_zone_masked helper

On Thu, Jul 04, 2019 at 05:28:20PM +0300, Paul Blakey wrote: > Sets zone in match. I think it would be good if a longer changelog was provided. Which included some "why", which is not present in the code, as well as "what", which is present in the code. This comment applies to the entire series.

Re: [ovs-dev] OVS / OVN split - post 2.12

On Fri, Jul 26, 2019 at 8:21 AM Numan Siddique wrote: > > Hello All, > > The split work is almost done and we have pushed it to the ovn repo branch > for now - https://github.com/ovn-org/ovn/commits/ovs_ovn_split > If some one is interested, please try it out and let us know any comments > or issu

[ovs-dev] [PATCH 1/1] stream_ssl: fix important memory leak in ssl_connect() function

While checking valgrind reports after running "make check-valgrind" I have noticed reports for several tests similar to the following: ==5345== Memcheck, a memory error detector ==5345== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al. ==5345== Using Valgrind-3.11.0 and Lib

Re: [ovs-dev] OVS / OVN split - post 2.12

On 25.07.2019 21:35, Mark Michelson wrote: > On 7/25/19 12:37 PM, Ilya Maximets wrote: >> Hi. >> >> I have a question regarding the split. >> Sorry if it's obvious from the RFC splitting code which I didn't look at. >> >> The question is: >> How the patches for the common data structures (lists, ha