Re: [ovs-dev] [PATCH v2 3/9] ct-dpif: Export ct_dpif_format_ipproto()

2019-08-02 Thread Justin Pettit
> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > This function will be useful for following patchs. s/patchs/patches/ Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v2 2/9] ovs-vsctl: Add conntrack zone commands.

2019-08-02 Thread Justin Pettit
> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > From: William Tu > > The patch adds commands creating/deleting/listing conntrack zone > timeout policies: > $ ovs-vsctl {add,del,list}-zone-tp zone=zone_id ... I think the command also requires a datapath argument. > Signed-off-by:

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix IP engine run with in-flight messages

2019-08-02 Thread Mark Michelson
Good catch! Acked-by: Mark Michelson On 8/2/19 5:22 AM, Dumitru Ceara wrote: When trying to incrementally process changes even if there are in-flight messages we were incorrectly setting the engine_aborted variable to the value returned by engine_run. However, engine_run returns true if the

[ovs-dev] Google Compensation

2019-08-02 Thread Google Inc via dev
GOOGLE INC. WELTWEIT ADRESSE: 20 W KINZIE ST, CHICAGO, IL 60654, VEREINIGTE STAATEN VON AMERIKA. Sie wurden von Google INC als einem ihrer aktiven Kunden und Betrugsopfern, die ihre Online-Werbetechnologien, Suchmaschinen, Cloud-Computing, Software und Hardware in ihren Büros und zu Hause

Re: [ovs-dev] [PATCH 02/12] vswitchd: Add datapath, CT_Zone, and CT_Timeout_Policy tables.

2019-08-02 Thread Justin Pettit
> On Jul 26, 2019, at 8:11 AM, William Tu wrote: > > On Thu, Jul 25, 2019 at 04:24:04PM -0700, Yi-Hung Wei wrote: >> >> + "type": {"key": "string", "value": "string", >> + "min": 0, "max": "unlimited"}}}, >> + "indexes": [["timeouts"]]}, > > Just to let you

Re: [ovs-dev] [PATCH v2 1/9] ovs-vswitchd: Add Datapath, CT_Zone, and CT_Zone_Policy tables.

2019-08-02 Thread Justin Pettit
> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > From: Justin Pettit > > From: Justin Pettit Can you drop one of these "From:" statements? Otherwise it appears in the commit message. As we discussed off-line, can you apply the following diff, which we worked on together along with

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix IP engine run with in-flight messages

2019-08-02 Thread Numan Siddique
On Fri, Aug 2, 2019 at 2:53 PM Dumitru Ceara wrote: > When trying to incrementally process changes even if there are in-flight > messages we were incorrectly setting the engine_aborted variable to the > value returned by engine_run. However, engine_run returns true if the > run was completed. >

Re: [ovs-dev] [PATCH ovn] Add -u option to ovn-nbctl

2019-08-02 Thread Numan Siddique
On Fri, Aug 2, 2019 at 12:14 AM Mark Michelson wrote: > This option can be used in one of two ways. > > When paired with --detach, this creates a unixctl socket with the name > given as the argument to '-u'. > > When not paired with --detach, this tells the ovn-nbctl client the name > of the

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fixed memory leak in ovn_port_update_sbrec()

2019-08-02 Thread Numan Siddique
On Fri, Aug 2, 2019 at 6:31 PM 0-day Robot wrote: > Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > git-am: > fatal: sha1 information is

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fixed memory leak in ovn_port_update_sbrec()

2019-08-02 Thread Numan Siddique
On Fri, Aug 2, 2019 at 5:45 PM Damijan Skvarc wrote: > Memory leak happens because of redundand memory allocation for array > of single pointer. Issue was solved by removing this redundand allocation > and using address of pointer to created chassis sb_ha_entity instead. > > Signed-off-by:

Re: [ovs-dev] [PATCH] OVN: fix L4 default lb proto reported by ovn-nbctl

2019-08-02 Thread Numan Siddique
On Fri, Aug 2, 2019 at 6:11 PM Dumitru Ceara wrote: > On Thu, Aug 1, 2019 at 7:40 PM Lorenzo Bianconi > wrote: > > > > If no protocol is specified defining a load balancing rule TCP is > > selected as default but ovn-nbctl lb-list reports 'tcp/udp'. > > Fix it reporting 'tcp' in this case > > >

Re: [ovs-dev] [PATCH ovn] Change the package name from openvswitch to ovn in AC_INIT()

2019-08-02 Thread Numan Siddique
On Thu, Aug 1, 2019 at 9:46 PM Mark Michelson wrote: > Acked-by: Mark Michelson > Thanks. I applied this to master. Numan > > On 8/1/19 9:46 AM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Signed-off-by: Numan Siddique > > --- > > configure.ac | 2 +- > > 1 file

Re: [ovs-dev] [branch2.12] ovn: Add a new logical switch port type - 'virtual'

2019-08-02 Thread Numan Siddique
On Fri, Aug 2, 2019 at 6:20 AM Guru Shetty wrote: > > > On Thu, 1 Aug 2019 at 10:52, wrote: > >> From: Numan Siddique >> >> This new type is added for the following reasons: >> >> - When a load balancer is created in an OpenStack deployment with >> Octavia >> service, it creates a

Re: [ovs-dev] Travis build failures due to base image change to Xenial.

2019-08-02 Thread Aaron Conole
Simon Horman writes: > On Thu, Aug 01, 2019 at 03:27:39PM -0700, Gregory Rose wrote: >> >> On 8/1/2019 8:53 AM, Ilya Maximets wrote: >> > Hi, everyone. >> > >> > I'm trying to fix TravisCI build failures on older branches. Recently they >> > started to change default images from Trusty to

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fixed memory leak in ovn_port_update_sbrec()

2019-08-02 Thread 0-day Robot
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (northd/ovn-northd.c). Repository lacks necessary

Re: [ovs-dev] [PATCH] OVN: fix L4 default lb proto reported by ovn-nbctl

2019-08-02 Thread Dumitru Ceara
On Thu, Aug 1, 2019 at 7:40 PM Lorenzo Bianconi wrote: > > If no protocol is specified defining a load balancing rule TCP is > selected as default but ovn-nbctl lb-list reports 'tcp/udp'. > Fix it reporting 'tcp' in this case > > Fixes: e2bfcad6cbb0 ("ovn-nbctl: Add LB commands") > Signed-off-by:

[ovs-dev] [PATCH 1/1] ovn-northd: fixed memory leak in ovn_port_update_sbrec()

2019-08-02 Thread Damijan Skvarc
Memory leak happens because of redundand memory allocation for array of single pointer. Issue was solved by removing this redundand allocation and using address of pointer to created chassis sb_ha_entity instead. Signed-off-by: Damijan Skvarc --- northd/ovn-northd.c | 6 ++ 1 file changed,

Re: [ovs-dev] [PATCH v2 ovn] add missing checkpatch.py script

2019-08-02 Thread Dumitru Ceara
On Thu, Aug 1, 2019 at 2:07 PM Lorenzo Bianconi wrote: > > Signed-off-by: Lorenzo Bianconi Hi Lorenzo, Should we also clone the ovs/tests/checkpatch.at tests and add them to tests/testsuite.at? I'm not sure why but in OVS checkpatch.py is also added to EXTRA_DIST (ovs/utilities/automake.mk).

[ovs-dev] [PATCH ovn] ovn-controller: Fix IP engine run with in-flight messages

2019-08-02 Thread Dumitru Ceara
When trying to incrementally process changes even if there are in-flight messages we were incorrectly setting the engine_aborted variable to the value returned by engine_run. However, engine_run returns true if the run was completed. This was causing discrepancies between logical flows and

[ovs-dev] [PATCH v3] vswitchd: Make packet-in controller queue size configurable

2019-08-02 Thread Dumitru Ceara
The ofconn packet-in queue for packets that can't be immediately sent on the rconn connection was limited to 100 packets (hardcoded value). While increasing this limit is usually not recommended as it might create buffer bloat and increase latency, in scaled scenarios it is useful if the

Re: [ovs-dev] Travis build failures due to base image change to Xenial.

2019-08-02 Thread Simon Horman
On Thu, Aug 01, 2019 at 03:27:39PM -0700, Gregory Rose wrote: > > On 8/1/2019 8:53 AM, Ilya Maximets wrote: > > Hi, everyone. > > > > I'm trying to fix TravisCI build failures on older branches. Recently they > > started to change default images from Trusty to Xenial. Not all the > >

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-02 Thread 0-day Robot
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-02 Thread Damijan Skvarc
Done! Thanks for review. On Wed, Jul 31, 2019 at 6:40 PM Mark Michelson wrote: > I've pushed this to OVN master. Damijan, could you post a backport patch > for OVS 2.12, please? Thanks! > > On 7/31/19 9:17 AM, Mark Michelson wrote: > > Thanks for the fix! > > Acked-by: Mark Michelson > > > >

[ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-02 Thread Damijan Skvarc
Within this function actions & match dynamic strings are used as helper variables for adding entries into logical flow table. Variables are used several times in order to optimize number of memory allocations, however at the end memory was forgotten to be deallocated. Signed-off-by: Damijan