Re: [ovs-dev] [PATCH v3] ovn-openstack.rst: Miscelaneous fixes.

2019-08-07 Thread 0-day Robot
Bleep bloop. Greetings Flavio Fernandes, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 99 characters long (recommended limit is 79) #37 FILE:

[ovs-dev] [PATCH v3] ovn-openstack.rst: Miscelaneous fixes.

2019-08-07 Thread Flavio Fernandes
Added a few clarifications to improve the tutorial: - VM needs to be at least 6 Gb on latest openstack (ouch!); - VM must support nesting; - local.conf may require HOST_IP depending on device name; - Omit --project from network create to be consistent with OS_PROJECT_NAME; - Use a

Re: [ovs-dev] [PATCH v2] ovn-openstack.rst: Miscelaneous fixes.

2019-08-07 Thread 0-day Robot
Bleep bloop. Greetings Flavio Fernandes, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 99 characters long (recommended limit is 79) #37 FILE:

[ovs-dev] [PATCH v2] ovn-openstack.rst: Miscelaneous fixes.

2019-08-07 Thread Flavio Fernandes
Added a few clarifications to improve the tutorial: - VM needs to be at least 6 Gb on latest openstack (ouch!); - VM must support nesting; - local.conf may require HOST_IP depending on device name; - Omit --project from network create to be consistent with OS_PROJECT_NAME; - Use a

Re: [ovs-dev] [PATCH ovn v2] OVN: Fix learning of neighbors from ARP/ND packets.

2019-08-07 Thread Han Zhou
On Wed, Aug 7, 2019 at 8:12 AM Dumitru Ceara wrote: > On Mon, Aug 5, 2019 at 5:34 PM Han Zhou wrote: > > > > > > > > On Mon, Aug 5, 2019 at 1:06 AM Dumitru Ceara wrote: > > > > > > On Mon, Aug 5, 2019 at 1:41 AM Han Zhou wrote: > > > > > > > > > > > > > > > > On Mon, Jul 29, 2019 at 2:30 AM

Re: [ovs-dev] [PATCH v2 2/9] ovs-vsctl: Add conntrack zone commands.

2019-08-07 Thread Darrell Ball
On Wed, Aug 7, 2019 at 1:37 PM William Tu wrote: > Thanks for the review. > > On Mon, Aug 05, 2019 at 04:12:02PM -0700, Darrell Ball wrote: > > Thanks for the patch > > > > I noticed '--may-exist' and '--if-exists' are supported now for > > add--zone-tp/del-zone-tp - thanks > > The check for

Re: [ovs-dev] [PATCH 1/1] ovn-openstack.rst: Miscelaneous fixes.

2019-08-07 Thread 0-day Robot
Bleep bloop. Greetings Flavio Fernandes, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 99 characters long (recommended limit is 79) #37 FILE:

[ovs-dev] [PATCH 1/1] ovn-openstack.rst: Miscelaneous fixes.

2019-08-07 Thread Flavio Fernandes
Added a few clarifications to improve the tutorial: - VM needs to be at least 6 Gb on latest openstack (ouch!); - VM must support nesting; - local.conf may require HOST_IP depending on device name; - Omit --project from network create to be consistent with OS_PROJECT_NAME; - Use a

Re: [ovs-dev] [PATCH v2] datapath: compat: Backports bugfixes for nf_conncount

2019-08-07 Thread Yifeng Sun
Thanks YiHung for reviewing. I've sent out a new version. Best, Yifeng On Wed, Aug 7, 2019 at 10:24 AM Yi-Hung Wei wrote: > > On Tue, Aug 6, 2019 at 5:06 PM Yifeng Sun wrote: > > > > This patch backports several critical bug fixes related to > > locking and data consistency in nf_conncount

[ovs-dev] [PATCH v3] datapath: compat: Backports bugfixes for nf_conncount

2019-08-07 Thread Yifeng Sun
This patch backports several critical bug fixes related to locking and data consistency in nf_conncount code. This backport is based on the following upstream net-next upstream commits. a007232 ("netfilter: nf_conncount: fix argument order to find_next_bit") c80f10b ("netfilter: nf_conncount:

[ovs-dev] Видеокурс "Как воспитать ребёнка, чтобы он вырос богатым, счастливым и успешным лидером" - подробно и с практическими рекомендациями. 13_05_2019 02_03 198707

2019-08-07 Thread Роман Колунов via dev
ВИДЕОКУРС КАК ВОСПИТАТЬ РЕБЁНКА, ЧТОБЫ ОН ВЫРОС БОГАТЫМ, СЧАСТЛИВЫМ И УСПЕШНЫМ ЛИДЕРОМ В помощь молодым родителям в воспитании у детей правильных убеждений и ценностей Наверно нет такого родителя, который не хочет, чтобы его ребенок был самым умным, счастливым, здоровым и успешным. Каждый

Re: [ovs-dev] [PATCH v4] Remove OVN.

2019-08-07 Thread Zhou, Han via dev
Remove the huge body of the email so that conversation can be easier through the email thread ( On 8/7/19, 3:06 PM, "ovs-dev-boun...@openvswitch.org on behalf of Han Zhou" wrote: Hi Mark, Does it remove the ovsdb-cluster.at and related files? I think they are important as

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-07 Thread Darrell Ball
On Wed, Aug 7, 2019 at 11:51 AM Darrell Ball wrote: > > > On Wed, Aug 7, 2019 at 11:40 AM Darrell Ball wrote: > >> >> >> On Tue, Aug 6, 2019 at 9:57 PM Justin Pettit wrote: >> >>> >>> > On Aug 5, 2019, at 8:07 PM, Darrell Ball wrote: >>> > >>> > On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei >>>

Re: [ovs-dev] [PATCH v2 2/9] ovs-vsctl: Add conntrack zone commands.

2019-08-07 Thread William Tu
Thanks for the review. On Mon, Aug 05, 2019 at 04:12:02PM -0700, Darrell Ball wrote: > Thanks for the patch > > I noticed '--may-exist' and '--if-exists' are supported now for > add--zone-tp/del-zone-tp - thanks > The check for duplicate timeout policies now correctly checks all key and > values

Re: [ovs-dev] memory leak in internal_dev_create

2019-08-07 Thread Pravin Shelar
On Tue, Aug 6, 2019 at 5:00 AM Hillf Danton wrote: > > > On Tue, 06 Aug 2019 01:58:05 -0700 > > Hello, > > > > syzbot found the following crash on: > > ... > > BUG: memory leak > > unreferenced object 0x8881228ca500 (size 128): > >comm "syz-executor032", pid 7015, jiffies 4294944622 (age

Re: [ovs-dev] [PATCH v2 2/9] ovs-vsctl: Add conntrack zone commands.

2019-08-07 Thread William Tu
On Fri, Aug 02, 2019 at 05:42:16PM -0700, Justin Pettit wrote: > > > On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > > > From: William Tu > > > > The patch adds commands creating/deleting/listing conntrack zone > > timeout policies: > > $ ovs-vsctl {add,del,list}-zone-tp zone=zone_id ...

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-07 Thread Darrell Ball
On Wed, Aug 7, 2019 at 11:40 AM Darrell Ball wrote: > > > On Tue, Aug 6, 2019 at 9:57 PM Justin Pettit wrote: > >> >> > On Aug 5, 2019, at 8:07 PM, Darrell Ball wrote: >> > >> > On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei >> wrote: >> > >> >> +struct ct_timeout_policy { >> >> +struct uuid

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-07 Thread Darrell Ball
On Tue, Aug 6, 2019 at 9:57 PM Justin Pettit wrote: > > > On Aug 5, 2019, at 8:07 PM, Darrell Ball wrote: > > > > On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei wrote: > > > >> +struct ct_timeout_policy { > >> +struct uuid uuid; > >> +unsigned int last_used_seqno; > >> +struct

Re: [ovs-dev] [PATCH ovn] Enable OVN in tutorial/ovs-sandbox by default

2019-08-07 Thread Numan Siddique
On Wed, Aug 7, 2019 at 11:27 PM Mark Michelson wrote: > Acked-by: Mark Michelson > > Thanks for the review. I applied this to master. Numan > On 8/7/19 11:06 AM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > The patch removs the --ovn option and enables OVN by default. > > > >

Re: [ovs-dev] [PATCH ovn] Enable OVN in tutorial/ovs-sandbox by default

2019-08-07 Thread Mark Michelson
Acked-by: Mark Michelson On 8/7/19 11:06 AM, nusid...@redhat.com wrote: From: Numan Siddique The patch removs the --ovn option and enables OVN by default. Signed-off-by: Numan Siddique --- tutorial/ovs-sandbox | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

Re: [ovs-dev] [PATCH v2] datapath: compat: Backports bugfixes for nf_conncount

2019-08-07 Thread Yi-Hung Wei
On Tue, Aug 6, 2019 at 5:06 PM Yifeng Sun wrote: > > This patch backports several critical bug fixes related to > locking and data consistency in nf_conncount code. > > This backport is based on the following upstream net-next upstream commits. > 4cd273b ("netfilter: nf_conncount: don't skip

[ovs-dev] OVS-DPDK public meeting 7th August

2019-08-07 Thread Stokes, Ian
Hi all, I don’t see anything on the agenda for today’s OVS DPDK community sync meeting. Unless I hear otherwise I propose we cancel today’s meeting and instead meet in two weeks when we’re closer to the release? If there are any issues for the agenda today please let me know and I’ll be happy

Re: [ovs-dev] [PATCH ovn v2] OVN: Fix learning of neighbors from ARP/ND packets.

2019-08-07 Thread Dumitru Ceara
On Mon, Aug 5, 2019 at 5:34 PM Han Zhou wrote: > > > > On Mon, Aug 5, 2019 at 1:06 AM Dumitru Ceara wrote: > > > > On Mon, Aug 5, 2019 at 1:41 AM Han Zhou wrote: > > > > > > > > > > > > On Mon, Jul 29, 2019 at 2:30 AM Dumitru Ceara wrote: > > > > > > > > Add a restriction on the target

[ovs-dev] [PATCH ovn] Enable OVN in tutorial/ovs-sandbox by default

2019-08-07 Thread nusiddiq
From: Numan Siddique The patch removs the --ovn option and enables OVN by default. Signed-off-by: Numan Siddique --- tutorial/ovs-sandbox | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox index 9b4c3e4f5..47032b499 100755 ---

Re: [ovs-dev] 2.12.0 branch snapshot - test 2618 failure on s390x

2019-08-07 Thread Numan Siddique
On Wed, Aug 7, 2019 at 4:20 PM James Page wrote: > Just tripped on this one whilst building for s390x on Ubuntu: > > ## ## > > ## Summary of the failures. ## > ## ## > Failed tests: > openvswitch 2.12.0 test suite test groups: > > NUM:

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-07 Thread Numan Siddique
On Wed, Aug 7, 2019 at 4:59 PM Damijan Skvarc wrote: > Within this function actions & match dynamic strings are used as helper > variables for adding entries into logical flow table. Variables are > used several times in order to optimize number of memory allocations, > however at the end memory

Re: [ovs-dev] [PATCH v2 ovn] logical-fields: fix memory leak while initializing ovnfield_by_name

2019-08-07 Thread 0-day Robot
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 logical-fields: fix memory leak while

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-07 Thread 0-day Robot
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (northd/ovn-northd.c). Repository lacks necessary

Re: [ovs-dev] [PATCH ovn] logical-fields: fix memory leak while initializing ovnfield_by_name

2019-08-07 Thread Dumitru Ceara
On Wed, Aug 7, 2019 at 12:50 PM Damijan Skvarc wrote: > > ovnfield_by_name is a hash table, intended to quicky find ovn_field by > name from a list of supported ovn_fields. This hash table is initialized > in ovn_init_symtab() function based on ovn_fields const array. In case > ovn_init_symtab()

[ovs-dev] [PATCH v2 ovn] logical-fields: fix memory leak while initializing ovnfield_by_name

2019-08-07 Thread Damijan Skvarc
fixed 0-day Robot issues Signed-off-by: Damijan Skvarc --- lib/logical-fields.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/logical-fields.c b/lib/logical-fields.c index 62b9a71..fdc78cf 100644 --- a/lib/logical-fields.c +++ b/lib/logical-fields.c @@ -57,9

[ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

2019-08-07 Thread Damijan Skvarc
Within this function actions & match dynamic strings are used as helper variables for adding entries into logical flow table. Variables are used several times in order to optimize number of memory allocations, however at the end memory was forgotten to be deallocated. Signed-off-by: Damijan

Re: [ovs-dev] [PATCH ovn] logical-fields: fix memory leak while initializing ovnfield_by_name

2019-08-07 Thread 0-day Robot
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around

[ovs-dev] [PATCH ovn] logical-fields: fix memory leak while initializing ovnfield_by_name

2019-08-07 Thread Damijan Skvarc
ovnfield_by_name is a hash table, intended to quicky find ovn_field by name from a list of supported ovn_fields. This hash table is initialized in ovn_init_symtab() function based on ovn_fields const array. In case ovn_init_symtab() function is called multiple times then hash table is

[ovs-dev] 2.12.0 branch snapshot - test 2618 failure on s390x

2019-08-07 Thread James Page
Just tripped on this one whilst building for s390x on Ubuntu: ## ## ## Summary of the failures. ## ## ## Failed tests: openvswitch 2.12.0 test suite test groups: NUM: FILE-NAME:LINE TEST-GROUP-NAME KEYWORDS 2618: ovn.at:789

[ovs-dev] [PATCH ovn] ovn-northd: Add IGMP Relay support

2019-08-07 Thread Dumitru Ceara
Add a new configuration option 'mcast_relay' to the Logical_Router:options in the OVN Northbound database. If a router is configured with 'mcast_relay' enabled then ovn-northd will install Logical_Flows to allow IP multicast traffic to be routed between Logical_Switches. The logical router will

[ovs-dev] Payment for Invoice(Confirm Bank Details And Amount)

2019-08-07 Thread Accounts Department
Greetings, We have been directed by our European District Company to send payment to your Bank Account for an outstanding invoice. We wish to reconfirm from you, Your correct Bank Details And Invoice Amount. We will not bear any lost if you fail to reconfirm details as attached as we intend

[ovs-dev] [PATCH] Do RCU synchronization at fixed interval in PMD main loop.

2019-08-07 Thread Nitin Katiyar
Each PMD updates the global sequence number for RCU synchronization purpose with other OVS threads. This is done at every 1025th iteration in PMD main loop. If the PMD thread is responsible for polling large number of queues that are carrying traffic, it spends a lot of time processing packets