On Wed, Aug 14, 2019 at 11:11 PM Dumitru Ceara wrote:
>
> On Thu, Aug 8, 2019 at 1:52 AM Han Zhou wrote:
> >
> >
> >
> > On Wed, Aug 7, 2019 at 8:12 AM Dumitru Ceara wrote:
> >>
> >> On Mon, Aug 5, 2019 at 5:34 PM Han Zhou wrote:
> >> >
> >> >
> >> >
> >> > On Mon, Aug 5, 2019 at 1:06 AM Dumitr
On Thu, Aug 8, 2019 at 1:52 AM Han Zhou wrote:
>
>
>
> On Wed, Aug 7, 2019 at 8:12 AM Dumitru Ceara wrote:
>>
>> On Mon, Aug 5, 2019 at 5:34 PM Han Zhou wrote:
>> >
>> >
>> >
>> > On Mon, Aug 5, 2019 at 1:06 AM Dumitru Ceara wrote:
>> > >
>> > > On Mon, Aug 5, 2019 at 1:41 AM Han Zhou wrote:
>
Sure. Thanks for re-validating different corner cases with me. Yup, we can
update more details in leader-only section about using single LB VIP while
accessing clustered db via ovn-nbctl/ovn-sbctl for sure to avoid
confusion.
On Wed, Aug 14, 2019 at 3:21 PM Han Zhou wrote:
> Hi Aginwala, thank
On Tue, Aug 13, 2019 at 8:03 PM Darrell Ball wrote:
>> diff --git a/lib/dpif-provider.h b/lib/dpif-provider.h
>> index e988626ea05b..d12b5a91c2eb 100644
>> --- a/lib/dpif-provider.h
>> +++ b/lib/dpif-provider.h
>> @@ -542,6 +542,16 @@ struct dpif_class {
>>
On Wed, Aug 14, 2019 at 2:35 PM Darrell Ball wrote:
> On Mon, Aug 12, 2019 at 5:54 PM Yi-Hung Wei wrote:
>> --- a/lib/dpif-netlink.c
>> +++ b/lib/dpif-netlink.c
>> +static int
>> +dpif_netlink_ct_set_timeout_policy(struct dpif *dpif OVS_UNUSED,
>> + const struct
On Tue, Aug 13, 2019 at 9:23 AM Han Zhou wrote:
>
> From: Han Zhou
>
> candiate_retrying is used to determine if the current node is disconnected
> from the cluster when the node is in candiate role. However, a node
> can flap between candidate and follower role before a leader is elected
> when
From: Han Zhou
candiate_retrying is used to determine if the current node is disconnected
from the cluster when the node is in candiate role. However, a node
can flap between candidate and follower role before a leader is elected
when majority of the cluster is down, so is_connected() will flap,
From: Han Zhou
As mentioned in RAFT paper, section 6.2:
Leaders: A server might be in the leader state, but if it isn’t the current
leader, it could be needlessly delaying client requests. For example, suppose a
leader is partitioned from the rest of the cluster, but it can still
communicate wit
From: Han Zhou
When clustered mode is used, the client needs to retry connecting
to new servers when certain failures happen. Today it is allowed to
retry new connection only if multiple remotes are used, which prevents
using LB VIP with clustered nodes. This patch makes sure the retry
logic work
From: Han Zhou
Fixes: commit 5a9b53a5 ("ovsdb raft: Fix duplicated transaction execution when
leader failover.")
Signed-off-by: Han Zhou
---
ovsdb/raft.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovsdb/raft.c b/ovsdb/raft.c
index c60ef41..1c38b3b 100644
--- a/ovsdb/ra
Hi Aginwala, thanks for the testing. The change of this patch will cause
the IDL to avoid connecting to a follower if "leader_only" is set to
"true". It is the same behavior as before when multiple remotes are used,
but now it just does the same even when a single remote is used, because
the single
Thanks for the patch
mostly minor comments
On Mon, Aug 12, 2019 at 5:54 PM Yi-Hung Wei wrote:
> This patch first defines the dpif interface for a datapath to support
> adding, deleting, getting and dumping conntrack timeout policy.
> The timeout policy is identified by a 4 bytes unsigned intege
On Wed, Aug 14, 2019 at 1:28 PM Yi-Hung Wei wrote:
> On Tue, Aug 13, 2019 at 7:46 PM Darrell Ball wrote:
> >
> > Thanks for the patch
> >
> > Some high level comments:
> >
> > 1/ The ct_tp_kill_list code is still in common code
> > I think we discussed moving that to the dpif backer code
> >
On Tue, Aug 13, 2019 at 7:46 PM Darrell Ball wrote:
>
> Thanks for the patch
>
> Some high level comments:
>
> 1/ The ct_tp_kill_list code is still in common code
> I think we discussed moving that to the dpif backer code
> ct_timeout_policy_unref() is adding to this deferred kill list whi
On Wed, Aug 14, 2019 at 9:47 AM Yi-Hung Wei wrote:
> On Mon, Aug 12, 2019 at 7:46 PM Darrell Ball wrote:
> >> diff --git a/vswitchd/vswitch.ovsschema b/vswitchd/vswitch.ovsschema
> >> index f7c6eb8983cd..c0a2242ad345 100644
> >> --- a/vswitchd/vswitch.ovsschema
> >> +++ b/vswitchd/vswitch.ovssch
On Mon, Aug 12, 2019 at 7:46 PM Darrell Ball wrote:
>> diff --git a/vswitchd/vswitch.ovsschema b/vswitchd/vswitch.ovsschema
>> index f7c6eb8983cd..c0a2242ad345 100644
>> --- a/vswitchd/vswitch.ovsschema
>> +++ b/vswitchd/vswitch.ovsschema
>> @@ -1,9 +1,14 @@
>> {"name": "Open_vSwitch",
>> - "vers
On Wed, Aug 14, 2019 at 7:58 AM William Tu wrote:
>
> On Wed, Aug 14, 2019 at 5:09 AM Eelco Chaudron wrote:
> >
> >
> >
> > On 8 Aug 2019, at 17:38, Ilya Maximets wrote:
> >
> >
> >
> > I see a rather high number of afxdp_cq_skip, which should to my
> > knowledge never happen?
> > >>>
On Tue, Aug 13, 2019 at 8:30 AM Ilya Maximets wrote:
>
> This allows to decrease code duplication and avoid using Linux-specific
> functions (this might be useful in the future if we'll try to allow
> running OvS+DPDK on FreeBSD).
>
> Signed-off-by: Ilya Maximets
LGTM
Acked-by: William Tu
> -
On Wed, Aug 14, 2019 at 02:28:13PM +0300, Ilya Maximets wrote:
> On 14.08.2019 11:39, Michele Baldessari wrote:
> > In some of our destructive testing of ovn-dbs inside containers managed
> > by pacemaker we reached a situation where /var/run/openvswitch had
> > empty .pid files. The current code d
In some of our destructive testing of ovn-dbs inside containers managed
by pacemaker we reached a situation where /var/run/openvswitch had
empty .pid files. The current code does not deal well with them
and pidfile_is_running() returns true in such a case and this confuses
the OCF resource agent.
In some of our destructive testing of ovn-dbs inside containers managed
by pacemaker we reached a situation where /var/run/openvswitch had
empty .pid files. The current code does not deal well with them
and pidfile_is_running() returns true in such a case and this confuses
the OCF resource agent.
Looks good Flavio.
Acked-By: Vasu Dasari
Thanks
-Vasu
*Vasu Dasari*
On Tue, Aug 13, 2019 at 12:45 PM Flavio Leitner via dev <
ovs-dev@openvswitch.org> wrote:
> On Tue, Aug 13, 2019 at 01:34:04PM -0300, Flavio Leitner via dev wrote:
> > When a packet needs to be encapsulated in userspace, the
On Tue, Aug 13, 2019 at 8:30 AM Ilya Maximets wrote:
>
> Unlike 'rte_get_tsc_cycles()' which doesn't need any specific
> initialization, 'rte_get_tsc_hz()' could be used only after successfull
> call to 'rte_eal_init()'. 'rte_eal_init()' estimates the TSC frequency
> for later use by 'rte_get_tsc_
On Tue, Aug 13, 2019 at 8:30 AM Ilya Maximets wrote:
>
> New functions to get and set CPU affinity using CPU dumps.
> This will abstract OS specific implementation details from the
> cross-platform code.
>
> Signed-off-by: Ilya Maximets
Acked-by: William Tu
One comment inline below.
> ---
>
On Wed, Aug 14, 2019 at 5:09 AM Eelco Chaudron wrote:
>
>
>
> On 8 Aug 2019, at 17:38, Ilya Maximets wrote:
>
>
>
> I see a rather high number of afxdp_cq_skip, which should to my
> knowledge never happen?
> >>>
> >>> I tried to investigate this previously, but didn't find anything
> >>
On Wed, Aug 14, 2019 at 6:08 PM Jaime Caamaño Ruiz wrote:
> Hello
>
> Some comments, that probably are due to me being confused checking the
> new repo:
>
>
Hi Jaime,
This is patch 4 of the series. Patch 1 takes care of adding ovn specific
run dirs (run, log, db dirs).
Can you please take a loo
Hello
Some comments, that probably are due to me being confused checking the
new repo:
1)
> sed -i 's:\(.*su\).*:\1 ovn ovn:' %{_sysconfdir}/logrotate.d/ovn
I dont see the file %{_sysconfdir}/logrotate.d/ovn included anywhere.
Anyway, since OVN_USER_ID defaults to openvswitch:openvswitch,
shoul
On 14.08.2019 11:33, Nitin Katiyar wrote:
>
>
>> -Original Message-
>> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
>> Sent: Wednesday, August 14, 2019 1:42 PM
>> To: Nitin Katiyar ; ovs-dev@openvswitch.org
>> Cc: Stokes, Ian
>> Subject: Re: [ovs-dev] [PATCH] Improve MPLSoGRE perf
Greetings
How are you today,
I am a NATO soldier serving in Afghanistan.I and my comrades, we are
seeking your assistance as a business entrepreneur or business
development manager to help us receive/invest our funds in your country
in any lucrative business.Please if this proposal is acceptable b
On 8 Aug 2019, at 17:38, Ilya Maximets wrote:
I see a rather high number of afxdp_cq_skip, which should to my
knowledge never happen?
I tried to investigate this previously, but didn't find anything
suspicious.
So, for my knowledge, this should never happen too.
However, I only looked at
On 14.08.2019 11:39, Michele Baldessari wrote:
> In some of our destructive testing of ovn-dbs inside containers managed
> by pacemaker we reached a situation where /var/run/openvswitch had
> empty .pid files. The current code does not deal well with them
> and pidfile_is_running() returns true in
Very fast delivery. Incredible service!
ENTER HERE
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Bleep bloop. Greetings Michele Baldessari, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 88 characters long (recommended limit is 79)
#46 FILE: ovn/utilities/ovn
In some of our destructive testing of ovn-dbs inside containers managed
by pacemaker we reached a situation where /var/run/openvswitch had
empty .pid files. The current code does not deal well with them
and pidfile_is_running() returns true in such a case and this confuses
the OCF resource agent.
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Tuesday, August 13, 2019 8:49 PM
> To: Nitin Katiyar ; ovs-dev@openvswitch.org
> Cc: Anju Thomas ; Stokes, Ian
>
> Subject: Re: [ovs-dev] [PATCH] Do RCU synchronization at fixed interval in
> PMD main loo
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Wednesday, August 14, 2019 1:42 PM
> To: Nitin Katiyar ; ovs-dev@openvswitch.org
> Cc: Stokes, Ian
> Subject: Re: [ovs-dev] [PATCH] Improve MPLSoGRE performance by reducing
> EMC hash collisions.
>
> On
On 13.08.2019 20:49, Nitin Katiyar wrote:
> When a packet is received, the RSS hash is calculated if it is not
> already available. The Exact Match Cache (EMC) entry is then looked up
> using this RSS hash.
>
> When a MPLSoGRE encapsulated packet is received, the GRE header is
> popped, the RSS ha
On 14 Aug 2019, at 9:45, Ilya Maximets wrote:
On 13.08.2019 19:46, Eelco Chaudron wrote:
On 13 Aug 2019, at 18:37, Ilya Maximets wrote:
This is highly useful to see on which core PMD is running by
only looking at the thread name. Thread Id still allows to
distinguish different threads run
On 13.08.2019 19:46, Eelco Chaudron wrote:
>
>
> On 13 Aug 2019, at 18:37, Ilya Maximets wrote:
>
>> This is highly useful to see on which core PMD is running by
>> only looking at the thread name. Thread Id still allows to
>> distinguish different threads running on the same core over the time:
39 matches
Mail list logo