Re: [ovs-dev] [PATCH v1] ovsdb.7.rst: some corrections in ovsdb-client usage.

2019-08-23 Thread Han Zhou
On Fri, Aug 23, 2019 at 3:36 PM wrote: > > From: Aliasgar Ginwala > > 1. Correct typo where it should be ovsdb-client backup vs ovsdb-tool backup. > 2. Update for which case will ovsdb-client not work. > > Signed-off-by: Aliasgar Ginwala > --- > Documentation/ref/ovsdb.7.rst | 6 -- > 1

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-23 Thread Ginwala, Aliasgar via dev
Thanks Ben: On 8/23/19, 2:50 PM, "Ben Pfaff" wrote: On Fri, Aug 23, 2019 at 09:29:00PM +, Ginwala, Aliasgar wrote: > Hi Ben: > > It seems ovsdb-client backup does conversion for openvswitch databases and not OVN dbs: > $ovsdb-client backup > standalone_db.db >

[ovs-dev] [PATCH v1] ovsdb.7.rst: some corrections in ovsdb-client usage.

2019-08-23 Thread amginwal
From: Aliasgar Ginwala 1. Correct typo where it should be ovsdb-client backup vs ovsdb-tool backup. 2. Update for which case will ovsdb-client not work. Signed-off-by: Aliasgar Ginwala --- Documentation/ref/ovsdb.7.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-23 Thread Ben Pfaff
On Fri, Aug 23, 2019 at 09:29:00PM +, Ginwala, Aliasgar wrote: > Hi Ben: > > It seems ovsdb-client backup does conversion for openvswitch databases and > not OVN dbs: > $ovsdb-client backup > standalone_db.db > > When trying for ovnnb dbs, it keeps complaining about syntax error. May be I

Re: [ovs-dev] [PATCH 1/3] raft.c: Election timer initial reset with value from log.

2019-08-23 Thread Ben Pfaff
On Thu, Aug 22, 2019 at 02:08:21PM -0700, Han Zhou wrote: > From: Han Zhou > > After election timer is changed through cluster/change-election-timer > command, if a server restarts, it firstly initializes with the default > value and use it to reset the timer. Although it reads the latest >

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix using uninitialised memory in user_action_cookie.

2019-08-23 Thread Ilya Maximets
On Thu, Jul 25, 2019 at 07:31:04PM +0300, Ilya Maximets wrote: Designated initializers are not suitable for initializing non-packed structures and unions which are subjects for comparison by memcmp(). Whole memory for 'struct user_action_cookie' must be explicitly cleared before using because

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-23 Thread Ginwala, Aliasgar via dev
Hi Ben: It seems ovsdb-client backup does conversion for openvswitch databases and not OVN dbs: $ovsdb-client backup > standalone_db.db When trying for ovnnb dbs, it keeps complaining about syntax error. May be I miss something ovsdb-client backup /var/run/openvswitch/ovnnb_db.sock

[ovs-dev] Liderazgo, clima, retribución

2019-08-23 Thread Salario Emocional
12 de Septiembre | Horario de 10:00 a 17:00 hrs. | (hora del centro de México) - Salario Emocional - y otras estrategias de compensación al personal ¿De qué hablaremos? Conoceremos las estrategias más innovadoras para fomentar la motivación de sus trabajadores y su compromiso con la

[ovs-dev] [PATCH] ovs-lib: Add timeout at ovs-check-dead-ifs.

2019-08-23 Thread William Tu
At SUSE12 SP3, we hit a case where ovs-check-dead-ifs tries to read an entry in /proc//fd/ but hangs forever. The pid is a qemu-system-x86_64 process and we suspect it's an issue related to qemu, not ovs. As a result, force-reload-kmod hangs and OVS bridge never gets restarted. This patch adds a

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-23 Thread aginwala
Thanks Ben for review! On Fri, Aug 23, 2019 at 10:42 AM Ben Pfaff wrote: > On Thu, Aug 22, 2019 at 05:53:10PM -0700, amgin...@gmail.com wrote: > > From: Aliasgar Ginwala > > > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > > E.g. usage to migrate nb/sb db to

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-23 Thread aginwala
Thanks Han for detailed review. On Fri, Aug 23, 2019 at 8:17 AM Han Zhou wrote: > On Thu, Aug 22, 2019 at 10:29 PM aginwala aginwala > wrote: > > > Thanks for the review Han. > > > > On Thu, Aug 22, 2019 at 7:27 PM Han Zhou wrote: > > > >> Ali, thanks for the patch. Please see my comments

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-23 Thread Ben Pfaff
On Thu, Aug 22, 2019 at 05:53:10PM -0700, amgin...@gmail.com wrote: > From: Aliasgar Ginwala > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > E.g. usage to migrate nb/sb db to standalone db from raft: > ovsdb-tool migrate-cluster-db ovnnb_db.db ovnnb_db_cluster.db >

Re: [ovs-dev] [PATCHv18] netdev-afxdp: add new netdev type for AF_XDP.

2019-08-23 Thread William Tu
On Fri, Aug 23, 2019 at 9:59 AM Ilya Maximets wrote: > > On 23.08.2019 19:08, William Tu wrote: > > On Wed, Aug 21, 2019 at 2:31 AM Eelco Chaudron wrote: > >> > >> > >> > > William, Eelco, which HW NIC you're using? Which kernel driver? > > I’m using the below on the latest

Re: [ovs-dev] [PATCHv18] netdev-afxdp: add new netdev type for AF_XDP.

2019-08-23 Thread Ilya Maximets
On 23.08.2019 19:08, William Tu wrote: > On Wed, Aug 21, 2019 at 2:31 AM Eelco Chaudron wrote: >> >> >> > William, Eelco, which HW NIC you're using? Which kernel driver? I’m using the below on the latest bpf-next driver: 01:00.0 Ethernet controller: Intel Corporation

Re: [ovs-dev] OVS-DPDK public meeting

2019-08-23 Thread Kevin Traynor
Next meeting September 18th 1700 UTC August 21st minutes Attendees: Pieter, Frikkie, Scott, Roni, Ian, Simon, Kevin. === GENERAL === - OVS 2.12 -- No updates - not aware of any blockers - DPDK Stable Releases -- 18.11.3 backports in progress -- Estimate of early October for 18.11.3

Re: [ovs-dev] [PATCH] conntrack: Correct length check for tcp packet inside ICMP data.

2019-08-23 Thread Darrell Ball
Thanks for the patch Goes back to release 2.6/day one :-). I'll provide more feedback after today. On Fri, Aug 23, 2019 at 6:20 AM Vishal Deep Ajmera < vishal.deep.ajm...@ericsson.com> wrote: > An ICMP packet with type destination or host not reachable also carries > 28 bytes of ICMP data

Re: [ovs-dev] [PATCHv18] netdev-afxdp: add new netdev type for AF_XDP.

2019-08-23 Thread William Tu
On Wed, Aug 21, 2019 at 2:31 AM Eelco Chaudron wrote: > > > > >>> William, Eelco, which HW NIC you're using? Which kernel driver? > >> > >> I’m using the below on the latest bpf-next driver: > >> > >> 01:00.0 Ethernet controller: Intel Corporation 82599ES 10-Gigabit > >> SFI/SFP+ Network

Re: [ovs-dev] [PATCH v2] ovsdb-tool: Convert clustered db to standalone db.

2019-08-23 Thread Han Zhou
On Thu, Aug 22, 2019 at 10:29 PM aginwala aginwala wrote: > Thanks for the review Han. > > On Thu, Aug 22, 2019 at 7:27 PM Han Zhou wrote: > >> Ali, thanks for the patch. Please see my comments below. >> >> On Thu, Aug 22, 2019 at 5:53 PM wrote: >> > >> > From: Aliasgar Ginwala >> > >> > Add

Re: [ovs-dev] [PATCH v2 1/2] netdev-dpdk: Fix not reporting rx_oversize_errors in stats.

2019-08-23 Thread Stokes, Ian
On 8/23/2019 2:58 PM, Ilya Maximets wrote: On 23.08.2019 16:20, Stokes, Ian wrote: On 8/19/2019 12:18 PM, Ilya Maximets wrote: There is a big code duplication issue with DPDK xstats that led to missed "rx_oversize_errors" statistics. It's defined but not used. Fix that by actually using this

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Refactor vhost custom stats for extensibility.

2019-08-23 Thread Ilya Maximets
On 23.08.2019 16:16, Kevin Traynor wrote: > On 19/08/2019 12:18, Ilya Maximets wrote: >> vHost interfaces currently has only one custom statistic, but there >> might be others in the near future. This refactoring makes the code >> work in the same way as it done for dpdk and afxdp stats to keep

Re: [ovs-dev] [PATCH v2 1/2] netdev-dpdk: Fix not reporting rx_oversize_errors in stats.

2019-08-23 Thread Ilya Maximets
On 23.08.2019 16:20, Stokes, Ian wrote: > > On 8/19/2019 12:18 PM, Ilya Maximets wrote: >> There is a big code duplication issue with DPDK xstats that led to >> missed "rx_oversize_errors" statistics. It's defined but not used. >> Fix that by actually using this stat along with code refactoring

Re: [ovs-dev] [PATCH v5 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-23 Thread Numan Siddique
On Fri, Aug 23, 2019, 12:52 AM Ankur Sharma wrote: > Hi Numan, > > Submitted a v6 last week. Awaiting your feedback on it, please feel free > to let me know if additional changes are needed. > > Thanks > Hi Ankit, Yes it's on top of my head to review these patches. I will take a look and come

[ovs-dev] [PATCH] conntrack: Correct length check for tcp packet inside ICMP data.

2019-08-23 Thread Vishal Deep Ajmera
An ICMP packet with type destination or host not reachable also carries 28 bytes of ICMP data field. This data field contains IP header and TCP header (partial first 8 bytes) of the original packet for which ICMP is being generated. Conntrack module when processing these ICMP packets checks for

Re: [ovs-dev] [PATCH v2 1/2] netdev-dpdk: Fix not reporting rx_oversize_errors in stats.

2019-08-23 Thread Stokes, Ian
On 8/19/2019 12:18 PM, Ilya Maximets wrote: There is a big code duplication issue with DPDK xstats that led to missed "rx_oversize_errors" statistics. It's defined but not used. Fix that by actually using this stat along with code refactoring that will allow us to not make same mistakes in the

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Refactor vhost custom stats for extensibility.

2019-08-23 Thread Kevin Traynor
On 19/08/2019 12:18, Ilya Maximets wrote: > vHost interfaces currently has only one custom statistic, but there > might be others in the near future. This refactoring makes the code > work in the same way as it done for dpdk and afxdp stats to keep the > common style over the different code places

Re: [ovs-dev] [PATCH v2 1/2] netdev-dpdk: Fix not reporting rx_oversize_errors in stats.

2019-08-23 Thread Kevin Traynor
On 19/08/2019 12:18, Ilya Maximets wrote: > There is a big code duplication issue with DPDK xstats that led to > missed "rx_oversize_errors" statistics. It's defined but not used. > Fix that by actually using this stat along with code refactoring that > will allow us to not make same mistakes in

Re: [ovs-dev] [PATCH v5] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-23 Thread Sriram Vatala via dev
-Original Message- From: Ilya Maximets Sent: 06 August 2019 22:02 To: Sriram Vatala ; 'Ben Pfaff' ; 'Stokes, Ian' Cc: ovs-dev@openvswitch.org Subject: Re: [PATCH v5] Detailed packet drop statistics per dpdk and vhostuser ports On 24.07.2019 11:55, Sriram Vatala wrote: > Hi, > > @Ben

Re: [ovs-dev] [PATCH 0/3] ovn-controller: Logical flow processing optimizations

2019-08-23 Thread Dumitru Ceara
On Fri, Aug 23, 2019 at 12:38 PM Dumitru Ceara wrote: > > This series adds some (independent) optimizations that improve > ovn-controller performance by lowering the number of operations that > need to be executed during a iteration of the main controller loop. > > Each patch in the series

[ovs-dev] [PATCH v2 ovn 3/3] ovn-controller: Minimize SB DB port_binding lookups.

2019-08-23 Thread Dumitru Ceara
Instead of storing only peer_ports in struct local_datapath, store both local-remote mappings for patch ports. Also, it's useful to directly store sbrec_port_binding pointers for all datapath ports as we avoid doing costly sbrec_port_binding index lookups by port name. Signed-off-by: Dumitru

[ovs-dev] [PATCH v2 ovn 2/3] ovn-controller: Optimize update of ct-zones external-ids.

2019-08-23 Thread Dumitru Ceara
commit_ct_zones() is called at every ovn-controller iteration but updates to ct-zones don't happen at every iteration. Avoid cloning the br-int->external_ids map unless an update is needed. Signed-off-by: Dumitru Ceara --- controller/ovn-controller.c | 53

[ovs-dev] [PATCH v2 ovn 1/3] ofctrl: Avoid recomputing match hash in ofctrl_dup_flow().

2019-08-23 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- controller/ofctrl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controller/ofctrl.c b/controller/ofctrl.c index 8928205..3131baf 100644 --- a/controller/ofctrl.c +++ b/controller/ofctrl.c @@ -743,7 +743,7 @@ ofctrl_dup_flow(struct

[ovs-dev] [PATCH v2 ovn 0/3] ovn-controller: Logical flow processing optimizations

2019-08-23 Thread Dumitru Ceara
This series adds some (independent) optimizations that improve ovn-controller performance by lowering the number of operations that need to be executed during a iteration of the main controller loop. Each patch in the series addresses a bottleneck reported by running `perf record -g --call-graph

Re: [ovs-dev] [PATCH 1/3] ofctrl: Avoid recomputing match hash in ofctrl_dup_flow().

2019-08-23 Thread 0-day Robot
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (controller/ofctrl.c). Repository lacks necessary

[ovs-dev] [PATCH 2/3] ovn-controller: Optimize update of ct-zones external-ids.

2019-08-23 Thread Dumitru Ceara
commit_ct_zones() is called at every ovn-controller iteration but updates to ct-zones don't happen at every iteration. Avoid cloning the br-int->external_ids map unless an update is needed. Signed-off-by: Dumitru Ceara --- controller/ovn-controller.c | 53

[ovs-dev] [PATCH 3/3] ovn-controller: Minimize SB DB port_binding lookups.

2019-08-23 Thread Dumitru Ceara
Instead of storing only peer_ports in struct local_datapath, store both local-remote mappings for patch ports. Also, it's useful to directly store sbrec_port_binding pointers for all datapath ports as we avoid doing costly sbrec_port_binding index lookups by port name. Signed-off-by: Dumitru

[ovs-dev] [PATCH 1/3] ofctrl: Avoid recomputing match hash in ofctrl_dup_flow().

2019-08-23 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- controller/ofctrl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controller/ofctrl.c b/controller/ofctrl.c index 8928205..3131baf 100644 --- a/controller/ofctrl.c +++ b/controller/ofctrl.c @@ -743,7 +743,7 @@ ofctrl_dup_flow(struct

[ovs-dev] [PATCH 0/3] ovn-controller: Logical flow processing optimizations

2019-08-23 Thread Dumitru Ceara
This series adds some (independent) optimizations that improve ovn-controller performance by lowering the number of operations that need to be executed during a iteration of the main controller loop. Each patch in the series addresses a bottleneck reported by running `perf record -g --call-graph

[ovs-dev] Dodatečné zdroje

2019-08-23 Thread Kamil Adamec via dev
Dobrý den! Živnostníkům často stojí v cestě k dosažení úspěchu nízká úroveň provozních zdrojů na nákup materiálu, zboží nebo surovin z důvodu např. nezaplacení faktur (nezaplacení od dodavatelů, prodloužená splatnost apod.). V této oblasti jsme již pomohli řadě firem, které mohly díky získání

Re: [ovs-dev] [PATCH branch-2.12] pinctrl: Fix DNS packet parsing

2019-08-23 Thread Dumitru Ceara
On Fri, Aug 16, 2019 at 4:35 PM Dumitru Ceara wrote: > > On Fri, Aug 16, 2019 at 4:32 PM Dumitru Ceara wrote: > > > > From: Dumitru Ceara > > > > Due to the use of a uint8_t to index inside the DNS payload we could end > > up in an infinite loop when specific (invalid) DNS packets were > >

Re: [ovs-dev] [PATCH ovn] Remove ageing check in run_put_mac_binding

2019-08-23 Thread Lorenzo Bianconi
> On Thu, Aug 22, 2019 at 06:51:40PM +0200, Lorenzo Bianconi wrote: > > Remove ageing check in run_put_mac_binding routine on mac-binding info > > since if ovn-controller main thread is heavy loaded the info will be > > discarded and the mac_binding table will not never be updated > > > >