Re: [ovs-dev] [PATCH v2] vswitch: ratelimit the device add log

2019-09-16 Thread William Tu
On Mon, Sep 16, 2019 at 8:17 AM Aaron Conole wrote: > > It's possible that a port added to the system with certain kinds > of invalid parameters will cause the 'could not add' log to be > triggered. When this happens, the vswitch run loop can continually > re-attempt adding the port. While the

Re: [ovs-dev] [PATCH 1/1] stream_ssl: fix important memory leak in ssl_connect() function

2019-09-16 Thread William Tu
On Mon, Sep 16, 2019 at 12:20 AM Damijan Skvarc wrote: > > Hi William and thanks for your review. > I agree with your proposed changes. > Is there still some action expected from me? > > thanks, Damijan No, thanks for the patch. Let's wait to see if others have more feedback. William > > > > On

[ovs-dev] [PATCH v1 ovn] ovn-ctl: Support passing ssl certs for northd

2019-09-16 Thread amginwal
From: Aliasgar Ginwala When using ssl mode for ovn nb/sb active-standby/cluster db service models, northd can use ssl mode too. e.g. one can pass --ovn-northd-ssl-key, --ovn-northd-ssl-ca-cert and --ovn-northd-ssl-cert to start northd with ssl Signed-off-by: Aliasgar Ginwala ---

Re: [ovs-dev] [PATCH v5 6/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-09-16 Thread Yi-Hung Wei
On Fri, Sep 13, 2019 at 5:33 PM Justin Pettit wrote: > > > > On Aug 28, 2019, at 3:14 PM, Yi-Hung Wei wrote: > > > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > > index 751535249e21..4b4c4d722645 100644 > > --- a/ofproto/ofproto-dpif.c > > +++ b/ofproto/ofproto-dpif.c > > > >

Re: [ovs-dev] [PATCH ovn v2] Learn the mac binding only if required

2019-09-16 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 91 characters long (recommended limit is 79) #1031 FILE: ovn-sb.xml:1401:

[ovs-dev] [PATCH ovn v2] Learn the mac binding only if required

2019-09-16 Thread nusiddiq
From: Numan Siddique OVN has the actions - put_arp and put_nd to learn the mac bindings from the ARP/ND packets. These actions update the Southbound MAC_Binding table. These actions translates to controller actions. Whenever pinctrl thread receives such packets, it wakes up the main

Re: [ovs-dev] [PATCH] checkpatch: Ignore utitilies/bugtool.

2019-09-16 Thread Gregory Rose
On 9/12/2019 11:11 AM, William Tu wrote: Signed-off-by: William Tu --- utilities/checkpatch.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index f8fa00e306a8..a9f27b52f3c8 100755 --- a/utilities/checkpatch.py +++

Re: [ovs-dev] [PATCH] ovs-bugtool: Add ip -s -s to get_device_stats.out.

2019-09-16 Thread Gregory Rose
On 9/12/2019 10:07 AM, William Tu wrote: The patch adds 'ip -s -s' to file get_device_stats.out to collect device statistics. When debugging tunnel related issues, the command shows much more detailed counters, ex: frame, crc, carrier, helping to understand the root cause when packets are

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

2019-09-16 Thread Han Zhou
On Mon, Sep 16, 2019 at 4:15 AM Dumitru Ceara wrote: > > On Sat, Sep 14, 2019 at 7:16 PM Han Zhou wrote: > > > > > > > > On Sat, Sep 14, 2019 at 9:09 AM Han Zhou wrote: > > > > > > > > > > > > On Sat, Sep 14, 2019 at 12:40 AM Numan Siddique wrote: > > > > > > > > > > > > > > > > On Sat, Sep

Re: [ovs-dev] [PATCH ovn] ovn-lib: Fix the wrong ovn_etcdir path

2019-09-16 Thread Mark Michelson
On 9/16/19 9:00 AM, Dumitru Ceara wrote: On Mon, Sep 16, 2019 at 2:55 PM wrote: From: Numan Siddique 'sysconfdir' is used instead of 'ovn_sysconfdir' to determine the ovn_etcdir path. Signed-off-by: Numan Siddique Looks good to me, thanks! Acked-by: Dumitru Ceara I pushed this to

[ovs-dev] [PATCH v2] vswitch: ratelimit the device add log

2019-09-16 Thread Aaron Conole
It's possible that a port added to the system with certain kinds of invalid parameters will cause the 'could not add' log to be triggered. When this happens, the vswitch run loop can continually re-attempt adding the port. While the parameters remain invalid the vswitch run loop will re-trigger

Re: [ovs-dev] Fw: Re: [PATCH v3] netdev-offload-dpdk : add ipv6 rte flow item support

2019-09-16 Thread Aaron Conole
刘畅 writes: > Hi Aaron: > I have encountered this rebot error but have no idea what should do. can > you offer some advice? > Many thanks ! > > Re: [ovs-dev] [PATCH v3] netdev-offload-dpdk : add ipv6 rte flow item support > > Bleep bloop. Greetings Timo_Liu, I am a robot and I have

Re: [ovs-dev] [PATCH v13] Improved Packet Drop Statistics in OVS

2019-09-16 Thread Eelco Chaudron
Hi Anju, For some reason, this version does not show up in patchwork! I have two small comments below but other than that it looks fine to me. If those two will be the only changes in your next rev, I’ll ack it straight away :) Cheers, Eelco On 9 Sep 2019, at 13:53, Anju Thomas wrote:

Re: [ovs-dev] [PATCH ovn] ovn-lib: Fix the wrong ovn_etcdir path

2019-09-16 Thread Dumitru Ceara
On Mon, Sep 16, 2019 at 2:55 PM wrote: > > From: Numan Siddique > > 'sysconfdir' is used instead of 'ovn_sysconfdir' to determine the ovn_etcdir > path. > > Signed-off-by: Numan Siddique Looks good to me, thanks! Acked-by: Dumitru Ceara > --- > utilities/ovn-lib.in | 2 +- > 1 file

[ovs-dev] [PATCH ovn] ovn-lib: Fix the wrong ovn_etcdir path

2019-09-16 Thread nusiddiq
From: Numan Siddique 'sysconfdir' is used instead of 'ovn_sysconfdir' to determine the ovn_etcdir path. Signed-off-by: Numan Siddique --- utilities/ovn-lib.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovn-lib.in b/utilities/ovn-lib.in index

Re: [ovs-dev] [PATCH] vswitch: ratelimit the device add log

2019-09-16 Thread Aaron Conole
Ben Pfaff writes: > On Thu, Sep 12, 2019 at 11:45:41AM -0400, Aaron Conole wrote: >> It's possible that a port added to the system with certain kinds >> of invalid parameters will cause the 'could not add' log to be >> triggered. When this happens, the vswitch run loop can continually >>

Re: [ovs-dev] [PATCH v3 ovn 0/2] ovn-controller: Logical flow processing optimizations

2019-09-16 Thread Dumitru Ceara
On Mon, Sep 16, 2019 at 12:39 PM Numan Siddique wrote: > > > > On Fri, Sep 13, 2019 at 3:13 AM Han Zhou wrote: >> >> On Thu, Sep 12, 2019 at 7:14 AM Dumitru Ceara wrote: >> > >> > This series adds some (independent) optimizations that improve >> > ovn-controller performance by lowering the

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

2019-09-16 Thread Dumitru Ceara
On Sat, Sep 14, 2019 at 7:16 PM Han Zhou wrote: > > > > On Sat, Sep 14, 2019 at 9:09 AM Han Zhou wrote: > > > > > > > > On Sat, Sep 14, 2019 at 12:40 AM Numan Siddique wrote: > > > > > > > > > > > > On Sat, Sep 14, 2019 at 2:41 AM Daniel Alvarez Sanchez > > > wrote: > > >> > > >> Acked-by:

Re: [ovs-dev] [PATCH v3 ovn] northd: add empty_lb controller_event for logical router

2019-09-16 Thread Numan Siddique
On Sat, Sep 14, 2019 at 2:03 AM Mark Michelson wrote: > Acked-by: Mark Michelson > > On 9/10/19 1:00 PM, Lorenzo Bianconi wrote: > > Add empty load balancer controller_event support to logical router > > pipeline. Update northd documentation even for logical switch pipeline > > > >

Re: [ovs-dev] [PATCH ovn] gitignore: Add missing OVN entries.

2019-09-16 Thread Numan Siddique
On Fri, Sep 13, 2019 at 8:24 PM Dumitru Ceara wrote: > Signed-off-by: Dumitru Ceara > Thanks. I applied this patch to master. Numan > --- > .gitignore | 8 > include/ovn/.gitignore | 2 ++ > utilities/.gitignore | 1 + > 3 files changed, 11 insertions(+) > create

Re: [ovs-dev] [PATCH v3 ovn 0/2] ovn-controller: Logical flow processing optimizations

2019-09-16 Thread Numan Siddique
On Fri, Sep 13, 2019 at 3:13 AM Han Zhou wrote: > On Thu, Sep 12, 2019 at 7:14 AM Dumitru Ceara wrote: > > > > This series adds some (independent) optimizations that improve > > ovn-controller performance by lowering the number of operations that > > need to be executed during a iteration of

Re: [ovs-dev] [PATCH v3] vswitchd: Make packet-in controller queue size configurable

2019-09-16 Thread Dumitru Ceara
Hi, Just a reminder, Mark has acked this change a while ago but it didn't get pushed yet. Thanks, Dumitru On Fri, Aug 9, 2019 at 5:08 PM Mark Michelson wrote: > > Acked-by: Mark Michelson > > On 8/2/19 4:29 AM, Dumitru Ceara wrote: > > The ofconn packet-in queue for packets that can't be

Re: [ovs-dev] [PATCH ovn] Learn the mac binding only if required

2019-09-16 Thread Dumitru Ceara
On Wed, Sep 11, 2019 at 10:05 PM wrote: > > From: Numan Siddique > > OVN has the actions - put_arp and put_nd to learn the mac bindings from the > ARP/ND packets. These actions update the Southbound MAC_Binding table. > These actions translates to controller actions. Whenever pinctrl thread >

Re: [ovs-dev] [PATCH ovn v2] OVN: Fix learning of neighbors from ARP/ND packets.

2019-09-16 Thread Dumitru Ceara
On Wed, Sep 11, 2019 at 10:15 PM Numan Siddique wrote: > > > > On Thu, Aug 15, 2019 at 12:24 PM Han Zhou wrote: >> >> On Wed, Aug 14, 2019 at 11:11 PM Dumitru Ceara wrote: >> > >> > On Thu, Aug 8, 2019 at 1:52 AM Han Zhou wrote: >> > > >> > > >> > > >> > > On Wed, Aug 7, 2019 at 8:12 AM

Re: [ovs-dev] [PATCH v3] netdev-offload-dpdk : add ipv6 rte flow item support

2019-09-16 Thread 0-day Robot
Bleep bloop. Greetings Timo_Liu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: patch failed: lib/netdev-offload-dpdk.c:503 error: lib/netdev-offload-dpdk.c: patch does not

[ovs-dev] [PATCH v3] netdev-offload-dpdk : add ipv6 rte flow item support

2019-09-16 Thread Timo_Liu
v2->v3: reformat patch from git record Signed-off-by: Liu Chang diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index 01e9004..ab3f82b 100644 --- a/lib/netdev-offload-dpdk.c +++ b/lib/netdev-offload-dpdk.c @@ -433,7 +433,10 @@ netdev_offload_dpdk_add_flow(struct

Re: [ovs-dev] [PATCH 1/1] stream_ssl: fix important memory leak in ssl_connect() function

2019-09-16 Thread Damijan Skvarc
Hi William and thanks for your review. I agree with your proposed changes. Is there still some action expected from me? thanks, Damijan On Thu, Sep 12, 2019 at 8:00 PM William Tu wrote: > On Fri, Jul 26, 2019 at 10:11:03AM +0200, Damijan Skvarc wrote: > > > > While checking valgrind reports