Re: [ovs-dev] [PATCH v1 ovn] ovn-ctl: Support passing ssl certs for northd

2019-09-17 Thread Han Zhou
On Mon, Sep 16, 2019 at 3:12 PM wrote: > > From: Aliasgar Ginwala > > When using ssl mode for ovn nb/sb active-standby/cluster db service models, > northd can use ssl mode too. > e.g. one can pass --ovn-northd-ssl-key, --ovn-northd-ssl-ca-cert and > --ovn-northd-ssl-cert to start northd with

Re: [ovs-dev] [PATCH] checkpatch: Ignore utitilies/bugtool.

2019-09-17 Thread Ben Pfaff
On Mon, Sep 16, 2019 at 09:35:48AM -0700, Gregory Rose wrote: > On 9/12/2019 11:11 AM, William Tu wrote: > > Signed-off-by: William Tu > > --- > > utilities/checkpatch.py | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py > >

Re: [ovs-dev] [PATCH] tests: Fix ovs-vsctl unit test failure regression.

2019-09-17 Thread Ben Pfaff
On Tue, Sep 17, 2019 at 04:34:37PM -0700, Justin Pettit wrote: > > > On Sep 17, 2019, at 2:30 PM, Ben Pfaff wrote: > > > > This worked fine as long as there was only one table whose name started > > with "C", but now we have three of them. > > > > CC: Justin Pettit > > Fixes: 61a5264d60d0

Re: [ovs-dev] [PATCH] tests: Fix ovs-vsctl unit test failure regression.

2019-09-17 Thread Justin Pettit
> On Sep 17, 2019, at 2:30 PM, Ben Pfaff wrote: > > This worked fine as long as there was only one table whose name started > with "C", but now we have three of them. > > CC: Justin Pettit > Fixes: 61a5264d60d0 ("ovs-vswitchd: Add Datapath, CT_Zone, and CT_Zone_Policy > tables.") >

[ovs-dev] [PATCH] tests: Fix ovs-vsctl unit test failure regression.

2019-09-17 Thread Ben Pfaff
This worked fine as long as there was only one table whose name started with "C", but now we have three of them. CC: Justin Pettit Fixes: 61a5264d60d0 ("ovs-vswitchd: Add Datapath, CT_Zone, and CT_Zone_Policy tables.") Signed-off-by: Ben Pfaff --- tests/ovs-vsctl.at | 4 ++-- 1 file changed,

Re: [ovs-dev] [PATCH ovn v2] Learn the mac binding only if required

2019-09-17 Thread Han Zhou
On Mon, Sep 16, 2019 at 10:17 AM wrote: > > From: Numan Siddique > > OVN has the actions - put_arp and put_nd to learn the mac bindings from the > ARP/ND packets. These actions update the Southbound MAC_Binding table. > These actions translates to controller actions. Whenever pinctrl thread >

[ovs-dev] [PATCH] fatal-signal: Catch SIGSEGV and print backtrace.

2019-09-17 Thread William Tu
The patch catches the SIGSEGV signal and prints the backtrace using libunwind, hopefully makes it easier to debug. Signed-off-by: William Tu --- .travis.yml| 1 + configure.ac | 1 + lib/fatal-signal.c | 40 +++- m4/openvswitch.m4 | 10

[ovs-dev] [PATCHv4] netdev-afxdp: Add need_wakeup supprt.

2019-09-17 Thread William Tu
The patch adds support for using need_wakeup flag in AF_XDP rings. A new option, use_need_wakeup, is added. When this option is used, it means that OVS has to explicitly wake up the kernel RX, using poll() syscall and wake up TX, using sendto() syscall. This feature improves the performance by

Re: [ovs-dev] [ovs-discuss] ovs-vswitchd exited silently

2019-09-17 Thread Flavio Leitner
On Thu, Sep 05, 2019 at 09:18:22AM +, Frank Wang(王培辉) wrote: > Hi All Hi Franck, Perhaps check the permissions of /var/run/openvswitch ? If they are correct, you can start ovsdb-server service first and then start the ovs-vswitchd manually as the service does. fbl > > > > I’m

Re: [ovs-dev] [PATCHv3] netdev-afxdp: Add need_wakeup supprt.

2019-09-17 Thread William Tu
On Tue, Sep 17, 2019 at 01:41:17PM +0200, Eelco Chaudron wrote: > Two comments below… > > > On 11 Sep 2019, at 19:58, William Tu wrote: > > >The patch adds support for using need_wakeup flag in AF_XDP rings. > >A new option, use_need_wakeup, is added. When this option is

Re: [ovs-dev] [PATCH 10/10] conntrack: Validate accessing of conntrack data in pkt_metadata

2019-09-17 Thread William Tu
On Wed, Sep 11, 2019 at 02:18:36PM -0700, Yifeng Sun wrote: > Valgrind reported: > > 1305: ofproto-dpif - conntrack - ipv6 > > ==26942== Conditional jump or move depends on uninitialised value(s) > ==26942==at 0x587C00: check_orig_tuple (conntrack.c:1006) > ==26942==by 0x587C00:

Re: [ovs-dev] [PATCH 09/10] db-ctl-base: Free leaked ovsdb_datum

2019-09-17 Thread William Tu
On Wed, Sep 11, 2019 at 02:18:35PM -0700, Yifeng Sun wrote: > Valgrind reported: > > 2491: database commands -- negative checks > > ==19245== 36 (32 direct, 4 indirect) bytes in 1 blocks are definitely lost in > loss record 36 of 53 > ==19245==at 0x4C2FD5F: realloc (in >

Re: [ovs-dev] [PATCH 08/10] ofproto-dpif: Free leaked 'webster'

2019-09-17 Thread William Tu
On Wed, Sep 11, 2019 at 02:18:34PM -0700, Yifeng Sun wrote: > Valgrind reported: > > 1122: ofproto-dpif - select group with explicit dp_hash selection method > > ==16884== 64 bytes in 1 blocks are definitely lost in loss record 320 of 346 > ==16884==at 0x4C2FB55: calloc (in >

Re: [ovs-dev] [PATCH 07/10] dns-resolve: Free 'struct ub_result' when callback returns error results

2019-09-17 Thread William Tu
On Wed, Sep 11, 2019 at 02:18:33PM -0700, Yifeng Sun wrote: > Valgrind reported: > > 1074: ofproto - flush flows, groups, and meters for controller change > > ==5499== 695 (288 direct, 407 indirect) bytes in 3 blocks are definitely lost > in loss record 344 of 355 > ==5499==at 0x4C2FB55:

Re: [ovs-dev] [PATCH 06/10] ovsdb-client: Free ovsdb_schema

2019-09-17 Thread William Tu
On Wed, Sep 11, 2019 at 02:18:32PM -0700, Yifeng Sun wrote: > Valgrind reported: > > 1925: schema conversion online - standalone > > ==10727== 689 (56 direct, 633 indirect) bytes in 1 blocks are definitely lost > in loss record 64 of 66 > ==10727==at 0x4C2FB55: calloc (in >

Re: [ovs-dev] [PATCH 05/10] trigger: Free leaked ovsdb_schema

2019-09-17 Thread William Tu
On Wed, Sep 11, 2019 at 02:18:31PM -0700, Yifeng Sun wrote: > Valgrind reported: > > 1925: schema conversion online - standalone > > ==10884== 689 (56 direct, 633 indirect) bytes in 1 blocks are definitely lost > in loss record 384 of 420 > ==10884==at 0x4C2FB55: calloc (in >

Re: [ovs-dev] [PATCH 04/10] ovs-ofctl: Free leaked minimatch

2019-09-17 Thread William Tu
On Wed, Sep 11, 2019 at 02:18:30PM -0700, Yifeng Sun wrote: > Valgrind reported: > > 1056: ofproto - bundle with multiple flow mods (OpenFlow 1.4) > > ==19220== 160 bytes in 2 blocks are definitely lost in loss record 24 of 34 > ==19220==at 0x4C2DB8F: malloc (in >

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

2019-09-17 Thread Han Zhou
On Tue, Sep 17, 2019 at 5:21 AM Mark Michelson wrote: > > On 9/16/19 12:04 PM, Han Zhou wrote: > > > > > > On Mon, Sep 16, 2019 at 4:15 AM Dumitru Ceara > > wrote: > > > > > > On Sat, Sep 14, 2019 at 7:16 PM Han Zhou > > wrote: > > > > > >

Re: [ovs-dev] [PATCH 03/10] dpif-netdev: Handle uninitialized value error for 'match.wc'

2019-09-17 Thread William Tu
On Wed, Sep 11, 2019 at 02:18:29PM -0700, Yifeng Sun wrote: > Valgrind reported that match.wc was not initialized, as below: > > 1176: ofproto-dpif - fragment handling - actions > > ==21214== Conditional jump or move depends on uninitialised value(s) > ==21214==at 0x4B77C1:

Re: [ovs-dev] [PATCH 02/10] ofproto-dpif: Uninitialize 'xlate_cache' to free resources

2019-09-17 Thread William Tu
On Wed, Sep 11, 2019 at 02:18:28PM -0700, Yifeng Sun wrote: > Valgrind reported: > > 1210: ofproto-dpif - continuation after clone > > ==32205== 4,392 (1,440 direct, 2,952 indirect) bytes in 12 blocks are > definitely lost in loss record 359 of 362 > ==32205==at 0x4C2DB8F: malloc (in >

Re: [ovs-dev] [PATCH 01/10] raft: Free leaked json data

2019-09-17 Thread William Tu
On Wed, Sep 11, 2019 at 02:18:27PM -0700, Yifeng Sun wrote: > Valgrind reported: > > 1924: compacting online - cluster > > ==29312== 2,886 (240 direct, 2,646 indirect) bytes in 6 blocks are definitely > lost in loss record 406 of 413 > ==29312==at 0x4C2DB8F: malloc (in >

Re: [ovs-dev] [PATCH v6 0/1] Balance-tcp bond mode optimization

2019-09-17 Thread Vishal Deep Ajmera via dev
> > > Let me check this in my setup. I always used 'netdev' bridges for testing my > patch. > May be I need to be check for data path support in the display function as > well. Hi, I have sent v7 version of patch fixing this issue. Warm Regards, Vishal Ajmera

Re: [ovs-dev] [PATCH ovn] Exclude inport and outport symbol tables from conjunction

2019-09-17 Thread Mark Michelson
On 9/16/19 12:04 PM, Han Zhou wrote: On Mon, Sep 16, 2019 at 4:15 AM Dumitru Ceara > wrote: > > On Sat, Sep 14, 2019 at 7:16 PM Han Zhou > wrote: > > > > > > > > On Sat, Sep 14, 2019 at 9:09 AM Han Zhou >

Re: [ovs-dev] [PATCHv3] netdev-afxdp: Add need_wakeup supprt.

2019-09-17 Thread Eelco Chaudron
Two comments below… On 11 Sep 2019, at 19:58, William Tu wrote: The patch adds support for using need_wakeup flag in AF_XDP rings. A new option, use_need_wakeup, is added. When this option is used, it means that OVS has to explicitly wake up the kernel RX, using

Re: [ovs-dev] [PATCH v7 1/1] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-09-17 Thread 0-day Robot
Bleep bloop. Greetings Vishal Deep Ajmera via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #218 FILE:

[ovs-dev] [PATCH v7 1/1] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-09-17 Thread Vishal Deep Ajmera via dev
Problem: In OVS-DPDK, flows with output over a bond interface of type “balance-tcp” (using a hash on TCP/UDP 5-tuple) get translated by the ofproto layer into "HASH" and "RECIRC" datapath actions. After recirculation, the packet is forwarded to the bond member port based on 8-bits of the

[ovs-dev] [PATCH v7 0/1] Balance-tcp bond mode optimization

2019-09-17 Thread Vishal Deep Ajmera via dev
v6->v7: Fixed issue reported by Matteo for bond/show. v5->v6: Addressed comments from Ilya Maximets. https://mail.openvswitch.org/pipermail/ovs-dev/2019-August/362001.html Rebased to OVS master. v4->v5: Support for stats per hash bucket. Support for dynamic load balancing. Rebased to OVS

[ovs-dev] INFO: task hung in ovs_dp_cmd_new

2019-09-17 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:2339cd6c bpf: fix precision tracking of stack slots git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=14707b0160 kernel config: https://syzkaller.appspot.com/x/.config?x=b89bb446a3faaba4 dashboard link: