On Mon, Sep 23, 2019 at 02:51:35PM -0700, Gregory Rose wrote:
>
> On 9/23/2019 12:38 PM, Ben Pfaff wrote:
> > We don't own ovs.org, and I doubt Ojai Valley School would enjoy
> > receiving our email.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > Documentation/internals/mailing-lists.rst | 2 +-
Valgrind reported that 'pkt->md.ct_orig_tuple.ipv4.ipv4_proto' is
uninitialized in 'check_orig_tuple()', if 'ct_state' is zero. Although
this is true, the check is superceded, as even if it succeeds the check
for natted packets based on 'ct_state' is an ORed condition and is intended
to catch
Sorry about that. Applied, thanks!
On Mon, Sep 16, 2019 at 12:24:24PM +0200, Dumitru Ceara wrote:
> Hi,
>
> Just a reminder, Mark has acked this change a while ago but it didn't
> get pushed yet.
>
> Thanks,
> Dumitru
>
> On Fri, Aug 9, 2019 at 5:08 PM Mark Michelson wrote:
> >
> > Acked-by:
Sorry about the delay. I applied this to master.
On Thu, Sep 19, 2019 at 05:32:09PM -0700, aginwala wrote:
> Hi Ben:
>
> Just a gentle reminder. Can you please help merge this patch if no
> additional comments? Got acked-by Han on the same already.
>
> On Fri, Aug 30, 2019 at 8:30 AM wrote:
>
On Mon, Sep 16, 2019 at 11:16:57AM -0400, Aaron Conole wrote:
> It's possible that a port added to the system with certain kinds
> of invalid parameters will cause the 'could not add' log to be
> triggered. When this happens, the vswitch run loop can continually
> re-attempt adding the port.
On Thu, Sep 19, 2019 at 02:25:31PM -0700, Greg Rose wrote:
> Upstream commit 648700f76b03 ("inet: frags: use rhashtables...") changed
> how ipv6 fragmentation is implemented. This patch was backported to
> the upstream stable 4.9.x kernel starting at 4.9.135.
>
> This patch creates the
On Thu, Sep 19, 2019 at 02:25:55PM -0700, Greg Rose wrote:
> Upstream commit 648700f76b03 ("inet: frags: use rhashtables...") changed
> how ipv6 fragmentation is implemented. This patch was backported to
> the upstream stable 4.9.x kernel starting at 4.9.135.
>
> This patch creates the
On Thu, Sep 19, 2019 at 02:26:10PM -0700, Greg Rose wrote:
> Upstream commit 648700f76b03 ("inet: frags: use rhashtables...") changed
> how ipv6 fragmentation is implemented. This patch was backported to
> the upstream stable 4.9.x kernel starting at 4.9.135.
>
> This patch creates the
On Mon, Sep 23, 2019 at 02:26:42PM -0700, Ben Pfaff wrote:
> On Fri, Sep 20, 2019 at 09:51:54AM -0700, William Tu wrote:
> > From: Damijan Skvarc
> >
> > While checking valgrind reports after running "make check-valgrind" I have
> > noticed
> > reports for several tests similar to the
On 9/23/2019 12:38 PM, Ben Pfaff wrote:
We don't own ovs.org, and I doubt Ojai Valley School would enjoy
receiving our email.
Signed-off-by: Ben Pfaff
---
Documentation/internals/mailing-lists.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Fri, Sep 20, 2019 at 09:51:54AM -0700, William Tu wrote:
> From: Damijan Skvarc
>
> While checking valgrind reports after running "make check-valgrind" I have
> noticed
> reports for several tests similar to the following:
Thanks. I applied this to master and am working on backports.
On Fri, Sep 20, 2019 at 05:12:47PM -0700, amgin...@gmail.com wrote:
> From: Aliasgar Ginwala
>
> When using ssl mode for ovn nb/sb active-standby/cluster db service models,
> northd can use ssl mode too.
> e.g. one can pass --ovn-northd-ssl-key, --ovn-northd-ssl-ca-cert and
>
Done.
On Mon, Sep 23, 2019 at 02:26:11PM -0700, Yifeng Sun wrote:
> Hi Ben,
>
> Could you please backport this patch to 2.12? Thanks.
> Yifeng
>
> On Thu, Aug 29, 2019 at 8:39 AM Yifeng Sun wrote:
> >
> > Thanks Yi-Hung for the explanation.
> >
> > On Wed, Aug 28, 2019 at 4:49 PM Yi-Hung Wei
Hi Ben,
Could you please backport this patch to 2.12? Thanks.
Yifeng
On Thu, Aug 29, 2019 at 8:39 AM Yifeng Sun wrote:
>
> Thanks Yi-Hung for the explanation.
>
> On Wed, Aug 28, 2019 at 4:49 PM Yi-Hung Wei wrote:
> >
> > On Wed, Aug 28, 2019 at 4:07 PM Ben Pfaff wrote:
> > >
> > > On Wed,
On Mon, Sep 23, 2019 at 04:59:11PM +0100, Kevin Traynor wrote:
> Indicate that OVS 2.12 uses DPDK 18.11.2.
>
> Signed-off-by: Kevin Traynor
> ---
>
> Can also be backported to branch-2.12.
Thanks!
Done.
___
dev mailing list
d...@openvswitch.org
On Mon, Sep 23, 2019 at 12:00:33PM +0530, Vishal Deep Ajmera wrote:
> From: Darrell Ball
>
> The ICMPv4 error data L4 length check was found to be too strict for TCP,
> expecting a minimum of 20 rather than 8 bytes. This worked by
> hapenstance for other inner protocols. The approach is to
On Mon, Sep 23, 2019 at 12:14:40PM +0530, Vishal Deep Ajmera wrote:
> From: Darrell Ball
>
> The ICMPv4 error data L4 length check was found to be too strict for TCP,
> expecting a minimum of 20 rather than 8 bytes. This worked by
> hapenstance for other inner protocols. The approach is to
On Mon, Sep 23, 2019 at 06:58:51AM +, Vishal Deep Ajmera wrote:
>
> >
> > Thanks
> > This is eligible to go back to 2.6; it should apply cleanly back to 2.9; I
> > can look into the remaining ones,
> > unless Vishal would like to do those.
>
> Thanks Darrell. I have sent patches for branch
On Tue, Sep 24, 2019 at 01:27:57AM +0530, Numan Siddique wrote:
> Hi,
>
> Now that OVN is compiled with OVS sources from external sources, I think we
> can go ahead and delete the ovs subtree [1],
>
> We can delete this in 2 ways
> (1) Just delete the ovs subfolder using "git rm -rf ovs"
> (2)
Sorry.
Acked-by: Russell Bryant
> On Sep 23, 2019, at 4:20 PM, nusid...@redhat.com wrote:
>
> From: Numan Siddique
>
> Below compilation errors are seen:
>
> - make[1]: *** No rule to make target 'Documentation/internals/charter.rst',
> needed by 'all-am'. Stop.
>
> - Warning, treated as
On Mon, Sep 23, 2019 at 12:46:17PM -0700, Han Zhou wrote:
> On Mon, Sep 23, 2019 at 12:08 PM Ben Pfaff wrote:
>
> > Han was elected by the OVN committers on Sept. 23. Welcome to the
> > team, Han!
> >
> > CC: Han Zhou
> > Signed-off-by: Ben Pfaff
> > ---
> > MAINTAINERS.rst | 2 ++
> > 1
On Tue, Sep 24, 2019 at 01:50:06AM +0530, nusid...@redhat.com wrote:
> From: Numan Siddique
>
> Below compilation errors are seen:
>
> - make[1]: *** No rule to make target 'Documentation/internals/charter.rst',
> needed by 'all-am'. Stop.
>
> - Warning, treated as error:
>
From: Numan Siddique
Below compilation errors are seen:
- make[1]: *** No rule to make target 'Documentation/internals/charter.rst',
needed by 'all-am'. Stop.
- Warning, treated as error:
../MAINTAINERS.rst:63:Insufficient data supplied (1 row(s)); no data remaining
for table body, required
Hi,
Now that OVN is compiled with OVS sources from external sources, I think we
can go ahead and delete the ovs subtree [1],
We can delete this in 2 ways
(1) Just delete the ovs subfolder using "git rm -rf ovs"
(2) Using git filter-branch
(2) deletes the history of ovs subfolder and rewrites
On Mon, Sep 23, 2019 at 12:08 PM Ben Pfaff wrote:
> Han was elected by the OVN committers on Sept. 23. Welcome to the
> team, Han!
>
> CC: Han Zhou
> Signed-off-by: Ben Pfaff
> ---
> MAINTAINERS.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst
We don't own ovs.org, and I doubt Ojai Valley School would enjoy
receiving our email.
Signed-off-by: Ben Pfaff
---
Documentation/internals/mailing-lists.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/internals/mailing-lists.rst
Han was elected by the OVN committers on Sept. 23. Welcome to the
team, Han!
CC: Han Zhou
Signed-off-by: Ben Pfaff
---
MAINTAINERS.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst
index f2c3e3ecd9c2..56e61c3b250e 100644
--- a/MAINTAINERS.rst
+++
On Mon, Sep 23, 2019 at 11:18:01AM -0700, Justin Pettit wrote:
>
> > On Sep 23, 2019, at 10:18 AM, Ben Pfaff wrote:
> >
> > Leonid was elected by the OVN committers on Sept. 23. Welcome to the
> > team, Leonid!
> >
> > CC: Leonid Ryzhyk
> > Signed-off-by: Ben Pfaff
>
> Acked-by: Justin
> On Sep 23, 2019, at 10:18 AM, Ben Pfaff wrote:
>
> Leonid was elected by the OVN committers on Sept. 23. Welcome to the
> team, Leonid!
>
> CC: Leonid Ryzhyk
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
fatal: sha1 information is lacking or useless (MAINTAINERS.rst).
Repository lacks necessary blobs to
Leonid was elected by the OVN committers on Sept. 23. Welcome to the
team, Leonid!
CC: Leonid Ryzhyk
Signed-off-by: Ben Pfaff
---
MAINTAINERS.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst
index 3b46daad1512..f2c3e3ecd9c2 100644
---
> Unfortunately, this wasn't possible without exporting some new C functions.
The approach we've taken so far was to export whatever C functions are needed
from either OVS or OVN. Numan has isolated the relevant patches here:
https://github.com/numansiddique/ovs/commits/ovs_ddlog_patches
>
Indicate that OVS 2.12 uses DPDK 18.11.2.
Signed-off-by: Kevin Traynor
---
Can also be backported to branch-2.12.
---
Documentation/faq/releases.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
index 8c29e32ef..e18f5db75
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Bleep bloop. Greetings Flavio Leitner, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
fatal: sha1 information is lacking or useless
(drivers/net/vhost/rte_eth_vhost.c).
Repository
Hallo!
Ich bin ein Vertreter der Chaos-Hacking-Gruppe.
Im Zeitraum vom 24/06/2019 bis 23/09/2019 haben wir durch Hacken eines der
OPENVSWITCH.ORG-Mailserver Zugriff auf Ihr Konto d...@openvswitch.org
erhalten.
Haben Sie Ihr Passwort schon geändert?
Gut! Aber unser Programm fängt es jedes Mal ab.
Add set_queue() action for qos capable localnet port in
S_SWITCH_OUT_PORT_SEC_L2 stage of logical swith pipeline
Introduce build_lswitch_port_sec and refactor lswitch_port_security code
in order to remove duplicated code
Signed-off-by: Lorenzo Bianconi
---
northd/ovn-northd.8.xml | 7 +-
Refactor allocate_chassis_queueid and free_chassis_queueid in order
to get an unused queue_id even for localnet ports and add the
the possibility to define localnet as qos capable port
Signed-off-by: Lorenzo Bianconi
---
northd/ovn-northd.c | 45 ++---
1
Introduce add_localnet_egress_interface_mappings routine in order to collect as
egress interfaces all ovs bridge interfaces marked with ovn-egress-iface
in the external_ids column of ovs interface table.
ovn-egress-iface is used to indicate to which localnet ports QoS egress
shaping has to be
OVN applies logical switch QoS settings to egress interfaces. It
currently works by analyzing each br-int interface to see what the remote-ip
is on it, and then adding qdiscs to the tunnel-egress-iface associated
with this br-int interface.
This doesn't work as well when working with VLAN
Bleep bloop. Greetings Flavio Leitner, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#23 FILE: lib/netdev-dpdk.c:2267:
if
Bleep bloop. Greetings Flavio Leitner, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#55 FILE:
Signed-off-by: Flavio Leitner
---
drivers/net/vhost/rte_eth_vhost.c | 4 +--
examples/tep_termination/main.c | 2 +-
examples/vhost/main.c | 2 +-
lib/librte_vhost/rte_vhost.h | 5 +++-
lib/librte_vhost/virtio_net.c | 47 +--
5 files
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index cfbd9a9e5..7965bf57a 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -2294,6 +2294,24 @@
Signed-off-by: Flavio Leitner
---
lib/dp-packet.h | 16
lib/netdev-dpdk.c | 93 ---
2 files changed, 103 insertions(+), 6 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 14f0897fa..2b12604b9 100644
--- a/lib/dp-packet.h
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 44
1 file changed, 44 insertions(+)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 48057835f..7eb294366 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -323,8 +323,11 @@
Hi Michal,
First of all thank you for continuing with the TSO work.
I spent a bit of time reviewing the patchset and my impression is
that the multi-segment support is quite expensive. Even when TSO
is off, we still have a non trivial CPU cost which we can't optimize
further. Also an
I'm adding the ovs-dev list since this discussion may be useful to the
general development community.
See my responses inline.
On 9/20/19 8:04 PM, Leonid Ryzhyk wrote:
Hi Mark,
Firstly, many thanks for giving DDlog a try! I am extremely impressed
that you managed to get this far without
Bleep bloop. Greetings Vishal Deep Ajmera via dev, I am a robot and I have
tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
Bleep bloop. Greetings Vishal Deep Ajmera via dev, I am a robot and I have
tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
>
> Thanks
> This is eligible to go back to 2.6; it should apply cleanly back to 2.9; I
> can look into the remaining ones,
> unless Vishal would like to do those.
Thanks Darrell. I have sent patches for branch 2.8 and 2.9.
For branches before 2.7 & 2.6 it is giving quite a few conflicts.
Can
From: Darrell Ball
The ICMPv4 error data L4 length check was found to be too strict for TCP,
expecting a minimum of 20 rather than 8 bytes. This worked by
hapenstance for other inner protocols. The approach is to explicitly
handle the ICMPv4 error data L4 length check and to do this for all
From: Darrell Ball
The ICMPv4 error data L4 length check was found to be too strict for TCP,
expecting a minimum of 20 rather than 8 bytes. This worked by
hapenstance for other inner protocols. The approach is to explicitly
handle the ICMPv4 error data L4 length check and to do this for all
53 matches
Mail list logo
