Re: [ovs-dev] [patch v2] conntrack: Fix ICMPv4 error data L4 length check.

2019-09-27 Thread Vishal Deep Ajmera via dev
> > Thanks Darrell. I have sent patches for branch 2.8 and 2.9. > For branches before 2.7 & 2.6 it is giving quite a few conflicts. > Can you please have a look at it? > Hi Darrell, Ben I have tried manual merge on OVS 2.6 branch and sent a patch. Can you please review and apply it on branch?

[ovs-dev] [PATCH branch-2.6] conntrack: Fix ICMPv4 error data L4 length check.

2019-09-27 Thread Vishal Deep Ajmera via dev
From: Darrell Ball The ICMPv4 error data L4 length check was found to be too strict for TCP, expecting a minimum of 20 rather than 8 bytes. This worked by hapenstance for other inner protocols. The approach is to explicitly handle the ICMPv4 error data L4 length check and to do this for all

[ovs-dev] [RFC PATCH ovn 09/10] ovn-ic: Interconnection gateway controller.

2019-09-27 Thread Han Zhou
From: Han Zhou Sync local and remote gateways between SB and ISB. Signed-off-by: Han Zhou --- ic/ovn-ic.c | 94 + 1 file changed, 94 insertions(+) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index 4de3e17..ddc9d0a 100644 ---

[ovs-dev] [RFC PATCH ovn 10/10] ovn-ic: Interconnection port controller.

2019-09-27 Thread Han Zhou
From: Han Zhou Sync interconnection logical ports and bindings between NB, SB and ISB. With this patch, the OVN interconnection works end to end. Signed-off-by: Han Zhou --- controller/binding.c | 6 +- ic/ovn-ic.c| 342 +

[ovs-dev] [RFC PATCH ovn 08/10] ovn-sb: Add columns is_interconn and is_remote to Chassis.

2019-09-27 Thread Han Zhou
From: Han Zhou Support the new columns in Chassis table for OVN interconnection. Also, populate the is_interconn column according to external_ids: is-interconn key of Open_vSwitch table on the chassis. Signed-off-by: Han Zhou --- controller/chassis.c | 14 ++ northd/ovn-northd.c

[ovs-dev] [RFC PATCH ovn 07/10] ovn-ic: Transit switch controller.

2019-09-27 Thread Han Zhou
From: Han Zhou Processing transit switches and sync between INB, ISB and NB. Signed-off-by: Han Zhou --- ic/ovn-ic.c | 113 northd/ovn-northd.c | 8 2 files changed, 121 insertions(+) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c

[ovs-dev] [RFC PATCH ovn 04/10] ovn-isb: Interconnection southbound DB schema and CLI.

2019-09-27 Thread Han Zhou
From: Han Zhou This patch introduces OVN_IC_Southbound DB schema and the CLI ovn-isbctl that manages the DB. Signed-off-by: Han Zhou --- .gitignore | 3 + automake.mk| 38 ++ debian/ovn-common.install | 1 + debian/ovn-common.manpages | 2 +

[ovs-dev] [RFC PATCH ovn 05/10] ovn-ic: Interconnection controller with AZ registeration.

2019-09-27 Thread Han Zhou
From: Han Zhou This patch introduces interconnection controller, ovn-ic, and implements the basic AZ registration feature: taking the AZ name from NB DB and create an Availability_Zone entry in IC-SB DB. Signed-off-by: Han Zhou --- Makefile.am | 1 + ic/.gitignore| 2 +

[ovs-dev] [RFC PATCH ovn 06/10] ovn-northd.c: Refactor allocate_tnlid.

2019-09-27 Thread Han Zhou
From: Han Zhou Move allocate_tnlid() and related interfaces to ovn_util module, so that they be reused by ovn-ic (in next patches). At the same time, define macros for the range of datapath tunnel keys, and reserve a range with ((1u << 16) - 1) keys for global transit switch datapaths, among the

[ovs-dev] [RFC PATCH ovn 03/10] ovn-inb: Interconnection northbound DB schema and CLI.

2019-09-27 Thread Han Zhou
From: Han Zhou This patch introduces OVN_IC_Northbound DB schema and the CLI ovn-inbctl that manages the DB. Signed-off-by: Han Zhou --- .gitignore | 3 + automake.mk| 37 ++ debian/ovn-common.install | 1 + debian/ovn-common.manpages | 2 +

[ovs-dev] [RFC PATCH ovn 02/10] ovn-architecture: Add documentation for OVN interconnection feature.

2019-09-27 Thread Han Zhou
From: Han Zhou Signed-off-by: Han Zhou --- ovn-architecture.7.xml | 107 - 1 file changed, 106 insertions(+), 1 deletion(-) diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index 7966b65..56b2167 100644 --- a/ovn-architecture.7.xml

[ovs-dev] [RFC PATCH ovn 01/10] ovn-northd.c: Fix datapath tunnel key allocation.

2019-09-27 Thread Han Zhou
From: Han Zhou The max tunnel key for datapath is defined as (1u << 24) - 1, but we are using uint16_t variable to hold the value, which will result in duplicated key when there are enough number of datapath key allocation and deletions. Signed-off-by: Han Zhou --- northd/ovn-northd.c | 2 +-

[ovs-dev] [RFC PATCH ovn 00/10] OVN Interconnection

2019-09-27 Thread Han Zhou
The series supports interconnecting multiple OVN deployments (e.g. located at multiple data centers) through logical routers connected with tansit logical switches with overlay tunnels, managed through OVN control plane. See the ovn-architecture document updates for more details. The series is

[ovs-dev] [PATCH] datapath: Fix conntrack cache with timeout

2019-09-27 Thread Yi-Hung Wei
This patch is from the following upstream net-next commit along with an updated system traffic test to avoid regression. Upstream commit: commit 7177895154e6a35179d332f4a584d396c50d0612 Author: Yi-Hung Wei Date: Thu Aug 22 13:17:50 2019 -0700 openvswitch: Fix conntrack

Re: [ovs-dev] [PATCH 1/2] ovsdb-cluster: Use ovs-vsctl instead of ovn-nbctl and ovn-sbctl.

2019-09-27 Thread Han Zhou
On Fri, Sep 27, 2019 at 12:50 PM Ben Pfaff wrote: > > This removes a dependency on OVN from the tests. > > This adds some options to ovs-vsctl to allow it to be used for testing > the clustering feature. The new options are undocumented because > they're really just useful for testing

Re: [ovs-dev] [PATCH v2 ovn 0/3] Introduce localnet egress QoS support

2019-09-27 Thread Mark Michelson
Acked-by: Mark Michelson On 9/24/19 12:39 PM, Lorenzo Bianconi wrote: OVN applies logical switch QoS settings to egress interfaces. It currently works by analyzing each br-int interface to see what the remote-ip is on it, and then adding qdiscs to the tunnel-egress-iface associated with this

Re: [ovs-dev] [PATCHv4] fatal-signal: Catch SIGSEGV and print backtrace.

2019-09-27 Thread Ben Pfaff
On Fri, Sep 27, 2019 at 10:22:55AM -0700, William Tu wrote: > The patch catches the SIGSEGV signal and prints the backtrace > using libunwind at the monitor daemon. This makes debugging easier > when there is no debug symbol package or gdb installed on production > systems. Thanks. Let's try it.

Re: [ovs-dev] [PATCH 3/3] debug: print mbuf extra info.

2019-09-27 Thread Aaron Conole
Flavio Leitner writes: > On Thu, Sep 26, 2019 at 07:49:28AM -0700, Ben Pfaff wrote: >> On Thu, Sep 26, 2019 at 11:59:14AM -0400, Aaron Conole wrote: >> > Flavio Leitner writes: >> > >> > > Signed-off-by: Flavio Leitner >> > > --- >> > > lib/netdev-dpdk.c | 18 ++ >> > > 1

Re: [ovs-dev] [PATCHv2] netdev-afxdp: Detect numa node id.

2019-09-27 Thread 0-day Robot
Bleep bloop. Greetings William Tu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #35 FILE: lib/netdev-afxdp.c:561:

Re: [ovs-dev] [PATCH v4] Require Python 3 and remove support for Python 2.

2019-09-27 Thread Numan Siddique
On Sat, Sep 28, 2019, 1:03 AM Ben Pfaff wrote: > On Fri, Sep 27, 2019 at 12:33:05PM +0530, Numan Siddique wrote: > > On Thu, Sep 26, 2019 at 11:12 PM Ben Pfaff wrote: > > > > > Python 2 reaches end-of-life on January 1, 2020, which is only > > > a few months away. This means that OVS needs to

[ovs-dev] [PATCH 1/2] ovsdb-cluster: Use ovs-vsctl instead of ovn-nbctl and ovn-sbctl.

2019-09-27 Thread Ben Pfaff
This removes a dependency on OVN from the tests. This adds some options to ovs-vsctl to allow it to be used for testing the clustering feature. The new options are undocumented because they're really just useful for testing clustering. Signed-off-by: Ben Pfaff --- tests/ovsdb-cluster.at | 37

Re: [ovs-dev] [PATCH v2] odp-util: calc checksum of ip hdr for tunnel encap

2019-09-27 Thread Ben Pfaff
Hi Martin, please fix the problems reported by the robot. Thanks, Ben. On Thu, Sep 26, 2019 at 09:58:22PM -0400, 0-day Robot wrote: > Bleep bloop. Greetings Martin Zhang, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I

Re: [ovs-dev] [PATCH v4] Require Python 3 and remove support for Python 2.

2019-09-27 Thread Ben Pfaff
On Fri, Sep 27, 2019 at 12:33:05PM +0530, Numan Siddique wrote: > On Thu, Sep 26, 2019 at 11:12 PM Ben Pfaff wrote: > > > Python 2 reaches end-of-life on January 1, 2020, which is only > > a few months away. This means that OVS needs to stop depending > > on in the next release that should

[ovs-dev] [PATCHv2] netdev-afxdp: Detect numa node id.

2019-09-27 Thread William Tu
The patch detects the numa node id from the name of the netdev, by reading the '/sys/class/net//device/numa_node'. If not available, ex: virtual device, or any error happens, return numa id 0. Signed-off-by: William Tu --- v2: Address feedback from Eelco fix memory leak of xaspintf log

[ovs-dev] [PATCHv4] fatal-signal: Catch SIGSEGV and print backtrace.

2019-09-27 Thread William Tu
The patch catches the SIGSEGV signal and prints the backtrace using libunwind at the monitor daemon. This makes debugging easier when there is no debug symbol package or gdb installed on production systems. The patch works when the ovs-vswitchd compiles even without debug symbol (no -g option),

Re: [ovs-dev] [PATCH ovn] Disable conjunction by force cross product for all the fields.

2019-09-27 Thread Numan Siddique
On Fri, Sep 27, 2019 at 10:15 PM Han Zhou wrote: > > > On Fri, Sep 27, 2019 at 9:42 AM Numan Siddique > wrote: > >> >> >> On Fri, Sep 27, 2019 at 10:05 PM Han Zhou wrote: >> >>> Thanks Numan. This is cleaner than the RFC. At the same time, shall we >>> revert the change of commit:

Re: [ovs-dev] [PATCH ovn] Disable conjunction by force cross product for all the fields.

2019-09-27 Thread Han Zhou
On Fri, Sep 27, 2019 at 9:42 AM Numan Siddique wrote: > > > On Fri, Sep 27, 2019 at 10:05 PM Han Zhou wrote: > >> Thanks Numan. This is cleaner than the RFC. At the same time, shall we >> revert the change of commit: 298701dbc996, which is covered by this change? >> (It is better to maintain

Re: [ovs-dev] [PATCH ovn] Disable conjunction by force cross product for all the fields.

2019-09-27 Thread Numan Siddique
On Fri, Sep 27, 2019 at 10:05 PM Han Zhou wrote: > Thanks Numan. This is cleaner than the RFC. At the same time, shall we > revert the change of commit: 298701dbc996, which is covered by this change? > (It is better to maintain one temporary workaround than two) > > Acked-by: Han Zhou >

Re: [ovs-dev] [PATCH ovn] Disable conjunction by force cross product for all the fields.

2019-09-27 Thread Han Zhou
Thanks Numan. This is cleaner than the RFC. At the same time, shall we revert the change of commit: 298701dbc996, which is covered by this change? (It is better to maintain one temporary workaround than two) Acked-by: Han Zhou On Fri, Sep 27, 2019 at 8:52 AM wrote: > From: Numan Siddique > >

Re: [ovs-dev] [RFC PATCH ovn] Disable conjunction

2019-09-27 Thread Numan Siddique
On Fri, Sep 27, 2019 at 12:04 PM Numan Siddique wrote: > > > On Fri, Sep 27, 2019 at 11:56 AM Han Zhou wrote: > >> >> Thanks Numan. It looks good to me. Is there a reason why this is RFC? >> > > Yes. I actually was thinking another way to disable conjunction. > > I will submit that patch and we

[ovs-dev] [PATCH ovn] Disable conjunction by force cross product for all the fields.

2019-09-27 Thread nusiddiq
From: Numan Siddique With this ovn-controller will not generate conjunction flows. There are issues with the conjunction flows generated by ovn-controller. Please see the commit 298701dbc996 for more information. Signed-off-by: Numan Siddique --- TODO.rst | 10 + lib/expr.c | 20 +-

Re: [ovs-dev] [PATCH 3/3] debug: print mbuf extra info.

2019-09-27 Thread Flavio Leitner
On Fri, Sep 27, 2019 at 10:05:53AM -0300, Flavio Leitner wrote: > On Thu, Sep 26, 2019 at 07:49:28AM -0700, Ben Pfaff wrote: > > On Thu, Sep 26, 2019 at 11:59:14AM -0400, Aaron Conole wrote: > > > Flavio Leitner writes: > > > > > > > Signed-off-by: Flavio Leitner > > > > --- > > > >

Re: [ovs-dev] [PATCH v16 00/14] Support multi-segment mbufs

2019-09-27 Thread Flavio Leitner
On Fri, Sep 27, 2019 at 10:37:55AM +, Obrembski, MichalX wrote: > Hi Flavio, Hi Michal! > Thank you very much for your comments, and given proof of concept! > I understood that CPU cost could be a problem, but we currently haven't found > any other solution. > > I saw your patches. In your

Re: [ovs-dev] [PATCH 3/3] debug: print mbuf extra info.

2019-09-27 Thread Flavio Leitner
On Thu, Sep 26, 2019 at 07:49:28AM -0700, Ben Pfaff wrote: > On Thu, Sep 26, 2019 at 11:59:14AM -0400, Aaron Conole wrote: > > Flavio Leitner writes: > > > > > Signed-off-by: Flavio Leitner > > > --- > > > lib/netdev-dpdk.c | 18 ++ > > > 1 file changed, 18 insertions(+) > > >

Re: [ovs-dev] [PATCHv5] netdev-afxdp: Add need_wakeup supprt.

2019-09-27 Thread Eelco Chaudron
On 26 Sep 2019, at 21:29, William Tu wrote: The patch adds support for using need_wakeup flag in AF_XDP rings. A new option, use_need_wakeup, is added. When this option is used, it means that OVS has to explicitly wake up the kernel RX, using poll() syscall and wake up TX, using sendto()

Re: [ovs-dev] [PATCH v16 00/14] Support multi-segment mbufs

2019-09-27 Thread Obrembski, MichalX
Hi Flavio, Thank you very much for your comments, and given proof of concept! I understood that CPU cost could be a problem, but we currently haven't found any other solution. I saw your patches. In your patches you've moved logic to select which mempool to use inside DPDK.

Re: [ovs-dev] dpdk-latest rebase

2019-09-27 Thread David Marchand
On Fri, Sep 27, 2019 at 11:09 AM Kevin Traynor wrote: > > On 27/09/2019 09:04, Ilya Maximets wrote: > > On 27.09.2019 10:43, David Marchand wrote: > >> On Thu, Sep 26, 2019 at 9:45 PM Stokes, Ian wrote: > >>> On 9/26/2019 1:09 PM, David Marchand wrote: > On Thu, Sep 26, 2019 at 11:41 AM

Re: [ovs-dev] [PATCH ovn v3] Learn the mac binding only if required

2019-09-27 Thread Numan Siddique
On Fri, Sep 27, 2019 at 11:51 AM Han Zhou wrote: > > > On Tue, Sep 24, 2019 at 1:39 PM wrote: > > diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml > > index 6115e84b5..c98db48d2 100644 > > --- a/ovn-architecture.7.xml > > +++ b/ovn-architecture.7.xml > > @@ -970,6 +970,24 @@ > >

Re: [ovs-dev] dpdk-latest rebase

2019-09-27 Thread Kevin Traynor
On 27/09/2019 09:04, Ilya Maximets wrote: > On 27.09.2019 10:43, David Marchand wrote: >> On Thu, Sep 26, 2019 at 9:45 PM Stokes, Ian wrote: >>> On 9/26/2019 1:09 PM, David Marchand wrote: On Thu, Sep 26, 2019 at 11:41 AM Ilya Maximets wrote: > > On 26.09.2019 12:08, Stokes, Ian

Re: [ovs-dev] dpdk-latest rebase

2019-09-27 Thread Ilya Maximets
On 27.09.2019 10:43, David Marchand wrote: On Thu, Sep 26, 2019 at 9:45 PM Stokes, Ian wrote: On 9/26/2019 1:09 PM, David Marchand wrote: On Thu, Sep 26, 2019 at 11:41 AM Ilya Maximets wrote: On 26.09.2019 12:08, Stokes, Ian wrote: Hi all, the dpdk-latest branch has been lagging behind

Re: [ovs-dev] dpdk-latest rebase

2019-09-27 Thread David Marchand
On Thu, Sep 26, 2019 at 9:45 PM Stokes, Ian wrote: > On 9/26/2019 1:09 PM, David Marchand wrote: > > On Thu, Sep 26, 2019 at 11:41 AM Ilya Maximets wrote: > >> > >> On 26.09.2019 12:08, Stokes, Ian wrote: > >>> Hi all, > >>> > >>> the dpdk-latest branch has been lagging behind ovs master for a

Re: [ovs-dev] DDLog after one week

2019-09-27 Thread Dumitru Ceara
On Thu, Sep 26, 2019 at 6:45 PM Leonid Ryzhyk wrote: > > > > > Q: Why doesn't the ddlog compiler generate Out_IP_Multicast and only > > > > "input IP_Multicast" in OVN_Southbound.dl. > > > > A: For every table to which ovn-northd-ddlog needs to write we need to > > > > update northd/automake.mk.

[ovs-dev] IMPORTANT! You hαve been recorded ʍasturbating! I hαve Ovs Dev.mp4!

2019-09-27 Thread Aʼnonym0us Hʌcker
ATTN: ovs-dev@openvswitch.org The last time you visited a Ƿorn website with teenagers, you downloaded and installed the vίrus I developed. My program has turned on your cam and recorded the act of your ʍasturbation.. My software also downloaded all your email contact lίsts and a list of your

Re: [ovs-dev] [RFC PATCH ovn] Disable conjunction

2019-09-27 Thread Numan Siddique
On Fri, Sep 27, 2019 at 11:56 AM Han Zhou wrote: > > Thanks Numan. It looks good to me. Is there a reason why this is RFC? > Yes. I actually was thinking another way to disable conjunction. I will submit that patch and we can discuss further. Thanks Numan > > On Wed, Sep 25, 2019 at 1:48 AM

Re: [ovs-dev] [RFC PATCH ovn] Disable conjunction

2019-09-27 Thread Han Zhou
Thanks Numan. It looks good to me. Is there a reason why this is RFC? On Wed, Sep 25, 2019 at 1:48 AM wrote: > From: Numan Siddique > > The commit 298701dbc996("Exclude inport and outport symbol tables from > conjunction") > was earlier added to disable conjunction for inport and outport

Re: [ovs-dev] [PATCH ovn v3] Learn the mac binding only if required

2019-09-27 Thread Han Zhou
On Tue, Sep 24, 2019 at 1:39 PM wrote: > diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml > index 6115e84b5..c98db48d2 100644 > --- a/ovn-architecture.7.xml > +++ b/ovn-architecture.7.xml > @@ -970,6 +970,24 @@ > this temporary use.) > > > + > +