Re: [ovs-dev] [PATCHv5] netdev-afxdp: Add need_wakeup supprt.

2019-10-18 Thread William Tu
On Fri, Oct 18, 2019 at 05:14:46PM +0200, Ilya Maximets wrote: > On 26.09.2019 21:29, William Tu wrote: > >The patch adds support for using need_wakeup flag in AF_XDP rings. > >A new option, use_need_wakeup, is added. When this option is used, > >it means that OVS has to explicitly wake up the

Re: [ovs-dev] [PATCH] debian and rhel: Add libunwind dev package.

2019-10-18 Thread William Tu
On Thu, Oct 17, 2019 at 01:38:08PM -0700, Yi-Hung Wei wrote: > On Thu, Oct 17, 2019 at 12:56 PM William Tu wrote: > > > > The patch add libunwind dev package to debian and rhel. > > > > Signed-off-by: William Tu > > --- > > Looks good to me. > > Acked-by: Yi-Hung Wei Applied to master,

Re: [ovs-dev] [PATCH net-next v4 03/10] net: openvswitch: shrink the mask array if necessary

2019-10-18 Thread William Tu
On Wed, Oct 16, 2019 at 5:53 AM wrote: > > From: Tonghao Zhang > > When creating and inserting flow-mask, if there is no available > flow-mask, we realloc the mask array. When removing flow-mask, > if necessary, we shrink mask array. > > Signed-off-by: Tonghao Zhang > Tested-by: Greg Rose >

Re: [ovs-dev] [PATCH net-next v4 02/10] net: openvswitch: convert mask list in mask array

2019-10-18 Thread William Tu
On Wed, Oct 16, 2019 at 5:52 AM wrote: > > From: Tonghao Zhang > > Port the codes to linux upstream and with little changes. > > Pravin B Shelar, says: > | mask caches index of mask in mask_list. On packet recv OVS > | need to traverse mask-list to get cached mask. Therefore array > | is better

Re: [ovs-dev] [PATCH net-next v4 01/10] net: openvswitch: add flow-mask cache for performance

2019-10-18 Thread William Tu
On Wed, Oct 16, 2019 at 5:51 AM wrote: > > From: Tonghao Zhang > > The idea of this optimization comes from a patch which > is committed in 2014, openvswitch community. The author > is Pravin B Shelar. In order to get high performance, I > implement it again. Later patches will use it. > >

Re: [ovs-dev] [PATCH net-next v4 10/10] net: openvswitch: simplify the ovs_dp_cmd_new

2019-10-18 Thread William Tu
On Wed, Oct 16, 2019 at 5:56 AM wrote: > > From: Tonghao Zhang > > use the specified functions to init resource. > > Signed-off-by: Tonghao Zhang > Tested-by: Greg Rose > --- Looks like this is simply moving code around. I don't have any opinion. > net/openvswitch/datapath.c | 60 >

Re: [ovs-dev] [PATCH net-next v4 09/10] net: openvswitch: don't unlock mutex when changing the user_features fails

2019-10-18 Thread William Tu
On Wed, Oct 16, 2019 at 5:56 AM wrote: > > From: Tonghao Zhang > > Unlocking of a not locked mutex is not allowed. > Other kernel thread may be in critical section while > we unlock it because of setting user_feature fail. > > Fixes: 95a7233c4 ("net: openvswitch: Set OvS recirc_id from tc chain

Re: [ovs-dev] [PATCH net-next v4 07/10] net: openvswitch: add likely in flow_lookup

2019-10-18 Thread William Tu
On Wed, Oct 16, 2019 at 5:55 AM wrote: > > From: Tonghao Zhang > > The most case *index < ma->max, and flow-mask is not NULL. > We add un/likely for performance. > > Signed-off-by: Tonghao Zhang > Tested-by: Greg Rose > --- LGTM Acked-by: William Tu > net/openvswitch/flow_table.c | 4 ++--

Re: [ovs-dev] [PATCH net-next v4 06/10] net: openvswitch: simplify the flow_hash

2019-10-18 Thread William Tu
On Wed, Oct 16, 2019 at 5:54 AM wrote: > > From: Tonghao Zhang > > Simplify the code and remove the unnecessary BUILD_BUG_ON. > > Signed-off-by: Tonghao Zhang > Tested-by: Greg Rose > --- LGTM Acked-by: William Tu > net/openvswitch/flow_table.c | 8 ++-- > 1 file changed, 2

Re: [ovs-dev] [PATCH net-next v4 05/10] net: openvswitch: optimize flow-mask looking up

2019-10-18 Thread William Tu
On Wed, Oct 16, 2019 at 5:54 AM wrote: > > From: Tonghao Zhang > > The full looking up on flow table traverses all mask array. > If mask-array is too large, the number of invalid flow-mask > increase, performance will be drop. > > One bad case, for example: M means flow-mask is valid and NULL >

[ovs-dev] [RFC ovn PATCH 3/5] Remove multithreading from pinctrl.

2019-10-18 Thread Mark Michelson
This more-or-less gets pinctrl back to how it was prior to being made multithreaded for OVS 2.11. Since pinctrl is in its own process, there's no immediate need to have multiple threads. Signed-off-by: Mark Michelson --- controller/pinctrl.c | 736

[ovs-dev] [RFC ovn PATCH 4/5] Move ovn-pinctrl to its own directory.

2019-10-18 Thread Mark Michelson
Signed-off-by: Mark Michelson --- Makefile.am | 1 + controller/automake.mk| 34 -- pinctrl/automake.mk | 25 + pinctrl/ovn-pinctrl.8.xml | 35

[ovs-dev] [RFC ovn PATCH 5/5] Flesh out manpage with more details about ovn-pinctrl

2019-10-18 Thread Mark Michelson
Signed-off-by: Mark Michelson --- pinctrl/ovn-pinctrl.8.xml | 77 ++- 1 file changed, 76 insertions(+), 1 deletion(-) diff --git a/pinctrl/ovn-pinctrl.8.xml b/pinctrl/ovn-pinctrl.8.xml index c0322cd4b..df8e717ca 100644 --- a/pinctrl/ovn-pinctrl.8.xml

[ovs-dev] [RFC ovn PATCH 1/5] Separate pinctrl to its own process.

2019-10-18 Thread Mark Michelson
This is a minimum effort separation. The pinctrl.c file has not been altered. A new ovn-pinctrl.c file starts an application that makes calls to pinctrl as necessary. To facilitate this change, a couple of extra modifications were made. * binding_run() now has a do_bind boolean parameter. With

[ovs-dev] [RFC ovn PATCH 2/5] Resolve duplicate functions in ovn-controller and ovn-pinctrl.

2019-10-18 Thread Mark Michelson
Most duplicate functions have been extracted to controller-utils.c. Signed-off-by: Mark Michelson --- controller/controller-utils.c | 166 ++ controller/ovn-controller.c | 171 +-- controller/ovn-controller.h | 20 +

[ovs-dev] [RFC ovn PATCH 0/5] Separate pinctrl to its own process

2019-10-18 Thread Mark Michelson
This proposes a set of patches to move pinctrl operations out of the ovn-controller process and into its own. The main reasons for doing this are the following: 1) Separating pinctrl makes it so that receiving a packet-in can't wake up ovn-controller. 2) Separating pinctrl allows for manipulating

Re: [ovs-dev] [PATCH ovn] Add RDNSS support to OVN

2019-10-18 Thread Mark Michelson
Acked-by: Mark Michelson On 10/18/19 7:09 AM, Lorenzo Bianconi wrote: Introduce the possibility to specify a RDNSS option to Router Advertisement packets. DNS IPv6 address can be specified using 'rdnss' tag in the ipv6_ra_configs column of logical router port table Signed-off-by: Lorenzo

Re: [ovs-dev] [PATCH net-next v4 08/10] net: openvswitch: fix possible memleak on destroy flow-table

2019-10-18 Thread Pravin Shelar
On Thu, Oct 17, 2019 at 8:16 PM Tonghao Zhang wrote: > > On Fri, Oct 18, 2019 at 6:38 AM Pravin Shelar wrote: > > > > On Wed, Oct 16, 2019 at 5:50 AM wrote: > > > > > > From: Tonghao Zhang > > > > > > When we destroy the flow tables which may contain the flow_mask, > > > so release the flow

Re: [ovs-dev] [PATCH] Remove oss-fuzz tests carried over from ovs

2019-10-18 Thread Ben Pfaff
This is the right mailing list for now. The convention is to write [PATCH ovn] in subject headings (but I figured it out ;-) On Fri, Oct 18, 2019 at 04:48:40PM +0200, Bhargava Shastry wrote: > Just want to add that the patch is to be applied to ovn source code, I > couldn't find the ovn mailing

Re: [ovs-dev] [PATCH] Remove oss-fuzz tests carried over from ovs

2019-10-18 Thread Ben Pfaff
On Fri, Oct 18, 2019 at 11:13:08AM +0200, bsh...@gmail.com wrote: > From: Bhargava Shastry > > It appears that ossfuzz specific test harnesses and configuration files > were carried over to the ovn repo from the ovs repo without > justification. This patch removes them until there is a need to >

Re: [ovs-dev] [PATCH ovn] ovn.at: Fix vtep autotest.

2019-10-18 Thread Numan Siddique
On Fri, Oct 18, 2019 at 10:57 PM Ben Pfaff wrote: > On Thu, Oct 17, 2019 at 03:51:42PM +0200, Dumitru Ceara wrote: > > With the removal of the OVS subtree the vtep autotest stopped working > > because the vtep.ovsschema couldn't be found anymore. The failure was > > however hidden by the "||

Re: [ovs-dev] [PATCH] ossfuzz: Simplify miniflow fuzzer harness.

2019-10-18 Thread Ben Pfaff
On Fri, Oct 18, 2019 at 05:17:34PM +0200, bsh...@gmail.com wrote: > From: Bhargava Shastry > > Google's oss-fuzz builder bots were complaining that miniflow_target is > too slow to fuzz in that some tests take longer than a second to > complete. This patch fixes this by replacing the random flow

Re: [ovs-dev] [PATCH 00/11] Backport upstream conntrack related patches

2019-10-18 Thread Ben Pfaff
On Tue, Oct 15, 2019 at 10:41:23AM -0700, Yi-Hung Wei wrote: > On Tue, Oct 15, 2019 at 10:18 AM Ben Pfaff wrote: > > > > On Mon, Oct 14, 2019 at 10:37:40AM -0700, Yi-Hung Wei wrote: > > > This series backports conntrack related patches from upstream kernel. > > > It has been tested on > > > *

Re: [ovs-dev] [PATCH v2 00/12] Backport upstream conntrack related patches

2019-10-18 Thread Ben Pfaff
On Tue, Oct 15, 2019 at 10:27:41AM -0700, Yi-Hung Wei wrote: > This series backports conntrack related patches from upstream kernel. > It has been tested on > * Ubuntu 14.04, 16.04, and 18.04. > * RHEL 7.4-7.6. > * 5.0 kernel. > > Travis test:

Re: [ovs-dev] [PATCH ovn] ovn.at: Fix vtep autotest.

2019-10-18 Thread Ben Pfaff
On Thu, Oct 17, 2019 at 03:51:42PM +0200, Dumitru Ceara wrote: > With the removal of the OVS subtree the vtep autotest stopped working > because the vtep.ovsschema couldn't be found anymore. The failure was > however hidden by the "|| return 1" when failing to create the vtep DB. > > Fix the path

Re: [ovs-dev] [PATCH] ossfuzz: Simplify miniflow fuzzer harness.

2019-10-18 Thread 0-day Robot
Bleep bloop. Greetings Bhargava Shastry, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has trailing whitespace #166 FILE: tests/oss-fuzz/miniflow_target.c:133:

Re: [ovs-dev] [PATCH 0/5] Backport upstream Linux kernel patches

2019-10-18 Thread Gregory Rose
On 10/18/2019 7:23 AM, Simon Horman wrote: On Thu, Oct 17, 2019 at 01:32:27PM -0700, Gregory Rose wrote: Hello maintainers, Yi-Hung has added his acks.  Please consider applying these patches. Thanks, - Greg Thanks Greg, applied to master. Thanks Simon!

[ovs-dev] [PATCH] ossfuzz: Simplify miniflow fuzzer harness.

2019-10-18 Thread bshas3
From: Bhargava Shastry Google's oss-fuzz builder bots were complaining that miniflow_target is too slow to fuzz in that some tests take longer than a second to complete. This patch fixes this by replacing the random flow generation within the harness to a more simpler scenario. Signed-off-by:

Re: [ovs-dev] [PATCHv5] netdev-afxdp: Add need_wakeup supprt.

2019-10-18 Thread Ilya Maximets
On 26.09.2019 21:29, William Tu wrote: The patch adds support for using need_wakeup flag in AF_XDP rings. A new option, use_need_wakeup, is added. When this option is used, it means that OVS has to explicitly wake up the kernel RX, using poll() syscall and wake up TX, using sendto() syscall.

Re: [ovs-dev] [PATCH] Remove oss-fuzz tests carried over from ovs

2019-10-18 Thread Bhargava Shastry
Just want to add that the patch is to be applied to ovn source code, I couldn't find the ovn mailing list so sent it here. Apologies. On Fri, Oct 18, 2019 at 11:13 AM wrote: > From: Bhargava Shastry > > It appears that ossfuzz specific test harnesses and configuration files > were carried over

Re: [ovs-dev] [PATCH 0/5] Backport upstream Linux kernel patches

2019-10-18 Thread Simon Horman
On Thu, Oct 17, 2019 at 01:32:27PM -0700, Gregory Rose wrote: > On 10/9/2019 2:22 PM, Greg Rose wrote: > > Pull in upstream kernel patches not related to conntrack and > > add compatibility layer code where needed. > > > > The upstream conntrack related patches will come later from Yi-Hung. > >

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-18 Thread Ilya Maximets
On 16.10.2019 19:48, Kevin Traynor wrote: On 16/10/2019 13:16, Ilya Maximets wrote: Hi Kevin, Thanks for review. Some comments inline. On 16.10.2019 12:15, Kevin Traynor wrote: Hi Sriram, Thanks for working on making more fine grained stats for debugging. As mentioned yesterday, this patch

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-18 Thread Sriram Vatala via dev
Hi, Thanks Kevin for your suggestion. Ilya, Can you please share your opinion also so that we can arrive at some conclusion on the approach. Thanks & Regards, Sriram. -Original Message- From: Kevin Traynor Sent: 16 October 2019 23:18 To: Ilya Maximets ; Sriram Vatala ;

Re: [ovs-dev] [PATCH v13] Improved Packet Drop Statistics in OVS

2019-10-18 Thread Eelco Chaudron
Are you planning on sending a v14? Cheers, Eelco On 16 Sep 2019, at 16:12, Eelco Chaudron wrote: Hi Anju, For some reason, this version does not show up in patchwork! I have two small comments below but other than that it looks fine to me. If those two will be the only changes in your

[ovs-dev] [PATCH ovn] Add RDNSS support to OVN

2019-10-18 Thread Lorenzo Bianconi
Introduce the possibility to specify a RDNSS option to Router Advertisement packets. DNS IPv6 address can be specified using 'rdnss' tag in the ipv6_ra_configs column of logical router port table Signed-off-by: Lorenzo Bianconi --- controller/pinctrl.c | 50

Re: [ovs-dev] [PATCH] tc: Limit the max action number to 16

2019-10-18 Thread Simon Horman
On Wed, Oct 16, 2019 at 11:53:52AM +, Roi Dayan wrote: > > > On 2019-10-16 2:40 PM, Simon Horman wrote: > > On Wed, Oct 16, 2019 at 11:37:14AM +0300, Roi Dayan wrote: > >> From: Chris Mi > >> > >> Currently, ovs supports to offload max TCA_ACT_MAX_PRIO(32) actions. > >> But net sched api

Re: [ovs-dev] [PATCH] Remove oss-fuzz tests carried over from ovs

2019-10-18 Thread 0-day Robot
Bleep bloop. Greetings , I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (tests/automake.mk). Repository lacks necessary blobs to fall

[ovs-dev] [PATCH] Remove oss-fuzz tests carried over from ovs

2019-10-18 Thread bshas3
From: Bhargava Shastry It appears that ossfuzz specific test harnesses and configuration files were carried over to the ovn repo from the ovs repo without justification. This patch removes them until there is a need to continuously fuzz ovn code as the ovs code is currently fuzzed.

Re: [ovs-dev] [RFC ovn] Add CoPP (Control Plane Protection).

2019-10-18 Thread Dumitru Ceara
On Fri, Oct 18, 2019 at 3:53 AM Han Zhou wrote: > > > > On Thu, Oct 10, 2019 at 1:20 AM Dumitru Ceara wrote: > > > > Add new 'Copp' (Control plane protection) table to OVN Northbound DB: > > - this stores mappings between control plane protocol names and meters > > that should be used to rate