Re: [ovs-dev] [PATCH net-next v4 08/10] net: openvswitch: fix possible memleak on destroy flow-table

2019-10-22 Thread Tonghao Zhang
On Tue, Oct 22, 2019 at 2:58 PM Pravin Shelar wrote: > > On Sun, Oct 20, 2019 at 10:02 PM Tonghao Zhang > wrote: > > > > On Sat, Oct 19, 2019 at 2:12 AM Pravin Shelar wrote: > > > > > > On Thu, Oct 17, 2019 at 8:16 PM Tonghao Zhang > > > wrote: > > > > > > > > On Fri, Oct 18, 2019 at 6:38 AM

Re: [ovs-dev] [PATCH net] net: openvswitch: free vport unless register_netdevice() succeeds

2019-10-22 Thread Stefano Brivio
Hi Jakub, On Tue, 22 Oct 2019 14:53:16 -0700 Jakub Kicinski wrote: > On Mon, 21 Oct 2019 12:01:57 +0200, Stefano Brivio wrote: > > From: Hillf Danton > > > > syzbot found the following crash on: > > > The function in net core, register_netdevice(), may fail with vport's > > destruction

Re: [ovs-dev] [PATCH net] net: openvswitch: free vport unless register_netdevice() succeeds

2019-10-22 Thread Jakub Kicinski
On Mon, 21 Oct 2019 12:01:57 +0200, Stefano Brivio wrote: > From: Hillf Danton > > syzbot found the following crash on: > The function in net core, register_netdevice(), may fail with vport's > destruction callback either invoked or not. After commit 309b66970ee2, I've added the correct

Re: [ovs-dev] [PATCH ovn v2] tests: Fix check-valgrind and check-lcov.

2019-10-22 Thread Han Zhou
On Mon, Oct 21, 2019 at 11:28 PM Numan Siddique wrote: > > > > On Tue, Oct 22, 2019 at 7:08 AM Han Zhou wrote: >> >> After split from OVS, make check-valgrind and check-lcov are not >> working any more, because the $ovs_srcdir are missing for these tests. >> Instead of add

Re: [ovs-dev] [PATCH ovn] lflow.c: Fix memory leak of lflow_ref_list_node->ref_name.

2019-10-22 Thread Han Zhou
On Mon, Oct 21, 2019 at 11:18 PM Numan Siddique wrote: > > > > On Tue, Oct 22, 2019 at 6:57 AM Han Zhou wrote: >> >> The ref_name is copied in lflow_resource_add(), but forgot to free in >> lflow_resource_destroy_lflow(). It can be fixed by freeing it in >> lflow_resource_destroy_lflow().

Re: [ovs-dev] [PATCH ovn] ovn-controller.c: Fix memory leak of local_datapath->ports.

2019-10-22 Thread Han Zhou
On Tue, Oct 22, 2019 at 12:08 AM Dumitru Ceara wrote: > > On Tue, Oct 22, 2019 at 8:28 AM Numan Siddique wrote: > > > > On Tue, Oct 22, 2019 at 5:19 AM Han Zhou wrote: > > > > > Fixes: 89f5048f960c ("ovn-controller: Minimize SB DB port_binding > > > lookups.") > > > Signed-off-by: Han Zhou > >

Re: [ovs-dev] [PATCH] faq: Give specific versions that introduced various features.

2019-10-22 Thread Ilya Maximets
On 22.10.2019 17:44, Ben Pfaff wrote: On Tue, Oct 22, 2019 at 06:22:17PM +0200, Ilya Maximets wrote: On 22.10.2019 0:00, Ben Pfaff wrote: Some users would find it useful to know the particular OVS version that introduced a feature to the OVS tree kernel module or to the OVS userspace (DPDK)

[ovs-dev] [PATCH v2] faq: Give specific versions that introduced various features.

2019-10-22 Thread Ben Pfaff
Some users would find it useful to know the particular OVS version that introduced a feature to the OVS tree kernel module or to the OVS userspace (DPDK) datapath implementation. This patch updates the FAQ to include that information. This information is primarily gleaned from the top-level NEWS

Re: [ovs-dev] [PATCH] faq: Give specific versions that introduced various features.

2019-10-22 Thread Ben Pfaff
On Tue, Oct 22, 2019 at 11:27:12AM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > Some users would find it useful to know the particular OVS version that > > introduced a feature to the OVS tree kernel module or to the OVS > > userspace (DPDK) datapath implementation. This patch updates

Re: [ovs-dev] [PATCH] faq: Give specific versions that introduced various features.

2019-10-22 Thread Ben Pfaff
On Tue, Oct 22, 2019 at 06:22:17PM +0200, Ilya Maximets wrote: > On 22.10.2019 0:00, Ben Pfaff wrote: > > Some users would find it useful to know the particular OVS version that > > introduced a feature to the OVS tree kernel module or to the OVS > > userspace (DPDK) datapath implementation. This

Re: [ovs-dev] [PATCH] faq: Give specific versions that introduced various features.

2019-10-22 Thread Ilya Maximets
On 22.10.2019 0:00, Ben Pfaff wrote: Some users would find it useful to know the particular OVS version that introduced a feature to the OVS tree kernel module or to the OVS userspace (DPDK) datapath implementation. This patch updates the FAQ to include that information. This information is

Re: [ovs-dev] [PATCH ovs v3 2/2] netdev-dpdk: Add dpdkvdpa port

2019-10-22 Thread William Tu
On Tue, Oct 22, 2019 at 12:17 AM Noa Ezra wrote: > > Hi, > Please see the answer below. > > Thanks, > Noa. > > > -Original Message- > > From: William Tu [mailto:u9012...@gmail.com] > > Sent: Friday, October 18, 2019 12:34 AM > > To: Noa Ezra > > Cc: ovs-dev@openvswitch.org; Oz Shlomo ;

Re: [ovs-dev] [PATCH net-next v4 00/10] optimize openvswitch flow looking up

2019-10-22 Thread William Tu
On Mon, Oct 21, 2019 at 6:16 PM Tonghao Zhang wrote: > > On Tue, Oct 22, 2019 at 1:14 AM William Tu wrote: > > > > On Wed, Oct 16, 2019 at 5:50 AM wrote: > > > > > > From: Tonghao Zhang > > > > > > This series patch optimize openvswitch for performance or simplify > > > codes. > > > > > >

Re: [ovs-dev] [PATCH] faq: Give specific versions that introduced various features.

2019-10-22 Thread Aaron Conole
Ben Pfaff writes: > Some users would find it useful to know the particular OVS version that > introduced a feature to the OVS tree kernel module or to the OVS > userspace (DPDK) datapath implementation. This patch updates the FAQ > to include that information. > > This information is primarily

[ovs-dev] [PATCH 2/2] ovs-tcpundump: allow multiple packet lengths

2019-10-22 Thread Aaron Conole
The tcpundump tool expects all packets to be a length which aligns to exactly a 4-nibble boundary. This means packets like DNS requests will be stripped before being correctly processed. Fix this by allowing at least two nibbles (or one byte) alignment. Signed-off-by: Aaron Conole ---

[ovs-dev] [PATCH 1/2] ovs-tcpundump: exit when getting version

2019-10-22 Thread Aaron Conole
Running 'ovs-tcpundump -V' will cause ovs-tcpundump to start processing on stdin. Instead, print the version and exit. Signed-off-by: Aaron Conole --- utilities/ovs-tcpundump.in | 1 + 1 file changed, 1 insertion(+) diff --git a/utilities/ovs-tcpundump.in b/utilities/ovs-tcpundump.in index

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Sriram Vatala via dev
Thanks Ilya and Kevin. I will send the updated patch set. Thanks & Regards, Sriram. -Original Message- From: Ilya Maximets Sent: 22 October 2019 16:07 To: Kevin Traynor ; Sriram Vatala ; 'Ilya Maximets' ; ovs-dev@openvswitch.org Cc: 'Stokes, Ian' Subject: Re: [PATCH v9 2/2]

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Ilya Maximets
On 22.10.2019 12:31, Kevin Traynor wrote: On 22/10/2019 09:25, Sriram Vatala wrote: Hi Ilya & Kevin, Thanks for your suggestions. I am summarizing our discussion, please feel free to correct me, if I am wrong. Hi Sriram, Will share my thought, Ilya may have different view. 1) All custom

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Kevin Traynor
On 22/10/2019 11:31, Kevin Traynor wrote: > On 22/10/2019 09:25, Sriram Vatala wrote: >> Hi Ilya & Kevin, >> Thanks for your suggestions. I am summarizing our discussion, please feel >> free >> to correct me, if I am wrong. >> > > Hi Sriram, > > Will share my thought, Ilya may have different

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Kevin Traynor
On 22/10/2019 09:25, Sriram Vatala wrote: > Hi Ilya & Kevin, > Thanks for your suggestions. I am summarizing our discussion, please feel > free > to correct me, if I am wrong. > Hi Sriram, Will share my thought, Ilya may have different view. > 1) All custom stats calculated in OVS will have

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Ilya Maximets
On 22.10.2019 10:25, Sriram Vatala wrote: Hi Ilya & Kevin, Thanks for your suggestions. I am summarizing our discussion, please feel free to correct me, if I am wrong. 1) All custom stats calculated in OVS will have the prefix , so that these stats will not intersect with the names of other

[ovs-dev] [PATCH v2] dpif-netdev: log rxq assignment in isolated pmd

2019-10-22 Thread Gowrishankar Muthukrishnan
There is no log about isolated rxq assignment in a pmd today, which sometimes could be useful to trace rxq/pmd pinning, when debugging with log. Ovs-appctl dpif-netdev/pmd-rxq-show reports about it already, but logging is helpful to trace pinning in time. Changes: v2: init numa_id for the info.

Re: [ovs-dev] [PATCH] dpif-netdev: log rxq assignment in isolated pmd

2019-10-22 Thread 0-day Robot
Bleep bloop. Greetings Gowrishankar Muthukrishnan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: mv -f $depbase.Tpo $depbase.Plo libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I.

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-22 Thread Sriram Vatala via dev
Hi Ilya & Kevin, Thanks for your suggestions. I am summarizing our discussion, please feel free to correct me, if I am wrong. 1) All custom stats calculated in OVS will have the prefix , so that these stats will not intersect with the names of other stats (driver/HW etc). 2) The prefix used for

[ovs-dev] [PATCH] dpif-netdev: log rxq assignment in isolated pmd

2019-10-22 Thread Gowrishankar Muthukrishnan
There is no log about isolated rxq assigment in a pmd today, which sometimes could be useful to trace rxq/pmd pinning, when debugging with log. Ovs-appctl dpif-netdev/pmd-rxq-show reports about it already, but logging is helpful to trace pinning in time. Reported-at:

Re: [ovs-dev] [PATCH ovs v3 2/2] netdev-dpdk: Add dpdkvdpa port

2019-10-22 Thread Noa Ezra
Hi, Please see the answer below. Thanks, Noa. > -Original Message- > From: William Tu [mailto:u9012...@gmail.com] > Sent: Friday, October 18, 2019 12:34 AM > To: Noa Ezra > Cc: ovs-dev@openvswitch.org; Oz Shlomo ; Majd > Dibbiny ; Ameer Mahagneh > ; Eli Britstein > Subject: Re:

Re: [ovs-dev] [PATCH ovn] ovn-controller.c: Fix memory leak of local_datapath->ports.

2019-10-22 Thread Dumitru Ceara
On Tue, Oct 22, 2019 at 8:28 AM Numan Siddique wrote: > > On Tue, Oct 22, 2019 at 5:19 AM Han Zhou wrote: > > > Fixes: 89f5048f960c ("ovn-controller: Minimize SB DB port_binding > > lookups.") > > Signed-off-by: Han Zhou > > > > Acked-by: Numan Siddique > > Numan My bad, thanks Han for fixing

Re: [ovs-dev] [PATCH net-next v4 08/10] net: openvswitch: fix possible memleak on destroy flow-table

2019-10-22 Thread Pravin Shelar
On Sun, Oct 20, 2019 at 10:02 PM Tonghao Zhang wrote: > > On Sat, Oct 19, 2019 at 2:12 AM Pravin Shelar wrote: > > > > On Thu, Oct 17, 2019 at 8:16 PM Tonghao Zhang > > wrote: > > > > > > On Fri, Oct 18, 2019 at 6:38 AM Pravin Shelar wrote: > > > > > > > > On Wed, Oct 16, 2019 at 5:50 AM

Re: [ovs-dev] [PATCH ovn v2] tests: Fix check-valgrind and check-lcov.

2019-10-22 Thread Numan Siddique
On Tue, Oct 22, 2019 at 7:08 AM Han Zhou wrote: > After split from OVS, make check-valgrind and check-lcov are not > working any more, because the $ovs_srcdir are missing for these tests. > Instead of add ovs_srcdir=$(ovs_srcdir) for each target, this patch > export ovs_srcdir once for all. > >

Re: [ovs-dev] [PATCH ovn] ovn-controller.c: Fix memory leak of local_datapath->ports.

2019-10-22 Thread Numan Siddique
On Tue, Oct 22, 2019 at 5:19 AM Han Zhou wrote: > Fixes: 89f5048f960c ("ovn-controller: Minimize SB DB port_binding > lookups.") > Signed-off-by: Han Zhou > Acked-by: Numan Siddique Numan > --- > controller/ovn-controller.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [ovs-dev] [PATCH] rhel: Remove the cond 'build_python3'

2019-10-22 Thread Numan Siddique
On Mon, Oct 21, 2019 at 10:51 PM Ben Pfaff wrote: > On Mon, Oct 21, 2019 at 03:12:42PM +0530, num...@ovn.org wrote: > > From: Numan Siddique > > > > A previous patch removed python2 support from ovs. So we can remove > > this condition and make python3 mandatory for builds. Without this > >

Re: [ovs-dev] [PATCH ovn] lflow.c: Fix memory leak of lflow_ref_list_node->ref_name.

2019-10-22 Thread Numan Siddique
On Tue, Oct 22, 2019 at 6:57 AM Han Zhou wrote: > The ref_name is copied in lflow_resource_add(), but forgot to free in > lflow_resource_destroy_lflow(). It can be fixed by freeing it in > lflow_resource_destroy_lflow(). However, this field is never really > used, so just delete it from

Re: [ovs-dev] [PATCH] lacp: report desync in ovs threads enabling slave

2019-10-22 Thread 0-day Robot
Bleep bloop. Greetings Gowrishankar Muthukrishnan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 84 characters long (recommended limit is 79) #25 FILE: