On Sat, Jan 11, 2020 at 6:31 AM Manoj Sharma wrote:
>
> Thank you for the review Numan.
>
> On 1/8/20, 11:14 PM, "Numan Siddique" wrote:
>
> Hi Manoj,
>
> Thanks for the patch. I didn't look into the complete patch. I have
> initial few comments.
>
> The patch fails to compile
Bleep bloop. Greetings Amber Hu via dev, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
fatal: corrupt patch at line 19
Repository lacks necessary blobs to fall back on 3-way merge.
Formerly, there is no tunnel information appended in the upcall’s
packet data, which is expected by IPFIX in userspace to calculate
the template for exporting the sampled flow record of on egress
tunnel port.
To fix this, during performing OvsOutputUserspaceAction(), we
would check whether it is
Hi Mark,
Thanks for your review.
On Mon, Jan 13, 2020 at 12:50 PM Mark Michelson wrote:
>
> On 1/12/20 5:10 PM, Han Zhou wrote:
> > When an old lflow is replaced by a new lflow, if the OVS flows
> > translated by the old and new lflows have same match, ofctrl will
> > update existing OVS flow
When an old lflow is replaced by a new lflow, if the OVS flows
translated by the old and new lflows have same match, ofctrl will
update existing OVS flow instead of deleting and adding a new one.
However, when updating the existing flows, the cookie was not updated
by current implementation,
Set this option to true will avoid using conditional monitoring in
ovn-controller. Setting it to true helps in environments where
all (or most) workloads need to be reachable from each other, thus
the effectiveness of conditional monitoring is low, but the overhead
of conditional monitoring is
In function update_sb_db(), it tries to access cfg->external_ids
outside of the "if (cfg)" block. This patch fixes it.
Signed-off-by: Han Zhou
---
controller/ovn-controller.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/controller/ovn-controller.c
Move the logic of handling OVN-SB related setting in external-ids
after the ovs_idl_loop run, so that any change in the external-ids
settings can take effect in the same iteration, without waiting for
the next one.
Signed-off-by: Han Zhou
---
controller/ovn-controller.c | 8
1 file
On 1/12/20 5:10 PM, Han Zhou wrote:
When an old lflow is replaced by a new lflow, if the OVS flows
translated by the old and new lflows have same match, ofctrl will
update existing OVS flow instead of deleting and adding a new one.
However, when updating the existing flows, the cookie was not
On 1/12/20 5:48 PM, Han Zhou wrote:
On Sun, Jan 12, 2020 at 2:10 PM Han Zhou wrote:
When an old lflow is replaced by a new lflow, if the OVS flows
translated by the old and new lflows have same match, ofctrl will
update existing OVS flow instead of deleting and adding a new one.
However,
On 1/13/2020 3:56 PM, Eelco Chaudron wrote:
This patch adds a new policer to the DPDK datapath based on RFC 4115's
Two-Rate, Three-Color marker. It's a two-level hierarchical policer
which first does a color-blind marking of the traffic at the queue
level, followed by a color-aware marking at
On Mon, Jan 13, 2020 at 03:48:29PM +, Ciara Loftus wrote:
> When using TSO in OVS-DPDK with an i40e device, the following
> commit is required for DPDK, which fixes an issue on the TSO path:
> http://git.dpdk.org/next/dpdk-next-net/commit/?id=b2a4dc260139409c539fb8e7f1b9d0a5182cfd2b
> Document
On Thu, Jan 9, 2020 at 5:39 AM Ilya Maximets wrote:
> On 06.01.2020 22:48, William Tu wrote:
> > On Mon, Dec 23, 2019 at 11:34 AM Yi-Hung Wei wrote:
> >>
> >> This patches detects the number of combined channels on a AF_XDP port
> >> via using ethtool interface. If the number of combined
On Mon, Jan 13, 2020 at 09:26:49AM +0530, Vishal Deep Ajmera via dev wrote:
> Currently fast-failover group does not support checking liveness of controller
> port (OFPP_CONTROLLER). However this feature can be useful for selecting
> alternate pipeline when controller connection itself is down for
On 09.01.2020 08:46, Eli Britstein wrote:
> Currently, netdev datapath offload only accelerates the flow match
> sequence by associating a mark per flow. This series introduces the full
> offload of netdev datapath flows by having the HW also perform the flow
> actions.
>
> This series adds HW
On Fri, Jan 10, 2020 at 06:02:29PM +0100, Ilya Maximets wrote:
> > OK. I applied both patches to master. Thank you!
>
> Hi, Ben.
>
> These patches broke OSX build:
>
> https://travis-ci.org/openvswitch/ovs/jobs/634863662
>
> lib/socket-util.c:1294:31: error: use of undeclared identifier
>
These functions failed to build on OS X because MSG_WAITFORONE is not
defined there. There are pitfalls for trying to define our own MSG_*
constants, since it's hard to pick a constant that is not used by the
system already. Because OVS only uses recvmmsg() and sendmmsg() on
Linux, it seems
On 09.01.2020 19:16, Ben Pfaff wrote:
> On Thu, Jan 09, 2020 at 05:27:36PM +0100, Ilya Maximets wrote:
>> Both ovs_key_ct_tuple_ipv* structures contains padding at the end
>> that mast be cleared before passing attributes to kernel:
>
> Good catch.
>
> I think that you could save a line for the
On Mon, Jan 13, 2020 at 05:47:03PM +0100, Timothy Redaelli wrote:
> Currently, ovs-tcpdump uses python3-netifaces in order to get the list of
> the network interfaces, but python3-netifaces may not be installed nor
> available on some distributions (for example on RHEL7).
>
> This commit adds,
On Thu, Jan 09, 2020 at 01:27:06PM -0500, Aaron Conole wrote:
> In "Use of library functions" in the C standard, the following statement
> is written to apply to all library functions:
>
> If an argument to a function has an invalid value (such as ... a
> null pointer ... the behavior is
On 1/13/2020 9:10 AM, Loftus, Ciara wrote:
In "Use of library functions" in the C standard, the following statement
is written to apply to all library functions:
If an argument to a function has an invalid value (such as ... a
null pointer ... the behavior is undefined.
Later, under
Currently, ovs-tcpdump uses python3-netifaces in order to get the list of
the network interfaces, but python3-netifaces may not be installed nor
available on some distributions (for example on RHEL7).
This commit adds, only for Linux, an alternative way (that is only used
when netifaces is not
Bleep bloop. Greetings Ciara Loftus, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
Failed to merge in the changes.
Patch failed at 0001 Documentation: add notes for TSO & i40e
The
On Mon, Jan 13, 2020 at 4:49 PM Ciara Loftus wrote:
>
> When using TSO in OVS-DPDK with an i40e device, the following
> commit is required for DPDK, which fixes an issue on the TSO path:
> http://git.dpdk.org/next/dpdk-next-net/commit/?id=b2a4dc260139409c539fb8e7f1b9d0a5182cfd2b
Please avoid
This patch adds a new policer to the DPDK datapath based on RFC 4115's
Two-Rate, Three-Color marker. It's a two-level hierarchical policer
which first does a color-blind marking of the traffic at the queue
level, followed by a color-aware marking at the port level. At the end
traffic marked as
netdev-dpdk: Add new DPDK RFC 4115 egress policer
This patch adds a new policer to the DPDK datapath based on RFC 4115's
Two-Rate, Three-Color marker. It's a two-level hierarchical policer
which first does a color-blind marking of the traffic at the queue
level, followed by a color-aware marking
This patch adds support for multi-queue QoS to the DPDK datapath. Most of
the code is based on an earlier patch from a patchset sent out by
zhaozhanxu. The patch was titled "[ovs-dev, v2, 1/4] netdev-dpdk.c: Support
the multi-queue QoS configuration for dpdk datapath"
Co-authored-by: zhaozhanxu
When using TSO in OVS-DPDK with an i40e device, the following
commit is required for DPDK, which fixes an issue on the TSO path:
http://git.dpdk.org/next/dpdk-next-net/commit/?id=b2a4dc260139409c539fb8e7f1b9d0a5182cfd2b
Document this as a limitation until a DPDK release with the fix
included is
On 7 Jan 2020, at 19:33, Stokes, Ian wrote:
On 10/1/2019 3:10 PM, Eelco Chaudron wrote:
This patch adds a new policer to the DPDK datapath based on RFC
4115's
Two-Rate, Three-Color marker. It's a two-level hierarchical policer
which first does a color-blind marking of the traffic at the
On 11 Nov 2019, at 20:12, Stokes, Ian wrote:
On 10/1/2019 3:10 PM, Eelco Chaudron wrote:
This patch adds support for multi-queue QoS to the DPDK datapath.
Most of
the code is based on an earlier patch from a patchset sent out by
zhaozhanxu. The patch was titled "[ovs-dev, v2, 1/4]
--
*Dear Sir,*
*We are Located in the united kingdom, the famous brand John Lewis PLC, is
UK's largest multi-channel retailer with over 45 shops furnished with
European products. We are looking for new products to attract new customers
and also retain our existing ones, create new partnerships
--
*Dear Sir,*
*We are Located in the united kingdom, the famous brand John Lewis PLC, is
UK's largest multi-channel retailer with over 45 shops furnished with
European products. We are looking for new products to attract new customers
and also retain our existing ones, create new partnerships
>-Original Message-
>From: Ilya Maximets
>Sent: Thursday, January 9, 2020 3:28 PM
>To: Ophir Munk ; Ben Pfaff ; Ilya
>Maximets
>Cc: Eveline Raine ; d...@openvswitch.org; Moshe Levi
>; Adrian Chiris ; Majd Dibbiny
>; Roni Bar Yanai ; Ameer
>Mahagneh
>Subject: Re: [PATCH 1/1] vswitchd:
On Mon, Jan 13, 2020 at 6:03 PM Simon Horman wrote:
>
> Hi,
>
> On Mon, Jan 13, 2020 at 05:28:04PM +0800, Tonghao Zhang wrote:
> > On Fri, Jan 10, 2020 at 7:06 PM Simon Horman
> > wrote:
> > >
> > > From: John Hurley
> > >
> > > Openstack may set an skb mark of 0 in tunnel rules. This is
On 13/01/2020 08:36, Tonghao Zhang wrote:
> On Sat, Jan 11, 2020 at 12:37 AM Kevin Traynor wrote:
>>
>> Next meeting Jan 22nd 1700 UTC
>> (Ian will run meeting - may be cancelled if no agenda)
>>
>> January 8th minutes
>>
>> Attendees: David, Flavio, Ilya, Johann, Malvika, Aaron, Simon, Ian,
Hi,
On Mon, Jan 13, 2020 at 05:28:04PM +0800, Tonghao Zhang wrote:
> On Fri, Jan 10, 2020 at 7:06 PM Simon Horman
> wrote:
> >
> > From: John Hurley
> >
> > Openstack may set an skb mark of 0 in tunnel rules. This is considered to
> > be an unused/unset value. However, it prevents the rule
On Fri, Jan 10, 2020 at 7:06 PM Simon Horman wrote:
>
> From: John Hurley
>
> Openstack may set an skb mark of 0 in tunnel rules. This is considered to
> be an unused/unset value. However, it prevents the rule from being
> offloaded.
>
> Check if the key value of the skb mark is 0 when it is in
>
> In "Use of library functions" in the C standard, the following statement
> is written to apply to all library functions:
>
> If an argument to a function has an invalid value (such as ... a
> null pointer ... the behavior is undefined.
>
> Later, under the "String handling" section,
On Sat, Jan 11, 2020 at 12:37 AM Kevin Traynor wrote:
>
> Next meeting Jan 22nd 1700 UTC
> (Ian will run meeting - may be cancelled if no agenda)
>
> January 8th minutes
>
> Attendees: David, Flavio, Ilya, Johann, Malvika, Aaron, Simon, Ian, Kevin.
>
> - OVS 2.13 Release
> -- Feature Freeze is
Please lets make joint business
I am, Dr. Salifou Sambo a bank auditor, I am in-charge of transferring out
funds or my village, which our village generates from the sales of our local
mined gold. I have some left over fund in the bank here that I alone is aware
of, and wants to transfer it
40 matches
Mail list logo
