Re: [ovs-dev] [PATCH] ofproto:ipv6 mld report error send to fports

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings dingxiaoxiong, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author dingxiaoxiong needs to sign off. WARNING: Unexpected sign-offs from developers

[ovs-dev] Amazonセキュリティ警告: サインインが検出されました

2020-09-09 Thread Amazon.co.jp via dev
あなたのアカウントは停止されました 新しいデバイスからアカウントサービスへのサインインが検出されました。 誰かがあなたのAmazonアカウントで他のデバイスから購入しようとしました。Amazonの保護におけるセキュリティと整合性の問題により、セキュリティ上の理由からアカウントがロックされます。 アカウントを引き続き使用するには、24時間前に情報を更新することをお勧めします。それ以外の場合、あなたのアカウントは永久ロック。 確認用アカウント © 2020 Amazon.com, Inc. or its affiliates. All rights reserved.

[ovs-dev] [PATCH] ofproto:ipv6 mld report error send to fports

2020-09-09 Thread dingxiaoxiong
when mld report come(same as mld done), will do funciton xlate_normal_mcast_send_rports, and because of no return, will doforwarding to group base ports logic,and if other_config:mcast-snooping-flood is set on a port, will do xlate_normal_mcast_send_fports. so mld report will be reveived when

[ovs-dev] [PATCH v2 3/3] Fix tap interface status update issue in network namespace

2020-09-09 Thread yang_y_yi
From: Yi Yang Currently OVS can't get link state, mtu, mac, driver, etc. when tap interface is in network namespace, with netns option and netns helper functions, these info can be gotten. This patch fixed all these issues and make sure tap interface in network namespace can get same info as it

[ovs-dev] [PATCH v2 0/3] userspace: enable tap interface statistics and status update support

2020-09-09 Thread yang_y_yi
From: Yi Yang OVS userspace datapath can't support tap interface statistics and status update, so users can't get these information by cmd "ovs-vsctl list interface tap1", the root cause of this issue is OVS doesn't know network namespace of tap interface. This patch series fixed this issue and

[ovs-dev] [PATCH v2 1/3] Add netns option for tap interface in userspace datapath

2020-09-09 Thread yang_y_yi
From: Yi Yang In userspace datapath, "ovs-vsctl list interface" can't get interface statistics and there are many WARN log, we can enable it work normally if it has correct network namespace. This patch enabled netns option for tap interface , it is the prerequisite interface statistics and

[ovs-dev] [PATCH v2 2/3] Fix tap interface statistics issue

2020-09-09 Thread yang_y_yi
From: Yi Yang After tap interface is moved to network namespace, "ovs-vsctl list interface tapXXX" can get statistics info of tap interface, the root cause is OVS still gets statistics info in root namespace. With netns option help, OVS can get statistics info in tap interface netns. This

[ovs-dev] Motivos de fracaso de los presupuestos

2020-09-09 Thread Elaboración y control de presupuestos
Webinar en Vivo: Elaboración y control de presupuestos Curso en línea - Webinar Interactivo – Martes 29 de Septiembre- Horario de 10:00 a 14:00 Hrs. La constante evolución de la organización empresarial y de su entorno hace que el control presupuestario sea una herramienta básica para la

Re: [ovs-dev] [PATCH v2 22/24] acinclude: Enable builds up to Linux 5.8

2020-09-09 Thread Gregory Rose
On 9/9/2020 12:20 PM, Greg Rose wrote: Allow building openvswitch against Linux kernels up to and including version 5.8. Signed-off-by: Greg Rose --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Optionally skip the check of lsp_is_up.

2020-09-09 Thread Han Zhou
On Wed, Sep 9, 2020 at 4:15 AM Numan Siddique wrote: > > On Wed, Sep 9, 2020 at 2:52 AM Han Zhou wrote: > > > > The checking of lsp "up" status before adding ARP responder flows was > > added to avoid confusion in cases when a network admin sees ARP response > > for VM/containers that is not up

Re: [ovs-dev] [PATCH v2 20/24] datapath: Distribute switch variables for initialization

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Kees Cook needs to sign off. WARNING: Unexpected sign-offs from developers who are

Re: [ovs-dev] [PATCH v2 19/24] datapath: use skb_list_walk_safe helper for gso segments

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Jason A. Donenfeld needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH ovn v2 0/9] Incremental processing for flow installation.

2020-09-09 Thread Han Zhou
On Wed, Sep 9, 2020 at 6:39 AM Mark Michelson wrote: > > Thanks for addressing my concerns on patch 9. > > Acked-by: Mark Michelson > > Warning: I'm also ACKing Numan's patch series that also adds some > lflow-level caching (but he is caching expressions). So whoever loses > this merge race may

Re: [ovs-dev] [PATCH v2 18/24] datapath: support asymmetric conntrack

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author aaron conole needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH v2 17/24] datapath: remove another BUG_ON()

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Paolo Abeni needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH v2 16/24] datapath: drop unneeded BUG_ON() in ovs_flow_cmd_build_info()

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Paolo Abeni needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH v2 15/24] datapath: fix flow command message size

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Paolo Abeni needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH v2 14/24] datapath: don't call pad_packet if not necessary

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Tonghao Zhang needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH v2 13/24] datapath: select vport upcall portid directly

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Tonghao Zhang needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH v2 12/24] datapath: simplify the ovs_dp_cmd_new

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Tonghao Zhang needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH v2 11/24] datapath: fix possible memleak on destroy flow-table

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Tonghao Zhang needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH v2 09/24] datapath: simplify the flow_hash

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Tonghao Zhang needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH v2 07/24] datapath: don't unlock mutex when changing the user_features fails

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Tonghao Zhang needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH v2 06/24] datapath: fix GFP flags in rtnl_net_notifyid()

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Guillaume Nault needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH v2 05/24] datapath: Set OvS recirc_id from tc chain index

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Paul Blakey needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH v2 04/24] datapath: Print error when ovs_execute_actions() fails

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Yifeng Sun needs to sign off. WARNING: Unexpected sign-offs from developers who are

Re: [ovs-dev] [PATCH v2 03/24] datapath: do not update max_headroom if new headroom is equal to old headroom

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Taehee Yoo needs to sign off. WARNING: Unexpected sign-offs from developers who are

Re: [ovs-dev] [PATCH v2 02/24] datapath: drop unneeded likely() call around IS_ERR()

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Enrico Weigelt needs to sign off. WARNING: Unexpected sign-offs from developers who

Re: [ovs-dev] [PATCH v2 01/24] datapath: return an error instead of doing BUG_ON()

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Eelco Chaudron needs to sign off. WARNING: Unexpected sign-offs from developers who

[ovs-dev] [PATCH v2 11/24] datapath: fix possible memleak on destroy flow-table

2020-09-09 Thread Greg Rose
From: Tonghao Zhang Upstream commit: commit 50b0e61b32ee890a75b4377d5fbe770a86d6a4c1 Author: Tonghao Zhang Date: Fri Nov 1 22:23:52 2019 +0800 net: openvswitch: fix possible memleak on destroy flow-table When we destroy the flow tables which may contain the flow_mask,

[ovs-dev] [PATCH v2 23/24] travis: Update kernel list as of 5.8

2020-09-09 Thread Greg Rose
Update the list to more closely track the LTS releases on kernel.org. Signed-off-by: Greg Rose --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 43e6a75cc..9fd8bbe01 100644 --- a/.travis.yml +++ b/.travis.yml @@ -38,8 +38,8

Re: [ovs-dev] [PATCH v2 00/24] Add support for Linux kernels up to 5.8.x

2020-09-09 Thread Gregory Rose
On 9/9/2020 12:19 PM, Greg Rose wrote: This patch set will add support for Linux kernels up to 5.9. In addition there are quite a few patches for openvswitch on the Linux kernel mailing list that have not been backported - here is a first batch attempting to catch up on some of that technical

[ovs-dev] [PATCH v2 15/24] datapath: fix flow command message size

2020-09-09 Thread Greg Rose
From: Paolo Abeni Upstream commit: commit 4e81c0b3fa93d07653e2415fa71656b080a112fd Author: Paolo Abeni Date: Tue Nov 26 12:55:50 2019 +0100 openvswitch: fix flow command message size When user-space sets the OVS_UFID_F_OMIT_* flags, and the relevant flow has no UFID,

[ovs-dev] [PATCH v2 09/24] datapath: simplify the flow_hash

2020-09-09 Thread Greg Rose
From: Tonghao Zhang Upstream commit: commit 515b65a4b99197ae062a795ab4de919e6d04be04 Author: Tonghao Zhang Date: Fri Nov 1 22:23:50 2019 +0800 net: openvswitch: simplify the flow_hash Simplify the code and remove the unnecessary BUILD_BUG_ON. Signed-off-by: Tonghao

[ovs-dev] [PATCH v2 24/24] Documentation: Update faq and NEWS for kernel 5.8

2020-09-09 Thread Greg Rose
Update the NEWS and faq now that we will support up to Linux kernel 5.8. Signed-off-by: Greg Rose --- Documentation/faq/releases.rst | 1 + NEWS | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index

[ovs-dev] [PATCH v2 12/24] datapath: simplify the ovs_dp_cmd_new

2020-09-09 Thread Greg Rose
From: Tonghao Zhang Upstream commit: commit eec62eadd1d757b0743ccbde55973814f3ad396e Author: Tonghao Zhang Date: Fri Nov 1 22:23:54 2019 +0800 net: openvswitch: simplify the ovs_dp_cmd_new use the specified functions to init resource. Signed-off-by: Tonghao Zhang

[ovs-dev] [PATCH v2 03/24] datapath: do not update max_headroom if new headroom is equal to old headroom

2020-09-09 Thread Greg Rose
From: Taehee Yoo Upstream commit: commit 6b660c4177aaebdc73df7a3378f0e8b110aa4b51 Author: Taehee Yoo Date: Sat Jul 6 01:08:09 2019 +0900 net: openvswitch: do not update max_headroom if new headroom is equal to old headroom When a vport is deleted, the maximum headroom

[ovs-dev] [PATCH v2 10/24] datapath: add likely in flow_lookup

2020-09-09 Thread Greg Rose
From: Tonghao Zhang Upstream commit: commit 0a3e01371db17d753dd92ec4d0fc6247412d3b01 Author: Tonghao Zhang Date: Fri Nov 1 22:23:51 2019 +0800 net: openvswitch: add likely in flow_lookup The most case *index < ma->max, and flow-mask is not NULL. We add un/likely for

[ovs-dev] [PATCH v2 06/24] datapath: fix GFP flags in rtnl_net_notifyid()

2020-09-09 Thread Greg Rose
From: Guillaume Nault Upstream commit: commit d4e4fdf9e4a27c87edb79b1478955075be141f67 Author: Guillaume Nault Date: Wed Oct 23 18:39:04 2019 +0200 netns: fix GFP flags in rtnl_net_notifyid() In rtnl_net_notifyid(), we certainly can't pass a null GFP flag to

[ovs-dev] [PATCH v2 20/24] datapath: Distribute switch variables for initialization

2020-09-09 Thread Greg Rose
From: Kees Cook Upstream commit: commit 16a556eeb7ed2dc3709fe2c5be76accdfa4901ab Author: Kees Cook Date: Wed Feb 19 22:23:09 2020 -0800 openvswitch: Distribute switch variables for initialization Variables declared in a switch statement before any case statements

[ovs-dev] [PATCH v2 01/24] datapath: return an error instead of doing BUG_ON()

2020-09-09 Thread Greg Rose
From: Eelco Chaudron Upstream commit: commit a734d1f4c2fc962ef4daa179e216df84a8ec5f84 Author: Eelco Chaudron Date: Thu May 2 16:12:38 2019 -0400 net: openvswitch: return an error instead of doing BUG_ON() For all other error cases in queue_userspace_packet() the error is

[ovs-dev] [PATCH v2 04/24] datapath: Print error when ovs_execute_actions() fails

2020-09-09 Thread Greg Rose
From: Yifeng Sun Upstream commit: commit aa733660dbd8d9192b8c528ae0f4b84f3fef74e4 Author: Yifeng Sun Date: Sun Aug 4 19:56:11 2019 -0700 openvswitch: Print error when ovs_execute_actions() fails Currently in function ovs_dp_process_packet(), return values of

[ovs-dev] [PATCH v2 00/24] Add support for Linux kernels up to 5.8.x

2020-09-09 Thread Greg Rose
This patch set will add support for Linux kernels up to 5.9. In addition there are quite a few patches for openvswitch on the Linux kernel mailing list that have not been backported - here is a first batch attempting to catch up on some of that technical debt. There will be a follow up batch of

[ovs-dev] [PATCH v2 02/24] datapath: drop unneeded likely() call around IS_ERR()

2020-09-09 Thread Greg Rose
From: Enrico Weigelt Upstream commit: commit b90f5aa4d6268e81dd1fd51e5ef89d2892bf040d Author: Enrico Weigelt Date: Wed Jun 5 23:06:40 2019 +0200 net: openvswitch: drop unneeded likely() call around IS_ERR() IS_ERR() already calls unlikely(), so this extra likely() call

[ovs-dev] [PATCH v2 17/24] datapath: remove another BUG_ON()

2020-09-09 Thread Greg Rose
From: Paolo Abeni Upstream commit: commit 8a574f86652a4540a2433946ba826ccb87f398cc Author: Paolo Abeni Date: Sun Dec 1 18:41:25 2019 +0100 openvswitch: remove another BUG_ON() If we can't build the flow del notification, we can simply delete the flow, no need to

[ovs-dev] [PATCH v2 16/24] datapath: drop unneeded BUG_ON() in ovs_flow_cmd_build_info()

2020-09-09 Thread Greg Rose
From: Paolo Abeni Upstream commit: commit 8ffeb03fbba3b599690b361467bfd2373e8c450f Author: Paolo Abeni Date: Sun Dec 1 18:41:24 2019 +0100 openvswitch: drop unneeded BUG_ON() in ovs_flow_cmd_build_info() All the callers of ovs_flow_cmd_build_info() already deal with

[ovs-dev] [PATCH v2 19/24] datapath: use skb_list_walk_safe helper for gso segments

2020-09-09 Thread Greg Rose
From: "Jason A. Donenfeld" Upstream commit: commit 2cec4448db38758832c2edad439f99584bb8fa0d Author: Jason A. Donenfeld Date: Mon Jan 13 18:42:29 2020 -0500 net: openvswitch: use skb_list_walk_safe helper for gso segments This is a straight-forward conversion case for the

[ovs-dev] [PATCH v2 14/24] datapath: don't call pad_packet if not necessary

2020-09-09 Thread Greg Rose
From: Tonghao Zhang Upstream commit: commit 61ca533c0e94104c35fcb7858a23ec9a05d78143 Author: Tonghao Zhang Date: Thu Nov 14 23:51:08 2019 +0800 net: openvswitch: don't call pad_packet if not necessary The nla_put_u16/nla_put_u32 makes sure that *attrlen is align. The

[ovs-dev] [PATCH v2 05/24] datapath: Set OvS recirc_id from tc chain index

2020-09-09 Thread Greg Rose
From: Paul Blakey Upstream commit: commit 95a7233c452a58a4c2310c456c73997853b2ec46 Author: Paul Blakey Date: Wed Sep 4 16:56:37 2019 +0300 net: openvswitch: Set OvS recirc_id from tc chain index Offloaded OvS datapath rules are translated one to one to tc rules, for

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: Do not use zero-weight buckets in select groups.

2020-09-09 Thread Ilya Maximets
On 6/8/19 1:28 AM, Ben Pfaff wrote: > The OpenFlow specification says that buckets in select groups with a weight > of zero should not be selected, but the ofproto-dpif implementation could > select them in corner cases. This fixes the problem. > > Reported-by: ychen > Reported-at: >

[ovs-dev] FROM MRS SUSAN READ.

2020-09-09 Thread Mrs Susan Read via dev
Greetings, My name is Mrs. Susan Read, from United Kindom, I have been suffering from ovarian cancer disease and the doctor says that I have just a short time to live. And for the past Twelve years, I have being dealing on gold exportation, before this disease crippled me down. My late

Re: [ovs-dev] [PATCH] ofproto: Preserve ofport number for failed ofport across restarts

2020-09-09 Thread Ilya Maximets
>> >> I've been taking a look at this patch for the last few minutes. It >> introduces a lot >> of mechanism for the use case. Did you consider any simpler mechanisms to >> achieve the same effect? What prevented them from working? >> > I agree Ben. This change does bring some complexity to

Re: [ovs-dev] [PATCH v1] rhel: retain OVS_CTL_OPTS for systemd service files

2020-09-09 Thread Ilya Maximets
On 9/9/20 5:39 PM, Gregory Rose wrote: > > > On 9/9/2020 5:51 AM, Ilya Maximets wrote: >>> On 1/31/2019 10:38 AM, Aaron Conole wrote: Martin Xu writes: > OVS init.d script calls ovs-ctl with $OVS_CTL_OPTS defined in the > config file. This variable is replaced by OPTIONS in

Re: [ovs-dev] [PATCH] rhel: fix logrotate group when dpdk is enabled

2020-09-09 Thread Ilya Maximets
On 4/30/19 7:10 PM, Jaime Caamaño Ruiz wrote: > Otherwise logrotate will fail to generate the rotated log files. > > Signed-off-by: Jaime Caamaño Ruiz > --- Hi. I'm looking through old patches after the patchwork cleanup and this one seems to be still valid and applicable. I could apply it if

Re: [ovs-dev] [PATCH] vxlan: Make vxlan tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2020-09-09 Thread Ilya Maximets
On 3/30/19 6:28 AM, we...@ucloud.cn wrote: > From: wenxu > > There is currently no support for the multicast/broadcast aspects > of VXLAN in ovs. In the datapath flow the tun_dst must specific. > But in the IP_TUNNEL_INFO_BRIDGE mode the tun_dst can not be specific. > And the packet can forward

[ovs-dev] [OVN] failed to connect 5K networks to 5K routers

2020-09-09 Thread Tony Liu
Hi, Here is what I did. #1 Create 5K networks, 5K routers and 1 provider/physical network. All resources are created in NB and translated to SB properly. #2 Connect 5K routers to provider network. All resources are created and updated in NB properly, but SB is not fully updated. I did 3

Re: [ovs-dev] [PATCH v1] rhel: retain OVS_CTL_OPTS for systemd service files

2020-09-09 Thread Gregory Rose
On 9/9/2020 5:51 AM, Ilya Maximets wrote: On 1/31/2019 10:38 AM, Aaron Conole wrote: Martin Xu writes: OVS init.d script calls ovs-ctl with $OVS_CTL_OPTS defined in the config file. This variable is replaced by OPTIONS in systemd service files. This patch addes $OVS_CTL_OPTS back to be

[ovs-dev] FOESCO Informa

2020-09-09 Thread FOESCO
Buenos días Soy Alex Pons, director de FOESCO (Formación Estatal Continua). Llegadas estas fechas y como cada año, recordamos a todas las empresas Españolas su derecho a consumir el Crédito de Formación del que disponen para la formación de sus empleados, antes de su caducidad a final de año.

Re: [ovs-dev] [PATCH v7] dpif-netlink: distribute polling to discreet handlers

2020-09-09 Thread Mark Gray
On 09/09/2020 14:49, Flavio Leitner wrote: > >> error: >> -vport_del_channels(dpif, vport.port_no); >> +vport_del_channel(dpif, port_no); > > The port_no here is uint32_t but vport_del_channel() receives odp_port_t. > That breaks build: >

Re: [ovs-dev] [PATCH v7] dpif-netlink: distribute polling to discreet handlers

2020-09-09 Thread Flavio Leitner
Hi Mark, Found one issue, and then since another spin is needed I am suggesting a stylish improvement. On Tue, Sep 08, 2020 at 06:27:48PM +0100, Mark Gray wrote: > From: Aaron Conole > > Currently, the channel handlers are polled globally. On some > systems, this causes a thundering herd

[ovs-dev] [PATCH] conntrack: add generic IP protocol support

2020-09-09 Thread Eelco Chaudron
Currently, userspace conntrack only tracks TCP, UDP, and ICMP, and all other IP protocols are discarded, and the +inv state is returned. This is not in line with the kernel conntrack. Where if no L4 information can be extracted it's treated as generic L3. The change below mimics the behavior of

Re: [ovs-dev] [PATCH ovn v2 0/9] Incremental processing for flow installation.

2020-09-09 Thread Mark Michelson
Thanks for addressing my concerns on patch 9. Acked-by: Mark Michelson Warning: I'm also ACKing Numan's patch series that also adds some lflow-level caching (but he is caching expressions). So whoever loses this merge race may have some work to do in order to apply their patch cleanly. On

Re: [ovs-dev] [PATCH ovn v2 3/4] expr: Evaluate the condition expression in a separate step.

2020-09-09 Thread Mark Michelson
For the whole series: Acked-by: Mark Michelson However, there are a few nits for this particular patch that I think should be addressed before committing: 1) The commit message says expr_simply() instead of expr_simplify() 2) The comment above expr_normalize() in expr.c needs to be updated

Re: [ovs-dev] [PATCH v1] rhel: retain OVS_CTL_OPTS for systemd service files

2020-09-09 Thread Ilya Maximets
> On 1/31/2019 10:38 AM, Aaron Conole wrote: >> Martin Xu writes: >> >>> OVS init.d script calls ovs-ctl with $OVS_CTL_OPTS defined in the >>> config file. This variable is replaced by OPTIONS in systemd service >>> files. This patch addes $OVS_CTL_OPTS back to be passed along with $OPTIONS >>>

Re: [ovs-dev] [PATCH] Update tutorial for newer versions of Faucet and Open vSwitch.

2020-09-09 Thread Ilya Maximets
On 9/12/18 1:53 AM, Brad Cowie wrote: > Newer versions of Faucet use a dynamic OpenFlow pipeline based on what > features are enabled in the configuration file. Update log output, flow > table dumps and explanations to be consistent with newer Faucet versions. > > Remove mentions of bugs that we

Re: [ovs-dev] [PATCH ovn] Replace ds_put_* evaluating to constant expressions

2020-09-09 Thread Anton Ivanov
On 09/09/2020 12:20, Ilya Maximets wrote: On 9/9/20 11:02 AM, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov Replaces ds_put_cstr and ds_put_format which evaluate to constant expressions with string constants Signed-off-by: Anton Ivanov --- Hi. Thanks for the fix! One general

Re: [ovs-dev] [Windows] Update documentation and build

2020-09-09 Thread Ilya Maximets
On 9/8/20 10:48 PM, Alin Gabriel Serdean wrote: > The following patchset contains small updates in the build process and > corresponding documentation. > > Alin Serdean (8): > windows: Remove unused variable > windows: Add default value for VSTUDIO_CONFIG > datapath_windows: Add

Re: [ovs-dev] [PATCH ovn] Replace ds_put_* evaluating to constant expressions

2020-09-09 Thread Ilya Maximets
On 9/9/20 11:02 AM, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov > > Replaces ds_put_cstr and ds_put_format which evaluate to > constant expressions with string constants > > Signed-off-by: Anton Ivanov > --- Hi. Thanks for the fix! One general comment to almost all of your

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Optionally skip the check of lsp_is_up.

2020-09-09 Thread Numan Siddique
On Wed, Sep 9, 2020 at 2:52 AM Han Zhou wrote: > > The checking of lsp "up" status before adding ARP responder flows was > added to avoid confusion in cases when a network admin sees ARP response > for VM/containers that is not up on chassis yet. However, this check > introduces an extra round of

Re: [ovs-dev] [PATCH ovn] Replace ds_put_* evaluating to constant expressions

2020-09-09 Thread Numan Siddique
On Wed, Sep 9, 2020 at 2:33 PM wrote: > > From: Anton Ivanov > > Replaces ds_put_cstr and ds_put_format which evaluate to > constant expressions with string constants > > Signed-off-by: Anton Ivanov Acked-by: Numan Siddique Thanks Numan > --- > northd/ovn-northd.c | 56

Re: [ovs-dev] [PATCH v1 1/1] DPDK: Remove support for vhost-user zero-copy.

2020-09-09 Thread Kevin Traynor
On 08/09/2020 16:26, Ian Stokes wrote: > Support for vhost-user dequeue zero-copy was deprecated in OVS 2.14 with > the aim of removing it for OVS 2.15. Support for zero-copy will also be > removed from DPDK 20.11. As such remove support from OVS. > Maybe you can add some links to the DPDK

Re: [ovs-dev] [PATCH ovn] Remove duplicate include file

2020-09-09 Thread Numan Siddique
On Wed, Sep 9, 2020 at 3:36 PM Yi Li wrote: > > Signed-off-by: Yi Li Thanks. I applied this patch to master. Numan' > --- > controller/bfd.c | 1 - > controller/pinctrl.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/controller/bfd.c b/controller/bfd.c > index

Re: [ovs-dev] [PATCH ovn 3/4] expr: Evaluate the condition expression in a separate step.

2020-09-09 Thread Numan Siddique
On Wed, Sep 9, 2020 at 1:32 AM Mark Michelson wrote: > > I know this is weird because I ACKed this exact patch once in the past, > but I found a small issue. See below: > > On 9/2/20 2:46 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > This patch was committed earlier [1] and then

[ovs-dev] [PATCH ovn v2 3/4] expr: Evaluate the condition expression in a separate step.

2020-09-09 Thread numans
From: Numan Siddique A similar patch was committed earlier [1] and then reverted [2]. This patch is similar to [1], but not exactly same. A new function is added - expr_evaluate_condition() which evaluates the condition expression - is_chassis_resident. expr_simply() will no longer evaluates

[ovs-dev] [PATCH ovn v2 4/4] ovn-controller: Cache logical flow expr matches.

2020-09-09 Thread numans
From: Numan Siddique This patch is a second attempt in caching the expr tree of logical flows. Earlier attemp [1] was reverted. In this approach, we do the following - If a logical flow match has any port group/address set references, we don't cache expr match or expr tree. - If a

[ovs-dev] [PATCH ovn v2 1/4] I-P engine: Provide the option to store client data in engine ctx.

2020-09-09 Thread numans
From: Numan Siddique There can be some client specific data which could change from one engine run to another. Adding a 'void *' data in 'struct engine_ctx' will be useful. One such usecase is to provide a config option in ovn-controller to turn on or off logical flow expr caching. And this

[ovs-dev] [PATCH ovn v2 2/4] ovn-controller: Persist the conjunction ids allocated for conjuctive matches.

2020-09-09 Thread numans
From: Numan Siddique For a logical flow which results in conjuctive OF matches, we are not persisting the allocated conjunction ids for it. There are few side effects because of this. - When a port group or address set gets modified, the logical flows which references these port

[ovs-dev] [PATCH ovn v2 0/4] Another attempt on lflow expr caching.

2020-09-09 Thread numans
From: Numan Siddique This patch series adds caching of logical flow expr matches/expr tree so that whenever a logical flow is processed, we can reuse the cached expr tree of expr matches. The expr matches/tree is not cached for a logical flow referencing port group/address sets as it is tricky

[ovs-dev] [PATCH ovn] Remove duplicate include file

2020-09-09 Thread Yi Li
Signed-off-by: Yi Li --- controller/bfd.c | 1 - controller/pinctrl.c | 1 - 2 files changed, 2 deletions(-) diff --git a/controller/bfd.c b/controller/bfd.c index b305eb15..cf011e38 100644 --- a/controller/bfd.c +++ b/controller/bfd.c @@ -17,7 +17,6 @@ #include "bfd.h" #include

Re: [ovs-dev] [PATCH] Remove duplicate include file

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Yi Li, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (controller/bfd.c). error: could not build fake ancestor

[ovs-dev] [PATCH] Remove duplicate include file

2020-09-09 Thread Yi Li
Signed-off-by: Yi Li --- controller/bfd.c | 1 - controller/pinctrl.c | 1 - 2 files changed, 2 deletions(-) diff --git a/controller/bfd.c b/controller/bfd.c index b305eb15..cf011e38 100644 --- a/controller/bfd.c +++ b/controller/bfd.c @@ -17,7 +17,6 @@ #include "bfd.h" #include

[ovs-dev] [PATCH ovn] Replace ds_put_* evaluating to constant expressions

2020-09-09 Thread anton . ivanov
From: Anton Ivanov Replaces ds_put_cstr and ds_put_format which evaluate to constant expressions with string constants Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 56 ++--- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git

Re: [ovs-dev] [PATCH ovn v2] ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 91 characters long (recommended limit is 79) #32 FILE:

Re: [ovs-dev] [PATCH v1] NEWS: Add external ip based NAT support

2020-09-09 Thread Numan Siddique
On Wed, Sep 9, 2020 at 1:28 AM Ankur Sharma wrote: > > Signed-off-by: Ankur Sharma Thanks. I applied the patch to master. I think you forgot to add the "ovn" tag in the subject prefix :). Now that we have a separate patchwork for OVN, please add this tag for future patches. Thanks Numan >

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb

2020-09-09 Thread Numan Siddique
On Wed, Sep 9, 2020 at 2:31 AM Mark Michelson wrote: > > This needs a rebase because commit > 413cf9864024c4ef253ea177435161af198d5784 changed the way that the ovsdb > server is started. Thanks for the review. I submitted v2 -

[ovs-dev] [PATCH ovn v2] ovn-ctl: Handle cluster db upgrades for run_(nb/sb)_ovsdb

2020-09-09 Thread numans
From: Numan Siddique when ovn-ctl run_(nb_sb)_ovsdb is called, the ovsdb-server is started without passing --detach and --monoitor and the process is exec'd. For cluster mode, upgrade_cluster is never called and hence the dbs are not upraded to new schema. CMS has to handle the db upgrade

Re: [ovs-dev] [PATCH v2] userspace: fix bad UDP performance issue of veth

2020-09-09 Thread 0-day Robot
Bleep bloop. Greetings yang_y_yi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #204 FILE:

[ovs-dev] [PATCH v2] userspace: fix bad UDP performance issue of veth

2020-09-09 Thread yang_y_yi
From: Yi Yang iperf3 UDP performance of veth to veth case is very very bad because of too many packet loss, the root cause is rmem_default and wmem_default are just 212992, but iperf3 UDP test used 8K UDP size which resulted in many UDP fragment in case that MTU size is 1500, one 8K UDP send