Re: [ovs-dev] OVN 20.09 Soft freeze

On Wed, Sep 16, 2020 at 2:13 PM Numan Siddique wrote: > > Hi All, > > branch-20.09 has been created. Please note that after the soft freeze, there > have been few bug fixes > and Anton's most of the build_lrouter_flows refactor patches have been > applied by me. Since those > patches split the

[ovs-dev] [PATCH v7 ovn] Add VXLAN support for non-VTEP datapath bindings

Because of limited space in VXLAN VNI to pass over all three of - datapath id, ingress port, egress port - the implementation ignores ingress; and splits the remaining 24 bits of VNI into two chunks, 12 bits each - one for datapath and one for egress port. This also bumps priority for ramp switch

Re: [ovs-dev] [PATCH v3 0/2] NAT port range support

Hi Numan, Sure, just submitted the V4. Regards, Ankur From: Numan Siddique Sent: Wednesday, September 16, 2020 12:52 AM To: svc.mail.git ; Ankur Sharma Cc: ovs-dev Subject: Re: [ovs-dev] [PATCH v3 0/2] NAT port range support On Wed, Sep 16, 2020 at 5:35 AM

[ovs-dev] [PATCH v4 2/2 ovn] NAT: Northd and parser changes to support port

From: Ankur Sharma This patch has following changes: a. Northd changes to put port range hash in the logical flow based on configuration. b. Changes to parse the logical flow, which specifies port_range_hash along with port_range for ct_nat action. Example logical flow:

[ovs-dev] [PATCH v4 0/2 ovn] NAT port range support

From: Ankur Sharma OVS supports additional paramaters while programming ct_nat rules. In continuation to 509733c, this series adds support for specifying a hashing algorithm, to be used while picking a port number from given range Ankur Sharma (2): NAT: Provide port hash in input NAT:

[ovs-dev] [PATCH v4 1/2 ovn] NAT: Provide port hash in input

From: Ankur Sharma This patch enhances the NB OVSSCHEMA to add an additional column in NAT table. external_port_hash: Specifies the hashing mechanism if port range is specified. Changes also add corresponding ovn-nbctl cli. Signed-off-by: Ankur Sharma ---

[ovs-dev] [PATCH v6 ovn] Allow to run multiple controllers on the same machine

User stories: 1) NFV: an admin wants to run two separate instances of OVN controller using the same database but configuring ports on different bridges. Some of these bridges may use DPDK while others may not. 2) Parallel OVN instances: an admin wants to run two separate instances of OVN

[ovs-dev] 答复: [PATCH v2] userspace: fix bad UDP performance issue of veth

Aaron, thank you so much for comments, I'll update it to fix your comment in v3, replies for comments inline, please check them. -邮件原件- 发件人: dev [mailto:ovs-dev-boun...@openvswitch.org] 代表 Aaron Conole 发送时间: 2020年9月17日 1:17 收件人: yang_y...@163.com 抄送: ovs-dev@openvswitch.org;

[ovs-dev] 答复: [PATCH v2 0/3] userspace: enable tap interface statistics and status update support

Aaron, any caller thread just binds it to netns on calling enter_netns, once it has entered netns, it won't disappear, so exit_netns caller thread must be current thread, once it exits netns, it returns back to original root netns, at this point, this thread can disappear, not a question, isn't

[ovs-dev] Slow internet means everyone has a bad day. Put this ONE simple device next to your router.

Having trouble viewing this email? Please follow this link to see the messaged emailed to you. [Unsubscribe Instructions Here] ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] Internet is slow. Here's a one-time fix to add TRIPLE the speed.

Having trouble viewing this email? Please follow this link to see the messaged emailed to you. [Unsubscribe Instructions Here] ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/1] daemon-unix: Support OVS-DPDK HW offloads for non-root user

David Marchand writes: > On Tue, Sep 15, 2020 at 12:52 PM Ameer Mahagneh wrote: >> >> For security reasons only root or privileged user can allocate Interconnect >> Context Memory (ICM). Add this capability for vendors that require ICM >> allocation when applying DPDK rte flows. >> >>

Re: [ovs-dev] [PATCH ovn v2 1/2] lflow.c: Avoid adding redundant resource refs for port-bindings.

On Wed, Sep 16, 2020 at 11:55 AM Dumitru Ceara wrote: > > On 9/16/20 8:02 PM, Han Zhou wrote: > > > > > > On Wed, Sep 16, 2020 at 5:10 AM Dumitru Ceara > > wrote: > >> > >> Hi Han, > >> > >> On 9/15/20 8:40 PM, Han Zhou wrote: > >> > When a lport is referenced by a

[ovs-dev] Timeshare notice

Having trouble viewing this email? Please follow this link to see the messaged emailed to you. Product Image Product Image (Unsubscribe Instructions Here) Product Image ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH ovn] inc-proc: Rename EN_VALID to EN_UNCHANGED

On 9/16/20 5:56 PM, Mark Gray wrote: > EN_VALID does not reflect the meaning of this state. For > example, EN_UPDATED is also "valid". > > Signed-off-by: Mark Gray > --- Hi Mark, This looks better indeed! Acked-by: Dumitru Ceara Thanks, Dumitru

Re: [ovs-dev] [PATCH ovn v2 2/2] lflow.c: Release ref_lflow_node as soon as it is not needed.

On 9/16/20 8:36 PM, Han Zhou wrote: > > > On Wed, Sep 16, 2020 at 10:51 AM Dumitru Ceara > wrote: >> >> On 9/16/20 2:18 PM, Dumitru Ceara wrote: >> >> [...] >> >> > >> >> +            hmap_remove(>ref_lflow_table, >rlfn->node); >> >> +            

Re: [ovs-dev] [PATCH ovn v2 1/2] lflow.c: Avoid adding redundant resource refs for port-bindings.

On 9/16/20 8:02 PM, Han Zhou wrote: > > > On Wed, Sep 16, 2020 at 5:10 AM Dumitru Ceara > wrote: >> >> Hi Han, >> >> On 9/15/20 8:40 PM, Han Zhou wrote: >> > When a lport is referenced by a logical flow where port-binding refs >> > needs to be added, currently it can

[ovs-dev] Health issues? This 2 Minute Ritual Is Destroying Medical Conditions ...

Having trouble viewing this email? Please follow this link to see the messaged emailed to you. (Unsubscribe Instructions Here) ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v2 2/2] lflow.c: Release ref_lflow_node as soon as it is not needed.

On Wed, Sep 16, 2020 at 10:51 AM Dumitru Ceara wrote: > > On 9/16/20 2:18 PM, Dumitru Ceara wrote: > > [...] > > > > >> +hmap_remove(>ref_lflow_table, >rlfn->node); > >> +ref_lflow_node_destroy(lrln->rlfn); > > > > As mentioned on v1 (at least for me) it's really hard to

Re: [ovs-dev] OVN 20.09 Soft freeze

Hi All, branch-20.09 has been created. Please note that after the soft freeze, there have been few bug fixes and Anton's most of the build_lrouter_flows refactor patches have been applied by me. Since those patches split the code into functions, I thought of including them before creating the

Re: [ovs-dev] [PATCH ovn v3 2/2] Prepare for post-20.09.0 (20.09.90).

On Wed, Sep 16, 2020 at 5:54 PM Dumitru Ceara wrote: > On 9/16/20 1:54 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > Signed-off-by: Numan Siddique > > Acked-by: Dumitru Ceara > Thanks Dumitru. I applied this patch to master. Numan > > Thanks, > Dumitru > >

Re: [ovs-dev] [PATCH ovn v3 1/2] Prepare for 20.09.0.

On Wed, Sep 16, 2020 at 5:54 PM Dumitru Ceara wrote: > On 9/16/20 1:54 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > Signed-off-by: Numan Siddique > > Acked-by: Dumitru Ceara > Thanks Dumitru. I applied this patch to master and created the branch 'branch-20.09'. Thanks Numan

Re: [ovs-dev] [PATCH ovn v2 1/2] lflow.c: Avoid adding redundant resource refs for port-bindings.

On Wed, Sep 16, 2020 at 5:10 AM Dumitru Ceara wrote: > > Hi Han, > > On 9/15/20 8:40 PM, Han Zhou wrote: > > When a lport is referenced by a logical flow where port-binding refs > > needs to be added, currently it can add the same reference pair multiple > > times in below situations (introduced

[ovs-dev] [PATCH] system-userspace-packet-type-aware.at: Wait for ip address updates.

ovs-router module checks for the source ip address of the interface while adding a new route. netdev module doesn't request ip addresses from the system every time, but instead it caches currently assigned ip addresses and updates the cache on netlink notifications if needed. So, there is a

[ovs-dev] [PATCH ovn v3 1/2] lflow.c: Avoid adding redundant resource refs for port-bindings.

When a lport is referenced by a logical flow where port-binding refs needs to be added, currently it can add the same reference pair multiple times in below situations (introduced in commit ade4e77): 1) In add_matches_to_flow_table(), different matches from same lflow can have same

[ovs-dev] [PATCH ovn v3 2/2] lflow.c: Release ref_lflow_node as soon as it is not needed.

If a resource doesn't have any lflows referencing it any more, the node ref_lflow_node in lflow_resource_ref.ref_lflow_table should be removed and released. Otherwise, the table could keep growing in some scenarios, until a recompute is triggered. Now that the chance of triggering recompute is

Re: [ovs-dev] [PATCH ovn v2 2/2] lflow.c: Release ref_lflow_node as soon as it is not needed.

On 9/16/20 2:18 PM, Dumitru Ceara wrote: [...] > >> +hmap_remove(>ref_lflow_table, >rlfn->node); >> +ref_lflow_node_destroy(lrln->rlfn); > > As mentioned on v1 (at least for me) it's really hard to keep track of > what's going on due to the variable/field names, e.g.,

[ovs-dev] [PATCH V3 24/24] Documentation: Update faq and NEWS for kernel 5.8

Update the NEWS and faq now that we will support up to Linux kernel 5.8. Signed-off-by: Greg Rose --- Documentation/faq/releases.rst | 1 + NEWS | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index

[ovs-dev] [PATCH V3 16/24] datapath: drop unneeded BUG_ON() in ovs_flow_cmd_build_info()

From: Paolo Abeni Upstream commit: commit 8ffeb03fbba3b599690b361467bfd2373e8c450f Author: Paolo Abeni Date: Sun Dec 1 18:41:24 2019 +0100 openvswitch: drop unneeded BUG_ON() in ovs_flow_cmd_build_info() All the callers of ovs_flow_cmd_build_info() already deal with

[ovs-dev] [PATCH V3 07/24] datapath: don't unlock mutex when changing the user_features fails

From: Tonghao Zhang Upstream commit: commit 4c76bf696a608ea5cc555fe97ec59a9033236604 Author: Tonghao Zhang Date: Fri Nov 1 22:23:53 2019 +0800 net: openvswitch: don't unlock mutex when changing the user_features fails Unlocking of a not locked mutex is not allowed.

[ovs-dev] [PATCH V3 14/24] datapath: don't call pad_packet if not necessary

From: Tonghao Zhang Upstream commit: commit 61ca533c0e94104c35fcb7858a23ec9a05d78143 Author: Tonghao Zhang Date: Thu Nov 14 23:51:08 2019 +0800 net: openvswitch: don't call pad_packet if not necessary The nla_put_u16/nla_put_u32 makes sure that *attrlen is align. The

[ovs-dev] [PATCH V3 20/24] datapath: Distribute switch variables for initialization

From: Kees Cook Upstream commit: commit 16a556eeb7ed2dc3709fe2c5be76accdfa4901ab Author: Kees Cook Date: Wed Feb 19 22:23:09 2020 -0800 openvswitch: Distribute switch variables for initialization Variables declared in a switch statement before any case statements

[ovs-dev] [PATCH V3 19/24] datapath: use skb_list_walk_safe helper for gso segments

From: "Jason A. Donenfeld" Upstream commit: commit 2cec4448db38758832c2edad439f99584bb8fa0d Author: Jason A. Donenfeld Date: Mon Jan 13 18:42:29 2020 -0500 net: openvswitch: use skb_list_walk_safe helper for gso segments This is a straight-forward conversion case for the

[ovs-dev] [PATCH V3 18/24] datapath: support asymmetric conntrack

From: aaron conole Upstream commit: commit 5d50aa83e2c8e91ced2cca77c198b468ca9210f4 author: aaron conole date: tue dec 3 16:34:13 2019 -0500 openvswitch: support asymmetric conntrack the openvswitch module shares a common conntrack and nat infrastructure exposed via

[ovs-dev] [PATCH V3 15/24] datapath: fix flow command message size

From: Paolo Abeni Upstream commit: commit 4e81c0b3fa93d07653e2415fa71656b080a112fd Author: Paolo Abeni Date: Tue Nov 26 12:55:50 2019 +0100 openvswitch: fix flow command message size When user-space sets the OVS_UFID_F_OMIT_* flags, and the relevant flow has no UFID,

[ovs-dev] [PATCH V3 22/24] acinclude: Enable builds up to Linux 5.8

Allow building openvswitch against Linux kernels up to and including version 5.8. Signed-off-by: Greg Rose --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 3d56510a0..1460289ca 100644 --- a/acinclude.m4 +++ b/acinclude.m4

[ovs-dev] [PATCH V3 23/24] travis: Update kernel list as of 5.8

Update the list to more closely track the LTS releases on kernel.org. Signed-off-by: Greg Rose --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 43e6a75cc..9fd8bbe01 100644 --- a/.travis.yml +++ b/.travis.yml @@ -38,8 +38,8

[ovs-dev] [PATCH V3 13/24] datapath: select vport upcall portid directly

From: Tonghao Zhang Upstream commit: commit 90ce9f23a886bdef7a4b7a9bd52c7a50a6a81635 Author: Tonghao Zhang Date: Thu Nov 7 00:34:28 2019 +0800 net: openvswitch: select vport upcall portid directly The commit 69c51582ff786 ("dpif-netlink: don't allocate per thread

[ovs-dev] [PATCH V3 11/24] datapath: fix possible memleak on destroy flow-table

From: Tonghao Zhang Upstream commit: commit 50b0e61b32ee890a75b4377d5fbe770a86d6a4c1 Author: Tonghao Zhang Date: Fri Nov 1 22:23:52 2019 +0800 net: openvswitch: fix possible memleak on destroy flow-table When we destroy the flow tables which may contain the flow_mask,

[ovs-dev] [PATCH V3 21/24] datapath: use hlist_for_each_entry_rcu instead of hlist_for_each_entry

From: Tonghao Zhang Upstream commit: commit 64948427a63f49dd0ce403388d232f22cc1971a8 Author: Tonghao Zhang Date: Thu Mar 26 04:27:24 2020 +0800 net: openvswitch: use hlist_for_each_entry_rcu instead of hlist_for_each_entry The struct sw_flow is protected by RCU, when

[ovs-dev] [PATCH V3 03/24] datapath: do not update max_headroom if new headroom is equal to old headroom

From: Taehee Yoo Upstream commit: commit 6b660c4177aaebdc73df7a3378f0e8b110aa4b51 Author: Taehee Yoo Date: Sat Jul 6 01:08:09 2019 +0900 net: openvswitch: do not update max_headroom if new headroom is equal to old headroom When a vport is deleted, the maximum headroom

[ovs-dev] [PATCH V3 10/24] datapath: add likely in flow_lookup

From: Tonghao Zhang Upstream commit: commit 0a3e01371db17d753dd92ec4d0fc6247412d3b01 Author: Tonghao Zhang Date: Fri Nov 1 22:23:51 2019 +0800 net: openvswitch: add likely in flow_lookup The most case *index < ma->max, and flow-mask is not NULL. We add un/likely for

[ovs-dev] [PATCH V3 09/24] datapath: simplify the flow_hash

From: Tonghao Zhang Upstream commit: commit 515b65a4b99197ae062a795ab4de919e6d04be04 Author: Tonghao Zhang Date: Fri Nov 1 22:23:50 2019 +0800 net: openvswitch: simplify the flow_hash Simplify the code and remove the unnecessary BUILD_BUG_ON. Signed-off-by: Tonghao

[ovs-dev] [PATCH V3 12/24] datapath: simplify the ovs_dp_cmd_new

From: Tonghao Zhang Upstream commit: commit eec62eadd1d757b0743ccbde55973814f3ad396e Author: Tonghao Zhang Date: Fri Nov 1 22:23:54 2019 +0800 net: openvswitch: simplify the ovs_dp_cmd_new use the specified functions to init resource. Signed-off-by: Tonghao Zhang

[ovs-dev] [PATCH V3 06/24] datapath: fix GFP flags in rtnl_net_notifyid()

From: Guillaume Nault Upstream commit: commit d4e4fdf9e4a27c87edb79b1478955075be141f67 Author: Guillaume Nault Date: Wed Oct 23 18:39:04 2019 +0200 netns: fix GFP flags in rtnl_net_notifyid() In rtnl_net_notifyid(), we certainly can't pass a null GFP flag to

[ovs-dev] [PATCH V3 08/24] datapath: optimize flow-mask looking up

From: Tonghao Zhang Upstream commit: commit 57f7d7b9164426c496300d254fd5167fbbf205ea Author: Tonghao Zhang Date: Fri Nov 1 22:23:49 2019 +0800 net: openvswitch: optimize flow-mask looking up The full looking up on flow table traverses all mask array. If mask-array is

[ovs-dev] [PATCH V3 17/24] datapath: remove another BUG_ON()

From: Paolo Abeni Upstream commit: commit 8a574f86652a4540a2433946ba826ccb87f398cc Author: Paolo Abeni Date: Sun Dec 1 18:41:25 2019 +0100 openvswitch: remove another BUG_ON() If we can't build the flow del notification, we can simply delete the flow, no need to

[ovs-dev] [PATCH V3 04/24] datapath: Print error when ovs_execute_actions() fails

From: Yifeng Sun Upstream commit: commit aa733660dbd8d9192b8c528ae0f4b84f3fef74e4 Author: Yifeng Sun Date: Sun Aug 4 19:56:11 2019 -0700 openvswitch: Print error when ovs_execute_actions() fails Currently in function ovs_dp_process_packet(), return values of

[ovs-dev] [PATCH V3 05/24] datapath: Set OvS recirc_id from tc chain index

From: Paul Blakey Upstream commit: commit 95a7233c452a58a4c2310c456c73997853b2ec46 Author: Paul Blakey Date: Wed Sep 4 16:56:37 2019 +0300 net: openvswitch: Set OvS recirc_id from tc chain index Offloaded OvS datapath rules are translated one to one to tc rules, for

[ovs-dev] [PATCH V3 00/24] Add support for Linux kernels up to 5.8.x

This patch set will add support for Linux kernels up to 5.9. In addition there are quite a few patches for openvswitch on the Linux kernel mailing list that have not been backported - here is a first batch attempting to catch up on some of that technical debt. There will be a follow up batch of

[ovs-dev] [PATCH V3 02/24] datapath: drop unneeded likely() call around IS_ERR()

From: Enrico Weigelt Upstream commit: commit b90f5aa4d6268e81dd1fd51e5ef89d2892bf040d Author: Enrico Weigelt Date: Wed Jun 5 23:06:40 2019 +0200 net: openvswitch: drop unneeded likely() call around IS_ERR() IS_ERR() already calls unlikely(), so this extra likely() call

[ovs-dev] [PATCH V3 01/24] datapath: return an error instead of doing BUG_ON()

From: Eelco Chaudron Upstream commit: commit a734d1f4c2fc962ef4daa179e216df84a8ec5f84 Author: Eelco Chaudron Date: Thu May 2 16:12:38 2019 -0400 net: openvswitch: return an error instead of doing BUG_ON() For all other error cases in queue_userspace_packet() the error is

Re: [ovs-dev] [PATCH v2] userspace: fix bad UDP performance issue of veth

yang_y...@163.com writes: > From: Yi Yang > > iperf3 UDP performance of veth to veth case is > very very bad because of too many packet loss, > the root cause is rmem_default and wmem_default > are just 212992, but iperf3 UDP test used 8K > UDP size which resulted in many UDP fragment in > case

Re: [ovs-dev] [PATCH v6 ovn] Add VXLAN support for non-VTEP datapath bindings

On Wed, Sep 16, 2020 at 7:32 AM Ihar Hrachyshka wrote: > Because of limited space in VXLAN VNI to pass over all three of - > datapath id, ingress port, egress port - the implementation ignores > ingress; and splits the remaining 24 bits of VNI into two chunks, 12 > bits each - one for datapath

[ovs-dev] [PATCH ovn 5/5] ovn-northd: move NAT, DEFRAG and LB to a helper function

From: Anton Ivanov This moves NAT, DEFRAG and load balancing out of build_lrouter_flows() and into a helper function. Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 1327 ++- 1 file changed, 672 insertions(+), 655 deletions(-) diff --git

[ovs-dev] [PATCH ovn 3/5] ovn-northd: move dhcpv6 reply in build_lrouter_flows() to a function

From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 45 +++-- 1 file changed, 27 insertions(+), 18 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index c3149d547..e81e7722a 100644 --- a/northd/ovn-northd.c +++

[ovs-dev] [PATCH ovn 4/5] ovn-northd: move ipv6 input flows out of build_lrouter_flows()

From: Anton Ivanov Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 271 +++- 1 file changed, 140 insertions(+), 131 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index e81e7722a..6687fe631 100644 --- a/northd/ovn-northd.c +++

[ovs-dev] [PATCH ovn 1/5] ovn-northd: Move out misc build_lrouter_flows() local deny rules into a function

From: Anton Ivanov This moves various rules which deny local traffic which should not be forwarded such as ND, RA, ARP, etc into a separate function. Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 200 +++- 1 file changed, 105 insertions(+), 95

[ovs-dev] [PATCH ovn 2/5] ovn-northd: move IPv4 input lrouter flow generation into functions

From: Anton Ivanov Move out IPv4 input lrouter flow generation into a helper function and split it into more manageable chunks. Signed-off-by: Anton Ivanov --- northd/ovn-northd.c | 841 +++- 1 file changed, 441 insertions(+), 400 deletions(-) diff

[ovs-dev] Remaining patches to reorganize build_lrouter_flows()

Hi, Follows a series of patches to finish the reorg of build_lrouter_flows(). I have followed Numan's naming conventions and I have split one of the larger chunks of code (ipv4 input) into several smaller pieces. There is still one large monolitic chunk of code remaining - NAT/DEFRAG/LB. I

Re: [ovs-dev] [PATCH v2 0/3] userspace: enable tap interface statistics and status update support

yang_y...@163.com writes: > From: Yi Yang > > OVS userspace datapath can't support tap interface statistics > and status update, so users can't get these information by cmd > "ovs-vsctl list interface tap1", the root cause of this issue > is OVS doesn't know network namespace of tap interface. >

[ovs-dev] FUNDS TRANSFER.

FUNDS TRANSFER. Good Day, I work as the accountant and auditor manager in a Bank here in South Africa; I have a very confidential Business Proposition for you. There is a huge amount of money floating in the bank unclaimed. Belonging to the bank foreign customer whom dies with his entire family

Re: [ovs-dev] [PATCH 1/1] daemon-unix: Support OVS-DPDK HW offloads for non-root user

On Tue, Sep 15, 2020 at 12:52 PM Ameer Mahagneh wrote: > > For security reasons only root or privileged user can allocate Interconnect > Context Memory (ICM). Add this capability for vendors that require ICM > allocation when applying DPDK rte flows. > > Signed-off-by: Ameer Mahagneh > Acked-by:

Re: [ovs-dev] [PATCH ovn] lflow.c: Rename function convert_acts_to_expr to convert_match_to_expr.

On Wed, Sep 16, 2020 at 7:28 AM Dumitru Ceara wrote: > > On 9/16/20 4:04 PM, Numan Siddique wrote: > > > > > > > > On Wed, Sep 16, 2020 at 3:56 PM Dumitru Ceara > > wrote: > > > > On 9/16/20 8:11 AM, Numan Siddique wrote: > > > On Wed, Sep 16, 2020 at 9:18 AM

Re: [ovs-dev] [PATCH v3 2/2] netdev-dpdk: Add option to configure VF MAC address.

Bleep bloop. Greetings Gaetan Rivet, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 97 characters long (recommended limit is 79) #52 FILE:

[ovs-dev] [PATCH ovn v2] lflow.c: Rename function convert_acts_to_expr to convert_match_to_expr.

The name was misleading because it in fact parses lflow match instead of actions. Fixes: 1213bc8270 ("ovn-controller: Cache logical flow expr matches.") Cc: Numan Siddique Acked-by: Numan Siddique Signed-off-by: Han Zhou --- v1 -> v2: Address Dumitru's comments for the indentation.

Re: [ovs-dev] [PATCH v3 1/2] netdev-dpdk: Add ability to set MAC address.

Bleep bloop. Greetings Gaetan Rivet, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

[ovs-dev] [PATCH ovn] inc-proc: Rename EN_VALID to EN_UNCHANGED

EN_VALID does not reflect the meaning of this state. For example, EN_UPDATED is also "valid". Signed-off-by: Mark Gray --- controller/ovn-controller.c | 8 lib/inc-proc-eng.c | 12 ++-- lib/inc-proc-eng.h | 4 ++-- 3 files changed, 12 insertions(+), 12

Re: [ovs-dev] [PATCH] conntrack: add generic IP protocol support

Eelco Chaudron writes: > Currently, userspace conntrack only tracks TCP, UDP, and ICMP, and all > other IP protocols are discarded, and the +inv state is returned. This > is not in line with the kernel conntrack. Where if no L4 information can > be extracted it's treated as generic L3. The

[ovs-dev] [PATCH v3 2/2] netdev-dpdk: Add option to configure VF MAC address.

In some cloud topologies, using DPDK VF representors in guest requires configuring a VF before it is assigned to the guest. A first basic option for such configuration is setting the VF MAC address. Add a key 'dpdk-vf-mac' to the 'options' column of the Interface table. This option can be used

[ovs-dev] [PATCH v3 1/2] netdev-dpdk: Add ability to set MAC address.

From: Ilya Maximets It is possible to set the MAC address of DPDK ports by calling rte_eth_dev_default_mac_addr_set(). OvS does not actually call this function for non-internal ports, but the implementation is exposed to be used in a later commit. Signed-off-by: Ilya Maximets Signed-off-by:

[ovs-dev] [PATCH v3 0/2] netdev-dpdk: support changing VF MAC

v3: fix Ilya's comments. v2: fix 0-day bot issues in 2/2. Hello Ilya, Following your suggestion, here is a small patch adding the ability to configure the MAC address of DPDK VF representors. As said off-ML, I've used the options column instead of other_configs, as it allows avoid having the

Re: [ovs-dev] [PATCH RFC 2/2] release-process: LTS transition period and policy for unmaintained branches.

On 16/09/2020 12:25, Ilya Maximets wrote: > On 9/8/20 6:41 PM, Kevin Traynor wrote: >> On 03/09/2020 15:20, Ilya Maximets wrote: >>> On 8/28/20 3:55 PM, Flavio Leitner wrote: On Tue, Aug 25, 2020 at 02:24:11PM +0200, Ilya Maximets wrote: > While only 2 branches are formally maintained

Re: [ovs-dev] [PATCH ovn] lflow.c: Rename function convert_acts_to_expr to convert_match_to_expr.

On 9/16/20 4:04 PM, Numan Siddique wrote: > > > > On Wed, Sep 16, 2020 at 3:56 PM Dumitru Ceara > wrote: > > On 9/16/20 8:11 AM, Numan Siddique wrote: > > On Wed, Sep 16, 2020 at 9:18 AM Han Zhou > wrote: > > > >> The name

Re: [ovs-dev] [PATCH] cirrus: Use FreeBSD 11.4.

On 9/16/20 12:05 AM, Aaron Conole wrote: > Ilya Maximets writes: > >> Support cycle of 11.3 ends in the end of September 2020, >> so we need to upgrade. >> >> Signed-off-by: Ilya Maximets >> --- >> >> This will go down to all branches that has integration with CirrusCI. >> > > LGTM > >

Re: [ovs-dev] [PATCH] selinux: Add missing permissions for ovs-kmod-ctl

On 9/3/20 8:21 PM, Ansis wrote: > Acked-by: Ansis Atteka > > On Thu, Sep 3, 2020, 10:03 AM Yi-Hung Wei wrote: > >> On RHEL 8, a SELinux policy is missing when ovs-kmod-ctl use modprobe >> to load kernel modules. This patch adds the missing permissions based >> on /var/log/audit/audit.log >>

Re: [ovs-dev] [PATCH ovn] lflow.c: Rename function convert_acts_to_expr to convert_match_to_expr.

On Wed, Sep 16, 2020 at 3:56 PM Dumitru Ceara wrote: > On 9/16/20 8:11 AM, Numan Siddique wrote: > > On Wed, Sep 16, 2020 at 9:18 AM Han Zhou wrote: > > > >> The name was misleading because it in fact parses lflow match instead > >> of actions. > >> > >> Fixes: 1213bc8270 ("ovn-controller:

Re: [ovs-dev] [PATCH v2] Remove manpages.mk from git

On 9/3/20 7:29 PM, Flavio Leitner wrote: > On Thu, Sep 03, 2020 at 02:12:54PM -0300, Flavio Leitner wrote: >> On Thu, Sep 03, 2020 at 04:55:43PM +0200, Timothy Redaelli wrote: >>> manpages.mk is generated at build-time using sodepends.py and so there is no >>> need to keep it in git. >>> >>>

Re: [ovs-dev] [PATCH] ovsdb: Add unixctl command to show storage status.

On 8/6/20 12:03 AM, Han Zhou wrote: > On Mon, Aug 3, 2020 at 8:05 AM Dumitru Ceara wrote: >> >> If a database enters an error state, e.g., in case of RAFT when reading >> the DB file contents if applying the RAFT records triggers constraint >> violations, there's no way to determine this unless a

Re: [ovs-dev] [PATCH v4] ovsdb-tool: Add a db consistency check to the ovsdb-tool check-cluster command

On 7/31/20 4:53 PM, Dumitru Ceara wrote: > On 7/30/20 12:41 PM, Federico Paolinelli wrote: >> There are some occurrences where the database ends up in an inconsistent >> state. This happened in ovn-k8s and is described in [0]. >> Here we are adding a supported way to check that a given db is

Re: [ovs-dev] [PATCH] netdev-dpdk: don't set rx mq mode for net_virtio

On 5/19/20 2:20 PM, Flavio Leitner wrote: > On Tue, May 19, 2020 at 01:37:01PM +0200, Jaime Caamaño Ruiz wrote: >> Since DPDK 19.11 [1], it is not allowed to set any RX mq mode for virtio >> driver. >> >> [1] >> https://github.com/DPDK/dpdk/commit/13b3137f3b7c8f866947a9b34e06a8aec0d084f7 >> >>

Re: [ovs-dev] [PATCH] rhel: Fix reload of OVS_USER_ID on startup

On 5/13/20 7:57 PM, Aaron Conole wrote: > Gregory Rose writes: > >> On 5/12/2020 9:38 AM, Jaime Caamaño Ruiz wrote: >>> OVS_USER_ID was being picked up from a previously existing >>> openvswitch.useropts rendering innefective any configuration change >>> through sysconfig. >>> >>> There is no

Re: [ovs-dev] [PATCH] classifier: Fix use of uninitialized value.

On 3/17/20 10:50 PM, Gregory Rose wrote: > > On 3/17/2020 2:39 PM, William Tu wrote: >> Coverity reports use of uninitialized value of cursor. >> This happens in cls_cursor_start(), when rule is false, >> cursor.subtable is uninitialized. CID 279324. >> >> Signed-off-by: William Tu >> --- >>  

Re: [ovs-dev] [PATCH v2] userspace-tso: Document the minimum kernel version.

On 3/10/20 3:39 PM, Flavio Leitner wrote: > The kernel needs to be at least 4.19-rc7 to include the commit > 9d2f67e43b73 ("net/packet: fix packet drop as of virtio gso") > otherwise the TSO packets are dropped when using raw sockets. > > Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation

Re: [ovs-dev] [PATCH] rhel: fix logrotate group when dpdk is enabled

On 9/15/20 7:15 PM, Flavio Leitner wrote: > On Wed, Sep 09, 2020 at 07:17:44PM +0200, Ilya Maximets wrote: >> On 4/30/19 7:10 PM, Jaime Caamaño Ruiz wrote: >>> Otherwise logrotate will fail to generate the rotated log files. >>> >>> Signed-off-by: Jaime Caamaño Ruiz >>> --- >> >> Hi. I'm looking

Re: [ovs-dev] [PATCH] Documentation: Correct claims about Debian packaging.

On 7/22/19 7:35 PM, Ben Pfaff wrote: > The documentation reported the union of all possible Debian- and > Debian-derived packaging. This isn't realistic: there are differences > between OVS upstream, Debian downstream, and Ubuntu downstream. This > commit distinguishes them. > > Reported-by:

[ovs-dev] GOOD DAY

Good day I am contacting you regarding a project i wish to execute with you,i will send you a comprehensive report once i get your response with your name and phone number to my mail. Regards, Mr.James Robertson ___ dev mailing list

Re: [ovs-dev] [PATCH RFC 2/2] release-process: LTS transition period and policy for unmaintained branches.

On Wed, Sep 16, 2020 at 01:09:29PM +0200, Ilya Maximets wrote: > On 9/7/20 6:27 PM, Flavio Leitner wrote: > > On Thu, Sep 03, 2020 at 04:20:53PM +0200, Ilya Maximets wrote: > >> On 8/28/20 3:55 PM, Flavio Leitner wrote: > >>> On Tue, Aug 25, 2020 at 02:24:11PM +0200, Ilya Maximets wrote: > >>

Re: [ovs-dev] [PATCH ovn v3 1/2] Prepare for 20.09.0.

On 9/16/20 1:54 PM, num...@ovn.org wrote: > From: Numan Siddique > > Signed-off-by: Numan Siddique Acked-by: Dumitru Ceara ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Log the emergency flow flush.

On 15 Sep 2020, at 21:21, Flavio Leitner wrote: > When the number of flows in the datapath reaches twice the > maximum, revalidators will delete all flows as an emergency > action to recover. In that case, log a message with values > and increase a coverage counter. > > Signed-off-by: Flavio

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Log the value of flow limit.

On 15 Sep 2020, at 21:20, Flavio Leitner wrote: > The datapath flow limit is calculated by revalidators so > log the value as well. > > Signed-off-by: Flavio Leitner Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH ovn v3 2/2] Prepare for post-20.09.0 (20.09.90).

On 9/16/20 1:54 PM, num...@ovn.org wrote: > From: Numan Siddique > > Signed-off-by: Numan Siddique Acked-by: Dumitru Ceara Thanks, Dumitru ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v2 2/2] lflow.c: Release ref_lflow_node as soon as it is not needed.

On 9/15/20 8:40 PM, Han Zhou wrote: > If a resource doesn't have any lflows referencing it any more, the > node ref_lflow_node in lflow_resource_ref.ref_lflow_table should > be removed and released. Otherwise, the table could keep growing > in some scenarios, until a recompute is triggered. Now

Re: [ovs-dev] [PATCH ovn v2 1/2] lflow.c: Avoid adding redundant resource refs for port-bindings.

Hi Han, On 9/15/20 8:40 PM, Han Zhou wrote: > When a lport is referenced by a logical flow where port-binding refs > needs to be added, currently it can add the same reference pair multiple > times in below situations (introduced in commit ade4e77): > > 1) In add_matches_to_flow_table(),

[ovs-dev] [PATCH ovn v3 1/2] Prepare for 20.09.0.

From: Numan Siddique Signed-off-by: Numan Siddique --- v2 -> v3 * Fixed another typo in the data. v1 -> v2 * Addressed the review comment from Dumitru. Corrected the version mistake in debian/changelog. NEWS | 2 +- configure.ac | 2 +- debian/changelog | 4

[ovs-dev] [PATCH ovn v3 2/2] Prepare for post-20.09.0 (20.09.90).

From: Numan Siddique Signed-off-by: Numan Siddique --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 899afdb202..dece5831c4 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@

Re: [ovs-dev] [PATCH ovn] build: Fix broken check-lcov target.

On 14/09/2020 23:04, Dumitru Ceara wrote: > Without this, the following fails: > > $ make check-lcov > [...] > Cannot open source file lib/dirs.c.in > [...] > make: *** [check-lcov] Error 2 > > CC: Ilya Maximets > Signed-off-by: Dumitru Ceara > --- > lib/ovn-dirs.c.in | 2 +- > 1 file

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Add option to configure VF MAC address.

On 9/16/20 9:51 AM, Gaëtan Rivet wrote: > On 16/09/20 00:08 +0200, Ilya Maximets wrote: >> On 7/7/20 11:18 AM, Gaetan Rivet wrote: >>> In some cloud topologies, using DPDK VF representors in guest requires >>> configuring a VF before it is assigned to the guest. >>> >>> A first basic option for

Re: [ovs-dev] [PATCH RFC 2/2] release-process: LTS transition period and policy for unmaintained branches.

On 9/8/20 6:41 PM, Kevin Traynor wrote: > On 03/09/2020 15:20, Ilya Maximets wrote: >> On 8/28/20 3:55 PM, Flavio Leitner wrote: >>> On Tue, Aug 25, 2020 at 02:24:11PM +0200, Ilya Maximets wrote: While only 2 branches are formally maintained (LTS and latest release), OVS team usually

Re: [ovs-dev] [PATCH RFC 2/2] release-process: LTS transition period and policy for unmaintained branches.

On 9/7/20 6:27 PM, Flavio Leitner wrote: > On Thu, Sep 03, 2020 at 04:20:53PM +0200, Ilya Maximets wrote: >> On 8/28/20 3:55 PM, Flavio Leitner wrote: >>> On Tue, Aug 25, 2020 at 02:24:11PM +0200, Ilya Maximets wrote: While only 2 branches are formally maintained (LTS and latest release),

  1   2   >