Re: [ovs-dev] [PATCH ovn v5] ovn-sbctl.c Add logical flows count numbers

OK, will make it a separate command. On Mon, May 24, 2021 at 8:44 PM Ben Pfaff wrote: > On Sat, May 22, 2021 at 10:56:13PM +0300, Alexey Roytman wrote: > > From: Alexey Roytman > > > > For big scale deployments, when number of logical flows can be 2M+, > > sometimes users just need to know the

Re: [ovs-dev] [PATCH v2] ovsdb-tool: add db-set-election-timer command for clustered databases

On Mon, May 24, 2021 at 02:59:58PM -0500, Dan Williams wrote: > On Mon, 2021-05-24 at 10:49 -0700, Ben Pfaff wrote: > > On Fri, May 21, 2021 at 02:25:52PM -0500, Dan Williams wrote: > > > After creating the new cluster database write a raft entry that > > > sets the desired election timer. This

Re: [ovs-dev] [PATCH v2] ovsdb-tool: add db-set-election-timer command for clustered databases

On Mon, 2021-05-24 at 10:49 -0700, Ben Pfaff wrote: > On Fri, May 21, 2021 at 02:25:52PM -0500, Dan Williams wrote: > > After creating the new cluster database write a raft entry that > > sets the desired election timer. This allows CMSes to set the > > election timer at cluster start and avoid an

Re: [ovs-dev] [PATCH 5/5] dpif-netlink: Fix send of uninitialized memory in ct limit requests.

On 5/21/21 9:23 AM, Mark Gray wrote: > On 20/05/2021 19:24, Ilya Maximets wrote: >> On 5/20/21 7:46 PM, Ilya Maximets wrote: >>> On 5/20/21 6:55 PM, Mark Gray wrote: On 04/04/2021 18:31, Ilya Maximets wrote: > ct limit requests never initializes the whole 'struct ovs_zone_limit' >

Re: [ovs-dev] [PATCH 4/5] ofproto-dpif: Fix use of uninitialized attributes of timeout policy.

On 5/20/21 6:49 PM, Mark Gray wrote: > On 04/04/2021 18:31, Ilya Maximets wrote: >> 'cdtp' is allocated on a stack and it has uninitialized 'present' >> field that specifies which attributes are actually set. This >> causes use of uninitialized attributes. >> >> Conditional jump or move depends

Re: [ovs-dev] [PATCH 1/5] netdev-linux: Fix use of uninitialized LAG master name.

On 5/20/21 6:43 PM, Mark Gray wrote: > On 04/04/2021 18:31, Ilya Maximets wrote: >> 'if_indextoname' may fail leaving the 'master_name' uninitialized: >> >> Conditional jump or move depends on uninitialised value(s) >> at 0x4C34329: strlen (vg_replace_strmem.c:459) >> by 0x51C638:

Re: [ovs-dev] [PATCH net-next v2] net: openvswitch: IPv6: Add IPv6 extension header support

On 5/24/21 8:57 PM, Cpp Code wrote: > Yes, these changes only works together with changes in userspace. I > believe in any solution there should be corresponding changes in > userspace. If we would be able to easily run old version of userspace > with these changes in kernel without userspace

Re: [ovs-dev] [PATCH v2 ovn 4/4] NEWS: Add CoPP support.

Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [PATCH v2 ovn 2/4] ovn-northd: Add support for CoPP.

Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #862 FILE: utilities/ovn-nbctl.c:430:

Re: [ovs-dev] [PATCH net-next v2] net: openvswitch: IPv6: Add IPv6 extension header support

Yes, these changes only works together with changes in userspace. I believe in any solution there should be corresponding changes in userspace. If we would be able to easily run old version of userspace with these changes in kernel without userspace complaining about struct size, we could get in

[ovs-dev] [PATCH v2 ovn 3/4] ovn-northd: Add CoPP policies for flows that punt packets to ovn-controller.

From: Dumitru Ceara Change the ovn-northd implementation to set the new 'controller_meter' field for flows that need to punt packets to ovn-controller. Protocol packets for which CoPP is enforced when sending packets to ovn-controller (if configured): - ARP - ND_NS - ND_NA - ND_RA - DNS - IGMP

[ovs-dev] [PATCH v2 ovn 2/4] ovn-northd: Add support for CoPP.

From: Dumitru Ceara Add new 'Copp' (Control plane protection) table to OVN Northbound DB: - this stores mappings between control plane protocol names and meters that should be used to rate limit controller-destined traffic for those protocols. Add new 'copp' columns to the following OVN

[ovs-dev] [PATCH v2 ovn 1/4] ovn-controller: Add support for Logical_Flow control meters

From: Dumitru Ceara Add a new 'controller_meter' column to OVN Southbound Logical_Flow table. This stores an optional string which should correspond to the Meter that must be used for rate limiting controller actions generated by packets hitting the flow. Add a new 'ofctrl_add_flow_metred'

[ovs-dev] [PATCH v2 ovn 4/4] NEWS: Add CoPP support.

From: Dumitru Ceara Signed-off-by: Dumitru Ceara Signed-off-by: Lorenzo Bianconi --- NEWS | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS b/NEWS index f8aa81e56..37d016d87 100644 --- a/NEWS +++ b/NEWS @@ -23,6 +23,7 @@ Post-v21.03.0 - Utilities: * ovn-nbctl daemon mode is no

[ovs-dev] [PATCH v2 ovn 0/4] respin CoPP series

This series respin CoPP support introduced here [0] by Dumitru rebasing on top of ovn master branch and adding some missing meters (e.g. bfd or acl reject). The main goal of this series is to continue the discussion about the proposed approach and to align on CMS APIs. For the moment no ddlog

Re: [ovs-dev] [PATCH ovn 0/5] respin CoPP series

> On 29/04/2021 18:04, Lorenzo Bianconi wrote: > > This series respin CoPP support introduced here [0] by Dumitru rebasing on > > top > > of ovn master branch and adding some missing meters (e.g. bfd or acl > > reject). > > The main goal of this series is to continue the discussion about the >

Re: [ovs-dev] [PATCH ovn 3/5] ovn-northd: Add CoPP policies for flows that punt packets to ovn-controller.

> On 29/04/2021 18:04, Lorenzo Bianconi wrote: > > From: Dumitru Ceara > > > > Change the ovn-northd implementation to set the new 'controller_meter' > > field for flows that need to punt packets to ovn-controller. > > > > Protocol packets for which CoPP is enforced when sending packets to > >

Re: [ovs-dev] [PATCH v2] ovsdb-tool: add db-set-election-timer command for clustered databases

On Fri, May 21, 2021 at 02:25:52PM -0500, Dan Williams wrote: > After creating the new cluster database write a raft entry that > sets the desired election timer. This allows CMSes to set the > election timer at cluster start and avoid an error-prone > election timer modification process after the

Re: [ovs-dev] [PATCH ovn v5] ovn-sbctl.c Add logical flows count numbers

On Sat, May 22, 2021 at 10:56:13PM +0300, Alexey Roytman wrote: > From: Alexey Roytman > > For big scale deployments, when number of logical flows can be 2M+, > sometimes users just need to know the total number of logical flows > and numbers of logical flows per table/per datapath. > > New

Re: [ovs-dev] [PATCH ovn v2 3/3] configure: Also find and verify version of ovsdb2ddlog.

On Mon, May 24, 2021 at 12:14:31PM -0400, Mark Michelson wrote: > On 5/21/21 11:02 PM, Ben Pfaff wrote: > > This tool is also needed and also varies from one version of DDlog to > > another, so we should find it and check its version in the same way. > > > > Signed-off-by: Ben Pfaff > > --- > >

[ovs-dev] [PATCH ovn v3 3/3] configure: Also find and verify version of ovsdb2ddlog.

This tool is also needed and also varies from one version of DDlog to another, so we should find it and check its version in the same way. Signed-off-by: Ben Pfaff --- acinclude.m4 | 24 northd/automake.mk | 4 ++-- 2 files changed, 18 insertions(+), 10

[ovs-dev] [PATCH ovn v3 0/3] Check ddlog version and improve configure process

v1->v2: Change leading tabs to spaces. v2->v3: - Use stricter regex for recognizing version numbers in "configure: Check for correct ddlog version.". - Print correct version number in error message in "configure: Also find and verify version of ovsdb2ddlog." Ben Pfaff (3):

[ovs-dev] [PATCH ovn v3 1/3] configure: Check for correct ddlog version.

Signed-off-by: Ben Pfaff Suggested-by: Mark Michelson --- acinclude.m4 | 20 +--- configure.ac | 2 +- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 1f8bf8224a9a..93177dfe71d4 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@

[ovs-dev] [PATCH ovn v3 2/3] configure: Improve how to find ddlog binaries and libraries.

There was no easy way to use a ddlog installation from one of the tarballs provided by the ddlog developers, because these put the binaries in a subdirectory of an installation directory instead of in a system- or user-level bin directory. This commit makes that easier: just do

Re: [ovs-dev] [PATCH ovn 4/5] ovn-northd: Extend metering to Controller-Events

> On 29/04/2021 18:04, Lorenzo Bianconi wrote: > > From: Dumitru Ceara > > > > Co-authored-by: Lorenzo Bianconi > > Signed-off-by: Lorenzo Bianconi > > Signed-off-by: Dumitru Ceara > > --- > > include/ovn/actions.h | 1 - > > lib/actions.c | 50

Re: [ovs-dev] [PATCH ovn 2/5] ovn-northd: Add support for CoPP.

> On 29/04/2021 18:04, Lorenzo Bianconi wrote: > > From: Dumitru Ceara > > [...] > > Could this be changed to copp_proto_get_name()? ack, I will fix it in v2 > > > +{ > > +if (proto >= COPP_PROTO_MAX) { > > +return ""; > > +} > > +return copp_proto_names[proto]; > > +} >

Re: [ovs-dev] [PATCH ovn 2/5] ovn-northd: Add support for CoPP.

> On 4/29/21 1:04 PM, Lorenzo Bianconi wrote: > > From: Dumitru Ceara > > [...] > > + > > +ds_put_cstr(, "Invalid control protocol. Allowed values: "); > > +for (size_t i = COPP_PROTO_FIRST; i < COPP_PROTO_MAX; i++) { > > +ds_put_format(, "%s, ", copp_proto_get(i)); > > +}

Re: [ovs-dev] [PATCH v3 2/2] dpctl: dpif: allow viewing and configuring dp cache sizes

Hi Eelco, Eelco Chaudron writes: > This patch adds a general way of viewing/configuring datapath > cache sizes. With an implementation for the netlink interface. > > The ovs-dpctl/ovs-appctl show commands will display the > current cache sizes configured: > > ovs-dpctl show > system@ovs-system:

Re: [ovs-dev] [PATCH ovn v2 3/3] configure: Also find and verify version of ovsdb2ddlog.

On 5/21/21 11:02 PM, Ben Pfaff wrote: This tool is also needed and also varies from one version of DDlog to another, so we should find it and check its version in the same way. Signed-off-by: Ben Pfaff --- acinclude.m4 | 24 northd/automake.mk | 4 ++-- 2

Re: [ovs-dev] [PATCH ovn 1/5] ovn-controller: Add support for Logical_Flow control meters

> On 20/05/2021 21:26, Mark Michelson wrote: > > I think this patch could use some ovn-controller tests to ensure that > > meters configured in the SB end up being applied to the resulting > > controller() actions. > > > > On 4/29/21 1:04 PM, Lorenzo Bianconi wrote: > >> From: Dumitru Ceara >

Re: [ovs-dev] [PATCH ovn 1/5] ovn-controller: Add support for Logical_Flow control meters

> I think this patch could use some ovn-controller tests to ensure that meters > configured in the SB end up being applied to the resulting controller() > actions. > > On 4/29/21 1:04 PM, Lorenzo Bianconi wrote: > > From: Dumitru Ceara > > > > Add a new 'controller_meter' column to OVN

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: avoid successive ct_clear datapath actions

On Tue, 18 May 2021 06:17:48 -0400 Eelco Chaudron wrote: > Due to flow lookup optimizations, especially in the resubmit/clone cases, > we might end up with multiple ct_clear actions, which are not necessary. > > This patch only adds the ct_clear action to the datapath if any ct state > is

Re: [ovs-dev] [PATCH ovn v3] ovn-sbctl: Add logical flows count numbers

Hi Mark, Thanks for the comments. With a delay, but I've fixed the patch. Mistakenly, I used a slightly different email subject, so please see the fixes in the [ovs-dev] [PATCH ovn v5] ovn-sbctl.c Add logical flows count numbers

Re: [ovs-dev] [PATCH] dpif-netdev.c : Fix indentation.

On 5/19/21 5:48 PM, lin huang wrote: > dpif-netdev.c : Fix indentation. > Add extra space to fix indentation. > > Signed-off-by: miter > --- > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c > index 816945375..dc77fa2fa 100644 > --- a/lib/dpif-netdev.c > +++ b/lib/dpif-netdev.c > @@ -7404,7

Re: [ovs-dev] [PATCH v2] dpif-netdev: Forwarding optimization for direct output flows.

Bleep bloop. Greetings Sriharsha Basavapatna, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

[ovs-dev] [PATCH v2] dpif-netdev: Forwarding optimization for direct output flows.

From: Ilya Maximets There are some cases where users want to have simple forwarding or drop rules for all packets received from particular port, i.e : "in_port=1,actions=2" "in_port=1,actions=IN_PORT" "in_port=1,actions=drop" There are also cases where complex OF flows could be

Re: [ovs-dev] [PATCH v2] Improve concurrency by adjust flow-limit

Hi Ben, Please help to review this patch ,which to optimize the flow-limit adjustment. The v1 patch links to http://patchwork.ozlabs.org/project/openvswitch/patch/20210511075200.19037-1-taoyunxi...@cmss.chinamobile.com/ Thanks, Yun At 2021-05-17 15:22:48, "Tao YunXiang" wrote: