From: Numan Siddique
In the cases where the C idl client is compiled with a newer schema
and the ovsdb-server is running with older schema, the IDL clients
can included tables or columns in the transaction which are missing
in the server schema. ovsdb-server will reject the transaction,
but the
From: Numan Siddique
This patch adds 2 new APIs in the ovsdb-idl client library
- ovsdb_idl_has_table() and ovsdb_idl_has_column_in_table() to
query if a table and a column is present in the IDL or not. This
is required for scenarios where the server schema is old and
missing a table or column
From: Numan Siddique
This patch series addresses the transaction issues seen when
the C IDL client is running compiled with newer schema and ovsdb-server
is still running with older schema.
Patch 1: Adds the API to query for table and column names.
Patch 2: Addresses the transaction issues.
v3
I think you should quote the results from the cover letter in this commit.
Other than that,
Acked-by: Mark Michelson
On 8/24/21 2:02 PM, Lorenzo Bianconi wrote:
Improve code efficiency of load-balancer unreachable_ips flows
processing when datapath_groups are enabled. We can avoid to
perform
Hi Lorenzo,
I have some minor findings below.
On 8/24/21 2:02 PM, Lorenzo Bianconi wrote:
Refactor unreachable IPs for vip load-balancers inverting the logic used
during the lb flow creation in order to visit lb first and then related
datapath/ovn_ports. This is a preliminary patch to avoid
On Sat, Aug 21, 2021 at 1:15 PM wrote:
>
> From: Mohammad Heib
>
> ovn-nbctl sync command will increase nb_cfg value each time it is executed
> with a specific wait_type, this increment will be handled without testing
> the current nb_cfg value because it is not monitored and that could lead
>
When a router port is attached to a localnet switch, sending periodic
RAs through localnet port will confuse upstream router by leaking
conflicting router advertisements into datacenter network.
This patch blocks all LOCAL_ONLY marked traffic leaving through localnet
port. In addition to RAs, it
On Tue, Aug 17, 2021 at 2:20 PM Numan Siddique wrote:
>
> On Fri, Aug 13, 2021 at 10:33 AM Frode Nordahl
> wrote:
> >
> > On Sat, Aug 7, 2021 at 12:20 AM Ihar Hrachyshka wrote:
> > >
> > > When a router port is attached to a localnet switch, sending periodic
> > > RAs through localnet port will
When a router port is attached to a localnet switch, sending periodic
RAs through localnet port will confuse upstream router by leaking
conflicting router advertisements into datacenter network.
This patch blocks all LOCAL_ONLY marked traffic leaving through localnet
port. In addition to RAs, it
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#154 FILE: tests/test-json.c:212:
for
On 8/24/21 10:07 PM, Anton Ivanov wrote:
> On 23/08/2021 22:36, Ilya Maximets wrote:
>> On 8/23/21 10:37 PM, Anton Ivanov wrote:
>>> On 23/08/2021 21:26, Ilya Maximets wrote:
On 8/23/21 10:20 PM, Anton Ivanov wrote:
> Should not be the case.
>
> The map is pre-sized for the size
On Fri, Aug 6, 2021 at 8:59 AM Lorenzo Bianconi
wrote:
>
> Allow ovn-nbctl to add a valid route without a nexthop. E.g:
>
> ovn-nbctl lr-route-add lr0 192.168.0.0/24 lr0-sw
>
> Lorenzo Bianconi (2):
> nbctl: validate outport in nbctl_lr_route_add
> northd: allow to configure routes with no
Currently pipeline is hashed as a string ("egress" or "ingress"),
and this seems wasteful. Hashing it as a digit (P_IN or P_OUT)
to eliminate one call to hash_string() for every generated logical
flow.
In my testing this saves 1.5 - 3 % of a processing time.
Signed-off-by: Ilya Maximets
---
Current string serialization code puts all characters one by one.
This is slow because dynamic string needs to perform length checks
on every ds_put_char() and it's also doesn't allow compiler to use
better memory copy operations, i.e. doesn't allow copying few bytes
at once.
Special symbols are
Implementation of SHA1 in OpenSSL library is much faster and optimized
for all available CPU architectures and instruction sets. OVS should
use it instead of internal implementation if possible.
Depending on compiler options OpenSSL's version finishes our sha1
unit tests from 3 to 12 times
Great, thanks!
*Vasu Dasari*
On Tue, Aug 24, 2021 at 4:11 PM Ashish Varma
wrote:
> I will take a look.
>
> Thanks,
> Ashish
>
> On Tue, Aug 24, 2021 at 9:29 AM Vasu Dasari wrote:
>
>> Hi Ben/Ashish,
>>
>> When you get a chance, Can you please take a look at my code?
>>
>> -Vasu
>>
>> *Vasu
I will take a look.
Thanks,
Ashish
On Tue, Aug 24, 2021 at 9:29 AM Vasu Dasari wrote:
> Hi Ben/Ashish,
>
> When you get a chance, Can you please take a look at my code?
>
> -Vasu
>
> *Vasu Dasari*
>
>
> On Thu, Jul 29, 2021 at 10:36 PM Vasu Dasari wrote:
>
>> Extended OpenFlow monitoring
On 23/08/2021 22:36, Ilya Maximets wrote:
On 8/23/21 10:37 PM, Anton Ivanov wrote:
On 23/08/2021 21:26, Ilya Maximets wrote:
On 8/23/21 10:20 PM, Anton Ivanov wrote:
Should not be the case.
The map is pre-sized for the size from the previous iterations.
Line 12861 in my tree which is
On 8/20/21 6:51 PM, Ilya Maximets wrote:
> In short, database snapshot stored inside the raft module is
> a huge json object. E.g. in ovn-heater scale tests with 270 MB
> on-disk Southbound DB, json object of a snapshot takes 1.6 GB of
> RAM out of total 3.8 GB of the RSS of an ovsdb-server
Same json from a json cache is typically sent to all the clients,
e.g., in case of OVN deployment with ovn-monitor-all=true.
There could be hundreds or thousands connected clients and ovsdb
will serialize the same json object for each of them before sending.
Serializing it once before storing
Raft log entries (and raft database snapshot) contains json objects
of the data. Follower receives append requests with data that gets
parsed and added to the raft log. Leader receives execution requests,
parses data out of them and adds to the log. In both cases, later
ovsdb-server reads the
Introducing a new json type JSON_SERIALIZED_OBJECT. It's not an
actual type that can be seen in a json message on a wire, but
internal type that is intended to hold a serialized version of
some other json object. For this reason it's defined after the
JSON_N_TYPES to not confuse parsers and
In short, database snapshot stored inside the raft module is
a huge json object. E.g. in ovn-heater scale tests with 270 MB
on-disk Southbound DB, json object of a snapshot takes 1.6 GB of
RAM out of total 3.8 GB of the RSS of an ovsdb-server process.
Second patch of the set is targeted to free
On Tue, Aug 24, 2021 at 2:20 PM Anton Ivanov
wrote:
>
> On 24/08/2021 19:16, Ilya Maximets wrote:
> > On 8/24/21 7:48 PM, Numan Siddique wrote:
> >> On Tue, Aug 24, 2021 at 1:24 PM Anton Ivanov
> >> wrote:
> >>>
> >>> On 24/08/2021 17:35, Ilya Maximets wrote:
> On 8/24/21 6:25 PM, Numan
When IC port_binding exists and transit switch is deleted,
the orphan port_binding if left in the IC_SB_DB.
This patch fixes such situation and adds test for this case.
Signed-off-by: Vladislav Odintsov
---
ic/ovn-ic.c | 35 +++--
tests/ovn-ic.at | 52
On 24/08/2021 19:16, Ilya Maximets wrote:
On 8/24/21 7:48 PM, Numan Siddique wrote:
On Tue, Aug 24, 2021 at 1:24 PM Anton Ivanov
wrote:
On 24/08/2021 17:35, Ilya Maximets wrote:
On 8/24/21 6:25 PM, Numan Siddique wrote:
On Tue, Aug 24, 2021 at 7:56 AM Anton Ivanov
wrote:
On 24/08/2021
On 8/24/21 7:48 PM, Numan Siddique wrote:
> On Tue, Aug 24, 2021 at 1:24 PM Anton Ivanov
> wrote:
>>
>>
>> On 24/08/2021 17:35, Ilya Maximets wrote:
>>> On 8/24/21 6:25 PM, Numan Siddique wrote:
On Tue, Aug 24, 2021 at 7:56 AM Anton Ivanov
wrote:
>
> On 24/08/2021 12:46, Ilya
Refactor unreachable IPs for vip load-balancers inverting the logic used
during the lb flow creation in order to visit lb first and then related
datapath/ovn_ports. This is a preliminary patch to avoid recomputing
flow hash and lflow lookup when not necessary.
Signed-off-by: Lorenzo Bianconi
---
ovn-master:
--
tatistics for 'ovnnb_db_run'
Total samples: 97
Maximum: 12596 msec
Minimum: 12324 msec
95th percentile: 12549.921348 msec
Short term average: 12438.001085 msec
Long term average: 12407.350781 msec
Statistics for 'ovn-northd-loop'
Total samples: 185
Maximum:
Improve code efficiency of load-balancer unreachable_ips flows
processing when datapath_groups are enabled. We can avoid to
perform a flow lookup for each ovn_port in
build_lrouter_flows_for_unreachable_ips() since lflows only
depends on vips (match and action filters).
Signed-off-by: Lorenzo
On 24/08/2021 18:48, Numan Siddique wrote:
On Tue, Aug 24, 2021 at 1:24 PM Anton Ivanov
wrote:
On 24/08/2021 17:35, Ilya Maximets wrote:
On 8/24/21 6:25 PM, Numan Siddique wrote:
On Tue, Aug 24, 2021 at 7:56 AM Anton Ivanov
wrote:
On 24/08/2021 12:46, Ilya Maximets wrote:
On 8/24/21 1:18
On Tue, Aug 24, 2021 at 1:24 PM Anton Ivanov
wrote:
>
>
> On 24/08/2021 17:35, Ilya Maximets wrote:
> > On 8/24/21 6:25 PM, Numan Siddique wrote:
> >> On Tue, Aug 24, 2021 at 7:56 AM Anton Ivanov
> >> wrote:
> >>>
> >>> On 24/08/2021 12:46, Ilya Maximets wrote:
> On 8/24/21 1:18 PM, Anton
Aaron Conole writes:
> Ilya Maximets writes:
>
>> On 8/12/21 6:17 PM, Aaron Conole wrote:
>>> we...@ucloud.cn writes:
>>>
From: wenxu
The ipf collect original fragment packets and reass a new pkt
to do the conntrack logic. After finsh the conntrack things
copy the ct
On 24/08/2021 17:35, Ilya Maximets wrote:
On 8/24/21 6:25 PM, Numan Siddique wrote:
On Tue, Aug 24, 2021 at 7:56 AM Anton Ivanov
wrote:
On 24/08/2021 12:46, Ilya Maximets wrote:
On 8/24/21 1:18 PM, Anton Ivanov wrote:
On 24/08/2021 12:05, Ilya Maximets wrote:
On 8/24/21 7:36 AM, Anton
On 24/08/2021 17:25, Numan Siddique wrote:
On Tue, Aug 24, 2021 at 7:56 AM Anton Ivanov
wrote:
On 24/08/2021 12:46, Ilya Maximets wrote:
On 8/24/21 1:18 PM, Anton Ivanov wrote:
On 24/08/2021 12:05, Ilya Maximets wrote:
On 8/24/21 7:36 AM, Anton Ivanov wrote:
On 23/08/2021 22:36, Ilya
On 8/24/21 6:25 PM, Numan Siddique wrote:
> On Tue, Aug 24, 2021 at 7:56 AM Anton Ivanov
> wrote:
>>
>>
>> On 24/08/2021 12:46, Ilya Maximets wrote:
>>> On 8/24/21 1:18 PM, Anton Ivanov wrote:
On 24/08/2021 12:05, Ilya Maximets wrote:
> On 8/24/21 7:36 AM, Anton Ivanov wrote:
>> On
Hi Ben/Ashish,
When you get a chance, Can you please take a look at my code?
-Vasu
*Vasu Dasari*
On Thu, Jul 29, 2021 at 10:36 PM Vasu Dasari wrote:
> Extended OpenFlow monitoring support
> * OpenFlow 1.3 with ONF extensions
> * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+.
>
>
On Tue, Aug 24, 2021 at 7:56 AM Anton Ivanov
wrote:
>
>
> On 24/08/2021 12:46, Ilya Maximets wrote:
> > On 8/24/21 1:18 PM, Anton Ivanov wrote:
> >> On 24/08/2021 12:05, Ilya Maximets wrote:
> >>> On 8/24/21 7:36 AM, Anton Ivanov wrote:
> On 23/08/2021 22:36, Ilya Maximets wrote:
> > On
On 8/24/21 6:04 PM, Eli Britstein wrote:
>
> On 8/24/2021 6:47 PM, Ilya Maximets wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 8/24/21 5:25 PM, Eli Britstein wrote:
>>> On 8/24/2021 6:08 PM, Finn, Emma wrote:
External email: Use caution opening links or
On 8/24/2021 6:47 PM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 8/24/21 5:25 PM, Eli Britstein wrote:
On 8/24/2021 6:08 PM, Finn, Emma wrote:
External email: Use caution opening links or attachments
-Original Message-
From: Eli Britstein
On Tue, Aug 24, 2021 at 11:21 AM Mark Gray wrote:
>
> On 24/08/2021 16:15, Mark Michelson wrote:
> > Excellent, thanks for the updated patch!
> >
> > Acked-by: Mark Michelson
>
> Thanks, and thanks for the review!
Thanks. I applied this patch to the main branch.
With the ovsrobot run for this
On 8/24/21 5:25 PM, Eli Britstein wrote:
>
> On 8/24/2021 6:08 PM, Finn, Emma wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> -Original Message-
>> From: Eli Britstein
>> Sent: Monday 16 August 2021 14:55
>> To: d...@openvswitch.org; Ilya Maximets
>> Cc:
Thanks Numan for the information.
Regards,
Vladislav Odintsov
> On 24 Aug 2021, at 18:43, Numan Siddique wrote:
>
> On Mon, Aug 23, 2021 at 1:38 PM Odintsov Vladislav wrote:
>>
>> Hi,
>>
>> I’m wonder if this patch series is interesting for the project.
>> Should I wait for review or what
-Original Message-
From: Eli Britstein
Sent: Tuesday 24 August 2021 16:26
To: Finn, Emma ; d...@openvswitch.org; Ilya Maximets
Cc: Stokes, Ian ; Sriharsha Basavapatna
; Gaetan Rivet ; Majd
Dibbiny ; Salem Sol
Subject: Re: [PATCH V3 1/2] netdev-offload-dpdk: Use has_vlan match
On Mon, Aug 23, 2021 at 1:38 PM Odintsov Vladislav wrote:
>
> Hi,
>
> I’m wonder if this patch series is interesting for the project.
> Should I wait for review or what is the process to add new functionality?
Hi Vladislav,
This is the present review queue -
On 8/24/2021 6:08 PM, Finn, Emma wrote:
External email: Use caution opening links or attachments
-Original Message-
From: Eli Britstein
Sent: Monday 16 August 2021 14:55
To: d...@openvswitch.org; Ilya Maximets
Cc: Finn, Emma ; Stokes, Ian ; Sriharsha Basavapatna
; Gaetan Rivet ;
On 24/08/2021 16:15, Mark Michelson wrote:
> Excellent, thanks for the updated patch!
>
> Acked-by: Mark Michelson
Thanks, and thanks for the review!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Excellent, thanks for the updated patch!
Acked-by: Mark Michelson
On 8/23/21 4:37 PM, Mark Gray wrote:
When adding a load balancer to a logical router, two flows are added to
the ingress DNAT table. One flow is for established connections and one is
for new connections. They have the
-Original Message-
From: Eli Britstein
Sent: Monday 16 August 2021 14:55
To: d...@openvswitch.org; Ilya Maximets
Cc: Finn, Emma ; Stokes, Ian ;
Sriharsha Basavapatna ; Gaetan Rivet
; Majd Dibbiny ; Eli Britstein
; Salem Sol
Subject: [PATCH V3 1/2] netdev-offload-dpdk: Use has_vlan
Bleep bloop. Greetings Kumar Amber, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author kumar Amber needs to sign off.
WARNING: Unexpected sign-offs from developers who
Bleep bloop. Greetings Kumar Amber, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author kumar Amber needs to sign off.
WARNING: Unexpected sign-offs from developers who
Bleep bloop. Greetings Kumar Amber, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author kumar Amber needs to sign off.
WARNING: Unexpected sign-offs from developers who
On Tue, Aug 24, 2021 at 7:31 AM Ilya Maximets wrote:
>
> On 8/24/21 12:59 AM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > In the cases where the C idl client is compiled with a newer schema
> > and the ovsdb-server is running with older schema, the IDL clients
> > can included tables
---
v2:
- fix the CI build.
- fix check-patch for co-author
---
The patch-set introduces AVX512 optimizations of IPv6
traffic profiles and hashing improvements for all AVX512
supported traffic profiles for IPv4 and IPv6.
Kumar Amber (3):
dpif-netdev/mfex: Add AVX512 basic ipv6 traffic profiles
Add AVX512 IPv6 optimized profile for IPv6/UDP and
IPv6/TCP.
MFEX autovalidaton test-case already has the IPv6 support for
validating against the scalar mfex.
Signed-off-by: Kumar Amber
Signed-off-by: Harry van Haaren
Co-authored-by: Harry van Haaren
---
v2:
- Fix CI build error
- Fix
From: kumar Amber
This commit adds IPv4 profile specific hashing which
uses fixed offsets into the packet to improve hashing
perforamnce.
Hash value is autovalidated by MFEX autovalidator.
Signed-off-by: Kumar Amber
Signed-off-by: Harry van Haaren
Co-authored-by: Harry van Haaren
---
v2:
-
From: kumar Amber
This patch avoids calculating the software hash of the packet again
if the optimized miniflow-extract hit and has already calculated the
packet hash. In cases of scalar miniflow extract, the normal hashing
calculation is performed.
Signed-off-by: Kumar Amber
---
This commit adds IPv6 profile specific hashing which
uses fixed offsets into the packet to improve hashing
perforamnce.
Hash value is autovalidated by MFEX autovalidator.
Signed-off-by: Kumar Amber
Signed-off-by: Harry van Haaren
Co-authored-by: Harry van Haaren
---
v2:
- Fix check-patch
From: kumar Amber
This patch adds the per profile AVX512 opt hashing to autovalidator
for validating the hash values against the scalar hash.
Signed-off-by: Kumar Amber
---
lib/dpif-netdev-private-extract.c | 12
1 file changed, 12 insertions(+)
diff --git
Add AVX512 Ipv6 optimized profile for vlan/IPv6/UDP and
vlan/IPv6/TCP.
MFEX autovalidaton test-case already has the IPv6 support for
validating against the scalar mfex.
Signed-off-by: Kumar Amber
Signed-off-by: Harry van Haaren
Co-authored-by: Harry van Haaren
---
v2:
- Fix check-patch
On 24/08/2021 12:46, Ilya Maximets wrote:
On 8/24/21 1:18 PM, Anton Ivanov wrote:
On 24/08/2021 12:05, Ilya Maximets wrote:
On 8/24/21 7:36 AM, Anton Ivanov wrote:
On 23/08/2021 22:36, Ilya Maximets wrote:
On 8/23/21 10:37 PM, Anton Ivanov wrote:
On 23/08/2021 21:26, Ilya Maximets wrote:
On 8/24/21 1:18 PM, Anton Ivanov wrote:
>
> On 24/08/2021 12:05, Ilya Maximets wrote:
>> On 8/24/21 7:36 AM, Anton Ivanov wrote:
>>> On 23/08/2021 22:36, Ilya Maximets wrote:
On 8/23/21 10:37 PM, Anton Ivanov wrote:
> On 23/08/2021 21:26, Ilya Maximets wrote:
>> On 8/23/21 10:20 PM,
On Tue, Aug 10, 2021 at 2:10 PM Kevin Traynor wrote:
>
> The 'Port/Rx Queue Assigment to PMD Threads' section has
> expanded over time and now includes info about stats/commands,
> manual pinning and different options for OVS assigning Rxqs to
> PMDs.
>
> Split them into different sections with
On 8/24/21 12:59 AM, num...@ovn.org wrote:
> From: Numan Siddique
>
> In the cases where the C idl client is compiled with a newer schema
> and the ovsdb-server is running with older schema, the IDL clients
> can included tables or columns in the transaction which are missing
> in the server
On 24/08/2021 12:05, Ilya Maximets wrote:
On 8/24/21 7:36 AM, Anton Ivanov wrote:
On 23/08/2021 22:36, Ilya Maximets wrote:
On 8/23/21 10:37 PM, Anton Ivanov wrote:
On 23/08/2021 21:26, Ilya Maximets wrote:
On 8/23/21 10:20 PM, Anton Ivanov wrote:
Should not be the case.
The map is
On 8/24/21 7:36 AM, Anton Ivanov wrote:
> On 23/08/2021 22:36, Ilya Maximets wrote:
>> On 8/23/21 10:37 PM, Anton Ivanov wrote:
>>> On 23/08/2021 21:26, Ilya Maximets wrote:
On 8/23/21 10:20 PM, Anton Ivanov wrote:
> Should not be the case.
>
> The map is pre-sized for the size
66 matches
Mail list logo
