Re: [ovs-dev] [PATCH] correct macro name

2021-09-13 Thread 杨燚
Acked-by: Yi Yang -邮件原件- 发件人: dev [mailto:ovs-dev-boun...@openvswitch.org] 代表 chengtcli--- via dev 发送时间: 2021年9月13日 21:34 收件人: ovs-dev 主题: [ovs-dev] [PATCH] correct macro name From: lic121 fix macro name from "VLXAN_GPE_FLAGS_P" to "VXLAN_GPE_FLAGS_P" Signed-off-by: lic121 ---

Re: [ovs-dev] [PATCH ovn v4 5/7] northd: Add n_nat_entries field to 'struct ovn_datapath'

2021-09-13 Thread Mark Michelson
Hi Mark, Of all the patches in this series, this is the one I am least sure about. It seems simple enough, but it's not clear to me 1) Why would the number of nat entries on an ovn_datapath differ from what's in the database? Since this series doesn't introduce any "real" incremental

Re: [ovs-dev] [PATCH ovn] ovn-northd: Avoid verification of NB_Global.options if nothing changed.

2021-09-13 Thread Mark Michelson
I merged this to master, branch-21.06 and branch-21.03. On 9/9/21 6:41 AM, Mark Gray wrote: On 08/09/2021 13:18, Ilya Maximets wrote: northd constructs transaction for the Northbound database options even if they don't need to be changed. This also includes verification of a current state.

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix update of a mac prefix.

2021-09-13 Thread Mark Michelson
Thanks, I backported this to branch-21.03 and branch-21.06. On 9/13/21 2:32 PM, Ilya Maximets wrote: On 9/13/21 20:29, Mark Michelson wrote: I merged this to master. Should this be backported as well? Setting options:mac_prefix="00:00:00:00:00:00" triggers infinite mac changes on all dynamic

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix update of a mac prefix.

2021-09-13 Thread Ilya Maximets
On 9/13/21 20:29, Mark Michelson wrote: > I merged this to master. Should this be backported as well? Setting options:mac_prefix="00:00:00:00:00:00" triggers infinite mac changes on all dynamic ports, so IMO this could be considered as a bug fix suitable for backporting. Best regards, Ilya

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix update of a mac prefix.

2021-09-13 Thread Mark Michelson
I merged this to master. Should this be backported as well? On 9/9/21 6:31 AM, Mark Gray wrote: On 08/09/2021 13:16, Ilya Maximets wrote: 'smap_add' doesn't check for duplicates. This leads to having more than one entry with a 'mac_prefix' key in the 'options' smap. 'ovsdb_datum_sort_unique'

Re: [ovs-dev] [PATCH ovn v2 00/10] 3x performance improvement for ddlog with load balancer benchmark

2021-09-13 Thread Mark Michelson
Hi Ben, for the series: Acked-by: Mark Michelson I had a question on patch 1, but it's minor and otherwise shouldn't block an ACK. On 9/7/21 6:45 PM, Ben Pfaff wrote: With and without these patches, I see the following performance when I run the load-balancer heavy benchmark. The

Re: [ovs-dev] [PATCH] correct macro name

2021-09-13 Thread Gregory Rose
On 9/13/2021 6:33 AM, chengtcli--- via dev wrote: From: lic121 fix macro name from "VLXAN_GPE_FLAGS_P" to "VXLAN_GPE_FLAGS_P" Signed-off-by: lic121 --- lib/packets.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/packets.h b/lib/packets.h index 515bb59..e8bdf08

Re: [ovs-dev] [OVN Patch v6 4/4] northd: Restore parallel build with dp_groups

2021-09-13 Thread Anton Ivanov
On 10/09/2021 16:37, Dumitru Ceara wrote: On 9/10/21 2:18 PM, Anton Ivanov wrote: On a side note, I ran some tests with this patch set applied and it drops performance of non-parallel case by 20% on my laptop with databases from the ovn-heater's 120 node density test. I see, you mentioned 10%

Re: [ovs-dev] [OVN Patch v6 4/4] northd: Restore parallel build with dp_groups

2021-09-13 Thread Anton Ivanov
The culprit has been found and neutralized. It is now marginally faster (~ 0.5%) than master. I will do full retests and scale tests for all combinations including parallel and if it tests out OK post v8 tomorrow. A. On 10/09/2021 17:13, Ilya Maximets wrote: On 9/10/21 4:19 PM, Anton Ivanov

Re: [ovs-dev] [PATCH ovn v4 2/2] system-ovn.at: Fix flaky "load-balancing" test (all servers targetted).

2021-09-13 Thread Numan Siddique
On Fri, Sep 10, 2021 at 1:48 PM Mark Michelson wrote: > > Hi Xavier, > > Thanks for the fix on this. Looks good to me. > > Acked-by: Mark Michelson Thanks. I applied this patch to the main branch. Numan > > On 9/10/21 8:23 AM, Xavier Simonart wrote: > > This test sends requests to LB and

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-13 Thread Vladislav Odintsov
Hi Numan, I’ve checked with OVS 2.16.0 and OVN master. The problem persists. Symptoms are the same. # grep ct_zero_snat /var/log/openvswitch/ovs-vswitchd.log 2021-09-13T16:10:01.792Z|00019|ofproto_dpif|INFO|system@ovs-system: Datapath supports ct_zero_snat Regards, Vladislav Odintsov > On 13

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-13 Thread Numan Siddique
On Mon, Sep 13, 2021 at 8:10 AM Vladislav Odintsov wrote: > > Hi, > > we’ve encountered a next problem with stateful ACLs. > > Suppose, we have one logical switch (ls1) and attached to it a VIF type > logical ports (lsp1, lsp2). > Each logical port has a linux VM besides it. > > Logical ports

Re: [ovs-dev] [PATCH v1] configure: Allow opt-in to CPU ISA opts at compile time

2021-09-13 Thread Van Haaren, Harry
> -Original Message- > From: Eelco Chaudron > Sent: Friday, September 10, 2021 3:41 PM > To: Van Haaren, Harry ; i.maxim...@ovn.org; > Stokes, Ian ; f...@sysclose.org > Cc: Amber, Kumar ; ovs-dev@openvswitch.org; > ktray...@redhat.com > Subject: Re: [PATCH v1] configure: Allow opt-in to

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-13 Thread Vladislav Odintsov
There’s a typo in my previous mail. Please, see inline fix. Regards, Vladislav Odintsov > On 13 Sep 2021, at 15:09, Vladislav Odintsov wrote: > > Hi, > > we’ve encountered a next problem with stateful ACLs. > > Suppose, we have one logical switch (ls1) and attached to it a VIF type >

[ovs-dev] [PATCH] correct macro name

2021-09-13 Thread chengtcli--- via dev
From: lic121 fix macro name from "VLXAN_GPE_FLAGS_P" to "VXLAN_GPE_FLAGS_P" Signed-off-by: lic121 --- lib/packets.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/packets.h b/lib/packets.h index 515bb59..e8bdf08 100644 --- a/lib/packets.h +++ b/lib/packets.h @@

[ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-13 Thread Vladislav Odintsov
Hi, we’ve encountered a next problem with stateful ACLs. Suppose, we have one logical switch (ls1) and attached to it a VIF type logical ports (lsp1, lsp2). Each logical port has a linux VM besides it. Logical ports reside in port group (pg1) and two ACLs are created within this PG: to-lport

Re: [ovs-dev] [PATCH v14 7/7] netdev-offload-tc: Add offload support for sFlow

2021-09-13 Thread Chris Mi via dev
On 9/13/2021 5:18 PM, Eelco Chaudron wrote: On 10 Sep 2021, at 13:02, Chris Mi wrote: On 9/9/2021 10:29 PM, Eelco Chaudron wrote: On 15 Jul 2021, at 8:01, Chris Mi wrote: Create a unique group ID to map the sFlow info when offloading sFlow action to TC. When showing the offloaded

Re: [ovs-dev] [PATCH v14 7/7] netdev-offload-tc: Add offload support for sFlow

2021-09-13 Thread Eelco Chaudron
On 10 Sep 2021, at 13:02, Chris Mi wrote: > On 9/9/2021 10:29 PM, Eelco Chaudron wrote: >> >> On 15 Jul 2021, at 8:01, Chris Mi wrote: >> >> Create a unique group ID to map the sFlow info when offloading sFlow >> action to TC. When showing the offloaded datapath flows, translate >>

Re: [ovs-dev] [PATCH v2] netdev-linux: Fix a null pointer dereference in netdev_linux_notify_sock()

2021-09-13 Thread David Marchand
On Sat, Sep 11, 2021 at 8:35 AM Yunjian Wang wrote: > > If nl_sock_join_mcgroup() returns an error, the 'sock' is freed and > set to NULL. This issues will lead to null pointer deference in > nl_sock_listen_all_nsid(). To fix it, we call nl_sock_listen_all_nsid() > before joining the mcgroups. >