Re: [ovs-dev] [PATCH] tnl: fix multiple tunnel pop for native tnl

2022-05-03 Thread lic121
On Tue, May 03, 2022 at 10:18:18PM +0200, Ilya Maximets wrote: > On 5/3/22 15:31, Peng He wrote: > > Hi, > > this issue has been found and resolved by two independent patches: > > > > http://patchwork.ozlabs.org/project/openvswitch/patch/20190726121839.92497-1-wang...@139.com/ > > > >

Re: [ovs-dev] [PATCH ovn] northd: Mark most of the SB columns as write-changed-only.

2022-05-03 Thread Han Zhou
On Thu, Apr 28, 2022 at 9:36 AM Dumitru Ceara wrote: > > This uses the newly added ovsdb_idl_set_write_changed_only_all() to > explicitly disable atomicity checks for read/write columns and to enable > optimizing the process of building the SB transaction. > > Bump OVS submodule to pick up

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Move myself to emeritus status.

2022-05-03 Thread Ben Pfaff
On Tue, May 3, 2022 at 3:15 PM Han Zhou wrote: > I believe this has been applied already last year. Oh, I see, we also transitioned to have the main branch be "main" but I was looking in the wrong place. No need to do anything. Thanks! ___ dev

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Move myself to emeritus status.

2022-05-03 Thread Han Zhou
On Thu, Apr 28, 2022 at 4:42 PM Ben Pfaff wrote: > > I am no longer actively working on OVN, so it's appropriate to move myself > to emeritus status. > > Signed-off-by: Ben Pfaff > --- > MAINTAINERS.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS.rst

Re: [ovs-dev] [RFC PATCH 6/6] Disable unsupported kernel builds

2022-05-03 Thread Ilya Maximets
On 5/3/22 21:20, Gregory Rose wrote: > > > On 4/26/2022 9:35 AM, Gregory Rose wrote: >> >> >> On 4/22/2022 8:34 AM, David Marchand wrote: >>> On Fri, Apr 22, 2022 at 9:24 AM Dumitru Ceara wrote: > @@ -37,14 +30,6 @@ jobs: >     - compiler: clang >   opts: 

Re: [ovs-dev] [PATCH] tnl: fix multiple tunnel pop for native tnl

2022-05-03 Thread Ilya Maximets
On 5/3/22 15:31, Peng He wrote: > Hi, > this issue has been found and resolved by two independent patches: > > http://patchwork.ozlabs.org/project/openvswitch/patch/20190726121839.92497-1-wang...@139.com/ > >

Re: [ovs-dev] OVS DPDK DMA-Dev library/Design Discussion

2022-05-03 Thread Van Haaren, Harry
> -Original Message- > From: Ilya Maximets > Sent: Thursday, April 28, 2022 2:00 PM > To: Richardson, Bruce > Cc: i.maxim...@ovn.org; Mcnamara, John ; Hu, Jiayu > ; Maxime Coquelin ; Van > Haaren, Harry ; Morten Brørup > ; Pai G, Sunil ; Stokes, > Ian > ; Ferriter, Cian ; ovs- >

[ovs-dev] [PATCH ovn v2] ovn-controller: Avoid recompute triggered by external_ids:ovn-installed update.

2022-05-03 Thread Han Zhou
During the process of claiming a VIF port on a chassis, there are multiple SB and local OVSDB updates by ovn-controller, which may trigger ovn-controller recompute, depending on the timing between the completion of SB and local OVSDB updates: After port claiming, ovn-controller sends an update to

[ovs-dev] [PATCH ovn 1/5] northd: move nat_flows_for_lb for skip_snat in a dedicated routine

2022-05-03 Thread Lorenzo Bianconi
Group together gw routers where a given load balancer is installed dividing them according to snat_type flag (skip_snat, force_snat). This is a preliminary patch to reduce load balancer logical flows computation cost for gw routers. Signed-off-by: Lorenzo Bianconi --- northd/northd.c | 83

[ovs-dev] [PATCH ovn 2/5] northd: move nat_flows_for_lb for force_nat in a dedicated routine

2022-05-03 Thread Lorenzo Bianconi
Similar to skip_snat counterpart, move force_nat gw router where a given lb is installed in a dedicated routine. This is a preliminary patch to reduce load balancer logical flows computation cost. Signed-off-by: Lorenzo Bianconi --- northd/northd.c | 39 +--

[ovs-dev] [PATCH ovn 5/5] northd: optimize build_gw_lrouter_nat_flows_for_lb code

2022-05-03 Thread Lorenzo Bianconi
Optimize lflow generation code in build_gw_lrouter_nat_flows_for_lb when the system is running with datapath group enabled. The following tests have been carried out on running ovn-northd on a real openshift db composed of 120 nodes, 10K pods, and 10K load balancers applied to all node logical

[ovs-dev] [PATCH ovn 4/5] northd: refactor logical router loop in build_lrouter_nat_flows_for_lb

2022-05-03 Thread Lorenzo Bianconi
This is a preliminary patch to reduce load balancer logical flows computation cost for gw routers. Signed-off-by: Lorenzo Bianconi --- northd/northd.c | 61 +++-- 1 file changed, 29 insertions(+), 32 deletions(-) diff --git a/northd/northd.c

[ovs-dev] [PATCH ovn 0/5] optimize lb lflow generation for gw router

2022-05-03 Thread Lorenzo Bianconi
ovn-main: - Statistics for 'lflows_lbs' Total samples: 51 Maximum: 1319 msec Minimum: 1282 msec 95th percentile: 1309.836278 msec Short term average: 1296.054252 msec Long term average: 1295.728676 msec ovn-main+optimization: -- Statistics for 'lflows_lbs'

[ovs-dev] [PATCH ovn 3/5] northd: move nat_flows_for_lb for gw router in a dedicated routine

2022-05-03 Thread Lorenzo Bianconi
This is a preliminary patch to reduce load balancer logical flows computation cost. Signed-off-by: Lorenzo Bianconi --- northd/northd.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/northd/northd.c b/northd/northd.c index 27be74ea7..e7901f348 100644 ---

Re: [ovs-dev] [RFC PATCH 6/6] Disable unsupported kernel builds

2022-05-03 Thread Gregory Rose
On 4/26/2022 9:35 AM, Gregory Rose wrote: On 4/22/2022 8:34 AM, David Marchand wrote: On Fri, Apr 22, 2022 at 9:24 AM Dumitru Ceara wrote: @@ -37,14 +30,6 @@ jobs:     - compiler: clang   opts: --disable-ssl -  - compiler: gcc -   

[ovs-dev] [PATCH ovn] northd: fix lflow grouping in build_lb_rules

2022-05-03 Thread Lorenzo Bianconi
Do not group lflows if the corresponding datapath does not run copp meters and the previous one has an associated copp entry. In order to fix the issue reset lflow_ref pointer to NULL if the logical router/logical flow runs a copp meter. Signed-off-by: Lorenzo Bianconi --- northd/northd.c | 15

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Delay ovn-installed if sb db is readonly

2022-05-03 Thread Han Zhou
On Thu, Apr 14, 2022 at 4:06 AM Dumitru Ceara wrote: > > On 4/1/22 12:16, Xavier Simonart wrote: > > Before this patch, when all flows for a port have been installed in OVS, > > ovn-installed was immediately written to the OVS DB; the notification of > > this change to the OVN controller (handled

[ovs-dev] [PATCH ovn] ovn-controller: Avoid recompute triggered by external_ids:ovn-installed update.

2022-05-03 Thread Han Zhou
During the process of claiming a VIF port on a chassis, there are multiple SB and local OVSDB updates by ovn-controller, which may trigger ovn-controller recompute, depending on the timing between the completion of SB and local OVSDB updates: After port claiming, ovn-controller sends an update to

[ovs-dev] [PATCH ovn] binding.c: Clear Port_Binding's encap column when encap-ip is removed.

2022-05-03 Thread Han Zhou
The external_ids:encap-ip was supported to optionally specify encap IP for a logical switch port. However, when the external_ids:encap-ip is unset, the implementation didn't clear the column in Port_Binding. This patch fixes it and updated the test to cover this scenario. Fixes: dd527a283cd8

Re: [ovs-dev] [Patch ovn] OVN - Add Support for Remote Port Mirroring

2022-05-03 Thread 0-day Robot
Bleep bloop. Greetings Abhiram R N, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #1059 FILE: utilities/ovn-nbctl.c:275:

Re: [ovs-dev] [PATCH v1] utilities: Handle dumping packets in GDB TUI

2022-05-03 Thread Paolo Valerio
Hello Mike, Mike Pattrick writes: > Currently, ovs_dump_packets will break the formatting of the GDB > terminal UI, resulting in artifacts displayed on the screen that > may make packets difficult to read. This patch suppresses stderr > output from tcpdump and feeds tcpdumps stdout into the

[ovs-dev] [Patch ovn] OVN - Add Support for Remote Port Mirroring

2022-05-03 Thread Abhiram R N
Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller. While Mirror creation just creates the mirror, the lsp-attach-mirror triggers the sequence to create Mirror in OVS DB on compute node. OVS already supports Port Mirroring. Note: This is targetted to mirror to destinations

[ovs-dev] [PATCH] [RFC] [ovn] northd: Fix IGMP external subscriber subscribing to internal feed

2022-05-03 Thread Alin-Gabriel Serdean
Add localnet ports to their corresponding southbound multicast group. Update unit tests. Reported-at: https://github.com/ovn-org/ovn/issues/125 Reported-by: Diko Parvanov Suggested-by: Dumitru Ceara Signed-off-by: Alin-Gabriel Serdean --- northd/northd.c | 17 ++--- tests/ovn.at

Re: [ovs-dev] [PATCH ovn v4 11/15] Clone packets to both port chassis

2022-05-03 Thread Mark Michelson
On 3/29/22 20:46, Ihar Hrachyshka wrote: When multiple chassis are set in requested-chassis, port binding is configured in multiple cluster locations. In case of live migration scenario, only one of the locations run a workload at a particular point in time. Yet, it's expected that the workload

Re: [ovs-dev] [PATCH] tnl: fix multiple tunnel pop for native tnl

2022-05-03 Thread Peng He
Hi, this issue has been found and resolved by two independent patches: http://patchwork.ozlabs.org/project/openvswitch/patch/20190726121839.92497-1-wang...@139.com/ http://patchwork.ozlabs.org/project/openvswitch/patch/20201009121503.43893-1-hepeng.0...@bytedance.com/ but I recently found my

[ovs-dev] [PATCH] tnl: fix multiple tunnel pop for native tnl

2022-05-03 Thread lic121
In compose_output_action__(), terminate_native_tunnel() is called to test if a pkt matches a tnl port. If yes, a TUNNEL_POP action is appended. Instead of outputing the pkt to the origin port, pkt is redirected into the tnl port. pkt metadata(i.e. nw_proto, dst_ip, dst_port) is considered when