On Wed, Jun 14, 2023 at 3:37 PM Dumitru Ceara wrote:
> On 6/13/23 16:02, Ales Musil wrote:
> > Add missing OVN_FOR_EACH_NORTHD around
> > FDB aging test.
> >
> > Signed-off-by: Ales Musil
> > ---
>
> Hi Ales,
>
> This misses the "Fixes" tag:
> Fixes: ae9a5488824c ("northd: Add FDB aging
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Peng He needs to sign off.
WARNING: Unexpected sign-offs from developers who are not
OVS allows overlapping megaflows, as long as the actions of these
megaflows are equal. However, the current implementation of action
modification relies on flow_lookup instead of ufid, this could result
in looking up a wrong megaflow and make the ukeys and megaflows inconsistent
Just like the
Simon Horman 于2023年6月14日周三 20:37写道：
> On Tue, Jun 13, 2023 at 09:41:42AM +0800, Peng He wrote:
> > Hi, Simon,
> >
> > I guess it's not related, as my patch fixes the code in dpif-netdev.c it
> > should has any impact on the ovsdb side.
> > But I am not sure that.
> > Is this test case a spike
On 6/14/23 15:17, Lorenzo Bianconi wrote:
> In the current codebase for distributed gw router port use-case,
> it is not possible to add a load balancer that redirects the traffic
> to a back-end if it is used as internal IP of a FIP NAT rule since
> the reply traffic is never centralized. Fix the
On 6/14/23 22:37, Han Zhou wrote:
> On Wed, Jun 14, 2023 at 4:16 AM Dumitru Ceara wrote:
>>
>> On 6/10/23 20:10, Han Zhou wrote:
>>> The test case is unstable because there are many factors that can impact
>>> the number of recomputes. For example, when northd updates both NB and
>>> SB, both
This adds a Python version of the async DNS support added in:
771680d96 DNS: Add basic support for asynchronous DNS resolving
The above version uses the unbound C library, and this
implimentation uses the SWIG-wrapped Python version of that.
In the event that the Python unbound library is not
On Wed, Jun 14, 2023 at 4:16 AM Dumitru Ceara wrote:
>
> On 6/10/23 20:10, Han Zhou wrote:
> > The test case is unstable because there are many factors that can impact
> > the number of recomputes. For example, when northd updates both NB and
> > SB, both sides have in-flight transactions, and if
On 6/14/23 21:08, Ilya Maximets wrote:
> On 6/14/23 20:11, Paolo Valerio wrote:
>> Ilya Maximets writes:
>>
>>> On 6/12/23 16:57, Aaron Conole wrote:
Paolo Valerio writes:
> since a27d70a89 ("conntrack: add generic IP protocol support") all
> the unrecognized IP protocols get
On 5/26/23 16:41, Timothy Redaelli wrote:
> Since on CentOS/RHEL the builds are based on stable branches and not on
> tags for debugging purpose it's better to have the downstream version as
> version so it's easier to know which commits are included in a build.
>
> This commit adds
On 6/14/23 20:11, Paolo Valerio wrote:
> Ilya Maximets writes:
>
>> On 6/12/23 16:57, Aaron Conole wrote:
>>> Paolo Valerio writes:
>>>
since a27d70a89 ("conntrack: add generic IP protocol support") all
the unrecognized IP protocols get handled using ct_proto_other ops
and are
The netdev receiving packets is supposed to provide the flags
indicating if the L4 checksum was verified and it is OK or BAD,
otherwise the stack will check when appropriate by software.
If the packet comes with good checksum, then postpone the
checksum calculation to the egress device if needed.
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Renamed documentation to reflect the userspace checksum nature of
this feature
- Edited for
This patch modifies netdev_get_status to include information about
checksum offload status by port, allowing the user to gain insight into
where checksum offloading is active.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Removed
This patch set is a stripped down subset of the initial 17 patchset introduced
by Flavio Leitner in 2021.
The initial omnibus patchset was very complex and included a refactor, which
stymied review and would have made backporting more complex. It also didn't
resolve an ongoing issue with the DPDK
The netdev receiving packets is supposed to provide the flags
indicating if the IP checksum was verified and it is GOOD or BAD,
otherwise the stack will check when appropriate by software.
If the packet comes with good checksum, then postpone the
checksum calculation to the egress device if
Ilya Maximets writes:
> On 6/12/23 16:57, Aaron Conole wrote:
>> Paolo Valerio writes:
>>
>>> since a27d70a89 ("conntrack: add generic IP protocol support") all
>>> the unrecognized IP protocols get handled using ct_proto_other ops
>>> and are managed as L3 using 3 tuples.
>>>
>>> This patch
Hi Mark,
thanks for taking time to look on this!
Your point with a hung OVS is really an interesting case.
From one hand it’s a possible situation, and from another I guess it’s much
higher probability for OVS to be busy by some other work rather than to hang in
a loop. In my installation the
On Wed, Jun 14, 2023 at 3:37 PM Kevin Traynor wrote:
>
> Max requested sleep time and status for a PMD thread
> is logged at start up or when changed, but it can be
> convenient to have a command to dump this information
> explicitly.
>
> It is envisaged that this will be expanded when future
>
On Wed, Jun 14, 2023 at 3:37 PM Kevin Traynor wrote:
>
> This is just cosmetic. There is no change to the tests.
Hum, except one issue in CHECK_DP_SLEEP_MAX, I would tend to agree :-).
>
> Signed-off-by: Kevin Traynor
> ---
> tests/pmd.at | 39 ---
> 1 file
Bleep bloop. Greetings David Marchand, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the
On 6/14/2023 9:22 PM, Ilya Maximets wrote:
External email: Use caution opening links or attachments
On 6/14/23 10:22, Roi Dayan wrote:
From: Gavin Li
Kernels that do not support vxlan gbp would treat the rule that has vxlan
gbp encap action or vxlan gbp id match differently, either reject
Thanks Dumitru!
> On 14 Jun 2023, at 16:37, Dumitru Ceara wrote:
>
> On 5/30/23 17:03, Vladislav Odintsov wrote:
>> This patch is intended to make next two changes:
>>
>> 1. Support create/update of MAC_Binding for GARP/ND from HW VTEP.
>>
>> Prior to this patch MAC_Binding records were
Signed-off-by: Kevin Traynor
---
Documentation/topics/dpdk/pmd.rst | 4 ++--
NEWS | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/topics/dpdk/pmd.rst
b/Documentation/topics/dpdk/pmd.rst
index bedd42194..40e6b7843 100644
---
At some point in OVS history, some virtio features were announced as
supported (ECN and UFO virtio features).
The userspace TSO code, which has been added later, does not support
those features and tries to disable them.
This breaks OVS upgrades: if an existing VM already negotiated such
On 5/30/23 17:03, Vladislav Odintsov wrote:
> This patch is intended to make next two changes:
>
> 1. Support create/update of MAC_Binding for GARP/ND from HW VTEP.
>
> Prior to this patch MAC_Binding records were created only when LRP issued
> ARP request/Neighbor solicitation. If IP to MAC in
On 6/13/23 16:02, Ales Musil wrote:
> Add missing OVN_FOR_EACH_NORTHD around
> FDB aging test.
>
> Signed-off-by: Ales Musil
> ---
Hi Ales,
This misses the "Fixes" tag:
Fixes: ae9a5488824c ("northd: Add FDB aging mechanism")
I added it and pushed the patch to the main branch.
Regards,
Add unit tests for new per pmd options of pmd-sleep-max.
Signed-off-by: Kevin Traynor
---
tests/pmd.at | 153 +++
1 file changed, 153 insertions(+)
diff --git a/tests/pmd.at b/tests/pmd.at
index e83206a9a..25f6b86a7 100644
--- a/tests/pmd.at
+++
Extend 'pmd-sleep-max' so that individual PMD thread cores
may have a specified max sleep request value.
Any PMD thread core without a value will use the datapath default
(no sleep request) or datapath global value set by the user.
To set PMD thread cores 8 and 9 to never request a load based
Max requested sleep time and status for a PMD thread
is logged at start up or when changed, but it can be
convenient to have a command to dump this information
explicitly.
It is envisaged that this will be expanded when future
additions are added.
Signed-off-by: Kevin Traynor
---
This is just cosmetic. There is no change to the tests.
Signed-off-by: Kevin Traynor
---
tests/pmd.at | 39 ---
1 file changed, 24 insertions(+), 15 deletions(-)
diff --git a/tests/pmd.at b/tests/pmd.at
index 374ad7217..64d8f6e2b 100644
--- a/tests/pmd.at
other_config:pmd-maxsleep is a config option to allow
PMD thread cores to sleep under low or no load conditions.
Rename it to 'pmd-sleep-max' to allow a more structured
name and so that additional options or command can follow
the 'pmd-sleep-xyz' pattern.
Signed-off-by: Kevin Traynor
---
Patches 1-4 are about polishing the existing functionality
and preparing for new functionality later in the series.
Patch 1 renames 'pmd-maxsleep' to 'pmd-sleep-max'. I think
this is allowed as it is still experimental, but we can keep
'pmd-maxsleep' as well, if people think it's a problem.
On 5/18/23 05:50, Terry Wilson wrote:
> This adds a Python version of the async DNS support added in:
>
> 771680d96 DNS: Add basic support for asynchronous DNS resolving
>
> The above version uses the unbound C library, and this
> implimentation uses the SWIG-wrapped Python version of that.
>
>
On 6/14/23 10:22, Roi Dayan wrote:
> From: Gavin Li
>
> Kernels that do not support vxlan gbp would treat the rule that has vxlan
> gbp encap action or vxlan gbp id match differently, either reject it or
> just skip the action/match and continue processing the knowing ones.
>
> To solve the
In the current codebase for distributed gw router port use-case,
it is not possible to add a load balancer that redirects the traffic
to a back-end if it is used as internal IP of a FIP NAT rule since
the reply traffic is never centralized. Fix the issue centralizing the
traffic if it is the reply
Ilya Maximets, Jun 14, 2023 at 13:21:
> While files are present in tabs-allowed it doesn't mean that
> all of them actually use tabs. I'm not sure about other
> folders, but at least the windows include folder contains files
> with different styles.
>
> Is it possible to just exclude the folder
On Wed, Jun 14, 2023 at 11:22:39AM +0300, Roi Dayan wrote:
> From: Gavin Li
>
> Add a vxlan gbp offload test case:
>
> vxlan offloads with gbp extention - ping between two ports - offloads
> enabled ok
>
> Signed-off-by: Gavin Li
Reviewed-by: Simon Horman
On Wed, Jun 14, 2023 at 11:22:38AM +0300, Roi Dayan wrote:
> From: Gavin Li
>
> Kernels that do not support vxlan gbp would treat the rule that has vxlan
> gbp encap action or vxlan gbp id match differently, either reject it or
> just skip the action/match and continue processing the knowing
On Wed, Jun 14, 2023 at 11:22:37AM +0300, Roi Dayan wrote:
> From: Gavin Li
>
> Add TC offload support for vxlan encap with gbp option
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
> Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
___
On Wed, Jun 14, 2023 at 11:22:35AM +0300, Roi Dayan wrote:
> From: Gavin Li
>
> Add TC offload support for filtering vxlan tunnels with gbp option
>
> Signed-off-by: Gavin Li
> Reviewed-by: Gavi Teitz
> Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
On Wed, Jun 14, 2023 at 11:22:34AM +0300, Roi Dayan wrote:
> From: Gavin Li
>
> Linux kernel netlink module added NLA_F_NESTED flag checking for nested
> netlink messages in 5.2. A nested message without the flag set will be
> treated as malformated one. The check is optional and is controlled
On Wed, Jun 14, 2023 at 02:34:39AM +0800, James Raphael Tiovalen wrote:
> This commit adds a few null pointer assertions and checks to some return
> values of `ovsdb_table_schema_get_column`. If a null pointer is
> encountered in these blocks, either the assertion will fail or the
> control flow
On Wed, Jun 14, 2023 at 02:34:37AM +0800, James Raphael Tiovalen wrote:
> This commit adds zero-initializations by changing `SFL_ALLOC` from
> `malloc` to `xzalloc`, adding a `memset` call to `sflAlloc`,
> initializing a `pollfd` struct variable with zeroes, and changing some
> calls to `xmalloc`
On Tue, Jun 13, 2023 at 09:41:42AM +0800, Peng He wrote:
> Hi, Simon,
>
> I guess it's not related, as my patch fixes the code in dpif-netdev.c it
> should has any impact on the ovsdb side.
> But I am not sure that.
> Is this test case a spike test case? Is there any testsuite log?
* Please
On 6/12/23 16:57, Aaron Conole wrote:
> Paolo Valerio writes:
>
>> since a27d70a89 ("conntrack: add generic IP protocol support") all
>> the unrecognized IP protocols get handled using ct_proto_other ops
>> and are managed as L3 using 3 tuples.
>>
>> This patch stores L4 information for SCTP in
Hi Terry,
Thanks for the patch. I have some minor comments and questions inline but
overall it looks pretty good to me.
On 5/18/23 05:50, Terry Wilson wrote:
This adds a Python version of the async DNS support added in:
771680d96 DNS: Add basic support for asynchronous DNS resolving
The
On 6/13/23 14:25, Robin Jarry wrote:
> EditorConfig is a file format and collection of text editor plugins for
> maintaining consistent coding styles between different editors and IDEs.
>
> Initialize the file following the coding rules in
> Documentation/internals/contributing/coding-style.rst
On 6/10/23 20:10, Han Zhou wrote:
> The test case is unstable because there are many factors that can impact
> the number of recomputes. For example, when northd updates both NB and
> SB, both sides have in-flight transactions, and if the SB notification
> comes back before the NB transaction (for
On 6/14/23 11:36, Igor Zhukov wrote:
> Sure.
>
> Acked-by: Igor Zhukov
>
Thanks, I pushed this to branch-22.03.
Regards,
Dumitru
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Sure.
Acked-by: Igor Zhukov
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
I agree.
Yes, we needed to check the build on version 22.03.
Sorry.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 6/14/23 11:19, Igor Zhukov wrote:
> I agree.
>
> Yes, we needed to check the build on version 22.03.
>
> Sorry.
>
Can I consider this a formal "Acked-by:" and push the patch to unblock CI?
Thanks,
Dumitru
___
dev mailing list
I agree.
Yes, we needed to check the build on version 22.03.
Sorry.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 6/9/23 21:13, Mark Michelson wrote:
> I pushed this change to main and all branches back to 22.03. Thanks!
>
Branch 22.03 doesn't have run_update_worker_pool() so this backport
broke compilation there. I posted a 22.03-only revert patch:
This reverts commit 6849811833b5a40137288145dc2c3e4ac22f90fd.
The function run_update_worker_pool() doesn't exist on branches <=
22.03 as the parallelization code changed in newer branches. There's no
need to complicate things just to make valgrind happy.
Fixes: 6849811833b5 ("call
From: Gavin Li
Add a vxlan gbp offload test case:
vxlan offloads with gbp extention - ping between two ports - offloads
enabled ok
Signed-off-by: Gavin Li
---
tests/system-offloads-traffic.at | 49
1 file changed, 49 insertions(+)
diff --git
From: Gavin Li
Kernels that do not support vxlan gbp would treat the rule that has vxlan
gbp encap action or vxlan gbp id match differently, either reject it or
just skip the action/match and continue processing the knowing ones.
To solve the issue, probe and disallow inserting rules with vxlan
From: Gavin Li
Add TC offload support for vxlan encap with gbp option
Signed-off-by: Gavin Li
Reviewed-by: Gavi Teitz
Reviewed-by: Roi Dayan
---
acinclude.m4 | 7
include/linux/tc_act/tc_tunnel_key.h | 17 +++-
lib/netdev-offload-tc.c | 31
From: Gavin Li
Add TC offload support for filtering vxlan tunnels with gbp option
Signed-off-by: Gavin Li
Reviewed-by: Gavi Teitz
Reviewed-by: Roi Dayan
---
include/linux/pkt_cls.h | 13 ++
lib/netdev-offload-tc.c | 17
lib/tc.c| 92
From: Gavin Li
Most of the data members of struct tc_action{ } are defined as anonymous
struct in place. Instead of passing all members of an anonymous struct,
which is not flexible to new members being added, expose encap as named
struct and pass it entirely.
Signed-off-by: Gavin Li
From: Gavin Li
Linux kernel netlink module added NLA_F_NESTED flag checking for nested
netlink messages in 5.2. A nested message without the flag set will be
treated as malformated one. The check is optional and is controlled by
message policy. To avoid this, add NLA_F_NESTED explicitly for all
From: Gavin Li
Extract vxlan gbp option decoding to odp_decode_gbp_raw to be used in
following commits.
Signed-off-by: Gavin Li
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
---
lib/odp-util.c | 9 +++--
lib/odp-util.h | 8
2 files changed, 11 insertions(+), 6 deletions(-)
From: Gavin Li
Extract vxlan gbp option encoding to odp_encode_gbp_raw to be used in
following commits.
Signed-off-by: Gavin Li
Reviewed-by: Roi Dayan
Reviewed-by: Simon Horman
---
lib/odp-util.c | 5 +++--
lib/odp-util.h | 5 +
2 files changed, 8 insertions(+), 2 deletions(-)
diff
From: Gavin Li
Tc flower tunnel key options were encoded in nl_msg_put_flower_tunnel_opts
and decoded in nl_parse_flower_tunnel_opts. Only geneve was supported.
To avoid adding more arguments to the function to support more vxlan
options in the future, change the function arguments to pass
Hi,
This series adds TC offload support for filtering vxlan tunnels with gbp option.
First 4 patches do some refactoring and the later patches adds the feature.
Thanks,
Roi
changelog
v4:
- probe TC kernel for vxlan gbp support.
- add test.
- style fix in patch 3.
- log warn instead of err in
66 matches
Mail list logo
