On Fri, Feb 2, 2024 at 5:23 PM Mark Michelson wrote:
>
> Acked-by: Mark Michelson
Thanks. Applied to main.
Numan
>
> On 2/2/24 16:57, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > The patch which added the helper function 'check_engine_stats'
> > didn't add it properly because of
Acked-by: Mark Michelson
On 2/2/24 16:57, num...@ovn.org wrote:
From: Numan Siddique
The patch which added the helper function 'check_engine_stats'
didn't add it properly because of which we are seeing the below
warnings.
test-source: line 2187: check_engine_stats: command not found
This
From: Numan Siddique
The patch which added the helper function 'check_engine_stats'
didn't add it properly because of which we are seeing the below
warnings.
test-source: line 2187: check_engine_stats: command not found
This patch fixes it by using m4_divert_push/m4_divert_pop macros.
Fixes:
On Fri, Feb 2, 2024 at 11:50 AM Mark Michelson wrote:
>
> ---
> NEWS | 3 +++
> configure.ac | 2 +-
> debian/changelog | 6 ++
> 3 files changed, 10 insertions(+), 1 deletion(-)
With your signed-off-by tag added
Acked-by: Numan Siddique
Numan
>
> diff --git a/NEWS
On Fri, Feb 2, 2024 at 11:50 AM Mark Michelson wrote:
>
> ---
> NEWS | 4 ++--
> configure.ac | 2 +-
> debian/changelog | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
With your signed-off-by tag added
Acked-by: Numan Siddique
Numan
>
> diff --git a/NEWS b/NEWS
Thanks Lorenzo,
Acked-by: Mark Michelson
On 2/2/24 08:49, Lorenzo Bianconi wrote:
Similar to OVN static routes, introduce the capability to link a BFD
session for OVN reroute policies.
Reported-at: https://issues.redhat.com/browse/FDP-234
Signed-off-by: Lorenzo Bianconi
---
NEWS
> Hi Lorenzo,
>
> I have a few comments below.
>
> On 1/17/24 06:11, Lorenzo Bianconi wrote:
> > Similar to OVN static routes, introduce the capability to link a BFD
> > session for OVN reroute policies.
> >
> > Reported-at: https://issues.redhat.com/browse/FDP-234
> > Signed-off-by: Lorenzo
Thanks a bunch Lorenzo.
Acked-by: Mark Michelson
I plan to merge this in a few hours, giving a bit of time in case others
want to review this. When I merge, I'll fold in Dumitru's suggestion.
On 2/2/24 11:03, Dumitru Ceara wrote:
On 2/2/24 16:41, Lorenzo Bianconi wrote:
Add the capbility
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Mark Michelson needs to sign off.
Lines checked: 53, Warnings: 0, Errors: 1
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Mark Michelson needs to sign off.
Lines checked: 55, Warnings: 0, Errors: 1
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index ff5e3c9ce..fadfcacfb 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+Post v24.03.0
+-
+
OVN v24.03.0 - xx xxx
---
NEWS | 4 ++--
configure.ac | 2 +-
debian/changelog | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/NEWS b/NEWS
index 6553bd078..ff5e3c9ce 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,5 @@
-Post v23.09.0
--
+OVN v24.03.0 - xx xxx
On 2/2/24 16:38, Simon Horman wrote:
> Since the patch-set that included [1] there has been a policy of using
> the term member for bonds, LACP, and bundle contexts. This is
> consistent with the more recently adopted policy of using the inclusive
> naming word list v1 [2, 3].
>
> This patch
On 2/2/24 16:41, Lorenzo Bianconi wrote:
> Add the capbility to mark (through pkt.mark) incoming/outgoing packets
> in logical_switch datapath according to user configured QoS rule.
>
> Co-developed-by: Dumitru Ceara
> Reported-at: https://issues.redhat.com/browse/FDP-42
> Signed-off-by: Lorenzo
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 286 characters long (recommended limit is 79)
#402 FILE:
On 1/29/24 07:20, Ales Musil wrote:
> The ct_commit nat was hardcoded to use DNAT zone
> in router pipeline. Extend it that it accepts
> two new arguments (snat/dnat) which will determine
> the zone for router pipeline. The switch pipeline
> has only one, so it resolves to the same for both
Add the capbility to mark (through pkt.mark) incoming/outgoing packets
in logical_switch datapath according to user configured QoS rule.
Co-developed-by: Dumitru Ceara
Reported-at: https://issues.redhat.com/browse/FDP-42
Signed-off-by: Lorenzo Bianconi
---
Changes since v2:
- set max dscp/mark
Since the patch-set that included [1] there has been a policy of using
the term member for bonds, LACP, and bundle contexts. This is
consistent with the more recently adopted policy of using the inclusive
naming word list v1 [2, 3].
This patch addresses two instances where the term member should
Since the patch-set that included [1] there has been a policy of using
the term member for bonds, LACP, and bundle contexts. This is
consistent with the more recently adopted policy of using the inclusive
naming word list v1 [2, 3].
This patch addresses the name of the bond_active_member ovsdb
Since the patch-set that included [1] there has been a policy of using
the term member for bonds, LACP, and bundle contexts. This is
consistent with the more recently adopted policy of using the inclusive
naming word list v1 [2, 3].
This patch-set addresses several instances where the term
On Fri, Feb 2, 2024 at 5:37 AM Ales Musil wrote:
>
> On Thu, Feb 1, 2024 at 1:10 AM wrote:
>
> > From: Numan Siddique
> >
> > Fixes: 121661678317 ("northd: Move router ports SB PB options sync to
> > sync_to_sb_pb node.")
> >
> > Signed-off-by: Numan Siddique
> > ---
> >
> > v1 -> v2
> > -
On 2 Feb 2024, at 15:16, Aaron Conole wrote:
>>> +OVS_USDT_PROBE(revalidate, flow_result, reason, udpif,
>>> ukey);
>>>
>>> I have been experimenting with several upcall tracking techniques
>> that would make it easier to correlate upcalls with their subsequent
>> related
Eelco Chaudron writes:
> On 2 Feb 2024, at 11:31, Adrian Moreno wrote:
>
>> On 2/1/24 10:02, Eelco Chaudron wrote:
>>>
>>>
>>> On 31 Jan 2024, at 18:03, Aaron Conole wrote:
>>>
Eelco Chaudron writes:
> On 25 Jan 2024, at 21:55, Aaron Conole wrote:
>
>> From: Kevin Sprague
Adrian Moreno writes:
> On 2/1/24 10:02, Eelco Chaudron wrote:
>> On 31 Jan 2024, at 18:03, Aaron Conole wrote:
>>
>>> Eelco Chaudron writes:
>>>
On 25 Jan 2024, at 21:55, Aaron Conole wrote:
> From: Kevin Sprague
>
> During normal operations, it is useful to understand
Eelco Chaudron writes:
> On 1 Feb 2024, at 18:28, Aaron Conole wrote:
>
>> Eelco Chaudron writes:
>>
>>> On 31 Jan 2024, at 18:03, Aaron Conole wrote:
>>>
Eelco Chaudron writes:
> On 25 Jan 2024, at 21:55, Aaron Conole wrote:
>
>> From: Kevin Sprague
>>
>> During
Similar to OVN static routes, introduce the capability to link a BFD
session for OVN reroute policies.
Reported-at: https://issues.redhat.com/browse/FDP-234
Signed-off-by: Lorenzo Bianconi
---
NEWS | 1 +
northd/northd.c | 86 ++
In order to properly check if we already have a running BFD session for
the next hop used by the brand new route, load logical port column of
the nb BFD table in nbctl_pre_lr_route_add routine.
Acked-by: Mark Michelson
Fixes: db6d30783bec ("ovn-nbctl: Don't replicate entire database
Fix regression introduce in BFD system tests
Acked-by: Mark Michelson
Fixes: 1655a6c146ca ("northd, utils: support for RouteTables in LRs")
Signed-off-by: Lorenzo Bianconi
---
tests/system-ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/system-ovn.at
Changes since v1:
- improve ipv6 address lookup
Lorenzo Bianconi (3):
test: Fix false positive in BFD system test.
ovn-nbctl: Fix nbctl_pre_lr_route_add for BFD.
northd: Add BFD support for ECMP route policy.
NEWS | 1 +
northd/northd.c | 86
On 2 Feb 2024, at 11:55, Adrian Moreno wrote:
> On 1/30/24 16:45, Eelco Chaudron wrote:
>>
>>
>> On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
>>
>>> This series introduces a python utility called ovs-flowviz.
>>>
>>> The goal of this utility is to read both datapath and Openflow flows
>>>
On Tue, Jan 30, 2024 at 10:08 PM Mark Michelson wrote:
> This adds a new "chassis_name" column to the BFD table. ovn-northd sets
> this to the logical port's chassis name when creating the BFD record.
> RBAC has been updated so that chassis may only update their own records.
>
> Signed-off-by:
On Tue, Jan 30, 2024 at 10:44 PM Mark Michelson wrote:
> On 1/30/24 16:08, Mark Michelson wrote:
> > RBAC did not restrict which chassis could update IGMP_Groups. With this
> > change, we add a new "chassis_name" column to IGMP_Group.
> >
> > This may seem odd since there is already a "chassis"
On Tue, Jan 30, 2024 at 10:08 PM Mark Michelson wrote:
> Service monitors already had the restriction that chassis could not
> insert or delete records. However, there was nothing restricting chassis
> from updating records for service monitors that are relevant to other
> chassis.
>
> This
Thanks for your review Ales.
On Fri, 2 Feb 2024 at 07:34 Ales Musil wrote:
>
>
> On Tue, Jan 30, 2024 at 3:10 PM Roberto Bartzen Acosta via dev <
> ovs-dev@openvswitch.org> wrote:
>
>> This commit fixes the prefix filter function as the return condition for
>> IPv6 addresses is disabling the
Branches 2.17/3.0/3.1/3.2 are using newer DPDK LTS releases.
Update the faq.
Signed-off-by: Kevin Traynor
---
Documentation/faq/releases.rst | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst
index
Update the CI and docs to use DPDK 22.11.4.
Signed-off-by: Kevin Traynor
---
.github/workflows/build-and-test.yml | 2 +-
Documentation/faq/releases.rst | 8
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 +-
4 files changed, 10
Update the CI and docs to use DPDK 22.11.4.
Signed-off-by: Kevin Traynor
---
.github/workflows/build-and-test.yml | 2 +-
Documentation/faq/releases.rst | 6 +++---
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 +-
4 files changed, 9
Update the CI and docs to use DPDK 21.11.6.
Signed-off-by: Kevin Traynor
---
.ci/linux-build.sh | 2 +-
Documentation/faq/releases.rst | 4 ++--
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 +-
4 files changed, 8
Update the CI and docs to use DPDK 21.11.6.
Signed-off-by: Kevin Traynor
---
.ci/linux-build.sh | 2 +-
Documentation/faq/releases.rst | 2 +-
Documentation/intro/install/dpdk.rst | 8
NEWS | 2 +-
4 files changed, 7
On 1/30/24 22:20, num...@ovn.org wrote:
> From: Numan Siddique
>
Hi Numan,
> This patch series adds incremental processing in the lflow engine
> node to handle changes to northd and other engine nodes.
> Changed related to load balancers and NAT are mainly handled in
> this patch series.
>
>
On 1/30/24 22:23, num...@ovn.org wrote:
> From: Numan Siddique
>
> A new engine node "global_config" is added which handles the changes
> to NB_Global an SB_Global tables. It also creates these rows if
> not present.
>
> Without the I-P, any changes to the options column of these tables
>
On 1/30/24 22:23, num...@ovn.org wrote:
> From: Numan Siddique
>
> Acked-by: Han Zhou
> Signed-off-by: Numan Siddique
> ---
Acked-by: Dumitru Ceara
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 1/30/24 22:22, num...@ovn.org wrote:
> From: Numan Siddique
>
> Acked-by: Han Zhou
> Signed-off-by: Numan Siddique
> ---
Acked-by: Dumitru Ceara
Thanks!
___
dev mailing list
d...@openvswitch.org
On 1/30/24 22:22, num...@ovn.org wrote:
> From: Numan Siddique
>
> Since northd tracked data has the changed lb information,
> the lflow change handler for northd inputs can now handle
> lb updates incrementally. All the lflows generated for
> each lb is stored in the
On 1/30/24 22:21, num...@ovn.org wrote:
> From: Numan Siddique
>
> ovn_lflow_add() and other related functions/macros are now moved
> into a separate module - lflow-mgr.c. This module maintains a
> table 'struct lflow_table' for the logical flows. lflow table
> maintains a hmap to store the
On 1/30/24 22:21, num...@ovn.org wrote:
> From: Numan Siddique
>
> This new engine now maintains the load balancer and NAT data of a
> logical router which was earlier part of northd engine node data.
> The main inputs to this engine are:
>- northd node
>- lr_nat node
>- lb_data node
On Fri, Feb 2, 2024 at 12:19 PM Ales Musil wrote:
>
>
> On Tue, Jan 30, 2024 at 2:59 PM Mohammad Heib wrote:
>
>> ovn-controller immediately removes the vport_bindings requests that were
>> generated by VIFs after handling them locally, this approach is intended
>> to avoid binding the vport to
On Tue, Jan 30, 2024 at 2:59 PM Mohammad Heib wrote:
> ovn-controller immediately removes the vport_bindings requests that were
> generated by VIFs after handling them locally, this approach is intended
> to avoid binding the vport to one VIF only and allocate the vport
> between the different
On 2/2/24 10:32, Felix Huettner via dev wrote:
> Previously the kernel did not provide a netlink interface to flush/list
> only conntrack entries matching a specific zone. With [1] it is now
> possible to flush and list conntrack entries filtered by zone. Older
> kernels not yet supporting this
On 1/30/24 16:45, Eelco Chaudron wrote:
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
This series introduces a python utility called ovs-flowviz.
The goal of this utility is to read both datapath and Openflow flows
(using the flow library already available) and print them in different
On 1/30/24 16:56, Eelco Chaudron wrote:
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
Using the existing FlowTree and HTMLFormatter, create an HTML tree
visualization that also supports collapsing and expanding entire flow
trees and subtrees.
This looks good to me, maybe add an example in
On 1/30/24 16:55, Eelco Chaudron wrote:
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
When anaylizing OVN issues, it might be useful to see what OpenFlow
flows were generated from each logical flow. In order to make it simpler
to visualize this, add a cookie format that simply sorts the
On 1/30/24 16:54, Eelco Chaudron wrote:
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
This view is interesting for debugging the logical pipeline. It arranges
the flows in "logical" groups (not to be confused with OVN's
Logical_Flows). A logical group of flows is a set of flows that:
- Have
On 1/30/24 16:53, Eelco Chaudron wrote:
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
Datapath flows can be arranged into a "tree"-like structure based on
recirculation ids, e.g:
recirc(0),eth(...),ipv4(...) actions=ct,recirc(0x42)
\-> recirc(42),ct_state(0/0),eth(...),ipv4(...)
On 1/30/24 16:51, Eelco Chaudron wrote:
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
Add a HTML Formatter and use it to print OpenFlow flows in an HTML list
with table links.
Signed-off-by: Adrian Moreno
No real comments from my side, this looks good! Maybe add an example to the
commit
On 2 Feb 2024, at 11:31, Adrian Moreno wrote:
> On 2/1/24 10:02, Eelco Chaudron wrote:
>>
>>
>> On 31 Jan 2024, at 18:03, Aaron Conole wrote:
>>
>>> Eelco Chaudron writes:
>>>
On 25 Jan 2024, at 21:55, Aaron Conole wrote:
> From: Kevin Sprague
>
> During normal
On Wed, Jan 31, 2024 at 1:14 PM Mohammad Heib wrote:
> Expose the igmp/mld group protocol version through the
> IGMP_GROUP table in SBDB.
>
> This patch can be used by ovn consumer for debuggability purposes, user
> now can match between the protocol version used in the OVN logical
> switches
On 1/30/24 16:50, Eelco Chaudron wrote:
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
It has two basic styles defined: "dark" and "light" intended for
dark and light terminals.
This patch looks fine to me. Should we maybe add an example in the commit
message on how to use the --style
On 1/30/24 16:49, Eelco Chaudron wrote:
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
Add a flow formatting framework and one implementation for console
printing using rich.
The flow formatting framework is a simple set of classes that can be
used to write different flow formatting
On 1/30/24 16:47, Eelco Chaudron wrote:
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
process.py contains a useful base class that processes files
odp.py and ofp.py: contain datapath and openflow subcommand definitions
as well as the first formatting option: json.
Also, this patch adds
On 1/30/24 16:46, Eelco Chaudron wrote:
On 1 Dec 2023, at 20:14, Adrian Moreno wrote:
Add a new python package (just the scheleton for now) to hold a flow
visualization tool based on the flow parsing library.
Thanks for this series, and sorry for the late review :(
No worries! Thanks
On Thu, Feb 1, 2024 at 1:10 AM wrote:
> From: Numan Siddique
>
> Fixes: 121661678317 ("northd: Move router ports SB PB options sync to
> sync_to_sb_pb node.")
>
> Signed-off-by: Numan Siddique
> ---
>
> v1 -> v2
> -
>* Fix the checkpatch errors.
>
> tests/ovn-northd.at | 2 ++
> 1
On Tue, Jan 30, 2024 at 3:10 PM Roberto Bartzen Acosta via dev <
ovs-dev@openvswitch.org> wrote:
> This commit fixes the prefix filter function as the return condition for
> IPv6 addresses is disabling the advertisement of all learned prefixes
> regardless of the match with the blacklist or not.
On 2/1/24 10:02, Eelco Chaudron wrote:
On 31 Jan 2024, at 18:03, Aaron Conole wrote:
Eelco Chaudron writes:
On 25 Jan 2024, at 21:55, Aaron Conole wrote:
From: Kevin Sprague
During normal operations, it is useful to understand when a particular flow
gets removed from the system.
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller :
On Wed, 31 Jan 2024 17:08:22 +1300 you wrote:
> Add a test case for regression in openvswitch nat that was fixed by
> commit e6345d2824a3 ("netfilter: nf_nat: fix action not being set for
> all ct states").
>
>
On Tue, Jan 30, 2024 at 1:07 PM Ilya Maximets wrote:
> checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using
> outdated Node.js 16 which is now deprecated in GHA [1], so these
> actions may stop working soon.
>
> Updating to most recent major versions with Node.js 20. This stops
>
On Fri, Feb 2, 2024 at 4:21 AM Mark Michelson wrote:
> The documentation for Service_Monitors in the southbound database state
> that only IPv4 is supported. However, IPv6 service monitors have been
> supported since OVN 23.03 was released.
>
> This patch addresses the problem by removing the
On 1 Feb 2024, at 18:28, Aaron Conole wrote:
> Eelco Chaudron writes:
>
>> On 31 Jan 2024, at 18:03, Aaron Conole wrote:
>>
>>> Eelco Chaudron writes:
>>>
On 25 Jan 2024, at 21:55, Aaron Conole wrote:
> From: Kevin Sprague
>
> During normal operations, it is useful to
Previously the kernel did not provide a netlink interface to flush/list
only conntrack entries matching a specific zone. With [1] it is now
possible to flush and list conntrack entries filtered by zone. Older
kernels not yet supporting this feature will ignore the filter.
For the list request that
69 matches
Mail list logo
