Re: [ovs-dev] [PATCH ovs v3] Documentation: Adding note about using the jemalloc library.

2024-02-04 Thread Eelco Chaudron
On 5 Feb 2024, at 2:24, Roberto Bartzen Acosta via dev wrote: > Updating the reference documentation with the inclusion of possible building > problems with libjemalloc and solution suggestions. > > Reported-at: > https://bugs.launchpad.net/ubuntu/+source/openvswitch/+bug/2015748 >

Re: [ovs-dev] [PATCH] bfd: Improve state change log message.

2024-02-04 Thread Eelco Chaudron
On 4 Feb 2024, at 15:40, Timothy Redaelli wrote: > A log message like this one: > > 2024-01-09T06:45:17.201Z|00071|bfd(handler2)|INFO|ovn-0af536-0: BFD state > change: down->up "Neighbor Signaled Session Down"->"Neighbor Signaled Session > Down". > > can be hard to read since '->' usually

Re: [ovs-dev] [PATCH ovn v6 00/13] northd lflow incremental processing

2024-02-04 Thread Han Zhou
On Sun, Feb 4, 2024 at 9:26 PM Numan Siddique wrote: > > On Sun, Feb 4, 2024 at 9:53 PM Han Zhou wrote: > > > > On Sun, Feb 4, 2024 at 5:46 AM Ilya Maximets wrote: > > > > > > >>> > > > >>> > 35 files changed, 9681 insertions(+), 4645 deletions(-) > > > >>> > > > >>> I had another look at this

Re: [ovs-dev] [PATCH ovn v6 00/13] northd lflow incremental processing

2024-02-04 Thread Numan Siddique
On Sun, Feb 4, 2024 at 9:53 PM Han Zhou wrote: > > On Sun, Feb 4, 2024 at 5:46 AM Ilya Maximets wrote: > > > > >>> > > >>> > 35 files changed, 9681 insertions(+), 4645 deletions(-) > > >>> > > >>> I had another look at this series and acked the remaining patches. I > > >>> just had some minor

[ovs-dev] [PATCH] ovsdb: Don't iterate over rows on empty mutation.

2024-02-04 Thread Mike Pattrick
Previously when an empty mutation was used to count the number of rows in a table, OVSDB would iterate over all rows twice. First to perform an RBAC check, and then to perform the no-operation. This change adds a short circuit to mutate operations with no conditions and an empty mutation set,

Re: [ovs-dev] [PATCH ovn v6 00/13] northd lflow incremental processing

2024-02-04 Thread Han Zhou
On Sun, Feb 4, 2024 at 5:46 AM Ilya Maximets wrote: > > >>> > >>> > 35 files changed, 9681 insertions(+), 4645 deletions(-) > >>> > >>> I had another look at this series and acked the remaining patches. I > >>> just had some minor comments that can be easily fixed when applying the > >>>

Re: [ovs-dev] [PATCH ovs v3] Documentation: Adding note about using the jemalloc library.

2024-02-04 Thread 0-day Robot
Bleep bloop. Greetings Roberto Bartzen Acosta, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless

[ovs-dev] [PATCH ovs v3] Documentation: Adding note about using the jemalloc library.

2024-02-04 Thread Roberto Bartzen Acosta via dev
Updating the reference documentation with the inclusion of possible building problems with libjemalloc and solution suggestions. Reported-at: https://bugs.launchpad.net/ubuntu/+source/openvswitch/+bug/2015748 Signed-off-by: Roberto Bartzen Acosta --- Documentation/intro/install/general.rst | 16

[ovs-dev] [PATCH ovn v4] ovn-ic: Fix global blacklist filter for IPv6 addresses.

2024-02-04 Thread Roberto Bartzen Acosta via dev
This commit fixes the prefix filter function as the return condition for IPv6 addresses is disabling the advertisement of all learned prefixes regardless of the match with the blacklist or not. Reported-at: https://bugs.launchpad.net/ubuntu/+source/ovn/+bug/2046804 Fixes: 57b347c55168 ("ovn-ic:

[ovs-dev] [PATCH] bfd: Improve state change log message.

2024-02-04 Thread Timothy Redaelli
A log message like this one: 2024-01-09T06:45:17.201Z|00071|bfd(handler2)|INFO|ovn-0af536-0: BFD state change: down->up "Neighbor Signaled Session Down"->"Neighbor Signaled Session Down". can be hard to read since '->' usually represents a status change, but in this case the diagnostic code

Re: [ovs-dev] [PATCH ovn v6 00/13] northd lflow incremental processing

2024-02-04 Thread Ilya Maximets
>>> >>> > 35 files changed, 9681 insertions(+), 4645 deletions(-) >>> >>> I had another look at this series and acked the remaining patches. I >>> just had some minor comments that can be easily fixed when applying the >>> patches to the main branch. >>> >>> Thanks for all the work on this! It