[ovs-dev] [PATCH] bond: Reset stats when deleting post recirc rule.

In order to properly balance bond traffic, ofproto/bond periodically reads usage statistics of the post-recirculation rules (which are added to a hidden internal table). To do that, each "struct bond_entry" (which represents a hash within a bond) stores the last seen statistics for its rule. When

Re: [ovs-dev] [PATCH ovn v1 0/4] northd memory and CPU increase fix due to lflow-mgr.

On Thu, Feb 8, 2024, 4:49 PM wrote: > From: Numan Siddique > > This patch series fixes the memory and CPU usage increase seen > in ovn-northd after the lflow I-P patches were merged. > > The first 2 patches in the series addresses duplicate flows > added by northd into the lflow table for the

[ovs-dev] [PATCH ovn v1 4/4] northd: lflow-mgr: Allocate DP reference counters on a second use.

From: Ilya Maximets Currently, whenever a new logical flow is created, northd allocates a reference counter for every datapath in the datapath group for that logical flow. Those reference counters are necessary in order to not remove the datapath from a logical flow during incremental

[ovs-dev] [PATCH ovn v1 3/4] northd: Fix lflow ref node's reference counting.

From: Numan Siddique When the lflows in an lflow_ref are unlinked by calling lflow_ref_unlink_lflows(lflow_ref), the dp_ref counter for each lflow in the lflow_ref is decremented (by calling dp_refcnt_release()), but it is not incremented later when the same lflow is linked back to the

[ovs-dev] [PATCH ovn v1 2/4] northd: Don't add ARP request responder flows for NAT multiple times.

From: Numan Siddique If an SNAT external_ip belongs to the router IP, then there is no need to generate ARP request responder flows in build_lswitch_rport_arp_req_flows_for_lbnats() as these flows for router ips are generated by build_lswitch_rport_arp_req_flows(). Otherwise this results in the

[ovs-dev] [PATCH ovn v1 1/4] northd: Don't add lr_out_delivery default drop flow for each lrp.

From: Numan Siddique The default drop flow in lr_out_delivery stage is generated for every router port of a logical router. This results in the lflow_table_add_lflow() to be called multiple times for the same match and actions and the ovn_lflow to have multiple dp_refcnts. Fix this by

[ovs-dev] [PATCH ovn v1 0/4] northd memory and CPU increase fix due to lflow-mgr.

From: Numan Siddique This patch series fixes the memory and CPU usage increase seen in ovn-northd after the lflow I-P patches were merged. The first 2 patches in the series addresses duplicate flows added by northd into the lflow table for the same datapath. The 3rd patch fixes a bug in

Re: [ovs-dev] [PATCH ovn] features.c: Always wait on the rconn.

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: "Fixes" tag is malformed. Use the following format: git log -1

[ovs-dev] [PATCH ovn] features.c: Always wait on the rconn.

When performing feature detection with OVS, we use an rconn connected to br-int.mgmt to query for features. If the rconn is not connected, then we would exit early. However, this early exit did not call rconn_run_wait() or rconn_recv_wait(). Therefore, if the rconn were in a state such as BACKOFF

Re: [ovs-dev] [RFC ovn] northd.c: Fix direct access to SNATed networks.

> On 8 Feb 2024, at 11:12, martin.kal...@canonical.com wrote: > > On Thu, 2024-02-08 at 09:30 +0100, Ales Musil wrote: >> >> >> On Thu, Feb 8, 2024 at 1:22 AM Mark Michelson >> wrote: >>> Hi Martin >>> >>> Thanks a bunch for your first OVN contribution. I have comments >>> below. >>> >>>

Re: [ovs-dev] [PATCH branch-3.2 2/2] Prepare for 3.2.3.

Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH branch-3.2 1/2] Set release date for 3.2.2.

Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the

Re: [ovs-dev] [PATCH branch-3.1 2/2] Prepare for 3.1.5.

Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH branch-3.1 1/2] Set release date for 3.1.4.

Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the

Re: [ovs-dev] [PATCH branch-3.0 2/2] Prepare for 3.0.7.

Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH branch-3.0 1/2] Set release date for 3.0.6.

Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the

Re: [ovs-dev] [PATCH branch-2.17 2/2] Prepare for 2.17.10.

Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH branch-2.17 1/2] Set release date for 2.17.9.

Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the

Re: [ovs-dev] [PATCH ovn v3 3/4] utilities: Add ovn-debug binary tool.

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #281 FILE: utilities/ovn-debug.c:87:

Re: [ovs-dev] [PATCH ovn v3 1/4] tests: Remove hardcoded numbers from comments

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should end with a dot. Subject: tests: Remove hardcoded numbers

[ovs-dev] [PATCH ovn v3 4/4] tests: Use the ovn-debug binary to determine table numbers.

Use the ovn-debug commands to determine OpenFlow table numbers based on stage name. With this there is no need to hardcode them and it should be future proof for stage shifts/updates. Signed-off-by: Ales Musil --- tests/ovn-controller.at | 342 +++--- tests/ovn.at

[ovs-dev] [PATCH ovn v3 2/4] checkpatch: Add rule to check for hardcoded table numbers.

To avoid issues with hardcoded table numbers in future add rule into check patch. The rule is only warning because there are still legitimate use cases and not everything can be abstracted. Signed-off-by: Ales Musil --- utilities/checkpatch.py | 12 1 file changed, 12 insertions(+)

[ovs-dev] [PATCH ovn v3 3/4] utilities: Add ovn-debug binary tool.

Add ovn-debug binary tool that can be extended with commands that might be useful for tests/debugging of OVN environment. Currently the tool supports only two commands: 1) "lflow-stage-to-ltable STAGE_NAME" that converts stage name into logical flow table id. 2) "lflow-stage-to-oftable

[ovs-dev] [PATCH ovn v3 0/4] Remove most of the hardcoded table numbers

This series has the remaing patches that weren't yet accepted with addition that fixes table numbers in comments. A lot of tests were relying on exact table numbers for flow comparison either logical or OpenFlows. In order to take care of table references into OpenFlow through logical flow

[ovs-dev] [PATCH ovn v3 1/4] tests: Remove hardcoded numbers from comments

There were some comments left with hardcoded numbers. Even if it wouldn't break any test table shift/change it would just left the comment outdated. Signed-off-by: Ales Musil --- tests/ovn-northd.at | 2 +- tests/ovn.at| 8 2 files changed, 5 insertions(+), 5 deletions(-) diff

Re: [ovs-dev] [PATCH branch-3.2 0/2] Release patches for v3.2.2.

On 2/8/24 18:06, Aaron Conole wrote: > Ilya Maximets writes: > >> Bug Fix + Security release. >> >> Ilya Maximets (2): >> Set release date for 3.2.2. >> Prepare for 3.2.3. >> >> NEWS | 8 +++- >> configure.ac | 2 +- >> debian/changelog | 8 +++- >> 3 files changed,

Re: [ovs-dev] [PATCH branch-3.1 0/2] Release patches for v3.1.4.

Ilya Maximets writes: > Bug Fix + Security release. > > Ilya Maximets (2): > Set release date for 3.1.4. > Prepare for 3.1.5. > > NEWS | 8 +++- > configure.ac | 2 +- > debian/changelog | 8 +++- > 3 files changed, 15 insertions(+), 3 deletions(-) Series:

Re: [ovs-dev] [PATCH branch-3.2 0/2] Release patches for v3.2.2.

Ilya Maximets writes: > Bug Fix + Security release. > > Ilya Maximets (2): > Set release date for 3.2.2. > Prepare for 3.2.3. > > NEWS | 8 +++- > configure.ac | 2 +- > debian/changelog | 8 +++- > 3 files changed, 15 insertions(+), 3 deletions(-) Series:

Re: [ovs-dev] [PATCH branch-2.17 0/2] Release patches for v2.17.9.

Ilya Maximets writes: > Bug Fix + Security release. > > Ilya Maximets (2): > Set release date for 2.17.9. > Prepare for 2.17.10. > > NEWS | 8 +++- > configure.ac | 2 +- > debian/changelog | 8 +++- > 3 files changed, 15 insertions(+), 3 deletions(-) Series:

Re: [ovs-dev] [PATCH branch-3.0 0/2] Release patches for v3.0.6.

Ilya Maximets writes: > Bug Fix + Security release. > > Ilya Maximets (2): > Set release date for 3.0.6. > Prepare for 3.0.7. > > NEWS | 8 +++- > configure.ac | 2 +- > debian/changelog | 8 +++- > 3 files changed, 15 insertions(+), 3 deletions(-) Series:

[ovs-dev] [PATCH branch-3.2 0/2] Release patches for v3.2.2.

Bug Fix + Security release. Ilya Maximets (2): Set release date for 3.2.2. Prepare for 3.2.3. NEWS | 8 +++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 15 insertions(+), 3 deletions(-) -- 2.43.0 ___

[ovs-dev] [PATCH branch-3.2 1/2] Set release date for 3.2.2.

Signed-off-by: Ilya Maximets --- NEWS | 5 - debian/changelog | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 0387b66d5..47be5e065 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,8 @@ -v3.2.2 - xx xxx +v3.2.2 - 08 Feb 2024

[ovs-dev] [PATCH branch-3.2 2/2] Prepare for 3.2.3.

Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 47be5e065..baeecae04 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v3.2.3 - xx xxx

[ovs-dev] [PATCH branch-3.1 0/2] Release patches for v3.1.4.

Bug Fix + Security release. Ilya Maximets (2): Set release date for 3.1.4. Prepare for 3.1.5. NEWS | 8 +++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 15 insertions(+), 3 deletions(-) -- 2.43.0 ___

[ovs-dev] [PATCH branch-3.1 2/2] Prepare for 3.1.5.

Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 8fff14652..aaddb77e8 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v3.1.5 - xx xxx

[ovs-dev] [PATCH branch-3.0 2/2] Prepare for 3.0.7.

Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index a88724e1e..0bb28638c 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v3.0.7 - xx xxx

[ovs-dev] [PATCH branch-3.1 1/2] Set release date for 3.1.4.

Signed-off-by: Ilya Maximets --- NEWS | 5 - debian/changelog | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 77cf4bbac..8fff14652 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,8 @@ -v3.1.4 - xx xxx +v3.1.4 - 08 Feb 2024

[ovs-dev] [PATCH branch-3.0 1/2] Set release date for 3.0.6.

Signed-off-by: Ilya Maximets --- NEWS | 5 - debian/changelog | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 2a9a99a8f..a88724e1e 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,8 @@ -v3.0.6 - xx xxx +v3.0.6 - 08 Feb 2024

[ovs-dev] [PATCH branch-3.0 0/2] Release patches for v3.0.6.

Bug Fix + Security release. Ilya Maximets (2): Set release date for 3.0.6. Prepare for 3.0.7. NEWS | 8 +++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 15 insertions(+), 3 deletions(-) -- 2.43.0 ___

[ovs-dev] [PATCH branch-2.17 2/2] Prepare for 2.17.10.

Signed-off-by: Ilya Maximets --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 4c3cdd651..ca111ae3a 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.17.10 - xx xxx

[ovs-dev] [PATCH branch-2.17 0/2] Release patches for v2.17.9.

Bug Fix + Security release. Ilya Maximets (2): Set release date for 2.17.9. Prepare for 2.17.10. NEWS | 8 +++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 15 insertions(+), 3 deletions(-) -- 2.43.0

[ovs-dev] [PATCH branch-2.17 1/2] Set release date for 2.17.9.

Signed-off-by: Ilya Maximets --- NEWS | 5 - debian/changelog | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 7ef97cfa8..4c3cdd651 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,8 @@ -v2.17.9 - xx xxx +v2.17.9 - 08 Feb 2024

[ovs-dev] [PATCH] netdev-offload-tc: Check geneve metadata length.

From: Timothy Redaelli Currently ovs-vswitchd crashes, with hw offloading enabled, if a geneve packet with corrupted metadata is received, because the metadata header is not verified correctly. This commit adds a check for geneve metadata length and, if the header is wrong, the packet is not

[ovs-dev] [PATCH] odp: ND: Follow Open Flow spec converting from OF to DP.

From: Aaron Conole The OpenFlow spec doesn't require that a user specify icmp_code when specifying a type. However, the conversion for a DP flow asks that the user explicitly specified an icmp_code field to match and forces this via a mask check. This means that valid matches for

Re: [ovs-dev] [PATCH 2/2] dpif-netlink: Fix overriding the number of handler threads.

On 8 Feb 2024, at 15:00, Ilya Maximets wrote: > On 2/8/24 13:44, Eelco Chaudron wrote: >> >> >> On 6 Feb 2024, at 16:01, Ilya Maximets wrote: >> >>> On 2/6/24 15:07, Eelco Chaudron wrote: On 6 Feb 2024, at 14:46, Ilya Maximets wrote: > On 2/6/24 14:30, Eelco Chaudron

Re: [ovs-dev] [PATCH 2/2] dpif-netlink: Fix overriding the number of handler threads.

On 2/8/24 13:44, Eelco Chaudron wrote: > > > On 6 Feb 2024, at 16:01, Ilya Maximets wrote: > >> On 2/6/24 15:07, Eelco Chaudron wrote: >>> >>> >>> On 6 Feb 2024, at 14:46, Ilya Maximets wrote: >>> On 2/6/24 14:30, Eelco Chaudron wrote: > Previously, the ability to override the system

Re: [ovs-dev] [PATCH ovn] ci: Bump CirrusCI Ubuntu image version

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should end with a dot. Subject: ci: Bump CirrusCI Ubuntu image

[ovs-dev] [PATCH ovn] ci: Bump CirrusCI Ubuntu image version

The Ubuntu 23.04 went EOL, change the image to 23.10. Signed-off-by: Ales Musil --- .cirrus.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 5453bf93d..1832e51f2 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -1,6 +1,6 @@

Re: [ovs-dev] [PATCH 2/2] dpif-netlink: Fix overriding the number of handler threads.

On 6 Feb 2024, at 16:01, Ilya Maximets wrote: > On 2/6/24 15:07, Eelco Chaudron wrote: >> >> >> On 6 Feb 2024, at 14:46, Ilya Maximets wrote: >> >>> On 2/6/24 14:30, Eelco Chaudron wrote: Previously, the ability to override the system default for the number of handler threads was

Re: [ovs-dev] [PATCH ovn v5 0/2] Keep track of SNAT status for ICMP need frag

On 2/7/24 17:35, Ales Musil wrote: > The ICMP need frag could be generated after routing > stage when the unSNAT already happened. Add flows > that will ensure that we are keeping track of the CT > state and do appropriate CT nat action later on. > > Because the ICMP traffic is related to already

Re: [ovs-dev] [PATCH ovn v2] northd: Remove the protocol match from ECMP symmetric reply flows

On 2/5/24 11:07, Ales Musil wrote: > > > On Mon, Feb 5, 2024 at 10:47 AM Ales Musil > wrote: > > There are 3 flows for matching ECMP symmetric reply that are different > in a single match part that is the protocol (udp/tcp/sctp) for ct.new > traffic and

Re: [ovs-dev] [PATCH net v2 2/2] selftests: openvswitch: Add validation for the recursion test

On Wed, Feb 07, 2024 at 08:24:16AM -0500, Aaron Conole wrote: > Add a test case into the netlink checks that will show the number of > nested action recursions won't exceed 16. Going to 17 on a small > clone call isn't enough to exhaust the stack on (most) systems, so > it should be safe to run

Re: [ovs-dev] [PATCH net v2 1/2] net: openvswitch: limit the number of recursions from action sets

On Wed, Feb 07, 2024 at 08:24:15AM -0500, Aaron Conole wrote: > The ovs module allows for some actions to recursively contain an action > list for complex scenarios, such as sampling, checking lengths, etc. > When these actions are copied into the internal flow table, they are > evaluated to

Re: [ovs-dev] [RFC ovn] northd.c: Fix direct access to SNATed networks.

On Thu, 2024-02-08 at 09:30 +0100, Ales Musil wrote: > > > On Thu, Feb 8, 2024 at 1:22 AM Mark Michelson > wrote: > > Hi Martin > > > > Thanks a bunch for your first OVN contribution. I have comments > > below. > > > > On 2/7/24 10:56, Martin Kalcok wrote: > > > When a machine from an

Re: [ovs-dev] [RFC ovn] northd.c: Fix direct access to SNATed networks.

On Thu, Feb 8, 2024 at 1:22 AM Mark Michelson wrote: > Hi Martin > > Thanks a bunch for your first OVN contribution. I have comments below. > > On 2/7/24 10:56, Martin Kalcok wrote: > > When a machine from an external network tries to access machine in the > > OVN's internal network with SNAT