[ovs-dev] [PATCH v2] bond: Reset stats when deleting post recirc rule.

2024-02-19 Thread Adrian Moreno
In order to properly balance bond traffic, ofproto/bond periodically reads usage statistics of the post-recirculation rules (which are added to a hidden internal table). To do that, each "struct bond_entry" (which represents a hash within a bond) stores the last seen statistics for its rule. When

Re: [ovs-dev] [PATCH v1 12/12] documentation: Document ovs-flowviz.

2024-02-19 Thread Adrian Moreno
On 2/19/24 23:53, Ilya Maximets wrote: On 2/19/24 09:14, Adrian Moreno wrote: Add a page for flow visualization with a few key concepts and examples. Signed-off-by: Adrian Moreno --- Documentation/automake.mk | 3 +- Documentation/topics/flow-visualization.rst | 469

Re: [ovs-dev] [PATCH v1 12/12] documentation: Document ovs-flowviz.

2024-02-19 Thread Ilya Maximets
On 2/19/24 09:14, Adrian Moreno wrote: > Add a page for flow visualization with a few key concepts and examples. > > Signed-off-by: Adrian Moreno > --- > Documentation/automake.mk | 3 +- > Documentation/topics/flow-visualization.rst | 469 Hi, Adrian.

[ovs-dev] [PATCH ovn] northd: Fix logical router load-balancer nat rules when using DGP.

2024-02-19 Thread Roberto Bartzen Acosta
This commit fixes the build_distr_lrouter_nat_flows_for_lb function to include one NAT flow entry for each DGP in use. Since we have added support to create multiple gateway ports per logical router, it's necessary to include in the LR nat rules pipeline a specific entry for each attached DGP.

Re: [ovs-dev] [PATCH ovn 09/10] tests: Speed up "multicast group buffer split".

2024-02-19 Thread Ilya Maximets
On 2/12/24 18:55, Xavier Simonart wrote: > Signed-off-by: Xavier Simonart > --- > tests/ovn-controller.at | 14 -- > tests/ovn-macros.at | 11 +++ > tests/ovn.at| 8 +--- > 3 files changed, 24 insertions(+), 9 deletions(-) > > diff --git

Re: [ovs-dev] [PATCH ovn v4 3/4] utilities: Add ovn-debug binary tool.

2024-02-19 Thread Mark Michelson
Thanks Ales, Acked-by: Mark Michelson On 2/12/24 10:55, Ales Musil wrote: Add ovn-debug binary tool that can be extended with commands that might be useful for tests/debugging of OVN environment. Currently the tool supports only two commands: 1) "lflow-stage-to-ltable STAGE_NAME" that

Re: [ovs-dev] [PATCH ovn v4 2/4] checkpatch: Add rule to check for hardcoded table numbers.

2024-02-19 Thread Mark Michelson
Thanks Ales, Acked-by: Mark Michelson On 2/12/24 10:55, Ales Musil wrote: To avoid issues with hardcoded table numbers in future add rule into check patch. The rule is only warning because there are still legitimate use cases and not everything can be abstracted. Signed-off-by: Ales Musil

Re: [ovs-dev] [PATCH ovn v4 1/4] tests: Remove hardcoded numbers from comments.

2024-02-19 Thread Mark Michelson
Thanks Ales! Acked-by: Mark Michelson On 2/12/24 10:55, Ales Musil wrote: There were some comments left with hardcoded numbers. Even if it wouldn't break any test table shift/change it would just leave the comment outdated. Signed-off-by: Ales Musil --- v4: Rebase on top of main. Align

Re: [ovs-dev] [PATCH ovn 00/10] Fixes to Unit tests.

2024-02-19 Thread Mark Michelson
On 2/13/24 03:47, Ales Musil wrote: On Mon, Feb 12, 2024 at 6:56 PM Xavier Simonart wrote: Check unit tests logs for errors. Fix multiple unit tests issues highlighted when checking logs for errors. Xavier Simonart (10): tests: Have tests fail when adding veth peer fails. tests: Fix

Re: [ovs-dev] [RFC 0/7] selftests: openvswitch: cleanups for running as selftests

2024-02-19 Thread Jakub Kicinski
On Fri, 16 Feb 2024 10:28:39 -0500 Aaron Conole wrote: > The series is a host of cleanups to the openvswitch selftest suite > which should be ready to run under the netdev selftest runners using > vng. For now, the testing has been done with RW directories, but > additional testing will be done

Re: [ovs-dev] [PATCH 2/2] dpif-netlink: Fix overriding the number of handler threads.

2024-02-19 Thread Ilya Maximets
On 2/8/24 16:53, Eelco Chaudron wrote: > > > On 8 Feb 2024, at 15:00, Ilya Maximets wrote: > >> On 2/8/24 13:44, Eelco Chaudron wrote: >>> >>> >>> On 6 Feb 2024, at 16:01, Ilya Maximets wrote: >>> On 2/6/24 15:07, Eelco Chaudron wrote: > > > On 6 Feb 2024, at 14:46, Ilya

Re: [ovs-dev] [PATCH v3] netlink-conntrack: Optimize flushing ct zone.

2024-02-19 Thread Ilya Maximets
On 2/12/24 11:38, Felix Huettner via dev wrote: > Previously the kernel did not provide a netlink interface to flush/list > only conntrack entries matching a specific zone. With [1] and [2] it is now > possible to flush and list conntrack entries filtered by zone. Older > kernels not yet

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-19 Thread Aaron Conole
Eelco Chaudron writes: > On 12 Feb 2024, at 15:15, Aaron Conole wrote: > >> Aaron Conole writes: >> >>> Eelco Chaudron writes: >>> On 2 Feb 2024, at 11:31, Adrian Moreno wrote: > On 2/1/24 10:02, Eelco Chaudron wrote: >> >> >> On 31 Jan 2024, at 18:03, Aaron Conole

Re: [ovs-dev] [PATCH v3 2/2] conntrack: Handle persistent selection for IP addresses.

2024-02-19 Thread Aaron Conole
Paolo Valerio writes: > The patch, when 'persistent' flag is specified, makes the IP selection > in a range persistent across reboots. > > Signed-off-by: Paolo Valerio > Acked-by: Simon Horman > --- Acked-by: Aaron Conole ___ dev mailing list

Re: [ovs-dev] [PATCH v3 1/2] conntrack: Handle random selection for port ranges.

2024-02-19 Thread Aaron Conole
Paolo Valerio writes: > The userspace conntrack only supported hash for port selection. > With the patch, both userspace and kernel datapath support the random > flag. > > The default behavior remains the same, that is, if no flags are > specified, hash is selected. > > Signed-off-by: Paolo

Re: [ovs-dev] [PATCH v3] netlink-conntrack: Optimize flushing ct zone.

2024-02-19 Thread Aaron Conole
Felix Huettner writes: >> > diff --git a/lib/netlink-conntrack.c b/lib/netlink-conntrack.c >> > index 492bfcffb..1b050894d 100644 >> > --- a/lib/netlink-conntrack.c >> > +++ b/lib/netlink-conntrack.c >> > @@ -25,6 +25,7 @@ >> > #include >> > #include >> > #include >> > +#include >> > >>

[ovs-dev] OVN technical community meeting - February 19th

2024-02-19 Thread Dumitru Ceara
On 1/9/24 13:30, Dumitru Ceara wrote: > I went ahead and scheduled a new instance of the meeting for: > > Date/Time: Monday February 19th 16:00 UTC > Meeting link: meet.google.com/zns-gqsd-jdn > Meeting notes: > https://docs.google.com/document/d/1dG4GwcYOSs4uArPGtOoaP5tH4KCto-GH_C3tIXSnZZ8 > >

Re: [ovs-dev] [PATCH v3 2/2] conntrack: Handle persistent selection for IP addresses.

2024-02-19 Thread Simon Horman
On Fri, Feb 16, 2024 at 06:19:14PM +0100, Paolo Valerio wrote: > The patch, when 'persistent' flag is specified, makes the IP selection > in a range persistent across reboots. > > Signed-off-by: Paolo Valerio > Acked-by: Simon Horman > --- > v3: > - rearranged branches in nat_get_unique_tuple()

[ovs-dev] [PATCH v2] upcall: Check flow consistant in upcall.

2024-02-19 Thread Cheng Li
Ovs ko passes odp key and packet to userspace. Next packet is extracted into flow, which is the input for xlate to generate wc. At last, ukey(= odp_key/wc) is installed into datapath. If the odp_key is not consistant with packet extracted flow. The ukey will be wrong. commit [1] was created to

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-19 Thread Eelco Chaudron
On 12 Feb 2024, at 15:15, Aaron Conole wrote: > Aaron Conole writes: > >> Eelco Chaudron writes: >> >>> On 2 Feb 2024, at 11:31, Adrian Moreno wrote: >>> On 2/1/24 10:02, Eelco Chaudron wrote: > > > On 31 Jan 2024, at 18:03, Aaron Conole wrote: > >> Eelco Chaudron

Re: [ovs-dev] [PATCH v1 12/12] documentation: Document ovs-flowviz.

2024-02-19 Thread 0-day Robot
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #101 FILE:

[ovs-dev] [PATCH v1 12/12] documentation: Document ovs-flowviz.

2024-02-19 Thread Adrian Moreno
Add a page for flow visualization with a few key concepts and examples. Signed-off-by: Adrian Moreno --- Documentation/automake.mk | 3 +- Documentation/topics/flow-visualization.rst | 469 Documentation/topics/index.rst | 1 + 3 files

[ovs-dev] [PATCH v1 10/12] python: ovs: flowviz: Add datapath graph format.

2024-02-19 Thread Adrian Moreno
Graph view leverages the tree format (specially the tree-based filtering) and uses graphviz library to build a visual graph of the datapath in graphviz format. Conntrack zones are shown in random colors to help visualize connection tracking interdependencies. An html flag builds an HTML page

[ovs-dev] [PATCH v1 11/12] python: ovs: flowviz: Support html dark style.

2024-02-19 Thread Adrian Moreno
In order to support dark style in html outputs, allow the config file to express the background color and set it in a top style object. Signed-off-by: Adrian Moreno --- python/ovs/flowviz/html_format.py | 4 +++- python/ovs/flowviz/odp/html.py | 30 -

[ovs-dev] [PATCH v1 08/12] python: ovs: flowviz: Add Openflow cookie format.

2024-02-19 Thread Adrian Moreno
When anaylizing OVN issues, it might be useful to see what OpenFlow flows were generated from each logical flow. In order to make it simpler to visualize this, add a cookie format that simply sorts the flows first by cookie, then by table. Example: $ export OVN_NB_DB=... $ export OVN_SB_DB=... $

[ovs-dev] [PATCH v1 09/12] python: ovs: flowviz: Add datapath html format.

2024-02-19 Thread Adrian Moreno
Using the existing FlowTree and HTMLFormatter, create an HTML tree visualization that also supports collapsing and expanding entire flow trees and subtrees. Examples: $ ovs-appcl dpctl/dump-flows | ovs-flowviz --highlight drop datapath html > /tmp/flows.html $ ovs-appcl dpctl/dump-flows |

[ovs-dev] [PATCH v1 05/12] python: ovs: flowviz: Add html formatting.

2024-02-19 Thread Adrian Moreno
Add a HTML Formatter and use it to print OpenFlow flows in an HTML list with table links. Examples $ ovs-flowviz -i offlows.txt --highlight "drop" openflow html > /tmp/flows.html $ ovs-flowviz -i offlows.txt --filter "n_packets > 0" openflow html > /tmp/flows.html Acked-by: Eelco Chaudron

[ovs-dev] [PATCH v1 06/12] python: ovs: flowviz: Add datapath tree format.

2024-02-19 Thread Adrian Moreno
Datapath flows can be arranged into a "tree"-like structure based on recirculation ids, e.g: recirc(0),eth(...),ipv4(...) actions=ct,recirc(0x42) \-> recirc(42),ct_state(0/0),eth(...),ipv4(...) actions=1 \-> recirc(42),ct_state(1/0),eth(...),ipv4(...) actions=userspace(...) This patch

[ovs-dev] [PATCH v1 03/12] python: ovs: flowviz: Add console formatting.

2024-02-19 Thread Adrian Moreno
Add a flow formatting framework and one implementation for console printing using rich. The flow formatting framework is a simple set of classes that can be used to write different flow formatting implementations. It supports styles to be described by any class, highlighting and config-file based

[ovs-dev] [PATCH v1 07/12] python: ovs: flowviz: Add OpenFlow logical view.

2024-02-19 Thread Adrian Moreno
This view is interesting for debugging the logical pipeline. It arranges the flows in "logical" groups (not to be confused with OVN's Logical_Flows). A logical group of flows is a set of flows that: - Have the same table number and priority - Match on the same fields (regardless of the value they

[ovs-dev] [PATCH v1 04/12] python: ovs: flowviz: Add default config file.

2024-02-19 Thread Adrian Moreno
It has two basic styles defined: "dark" and "light" intended for dark and light terminals. Examples: $ ovs-flowviz -i /tmp/dpflows --style=dark datapath console $ ovs-flowviz -i /tmp/ofpflows --style=light openflow console Acked-by: Eelco Chaudron Signed-off-by: Adrian Moreno ---

[ovs-dev] [PATCH v1 02/12] python: ovs: flowviz: Add file processing infra.

2024-02-19 Thread Adrian Moreno
process.py contains a useful base class that processes files odp.py and ofp.py: contain datapath and openflow subcommand definitions as well as the first formatting option: json. Also, this patch adds basic filtering support. Examples: $ ovs-ofctl dump-flows br-int | ovs-flowviz openflow json $

[ovs-dev] [PATCH v1 01/12] python: ovs: Add flowviz scheleton.

2024-02-19 Thread Adrian Moreno
Add a new python package (just the scheleton for now) to hold a flow visualization tool based on the flow parsing library. flowviz dependencies are installed via "extras_require", so a user must run: $ pip install .[flowviz] or $ pip install ovs[flowviz] Signed-off-by: Adrian Moreno ---

[ovs-dev] [PATCH v1 00/12] Add flow visualization utility.

2024-02-19 Thread Adrian Moreno
The goal of this utility is to read both datapath and Openflow flows (using the flow library already available) and print them in different formats and styles to make it easier to understand them and troubleshoot issues. The formats are quite opinionated and so are the colors chosen so I'm eager