[ovs-dev] [PATCH ovn] tests: Fix IPv6 prefix delegation test.

2024-02-29 Thread Ales Musil
The IPv6 prefix delegation test was failing from time to time, because the tcpdump stderr "leaked" into the test stderr. Make sure the stderr for every tcpdump is redirected into file and while at it properly wait for the tcpdump to fully start. Signed-off-by: Ales Musil ---

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-29 Thread Chris Mi via dev
On 2/29/2024 9:04 PM, Ilya Maximets wrote: On 2/29/24 01:56, Chris Mi wrote: On 2/28/2024 8:51 PM, Ilya Maximets wrote: On 2/28/24 13:26, Chris Mi wrote: Hi Ilya, On 2/28/2024 7:56 PM, Ilya Maximets wrote: On 2/28/24 11:03, Eelco Chaudron wrote: On 28 Feb 2024, at 8:06, Chris Mi wrote:

Re: [ovs-dev] [PATCH v2] dp-packet: Don't offload inner csum if outer isn't supported.

2024-02-29 Thread Ilya Maximets
On 2/26/24 14:38, Mike Pattrick wrote: > Some network cards support inner checksum offloading but not outer > checksum offloading. Currently OVS will resolve that outer checksum but > allows the network card to resolve the inner checksum, invalidating the > outer checksum in the process. > > Now

[ovs-dev] [PATCH ovn v4] ovn-ctl: Add ssl-ciphers and protocols support.

2024-02-29 Thread amginwal
From: Aliasgar Ginwala Setting up OVN on new kernel bumps openssl version. Since OVS PKI infrastructure that generated older ssl certs based on old openssl version, raft fails with error 2024-02-27T19:28:39.673Z|00022|stream_ssl|WARN|SSL_connect: error:1416F086:SSL

Re: [ovs-dev] [PATCH ovn branch-23.09 2/2] Prepare for 23.09.3.

2024-02-29 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (NEWS). error: could not build fake ancestor hint:

[ovs-dev] [PATCH ovn branch-24.03 2/2] Prepare for 24.03.1.

2024-02-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 71de7bf78..c66a2bc50 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v24.03.1 - xx xxx

[ovs-dev] [PATCH ovn branch-24.03 1/2] Set release date for 24.03.0.

2024-02-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index a58c8d350..71de7bf78 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -OVN v24.03.0 - xx xxx +OVN v24.03.0 - 01 Mar 2024

[ovs-dev] [PATCH ovn branch-23.09 1/2] Set release date for 23.09.2.

2024-02-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 060b0d0e6..c6e0e2483 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -OVN v23.09.2 - xx xxx +OVN v23.09.2 - 01 Mar 2024

[ovs-dev] [PATCH ovn branch-23.09 2/2] Prepare for 23.09.3.

2024-02-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index c6e0e2483..58b1c9066 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.09.3 - xx xxx

[ovs-dev] [PATCH ovn branch-22.03 2/2] Prepare for 22.03.7.

2024-02-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 8f691f2b5..5e707974d 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v22.03.7 - xx xxx

[ovs-dev] [PATCH ovn branch-24.03 0/2] Release patches for v24.03.0.

2024-02-29 Thread Mark Michelson
Mark Michelson (2): Set release date for 24.03.0. Prepare for 24.03.1. NEWS | 5 - configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 12 insertions(+), 3 deletions(-) -- 2.43.0 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-22.03 1/2] Set release date for 22.03.6.

2024-02-29 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index d2e495af3..8f691f2b5 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -OVN v22.03.6 - xx xxx +OVN v22.03.6 - 01 Mar 2024

[ovs-dev] [PATCH ovn branch-23.09 0/2] Release patches for v23.09.2.

2024-02-29 Thread Mark Michelson
Mark Michelson (2): Set release date for 23.09.2. Prepare for 23.09.3. NEWS | 5 - configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 12 insertions(+), 3 deletions(-) -- 2.43.0 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-22.03 0/2] Release patches for v22.03.6.

2024-02-29 Thread Mark Michelson
Mark Michelson (2): Set release date for 22.03.6. Prepare for 22.03.7. NEWS | 6 +- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 13 insertions(+), 3 deletions(-) -- 2.43.0 ___ dev mailing list

[ovs-dev] [PATCH ovn] Update copyright year to 2024.

2024-02-29 Thread Igor Zhukov
I noticed the copyright year at the bottom of https://docs.ovn.org/en/latest/contents.html Signed-off-by: Igor Zhukov --- Documentation/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/conf.py b/Documentation/conf.py index f8fc0125f..828e9443b 100644

Re: [ovs-dev] [PATCH ovn] northd: Don't create fair Sb meters for ACLs with logging disabled.

2024-02-29 Thread Mark Michelson
On 2/28/24 02:21, Ales Musil wrote: On Tue, Feb 27, 2024 at 5:04 PM Ilya Maximets wrote: If the ACL.log is false for a fair meter, but ACL.meter is set in the Northbound database, northd will create a unique meter for this ACL in a Southbound database, even though it will never be used.

Re: [ovs-dev] [PATCH v1 12/12] documentation: Document ovs-flowviz.

2024-02-29 Thread Eelco Chaudron
On 20 Feb 2024, at 7:29, Adrian Moreno wrote: > On 2/19/24 23:53, Ilya Maximets wrote: >> On 2/19/24 09:14, Adrian Moreno wrote: >>> Add a page for flow visualization with a few key concepts and examples. >>> >>> Signed-off-by: Adrian Moreno >>> --- >>> Documentation/automake.mk

[ovs-dev] [PATCH AUTOSEL 6.6 09/21] selftests: openvswitch: Add validation for the recursion test

2024-02-29 Thread Sasha Levin
From: Aaron Conole [ Upstream commit bd128f62c365504e1268dc09fcccdfb1f091e93a ] Add a test case into the netlink checks that will show the number of nested action recursions won't exceed 16. Going to 17 on a small clone call isn't enough to exhaust the stack on (most) systems, so it should be

[ovs-dev] [PATCH AUTOSEL 6.7 10/26] selftests: openvswitch: Add validation for the recursion test

2024-02-29 Thread Sasha Levin
From: Aaron Conole [ Upstream commit bd128f62c365504e1268dc09fcccdfb1f091e93a ] Add a test case into the netlink checks that will show the number of nested action recursions won't exceed 16. Going to 17 on a small clone call isn't enough to exhaust the stack on (most) systems, so it should be

Re: [ovs-dev] [PATCH v1 11/12] python: ovs: flowviz: Support html dark style.

2024-02-29 Thread Eelco Chaudron
On 19 Feb 2024, at 9:14, Adrian Moreno wrote: > In order to support dark style in html outputs, allow the config file to > express the background color and set it in a top style object. > > Signed-off-by: Adrian Moreno Thanks for adding this. It makes my eyes happy ;) Acked-by: Eelco

Re: [ovs-dev] [PATCH v1 10/12] python: ovs: flowviz: Add datapath graph format.

2024-02-29 Thread Eelco Chaudron
On 19 Feb 2024, at 9:14, Adrian Moreno wrote: > Graph view leverages the tree format (specially the tree-based > filtering) and uses graphviz library to build a visual graph of the > datapath in graphviz format. > > Conntrack zones are shown in random colors to help visualize connection >

Re: [ovs-dev] [PATCH v1 09/12] python: ovs: flowviz: Add datapath html format.

2024-02-29 Thread Eelco Chaudron
On 19 Feb 2024, at 9:14, Adrian Moreno wrote: > Using the existing FlowTree and HTMLFormatter, create an HTML tree > visualization that also supports collapsing and expanding entire flow > trees and subtrees. > > Examples: > $ ovs-appcl dpctl/dump-flows | ovs-flowviz --highlight drop datapath

Re: [ovs-dev] [PATCH v1 08/12] python: ovs: flowviz: Add Openflow cookie format.

2024-02-29 Thread Eelco Chaudron
On 19 Feb 2024, at 9:14, Adrian Moreno wrote: > When anaylizing OVN issues, it might be useful to see what OpenFlow > flows were generated from each logical flow. In order to make it simpler > to visualize this, add a cookie format that simply sorts the flows first > by cookie, then by table.

Re: [ovs-dev] [PATCH v1 07/12] python: ovs: flowviz: Add OpenFlow logical view.

2024-02-29 Thread Eelco Chaudron
On 19 Feb 2024, at 9:14, Adrian Moreno wrote: > This view is interesting for debugging the logical pipeline. It arranges > the flows in "logical" groups (not to be confused with OVN's > Logical_Flows). A logical group of flows is a set of flows that: > - Have the same table number and priority

Re: [ovs-dev] [PATCH v1 06/12] python: ovs: flowviz: Add datapath tree format.

2024-02-29 Thread Eelco Chaudron
On 19 Feb 2024, at 9:14, Adrian Moreno wrote: > Datapath flows can be arranged into a "tree"-like structure based on > recirculation ids, e.g: > > recirc(0),eth(...),ipv4(...) actions=ct,recirc(0x42) >\-> recirc(42),ct_state(0/0),eth(...),ipv4(...) actions=1 >\->

Re: [ovs-dev] [PATCH v1 01/12] python: ovs: Add flowviz scheleton.

2024-02-29 Thread Eelco Chaudron
On 19 Feb 2024, at 9:14, Adrian Moreno wrote: > Add a new python package (just the scheleton for now) to hold a flow > visualization tool based on the flow parsing library. > > flowviz dependencies are installed via "extras_require", so a user must > run: > > $ pip install .[flowviz] > or > $

Re: [ovs-dev] [PATCH v1 03/12] python: ovs: flowviz: Add console formatting.

2024-02-29 Thread Eelco Chaudron
On 19 Feb 2024, at 9:14, Adrian Moreno wrote: > Add a flow formatting framework and one implementation for console > printing using rich. > > The flow formatting framework is a simple set of classes that can be > used to write different flow formatting implementations. It supports > styles to

Re: [ovs-dev] [PATCH v1 02/12] python: ovs: flowviz: Add file processing infra.

2024-02-29 Thread Eelco Chaudron
On 19 Feb 2024, at 9:14, Adrian Moreno wrote: > process.py contains a useful base class that processes files > odp.py and ofp.py: contain datapath and openflow subcommand definitions > as well as the first formatting option: json. > > Also, this patch adds basic filtering support. > > Examples: >

Re: [ovs-dev] [PATCH ovn] Update copyright year to 2024

2024-02-29 Thread 0-day Robot
Bleep bloop. Greetings Igor Zhukov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should end with a dot. Subject: Update copyright year to 2024

[ovs-dev] [PATCH ovn] Update copyright year to 2024

2024-02-29 Thread Igor Zhukov
I noticed the copyright year at the bottom of https://docs.ovn.org/en/latest/contents.html Signed-off-by: Igor Zhukov --- Documentation/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/conf.py b/Documentation/conf.py index f8fc0125f..828e9443b 100644

Re: [ovs-dev] [PATCH v1 04/12] python: ovs: flowviz: Add default config file.

2024-02-29 Thread Eelco Chaudron
On 19 Feb 2024, at 9:14, Adrian Moreno wrote: > It has two basic styles defined: "dark" and "light" intended for > dark and light terminals. > > Examples: > $ ovs-flowviz -i /tmp/dpflows --style=dark datapath console > $ ovs-flowviz -i /tmp/ofpflows --style=light openflow console > > Acked-by:

Re: [ovs-dev] [PATCH v28 8/8] system-offloads-traffic.at: Add sFlow offload test cases

2024-02-29 Thread Ilya Maximets
On 2/29/24 01:56, Chris Mi wrote: > On 2/28/2024 8:51 PM, Ilya Maximets wrote: >> On 2/28/24 13:26, Chris Mi wrote: >>> Hi Ilya, >>> >>> On 2/28/2024 7:56 PM, Ilya Maximets wrote: On 2/28/24 11:03, Eelco Chaudron wrote: > > > On 28 Feb 2024, at 8:06, Chris Mi wrote: > >>

Re: [ovs-dev] [PATCH v2] dpif-netdev: Do not create handler threads.

2024-02-29 Thread Eelco Chaudron
On 20 Feb 2024, at 17:50, Mike Pattrick wrote: > On Tue, Feb 20, 2024 at 4:32 AM Eelco Chaudron wrote: >> >> Avoid unnecessary thread creation as no upcalls are generated, >> resulting in idle threads waiting for process termination. >> >> This optimization significantly reduces memory usage,