On 2/22/24 16:54, Adrian Moreno wrote:
> In order to properly balance bond traffic, ofproto/bond periodically
> reads usage statistics of the post-recirculation rules (which are added
> to a hidden internal table).
>
> To do that, each "struct bond_entry" (which represents a hash within a
> bond)
On 2/26/24 14:10, Simon Horman wrote:
> On Thu, Feb 22, 2024 at 04:06:32PM +0100, Ilya Maximets wrote:
>> Trace attempts to process all the recirculations. However, if there
>> is a recirculation loop, i.e. if every recirculation generates another
>> recirculation, this process will never stop.
Lgtm. Thank you so much Ilya
Acked-by: Alin-Gabriel Serdean
>
> On 1 Mar 2024, at 22:10, Ilya Maximets wrote:
>
> OpenSSL 1.0.2u is long deprecated and not available for download.
> So, our CI never actually downloads it and uses whatever is in the
> OpenSSL-Win64 folder provided by
On 2/20/24 23:52, Ilya Maximets wrote:
> On 2/20/24 23:33, Alin Serdean wrote:
>> Thank you so much for the patches and dealing with this, Ilya!
>>
>> Regarding the MD / MT linking for a given binary, this can work, usually,
>> without any issues, although it will increase the memory used by the
OpenSSL 1.0.2u is long deprecated and not available for download.
So, our CI never actually downloads it and uses whatever is in the
OpenSSL-Win64 folder provided by AppVeyor. Luckily, it happens to
be OpenSSL 1.0.2u today.
The oldest supported version of OpenSSL upstream today is 3.0.
And it is
OpenSSL 1.1.0 changed the library names from libeay32 and ssleay32 to
standard libssl and libcrypto. All the versions of OpenSSL that used
old names reached their official EoL, so it should be safe to just
migrate to new names. They can still be supported via premium support
option, but I don't
There is no chmod or 'mkdir -m' support on Windows, so setting file
permissions for keys and certificates doesn't actually work.
Implementing them using icacls utility instead.
ovs-pki script currently only uses 0700 and 0750 modes, so only those
(and 0600) are implemented. NTFS ACLs on Windows
We need to know exact linking / compilation errors in order
to fix issues. We could have uploaded it as an artifact,
but it seems easier to just print it out for now.
Acked-by: Simon Horman
Signed-off-by: Ilya Maximets
---
.ci/windows-build.sh | 2 +-
1 file changed, 1 insertion(+), 1
This is an enhanced version of two previous attempts to fix
AppVeyor CI with OpenSSL and add support for OpenSSL 3+:
https://patchwork.ozlabs.org/project/openvswitch/patch/20201013124655.1408-1-aserd...@cloudbasesolutions.com/
The "pass" verdict was not explicitly defined in the list of verdicts
for ACL logging. This resulted in logs saying "Syntax error at `pass'
unknown verdict."
This change adds the "pass" verdict explicitly so that it shows up as a
proper log in ovn-controller.
Reported-at:
On 2/26/24 22:16, Mike Pattrick wrote:
> Currently a bridge mirror will collect all packets and tools like
> ovs-tcpdump can apply additional filters after they have already been
> duplicated by vswitchd. This can result in inefficient collection.
>
> This patch adds support to apply
On 2/26/24 22:16, Mike Pattrick wrote:
> Previously the mirror_set() and mirror_get() functions took a large
> number of parameters, which was inefficient and difficult to read and
> extend. This patch moves most of the parameters into a struct.
>
> Signed-off-by: Mike Pattrick
> Acked-by: Simon
On 2/26/24 11:49, Xavier Simonart wrote:
> On netdev datapath, when a ct element was cleaned, the cmap
> could be shrinked, potentially causing some elements to be skipped
> in the flush iteration.
>
> Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.")
> Signed-off-by: Xavier Simonart
> ---
>
On Fri, Mar 1, 2024 at 2:26 AM Dumitru Ceara wrote:
>
> On 2/16/24 07:52, Han Zhou wrote:
> > In commit 41eefcb2807d, the format of external_ids:ovn-chassis-id for
> > tunnels was modified to include the local encapsulation IP. This change
> > can lead to the recreation of tunnels during an
On 3/1/24 16:18, Paolo Valerio wrote:
> Ilya Maximets writes:
>
>> With a new runner update, GitHub Actions had a kernel update.
>> And it seems like something changed between kernels 6.2 and 6.5
>> so this test now fails very frequently.
>>
>> I can reproduce the same issue on RHEL 9, and I
On 1 Mar 2024, at 13:42, Ilya Maximets wrote:
> On 3/1/24 12:37, Ilya Maximets wrote:
>> With a new runner update, GitHub Actions had a kernel update.
>> And it seems like something changed between kernels 6.2 and 6.5
>> so this test now fails very frequently.
>>
>> I can reproduce the same
On 1 Mar 2024, at 15:50, Simon Horman wrote:
> Recently OVS adopted a policy of using the inclusive naming word list v1
> [1, 2].
>
> This patch partially addresses the use of the term master in the
> context of LAG devices by using the term primary instead: the
> is_lag_master field of struct
On 1 Mar 2024, at 15:50, Simon Horman wrote:
> Recently OVS adopted a policy of using the inclusive naming word list v1
> [1, 2].
>
> This patch partially addresses the use of the term master in the
> context of LAG devices by using the term primary instead: the local
> variables master_netdev
On 1 Mar 2024, at 15:50, Simon Horman wrote:
> Recently OVS adopted a policy of using the inclusive naming word list v1
> [1, 2].
>
> This patch addresses the use of the term master repository by
> using the term main repository instead.
>
> This is as distinct from addressing the use of a
On 1 Mar 2024, at 15:50, Simon Horman wrote:
> Since the patch-set that included [1] there has been a policy of using
> the term member for bonds, LACP, and bundle contexts. This is
> consistent with the more recently adopted policy of using the inclusive
> naming word list v1 [2, 3].
>
>
On 1 Mar 2024, at 15:50, Simon Horman wrote:
> Recently OVS adopted a policy of using the inclusive naming word list v1
> [1, 2].
>
> This patch addresses the use of the term master in the context of a
> hostname used in documentation of the kernel_delay utility. It does so
> by using
On 26 Feb 2024, at 22:16, Mike Pattrick wrote:
> Currently a bridge mirror will collect all packets and tools like
> ovs-tcpdump can apply additional filters after they have already been
> duplicated by vswitchd. This can result in inefficient collection.
>
> This patch adds support to apply
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 108 characters long (recommended limit is 79)
#66 FILE:
Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should end with a dot.
Subject: netdev-linux: Rename sturct
On 2/29/24 20:09, Mark Michelson wrote:
> Signed-off-by: Mark Michelson
> ---
> NEWS | 3 +++
> configure.ac | 2 +-
> debian/changelog | 6 ++
> 3 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/NEWS b/NEWS
> index 8f691f2b5..5e707974d 100644
> --- a/NEWS
>
On 2/29/24 20:09, Mark Michelson wrote:
> Signed-off-by: Mark Michelson
> ---
> NEWS | 3 ++-
> debian/changelog | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index d2e495af3..8f691f2b5 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,5 +1,6 @@
>
On 26 Feb 2024, at 22:16, Mike Pattrick wrote:
> Previously the mirror_set() and mirror_get() functions took a large
> number of parameters, which was inefficient and difficult to read and
> extend. This patch moves most of the parameters into a struct.
>
> Signed-off-by: Mike Pattrick
>
On 2/29/24 20:09, Mark Michelson wrote:
> Signed-off-by: Mark Michelson
> ---
> NEWS | 2 +-
> debian/changelog | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index 060b0d0e6..c6e0e2483 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,4 +1,4 @@
>
On 2/29/24 20:09, Mark Michelson wrote:
> Signed-off-by: Mark Michelson
> ---
> NEWS | 3 +++
> configure.ac | 2 +-
> debian/changelog | 6 ++
> 3 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/NEWS b/NEWS
> index c6e0e2483..58b1c9066 100644
> --- a/NEWS
>
Ilya Maximets writes:
> With a new runner update, GitHub Actions had a kernel update.
> And it seems like something changed between kernels 6.2 and 6.5
> so this test now fails very frequently.
>
> I can reproduce the same issue on RHEL 9, and I can't reproduce
> it on Ubuntu 23.04 (kernel 6.2).
Since the patch-set that included [1] there has been a policy of using
the term member for bonds, LACP, and bundle contexts. This is
consistent with the more recently adopted policy of using the inclusive
naming word list v1 [2, 3].
This patch addresses two instances where the term member should
Recently OVS adopted a policy of using the inclusive naming word list v1
[1, 2].
This patch addresses the use of the term master in the context of a
hostname used in documentation of the kernel_delay utility. It does so
by using localhost as the hostname instead.
[1] df5e5cf ("Documentation:
Recently OVS adopted a policy of using the inclusive naming word list v1
[1, 2].
This patch partially addresses the use of the term master in the
context of LAG devices by using the term primary instead: the local
variables master_netdev and master_name are renamed as primary_netdev
and
Recently OVS adopted a policy of using the inclusive naming word list v1
[1, 2].
This patch-set addresses some uses of the terms master and slave
by using alternate terms.
These changes are not intended to have any runtime effect.
[1] df5e5cf ("Documentation: Add section on inclusive
Recently OVS adopted a policy of using the inclusive naming word list v1
[1, 2].
This patch partially addresses the use of the term master in the
context of LAG devices by using the term primary instead: the
is_lag_master field of struct netdev_linux is renamed is_lag_primary.
A related comment
Recently OVS adopted a policy of using the inclusive naming word list v1
[1, 2].
This patch addresses the use of the term master repository by
using the term main repository instead.
This is as distinct from addressing the use of a master branch,
which remains as a follow-up task.
[1] df5e5cf
On Fri, Mar 01, 2024 at 12:37:36PM +0100, Ilya Maximets wrote:
> With a new runner update, GitHub Actions had a kernel update.
> And it seems like something changed between kernels 6.2 and 6.5
> so this test now fails very frequently.
>
> I can reproduce the same issue on RHEL 9, and I can't
On 2/29/24 20:09, Mark Michelson wrote:
> Signed-off-by: Mark Michelson
> ---
> NEWS | 3 +++
> configure.ac | 2 +-
> debian/changelog | 6 ++
> 3 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/NEWS b/NEWS
> index 71de7bf78..c66a2bc50 100644
> --- a/NEWS
>
On 2/29/24 20:09, Mark Michelson wrote:
> Signed-off-by: Mark Michelson
> ---
> NEWS | 2 +-
> debian/changelog | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index a58c8d350..71de7bf78 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,4 +1,4 @@
>
On 20 Feb 2024, at 22:47, Aaron Conole wrote:
> All supported versions of Fedora do package libbpf, so it
> makes sense to enable USDT support.
>
> Acked-by: Simon Horman
> Signed-off-by: Aaron Conole
This patch looks good to me.
Acked-by: Eelco Chaudron
On 20 Feb 2024, at 22:47, Aaron Conole wrote:
> From: Kevin Sprague
>
> During normal operations, it is useful to understand when a particular flow
> gets removed from the system. This can be useful when debugging performance
> issues tied to ofproto flow changes, trying to determine deployed
On 3/1/24 12:37, Ilya Maximets wrote:
> With a new runner update, GitHub Actions had a kernel update.
> And it seems like something changed between kernels 6.2 and 6.5
> so this test now fails very frequently.
>
> I can reproduce the same issue on RHEL 9, and I can't reproduce
> it on Ubuntu
The way how tcpdump was called in tests was incosistent,
a lot fo the tests didn't even wait for the tcpdump to properly
start, some of them didn't redirect the stderr which could cause
leak into the test stderr and fail the test.
To prevent that add macro that starts tcpdump and properly
waits
With a new runner update, GitHub Actions had a kernel update.
And it seems like something changed between kernels 6.2 and 6.5
so this test now fails very frequently.
I can reproduce the same issue on RHEL 9, and I can't reproduce
it on Ubuntu 23.04 (kernel 6.2).
The test is creating a NAT with a
On Tue, Feb 27, 2024 at 03:36:04PM +, Simon Horman wrote:
> * Update copyright to cover up to 2024
>
> * Fix broken or otherwise out of date hyperlinks
>
> * Spelling corrections
Series applied:
- Documentation: Update links to upstream Kernel documentation.
On 1 Mar 2024, at 11:00, Simon Horman wrote:
> On Wed, Feb 28, 2024 at 10:41:11AM +0100, Eelco Chaudron wrote:
>>
>>
>> On 27 Feb 2024, at 16:36, Simon Horman wrote:
>>
>>> Correct spelling errors in .rst files flagged by codespell.
>>
>> Some small nits below.
>
> Thanks Eelco,
>
> I plan to
On Tue, Feb 27, 2024 at 03:36:08PM +, Simon Horman wrote:
> Update link to OCF Resource Agents documentation as the existing link
> is broken. Also, use HTTPS.
>
> Broken link flagged by make check-docs
>
> Signed-off-by: Simon Horman
Not without some irony, there is a spelling mistake in
On 2/16/24 07:52, Han Zhou wrote:
> In commit 41eefcb2807d, the format of external_ids:ovn-chassis-id for
> tunnels was modified to include the local encapsulation IP. This change
> can lead to the recreation of tunnels during an upgrade, potentially
> disrupting the dataplane temporarily,
On Wed, Feb 28, 2024 at 10:41:11AM +0100, Eelco Chaudron wrote:
>
>
> On 27 Feb 2024, at 16:36, Simon Horman wrote:
>
> > Correct spelling errors in .rst files flagged by codespell.
>
> Some small nits below.
Thanks Eelco,
I plan to apply this with your nit's addressed.
...
> > @@ -49,7
On Wed, Feb 28, 2024 at 02:16:52PM +0100, Eelco Chaudron wrote:
>
>
> On 28 Feb 2024, at 14:07, Ilya Maximets wrote:
>
> > On 2/28/24 10:35, Eelco Chaudron wrote:
> >>
> >>
> >> On 28 Feb 2024, at 10:15, Simon Horman wrote:
> >>
> >>> On Wed, Feb 28, 2024 at 08:40:40AM +0100, Eelco Chaudron
On Fri, Mar 1, 2024 at 9:46 AM Dumitru Ceara wrote:
> On 3/1/24 07:42, Ales Musil wrote:
> > The IPv6 prefix delegation test was failing from time to time,
> > because the tcpdump stderr "leaked" into the test stderr. Make sure
> > the stderr for every tcpdump is redirected into file and while
On 3/1/24 07:42, Ales Musil wrote:
> The IPv6 prefix delegation test was failing from time to time,
> because the tcpdump stderr "leaked" into the test stderr. Make sure
> the stderr for every tcpdump is redirected into file and while at it
> properly wait for the tcpdump to fully start.
>
>
52 matches
Mail list logo
