[ovs-dev] [PATCH ovn] ofctrl: Wait at S_WAIT_BEFORE_CLEAR only once.

2024-03-04 Thread Han Zhou
The ovn-ofctrl-wait-before-clear setting is designed to minimize downtime during the initial start-up of the ovn-controller. For this purpose, the ovn-controller should wait only once upon entering the S_WAIT_BEFORE_CLEAR state for the first time. Subsequent reconnections to the OVS, such as those

[ovs-dev] [PATCH ovn] utilities: Make database connection optional for ovn-detrace.

2024-03-04 Thread Ales Musil
The ovn-detrace required both connections (SB and NB) to provide some output. However, it is a valid scenario to have only one database available, usually the SB. With that in mind make the connection optional and print warning into stderr that the output will not contain information from DB that

[ovs-dev] [PATCH ovn] Fix broken link for LTS release.

2024-03-04 Thread Igor Zhukov
I found the broken link at https://docs.ovn.org/en/latest/internals/release-process.html. I believe the correct link is https://www.ovn.org/en/releases/#long-term-support Signed-off-by: Igor Zhukov --- Documentation/internals/release-process.rst | 2 +- 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [PATCH v2 4/4] appveyor: Build with OpenSSL 3.0.

2024-03-04 Thread Alin Serdean
That’s understandable, I think we should be fine for now and if someone asks for a backport we can address it then. Thank you again for all the work you put into this! Alin > > On 4 Mar 2024, at 23:44, Ilya Maximets wrote: > > On 3/1/24 22:29, Alin Serdean wrote: >> Lgtm. Thank you so

Re: [ovs-dev] [PATCH v2 4/4] appveyor: Build with OpenSSL 3.0.

2024-03-04 Thread Ilya Maximets
On 3/1/24 22:29, Alin Serdean wrote: > Lgtm. Thank you so much Ilya > > Acked-by: Alin-Gabriel Serdean Thanks, Alin and Simon! I applied the set now. Also backported patches 2 and 3 to branch-3.3, since they are bug fixes and 3.3 is planned to be our next LTS. We may backport further, but

Re: [ovs-dev] [PATCH v3] conntrack: Fix flush not flushing all elements.

2024-03-04 Thread Mike Pattrick
On Mon, Mar 4, 2024 at 10:22 AM Xavier Simonart wrote: > > On netdev datapath, when a ct element was cleaned, the cmap > could be shrinked, potentially causing some elements to be skipped > in the flush iteration. > > Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.") > Signed-off-by: Xavier

Re: [ovs-dev] [PATCH v9 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-03-04 Thread Eelco Chaudron
On 4 Mar 2024, at 16:46, Aaron Conole wrote: > Eelco Chaudron writes: > >> On 20 Feb 2024, at 22:47, Aaron Conole wrote: >> >>> From: Kevin Sprague >>> >>> During normal operations, it is useful to understand when a particular flow >>> gets removed from the system. This can be useful when

Re: [ovs-dev] [PATCH v9 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-03-04 Thread Aaron Conole
Eelco Chaudron writes: > On 20 Feb 2024, at 22:47, Aaron Conole wrote: > >> From: Kevin Sprague >> >> During normal operations, it is useful to understand when a particular flow >> gets removed from the system. This can be useful when debugging performance >> issues tied to ofproto flow

Re: [ovs-dev] [PATCH v2 3/4] m4: Fix linking with OpenSSL 1.1.0+ and 3+ on Windows.

2024-03-04 Thread Simon Horman
On Fri, Mar 01, 2024 at 10:10:39PM +0100, Ilya Maximets wrote: > OpenSSL 1.1.0 changed the library names from libeay32 and ssleay32 to > standard libssl and libcrypto. All the versions of OpenSSL that used > old names reached their official EoL, so it should be safe to just > migrate to new

[ovs-dev] [PATCH v3] conntrack: Fix flush not flushing all elements.

2024-03-04 Thread Xavier Simonart
On netdev datapath, when a ct element was cleaned, the cmap could be shrinked, potentially causing some elements to be skipped in the flush iteration. Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.") Signed-off-by: Xavier Simonart --- v2: - Updated commit message. - Use compose-packet

Re: [ovs-dev] [PATCH v2] conntrack: Fix flush not flushing all elements.

2024-03-04 Thread Xavier Simonart
Thanks Mike and Ilya. Sending v3 to handle comments from Mike and Ilya. Thanks Xavier On Fri, Mar 1, 2024 at 7:48 PM Ilya Maximets wrote: > On 2/26/24 11:49, Xavier Simonart wrote: > > On netdev datapath, when a ct element was cleaned, the cmap > > could be shrinked, potentially causing some

[ovs-dev] [Patch ovn 2/2] northd.c: Fix direct access to SNAT network on DR.

2024-03-04 Thread Martin Kalcok
This change fixes bug that breaks ability of machines from external networks to communicate with machines in SNATed networks (specifically when using a Distributed router). Currently when a machine (S1) on an external network tries to talk over TCP with a machine (A1) in a network that has

[ovs-dev] [Patch ovn 1/2] actions.c/h: Enable specifying zone for ct_commit.

2024-03-04 Thread Martin Kalcok
Action `ct_commit` currently does not allow specifying zone into which connection is committed. For example, in LR datapath, the `ct_commit` will always use the DNAT zone. This change adds option to use `ct_commit(snat)` or `ct_commit(dnat)` to explicitly specify the zone into which the

[ovs-dev] [PATCH v6 2/2] netlink-conntrack: Optimize flushing ct zone.

2024-03-04 Thread Felix Huettner via dev
Previously the kernel did not provide a netlink interface to flush/list only conntrack entries matching a specific zone. With [1] and [2] it is now possible to flush and list conntrack entries filtered by zone. Older kernels not yet supporting this feature will ignore the filter. For the list

[ovs-dev] [PATCH v6 1/2] util: Support checking for kernel versions.

2024-03-04 Thread Felix Huettner via dev
Extract checking for a given kernel version to a separate function. It will be used also in the next patch. Signed-off-by: Felix Huettner --- v5->v6: - fix ovs_kernel_is_version_or_newer returning false if major and minor are equal (thanks Mike) v4->v5: - fix wrong ifdef that broke on macos -