Re: [ovs-dev] [PATCH v3] ovsdb: Don't iterate over rows on empty mutation.

2024-03-08 Thread Ilya Maximets
On 3/6/24 22:40, Mike Pattrick wrote: > Previously when an empty mutation was used to count the number of rows > in a table, OVSDB would iterate over all rows twice. First to perform an > RBAC check, and then to perform the no-operation. > > This change adds a short circuit to mutate operations

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Dump packets that fail Tx preparation.

2024-03-08 Thread Ilya Maximets
On 3/8/24 12:21, Kevin Traynor wrote: > On 07/03/2024 19:39, Ilya Maximets wrote: >> It's hard to debug situations where driver rejects packets for some >> reason. Dumping out the mbuf should help with that. >> >> Sample output looks like this: >> >> |netdev_dpdk(pmd-c03/id:8)|DBG|ovs-p1: First

Re: [ovs-dev] [PATCH v2] bfd: Improve state change log message.

2024-03-08 Thread Ilya Maximets
On 3/8/24 11:22, Eelco Chaudron wrote: > > > On 5 Mar 2024, at 21:37, Timothy Redaelli wrote: > >> A log message like this one: >> >> 2024-01-09T06:45:17.201Z|00071|bfd(handler2)|INFO|ovn-0af536-0: BFD state >> change: down->up "Neighbor Signaled Session Down"->"Neighbor Signaled Session >>

Re: [ovs-dev] [PATCH] tests: Fix "SSL db: implementation" test with openssl > 3.2.0.

2024-03-08 Thread Ilya Maximets
On 3/8/24 11:37, Eelco Chaudron wrote: > > > On 5 Mar 2024, at 19:55, Timothy Redaelli wrote: > >> In OpenSSL 3.2.0 (81b741f) all the "alert" error messages was updated to > > was -> were > >> replace "sslv3" with "ssl/tls". >> >> This commit updates the "SSL db: implementation" test to

Re: [ovs-dev] [PATCH branch-2.17] conntrack: Fix flush not flushing all elements.

2024-03-08 Thread Simon Horman
On Wed, Mar 06, 2024 at 07:06:39PM +, Simon Horman wrote: > From: Xavier Simonart > > On netdev datapath, when a ct element was cleaned, the cmap > could be shrinked, potentially causing some elements to be skipped > in the flush iteration. > > Fixes: 967bb5c5cd90 ("conntrack: Add rcu

Re: [ovs-dev] [PATCH branch-3.0] conntrack: Fix flush not flushing all elements.

2024-03-08 Thread Simon Horman
On Wed, Mar 06, 2024 at 07:00:50PM +, Simon Horman wrote: > From: Xavier Simonart > > On netdev datapath, when a ct element was cleaned, the cmap > could be shrinked, potentially causing some elements to be skipped > in the flush iteration. > > Fixes: 967bb5c5cd90 ("conntrack: Add rcu

Re: [ovs-dev] [PATCH branch-3.1] conntrack: Fix flush not flushing all elements.

2024-03-08 Thread Simon Horman
On Wed, Mar 06, 2024 at 06:21:36PM +, 'Simon Horman' wrote: > From: Xavier Simonart > > On netdev datapath, when a ct element was cleaned, the cmap > could be shrinked, potentially causing some elements to be skipped > in the flush iteration. > > Fixes: 967bb5c5cd90 ("conntrack: Add rcu

Re: [ovs-dev] [PATCH branch-3.2 0/2] conntrack: Fix flush not flushing all elements.

2024-03-08 Thread Simon Horman
On Wed, Mar 06, 2024 at 06:11:08PM +, 'Simon Horman' wrote: > Backport to branch-3.2 of: > > - conntrack: Fix flush not flushing all elements. > https://github.com/openvswitch/ovs/commit/6c082a8310d5 > > Including dependency which is not present in branch-3.2. Applied to branch-3.2: -

Re: [ovs-dev] [PATCH ovn 2/3] northd: Add nexhop id in ct_label.label.

2024-03-08 Thread Mark Michelson
Hi Lorenzo, Just a couple of small comments below. On 3/7/24 08:19, Lorenzo Bianconi wrote: Introduce the nexthop identifier in the ct_label.label field for ecmp-symmetric replies connections. This field will be used by ovn-controller to track ct entries and to flush them if requested by the

Re: [ovs-dev] [PATCH ovn 2/3] northd: Add nexhop id in ct_label.label.

2024-03-08 Thread Mark Michelson
Hi Lorenzo, Just a couple of small comments below. On 3/7/24 08:19, Lorenzo Bianconi wrote: Introduce the nexthop identifier in the ct_label.label field for ecmp-symmetric replies connections. This field will be used by ovn-controller to track ct entries and to flush them if requested by the

Re: [ovs-dev] [PATCH ovn 1/3] northd: Introduce ECMP_Nexthop table in SB db.

2024-03-08 Thread Mark Michelson
Hi Lorenzo, I have some comments below. On 3/7/24 08:19, Lorenzo Bianconi wrote: Introduce ECMP_Nexthop table in the SB db in order to track active ecmp-symmetric-reply connections and flush stale ones. Signed-off-by: Lorenzo Bianconi --- northd/en-northd.c | 4 ++

Re: [ovs-dev] [PATCH ovn 0/3] Introduce ECMP_nexthop monitor in ovn-controller

2024-03-08 Thread Mark Michelson
Hi Lorenzo, I haven't had time to review patch 3 yet, but I have made some comments on patches 1 and 2 for now. On 3/7/24 08:19, Lorenzo Bianconi wrote: Reported-at: https://issues.redhat.com/browse/FDP-56 Lorenzo Bianconi (3): northd: Introduce ECMP_Nexthop table in SB db. northd:

Re: [ovs-dev] [PATCH ovn] utilities: Make database connection optional for ovn-detrace.

2024-03-08 Thread Mark Michelson
Thanks Ales, it looks good to me. Acked-by: Mark Michelson On 3/5/24 01:21, Ales Musil wrote: The ovn-detrace required both connections (SB and NB) to provide some output. However, it is a valid scenario to have only one database available, usually the SB. With that in mind make the

Re: [ovs-dev] [RFC PATCH 0/4] net: openvswitch: Add sample multicasting.

2024-03-08 Thread Ilya Maximets
On 3/7/24 22:29, Ilya Maximets wrote: > On 3/7/24 21:59, Adrian Moreno wrote: >> >> >> On 3/7/24 17:54, Ilya Maximets wrote: >>> On 3/7/24 16:18, Adrian Moreno wrote: ** Background ** Currently, OVS supports several packet sampling mechanisms (sFlow, per-bridge IPFIX, per-flow IPFIX).

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Dump packets that fail Tx preparation.

2024-03-08 Thread Kevin Traynor
On 07/03/2024 19:39, Ilya Maximets wrote: > It's hard to debug situations where driver rejects packets for some > reason. Dumping out the mbuf should help with that. > > Sample output looks like this: > > |netdev_dpdk(pmd-c03/id:8)|DBG|ovs-p1: First invalid packet: > dump mbuf at

Re: [ovs-dev] [PATCH ovn] tests: Skip EDNS test if the scapy version doesn't support it.

2024-03-08 Thread Dumitru Ceara
On 3/8/24 09:26, Ales Musil wrote: > On Thu, Mar 7, 2024 at 4:19 PM Dumitru Ceara wrote: > >> EDNS0ClientSubnet is quite a recent addition to scapy and not all >> distros might already have a new enough version of scapy available. >> >> Fixes: b7fe2c8b1b08 ("pinctrl: dns: Ignore additional

Re: [ovs-dev] [PATCH v10 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-03-08 Thread Eelco Chaudron
On 5 Mar 2024, at 16:44, Aaron Conole wrote: > From: Kevin Sprague > > During normal operations, it is useful to understand when a particular flow > gets removed from the system. This can be useful when debugging performance > issues tied to ofproto flow changes, trying to determine deployed

Re: [ovs-dev] [PATCH v6 2/2] netlink-conntrack: Optimize flushing ct zone.

2024-03-08 Thread Ilya Maximets
On 3/4/24 09:22, Felix Huettner via dev wrote: > Previously the kernel did not provide a netlink interface to flush/list > only conntrack entries matching a specific zone. With [1] and [2] it is now > possible to flush and list conntrack entries filtered by zone. Older > kernels not yet supporting

Re: [ovs-dev] [PATCH] tests: Fix "SSL db: implementation" test with openssl > 3.2.0.

2024-03-08 Thread Eelco Chaudron
On 5 Mar 2024, at 19:55, Timothy Redaelli wrote: > In OpenSSL 3.2.0 (81b741f) all the "alert" error messages was updated to was -> were > replace "sslv3" with "ssl/tls". > > This commit updates the "SSL db: implementation" test to support both the > pre-openssl 3.2.0 error message: "sslv3

Re: [ovs-dev] [PATCH v1 12/12] documentation: Document ovs-flowviz.

2024-03-08 Thread Ilya Maximets
On 3/8/24 11:02, Adrian Moreno wrote: > > > On 2/20/24 07:29, Adrian Moreno wrote: >> >> >> On 2/19/24 23:53, Ilya Maximets wrote: >>> On 2/19/24 09:14, Adrian Moreno wrote: Add a page for flow visualization with a few key concepts and examples. Signed-off-by: Adrian Moreno

Re: [ovs-dev] [PATCH v2] bfd: Improve state change log message.

2024-03-08 Thread Eelco Chaudron
On 5 Mar 2024, at 21:37, Timothy Redaelli wrote: > A log message like this one: > > 2024-01-09T06:45:17.201Z|00071|bfd(handler2)|INFO|ovn-0af536-0: BFD state > change: down->up "Neighbor Signaled Session Down"->"Neighbor Signaled Session > Down". > > can be hard to read since '->' usually

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Dump packets that fail Tx preparation.

2024-03-08 Thread Eelco Chaudron
On 7 Mar 2024, at 20:39, Ilya Maximets wrote: > It's hard to debug situations where driver rejects packets for some > reason. Dumping out the mbuf should help with that. > > Sample output looks like this: > > |netdev_dpdk(pmd-c03/id:8)|DBG|ovs-p1: First invalid packet: > dump mbuf at

Re: [ovs-dev] [PATCH v1 12/12] documentation: Document ovs-flowviz.

2024-03-08 Thread Adrian Moreno
On 2/20/24 07:29, Adrian Moreno wrote: On 2/19/24 23:53, Ilya Maximets wrote: On 2/19/24 09:14, Adrian Moreno wrote: Add a page for flow visualization with a few key concepts and examples. Signed-off-by: Adrian Moreno ---   Documentation/automake.mk   |   3 +-  

Re: [ovs-dev] [PATCH v6 1/2] util: Support checking for kernel versions.

2024-03-08 Thread Eelco Chaudron
On 4 Mar 2024, at 9:22, Felix Huettner via dev wrote: > Extract checking for a given kernel version to a separate function. > It will be used also in the next patch. > > Signed-off-by: Felix Huettner Thanks for fixing the version check. Acked-by: Eelco Chaudron

Re: [ovs-dev] [PATCH OVN] Add support to make fdb table local to the chassis.

2024-03-08 Thread Ales Musil
On Wed, Mar 6, 2024 at 8:24 PM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > > > > On 18-Dec-2023, at 8:53 PM, Dumitru Ceara wrote: > > > > On 12/18/23 16:17, Naveen Yerramneni wrote: > >> > >> > >>> On 18-Dec-2023, at 7:26 PM, Dumitru Ceara wrote: > >>> > >>> On 11/30/23 16:32,

[ovs-dev] [PATCH] ofproto: Fix mod flow table name not to take effect.

2024-03-08 Thread Yuhao zhou via dev
From: "zhouyuhao.philozhou" When mod a flow table's name with table's prefix name, there will be no change. Because when check whether the new and old name are the same, only compare the length of the new name. Case: table 10: "good" There will be no change if mod the table's name with "g"

Re: [ovs-dev] [RFC] bridge: Retry tunnel port addition for conflict.

2024-03-08 Thread Tao Liu
On 3/7/24 5:39 AM, Ilya Maximets wrote: On 2/27/24 20:14, Han Zhou wrote: For kernel datapath, when a new tunnel port is created in the same transaction in which an old tunnel port with the same tunnel configuration is deleted, the new tunnel port creation will fail and left in an error state.

Re: [ovs-dev] [PATCH ovn] tests: Skip EDNS test if the scapy version doesn't support it.

2024-03-08 Thread Ales Musil
On Thu, Mar 7, 2024 at 4:19 PM Dumitru Ceara wrote: > EDNS0ClientSubnet is quite a recent addition to scapy and not all > distros might already have a new enough version of scapy available. > > Fixes: b7fe2c8b1b08 ("pinctrl: dns: Ignore additional records.") > Signed-off-by: Dumitru Ceara > ---

[ovs-dev] [PATCH] ofproto: Fix mod flow table name not to take effect.

2024-03-08 Thread Yuhao zhou via dev
From: "zhouyuhao.philozhou" When mod a flow table's name with table's prefix name, there will be no change. Because when check whether the new and old name are the same, only compare the length of the new name. Case: table 10: "good" There will be no change if mod the table's name with "g"