Re: [ovs-dev] [Patch ovn v2 1/2] actions: Enable specifying zone for ct_commit.

Following up on the comments from v1. @amusil You were right that the struct in actions.h was not necessary then. However I also noticed that I forgot to modify `format_CT_COMMIT_V1` function and for that I think the struct is necessary. I need to distinguish whether the `ct_commit` action was

Re: [ovs-dev] [Patch ovn v2 1/2] actions: Enable specifying zone for ct_commit.

Bleep bloop. Greetings Martin Kalcok, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #223 FILE: ovn-sb.xml:1431:

Re: [ovs-dev] [PATCH] github: Reduce ASLR entropy to be compatible with asan in llvm 14.

On 3/12/24 15:12, Ilya Maximets wrote: > On 3/12/24 13:16, Eelco Chaudron wrote: >> >> >> On 12 Mar 2024, at 12:47, Ilya Maximets wrote: >> >>> Starting with image version 20240310.1.0, GitHub runners are using >>> 32-bit entropy for ASLR: >>> >>> $ sudo sysctl -a | grep vm.mmap.rnd >>>

[ovs-dev] [Patch ovn v2 2/2] northd: Fix direct access to SNAT network on DR.

This change fixes bug that breaks ability of machines from external networks to communicate with machines in SNATed networks (specifically when using a Distributed router). Currently when a machine (S1) on an external network tries to talk over TCP with a machine (A1) in a network that has

[ovs-dev] [Patch ovn v2 1/2] actions: Enable specifying zone for ct_commit.

Action `ct_commit` currently does not allow specifying zone into which connection is committed. For example, in LR datapath, the `ct_commit` will always use the DNAT zone. This change adds option to use `ct_commit(snat)` or `ct_commit(dnat)` to explicitly specify the zone into which the

[ovs-dev] [PATCH] ofproto-dpif-upcall: Don't mirror packets that aren't modified.

Previously OVS reset the mirror contents when a packet is modified in such a way that the packets contents changes. However, this change incorrectly reset that mirror context when only metadata changes as well. Now we check for all metadata fields, instead of just tunnel metadata, before

[ovs-dev] [PATCH ovn v2 1/3] northd: Introduce ECMP_Nexthop table in SB db.

Introduce ECMP_Nexthop table in the SB db in order to track active ecmp-symmetric-reply connections and flush stale ones. Signed-off-by: Lorenzo Bianconi --- northd/en-northd.c | 4 +++ northd/inc-proc-northd.c | 8 +++-- northd/northd.c | 73

[ovs-dev] [PATCH ovn v2 2/3] northd: Add nexhop id in ct_label.label.

Introduce the nexthop identifier in the ct_label.label field for ecmp-symmetric replies connections. This field will be used by ovn-controller to track ct entries and to flush them if requested by the CMS (e.g. removing the related static routes). Signed-off-by: Lorenzo Bianconi ---

[ovs-dev] [PATCH ovn v2 3/3] ofctrl: Introduce ecmp_nexthop_monitor.

Introduce ecmp_nexthop_monitor in ovn-controller in order to track and flush ecmp-symmetric reply ct entires when requested by the CMS (e.g removing the related static routes). Signed-off-by: Lorenzo Bianconi --- controller/ofctrl.c | 101 ++ controller/ofctrl.h |

[ovs-dev] [PATCH ovn v2 0/3] Introduce ECMP_nexthop monitor in ovn-controller

Reported-at: https://issues.redhat.com/browse/FDP-56 Changes since v1: - add ID column in ECMP_Nexthop table in SB db - remove nexthop-id in logical_router_static_route option column Lorenzo Bianconi (3): northd: Introduce ECMP_Nexthop table in SB db. northd: Add nexhop id in ct_label.label.

Re: [ovs-dev] [PATCH ovn 2/3] northd: Add nexhop id in ct_label.label.

> Hi Lorenzo, > > Just a couple of small comments below. > > On 3/7/24 08:19, Lorenzo Bianconi wrote: > > Introduce the nexthop identifier in the ct_label.label field for > > ecmp-symmetric replies connections. This field will be used by > > ovn-controller to track ct entries and to flush them

Re: [ovs-dev] [PATCH] github: Reduce ASLR entropy to be compatible with asan in llvm 14.

On 3/12/24 13:16, Eelco Chaudron wrote: > > > On 12 Mar 2024, at 12:47, Ilya Maximets wrote: > >> Starting with image version 20240310.1.0, GitHub runners are using >> 32-bit entropy for ASLR: >> >> $ sudo sysctl -a | grep vm.mmap.rnd >> vm.mmap_rnd_bits = 32 >> vm.mmap_rnd_compat_bits =

Re: [ovs-dev] [PATCH ovn] controller: Set check_tnl_key for BFD on tunnel ifaces.

Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Committer Mark Michelson needs to sign off. WARNING: Unexpected sign-offs from

[ovs-dev] [PATCH] ofproto-dpif: Fix vxlan with different name del/add failed.

Reproduce: ovs-vsctl add-port br-int p0 \ -- set interface p0 type=vxlan options:remote_ip=10.10.10.1 sleep 2 ovs-vsctl --if-exists del-port p0 \ -- add-port br-int p1 \ -- set interface p1 type=vxlan options:remote_ip=10.10.10.1 ovs-vsctl: Error detected while setting up

Re: [ovs-dev] [RFC] bridge: Retry tunnel port addition for conflict.

On 03/11 , Ilya Maximets wrote: > On 3/11/24 06:17, Han Zhou wrote: > > > > > > On Fri, Mar 8, 2024 at 12:17 AM Tao Liu > > wrote: > >> > >> > >> On 3/7/24 5:39 AM, Ilya Maximets wrote: > >> > On 2/27/24 20:14, Han Zhou wrote: > >> >> For kernel datapath, when a new

Re: [ovs-dev] [PATCH] netdev-dpdk: Clean up all marker flags if no offloads requested.

On Mon, Mar 11, 2024 at 2:31 PM Ilya Maximets wrote: > > Some drivers (primarily, Intel ones) do not expect any marking flags > being set if no offloads are requested. If these flags are present, > driver will fail Tx preparation or behave abnormally. > > For example, ixgbe driver will refuse to

Re: [ovs-dev] [PATCH] github: Reduce ASLR entropy to be compatible with asan in llvm 14.

On 3/12/24 14:28, Dumitru Ceara wrote: > On 3/12/24 13:16, Eelco Chaudron wrote: >> >> >> On 12 Mar 2024, at 12:47, Ilya Maximets wrote: >> >>> Starting with image version 20240310.1.0, GitHub runners are using >>> 32-bit entropy for ASLR: >>> >>> $ sudo sysctl -a | grep vm.mmap.rnd >>>

Re: [ovs-dev] [PATCH] github: Reduce ASLR entropy to be compatible with asan in llvm 14.

On 3/12/24 13:16, Eelco Chaudron wrote: > > > On 12 Mar 2024, at 12:47, Ilya Maximets wrote: > >> Starting with image version 20240310.1.0, GitHub runners are using >> 32-bit entropy for ASLR: >> >> $ sudo sysctl -a | grep vm.mmap.rnd >> vm.mmap_rnd_bits = 32 >> vm.mmap_rnd_compat_bits =

Re: [ovs-dev] [PATCH] github: Reduce ASLR entropy to be compatible with asan in llvm 14.

Ilya Maximets writes: > Starting with image version 20240310.1.0, GitHub runners are using > 32-bit entropy for ASLR: > > $ sudo sysctl -a | grep vm.mmap.rnd > vm.mmap_rnd_bits = 32 > vm.mmap_rnd_compat_bits = 16 > > This breaks all the asan-enabled builds, because older asan gets >

Re: [ovs-dev] [PATCH ovn branch-23.09 2/2] Prepare for 23.09.4.

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (NEWS). error: could not build fake ancestor hint:

Re: [ovs-dev] [PATCH ovn branch-24.03 2/2] Prepare for 24.03.2.

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (NEWS). error: could not build fake ancestor hint:

Re: [ovs-dev] [PATCH ovn branch-24.03 1/2] Set release date for 24.03.1.

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the

[ovs-dev] [PATCH ovn] controller: Set check_tnl_key for BFD on tunnel ifaces.

From: Frode Nordahl The OVS BFD configuration option `check_tnl_key` controls whether OVS should consider the tunnel key before processing BFD control messages. The OVN pipeline design ensures traffic originating from a logical port will have a non-zero tunnel key. Always set `check_tnl_key`

Re: [ovs-dev] [PATCH ovn branch-22.03 2/2] Prepare for 22.03.8.

On 3/12/24 13:36, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index

Re: [ovs-dev] [PATCH ovn branch-22.03 1/2] Set release date for 22.03.7.

On 3/12/24 13:36, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara > NEWS | 4 +++- > debian/changelog | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 6087f91d8..a28249bff 100644 > --- a/NEWS > +++

Re: [ovs-dev] [PATCH ovn branch-23.03 2/2] Prepare for 23.03.4.

On 3/12/24 13:36, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index

Re: [ovs-dev] [PATCH ovn branch-23.03 1/2] Set release date for 23.03.3.

On 3/12/24 13:36, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara > NEWS | 4 +++- > debian/changelog | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 6caaeead1..b36fa42a4 100644 > --- a/NEWS > +++

Re: [ovs-dev] [PATCH ovn branch-23.06 2/2] Prepare for 23.06.4.

On 3/12/24 13:36, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index

Re: [ovs-dev] [PATCH ovn branch-23.06 1/2] Set release date for 23.06.3.

On 3/12/24 13:36, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara > NEWS | 4 +++- > debian/changelog | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 12c5e9efd..9c73ad4ec 100644 > --- a/NEWS > +++

Re: [ovs-dev] [PATCH ovn branch-23.09 2/2] Prepare for 23.09.4.

On 3/12/24 13:36, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index

Re: [ovs-dev] [PATCH ovn branch-23.09 1/2] Set release date for 23.09.3.

On 3/12/24 13:36, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara > NEWS | 4 +++- > debian/changelog | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 58b1c9066..31c069aea 100644 > --- a/NEWS > +++

Re: [ovs-dev] [PATCH ovn branch-24.03 2/2] Prepare for 24.03.2.

On 3/12/24 13:36, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index

Re: [ovs-dev] [PATCH ovn branch-24.03 1/2] Set release date for 24.03.1.

On 3/12/24 13:36, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara > NEWS | 4 +++- > debian/changelog | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index c66a2bc50..e91cbe43f 100644 > --- a/NEWS > +++

[ovs-dev] [PATCH ovn branch-23.09 2/2] Prepare for 23.09.4.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 31c069aea..97e1c41d5 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.09.4 - xx xxx

[ovs-dev] [PATCH ovn branch-22.03 1/2] Set release date for 22.03.7.

Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 6087f91d8..a28249bff 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,7 @@ -OVN v22.03.7 - xx xxx +OVN v22.03.7 - 12 Mar 2024

[ovs-dev] [PATCH ovn branch-22.03 0/2] Release patches for v22.03.7.

Mark Michelson (2): Set release date for 22.03.7. Prepare for 22.03.8. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-22.03 2/2] Prepare for 22.03.8.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index a28249bff..8d92161bb 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v22.03.8 - xx xxx

[ovs-dev] [PATCH ovn branch-23.03 2/2] Prepare for 23.03.4.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index b36fa42a4..9f93953db 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.03.4 - xx xxx

[ovs-dev] [PATCH ovn branch-23.06 1/2] Set release date for 23.06.3.

Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 12c5e9efd..9c73ad4ec 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,9 @@ -OVN v23.06.3 - xx xxx +OVN v23.06.3 - 12 Mar 2024

[ovs-dev] [PATCH ovn branch-23.03 1/2] Set release date for 23.03.3.

Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 6caaeead1..b36fa42a4 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,9 @@ -OVN v23.03.3 - xx xxx +OVN v23.03.3 - 12 Mar 2024

[ovs-dev] [PATCH ovn branch-23.06 2/2] Prepare for 23.06.4.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 9c73ad4ec..a87cfd7ec 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.06.4 - xx xxx

[ovs-dev] [PATCH ovn branch-23.03 0/2] Release patches for v23.03.3.

Mark Michelson (2): Set release date for 23.03.3. Prepare for 23.03.4. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-23.09 0/2] Release patches for v23.09.3.

Mark Michelson (2): Set release date for 23.09.3. Prepare for 23.09.4. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-23.06 0/2] Release patches for v23.06.3.

Mark Michelson (2): Set release date for 23.06.3. Prepare for 23.06.4. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-24.03 2/2] Prepare for 24.03.2.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index e91cbe43f..ca3562425 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v24.03.2 - xx xxx

[ovs-dev] [PATCH ovn branch-23.09 1/2] Set release date for 23.09.3.

Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 58b1c9066..31c069aea 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,7 @@ -OVN v23.09.3 - xx xxx +OVN v23.09.3 - 12 Mar 2024

[ovs-dev] [PATCH ovn branch-24.03 0/2] Release patches for v24.03.1.

Mark Michelson (2): Set release date for 24.03.1. Prepare for 24.03.2. NEWS | 7 ++- configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 14 insertions(+), 3 deletions(-) -- 2.44.0 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-24.03 1/2] Set release date for 24.03.1.

Signed-off-by: Mark Michelson --- NEWS | 4 +++- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index c66a2bc50..e91cbe43f 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,7 @@ -OVN v24.03.1 - xx xxx +OVN v24.03.1 - 12 Mar 2024

Re: [ovs-dev] [PATCH] github: Reduce ASLR entropy to be compatible with asan in llvm 14.

On 12 Mar 2024, at 12:47, Ilya Maximets wrote: > Starting with image version 20240310.1.0, GitHub runners are using > 32-bit entropy for ASLR: > > $ sudo sysctl -a | grep vm.mmap.rnd > vm.mmap_rnd_bits = 32 > vm.mmap_rnd_compat_bits = 16 > > This breaks all the asan-enabled builds,

[ovs-dev] [PATCH] github: Reduce ASLR entropy to be compatible with asan in llvm 14.

Starting with image version 20240310.1.0, GitHub runners are using 32-bit entropy for ASLR: $ sudo sysctl -a | grep vm.mmap.rnd vm.mmap_rnd_bits = 32 vm.mmap_rnd_compat_bits = 16 This breaks all the asan-enabled builds, because older asan gets confused by memory mappings and crashes with

Re: [ovs-dev] [PATCH ovn 1/3] northd: Introduce ECMP_Nexthop table in SB db.

> Hi Lorenzo, Hi Mark, > > I have some comments below. thx for the review. > > On 3/7/24 08:19, Lorenzo Bianconi wrote: > > Introduce ECMP_Nexthop table in the SB db in order to track active > > ecmp-symmetric-reply connections and flush stale ones. > > > > Signed-off-by: Lorenzo Bianconi

[ovs-dev] [PATCH ovn v2 1/2] tests: Move ovn interconnection tests to ovn-ic.at.

Move ovn-ic tests that exist in ovn.at to ovn-ic.at. Signed-off-by: Mohammad Heib --- tests/ovn-ic.at | 687 tests/ovn.at| 686 --- 2 files changed, 687 insertions(+), 686 deletions(-) diff --git

[ovs-dev] [PATCH ovn v2 2/2] tests: Use sync command in ovn-ic tests.

Use the sync commands in the ovn-ic unit tests and remove lines that wait for IC-SB to sync with IC-NB. Signed-off-by: Mohammad Heib --- tests/ovn-ic.at | 178 1 file changed, 72 insertions(+), 106 deletions(-) diff --git a/tests/ovn-ic.at

[ovs-dev] [PATCH] conntrack: Do not use icmp reverse helper for icmpv6.

In the flush tuple code path, while populating the conn_key, reverse_icmp_type() gets called for both icmp and icmpv6 cases, while, depending on the proto, its respective helper should be called, instead. The above leads to an abort: [...] 0x7f3d461888ff in __GI_abort () at abort.c:79

[ovs-dev] [PATCH ovn v3 1/2] tests: Add helper for tcpdump.

The way how tcpdump was called in tests was inconsistent, a lot fo the tests didn't even wait for the tcpdump to properly start, some of them didn't redirect the stderr which could cause leak into the test stderr and fail the test. To prevent that add macro that starts tcpdump and properly waits

[ovs-dev] [PATCH ovn v3 2/2] tests: Address netcat 7.94 changes.

Fedora received an update of netcat to version 7.94, this version brings ability for UDP to accept multiple connections without closing (-k/--keep-open) [0]. That had negative impact on the tests as the UDP netcat server was closing sooner that expected. Make sure that the server is alive when we