[ovs-dev] [PATCH ovn] ovn-controller: Fix busy loop when ofctrl is disconnected.

ovn-controller runs at 100% cpu when OVS exits. This is because the ofctrl_run is not called while ofctrl_wait is always called in the main loop. Because of the missing ofctrl_run, it doesn't even detect that the ofctrl connection is disconnected. This patch fixes the issue by always giving a

[ovs-dev] [PATCH v3] ovs-tcpdump: Fix cleanup mirror failed with twice fatal signals.

After running ovs-tcpdump and inputs multiple CTRL+C, the program will raise the following exception. Error in atexit._run_exitfuncs: Traceback (most recent call last): File "/usr/bin/ovs-tcpdump", line 421, in cleanup_mirror ovsdb = OVSDB(db_sock) File "/usr/bin/ovs-tcpdump", line 168,

[ovs-dev] [PATCH v2] netdev-dpdk: Disable outer udp checksum offload for ice driver.

Signed-off-by: Jun Wang --- lib/netdev-dpdk.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 29a6bf0..1820163 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1354,6 +1354,12 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev)

Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

On 3/15/24 11:04, LIU Yulong wrote: > A potential race condition happened with the following 3 threads: > * PMD thread replaced the old_ukey and transitioned the state to > UKEY_DELETED. > * RCU thread is freeing the old_ukey mutex. > * While the revalidator thread is trying to lock the old_ukey

Re: [ovs-dev] [PATCH] ovs-monitor-ipsec: LibreSwan autodetect paths.

On 3/13/24 22:54, Mike Pattrick wrote: > In v4.0, LibreSwan changed a default paths that had been hardcoded in > ovs-monitor-ipsec, breaking some uses of this script. This patch adds > support for both old and newer versions by auto detecting the location > of these paths from LibreSwan shell

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix vxlan with different name del/add failed.

On 3/14/24 05:51, Han Zhou wrote: > > Thanks Tao for fixing this. I think the title can be more generic because > this problem and fix applies to all tunnel types rather than just VXLAN. > > On Tue, Mar 12, 2024 at 7:04 AM Tao Liu > wrote: >> >> Reproduce: >>  

Re: [ovs-dev] [PATCH] ofpbuf: Prevent undefined behavior in ofpbuf_clone

On 3/7/24 16:01, Ales Musil wrote: > The new_buffer data pointer is NULL when the size of the cloned > buffer is 0. This is fine as there is no need to allocate space. > However, the cloned buffer header/msg might be the same pointer > as data. This causes undefined behavior by adding 0 to NULL

Re: [ovs-dev] [PATCH v2] ovs-tcpdump: Fix cleanup mirror failed with twice fatal signals.

On 3/18/24 09:38, Daniel Ding wrote: > > >> 2024年3月16日 上午9:17，Ilya Maximets > > 写道： >> >> On 2/23/24 04:37, Daniel Ding wrote: >>> After running ovs-tcpdump and inputs multiple CTRL+C, the program will >>> raise the following exception. >>> >>> Error in

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix continuations with associated metering.

Ilya Maximets writes: > On 3/7/24 18:25, Aaron Conole wrote: >> Open vSwitch supports the ability to invoke a controller action by way >> of a sample action with a specified meter. In the normal case, this >> sample action is transparently generated during xlate processing. However, >> when

Re: [ovs-dev] [PATCH] route-table: Avoid routes from non-standard routing tables.

Ilya Maximets writes: > Currently, ovs-vswitchd is subscribed to all the routing changes in the > kernel. On each change, it marks the internal routing table cache as > invalid, then resets it and dumps all the routes from the kernel from > scratch. The reason for that is kernel routing

Re: [ovs-dev] [PATCH OVN v4 3/4] northd: DHCP Relay Agent support for overlay IPv4 subnets.

References: <20240319191726.165359-4-naveen.yerramn...@nutanix.com> Bleep bloop. Greetings Naveen Yerramneni, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is

[ovs-dev] [PATCH OVN v4 4/4] tests: DHCP Relay Agent support for overlay IPv4 subnets.

Added tests for DHCP Relay feature. Signed-off-by: Naveen Yerramneni --- tests/atlocal.in| 3 + tests/ovn-northd.at | 38 +++ tests/ovn.at| 258 +++- tests/system-ovn.at | 148 + 4 files changed, 446

[ovs-dev] [PATCH OVN v4 3/4] northd: DHCP Relay Agent support for overlay IPv4 subnets.

NB SCHEMA CHANGES - 1. New DHCP_Relay table "DHCP_Relay": { "columns": { "name": {"type": "string"}, "servers": {"type": {"key": "string", "min": 0,

[ovs-dev] [PATCH OVN v4 2/4] controller: DHCP Relay Agent support for overlay IPv4 subnets.

Added changes in pinctrl to process DHCP Relay opcodes: - ACTION_OPCODE_DHCP_RELAY_REQ_CHK: For request packets - ACTION_OPCODE_DHCP_RELAY_RESP_CHK: For response packet Signed-off-by: Naveen Yerramneni --- controller/pinctrl.c | 596 ++- lib/ovn-l7.h

[ovs-dev] [PATCH OVN v4 1/4] actions: DHCP Relay Agent support for overlay IPv4 subnets.

NEW OVN ACTIONS --- 1. dhcp_relay_req_chk(, ) - This action executes on the source node on which the DHCP request originated. - This action relays the DHCP request coming from client to the server. Relay-ip is used to update GIADDR in the DHCP header. 2.

[ovs-dev] [PATCH OVN v4 0/4] DHCP Relay Agent support for overlay subnets.

This patch contains changes to enable DHCP Relay Agent support for overlay subnets. USE CASE: -- - Enable IP address assignment for overlay subnets from the centralized DHCP server present in the underlay network. PREREQUISITES -- - Logical

Re: [ovs-dev] [PATCH ovn] controller: Track individual address set constants.

On 3/19/24 17:43, Ales Musil wrote: > Instead of tracking address set per struct expr_constant_set track it > per individual struct expr_constant. This allows more fine grained > control for I-P processing of address sets in controller. It helps with > scenarios like matching on two address sets

Re: [ovs-dev] [PATCH ovn] controller: Track individual address set constants.

On Tue, Mar 19, 2024 at 5:43 PM Ales Musil wrote: > Instead of tracking address set per struct expr_constant_set track it > per individual struct expr_constant. This allows more fine grained > control for I-P processing of address sets in controller. It helps with > scenarios like matching on

[ovs-dev] [PATCH ovn] controller: Track individual address set constants.

Instead of tracking address set per struct expr_constant_set track it per individual struct expr_constant. This allows more fine grained control for I-P processing of address sets in controller. It helps with scenarios like matching on two address sets in one expression e.g. "ip4.src == {$as1,

Re: [ovs-dev] [PATCH v1] netdev-dpdk: disable outer udp checksum offload for ice driver

Bleep bloop. Greetings Jun Wang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should start with a capital. WARNING: The subject summary should end

[ovs-dev] [PATCH v1] netdev-dpdk: disable outer udp checksum offload for ice driver

Signed-off-by: Jun Wang --- lib/netdev-dpdk.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 29a6bf0..1820163 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1354,6 +1354,12 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev)

[ovs-dev] [PATCH ovn] controller: Fix ofctrl memory usage underflow.

The memory usage would be increased for size of sb_addrset_ref struct, but decreased for the size of the struct + the name. That would slowly lead to underflows in some cases. Reported-at: https://issues.redhat.com/browse/FDP-507 Signed-off-by: Ales Musil --- controller/ofctrl.c | 10 --

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

On 19 Mar 2024, at 16:19, Ilya Maximets wrote: > On 3/19/24 15:54, Eelco Chaudron wrote: >> >> >> On 19 Mar 2024, at 15:46, Ilya Maximets wrote: >> >>> On 3/19/24 15:17, Eelco Chaudron wrote: On 19 Mar 2024, at 15:00, Ilya Maximets wrote: > On 3/19/24 14:41, Jakob Meng

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

On 3/19/24 15:54, Eelco Chaudron wrote: > > > On 19 Mar 2024, at 15:46, Ilya Maximets wrote: > >> On 3/19/24 15:17, Eelco Chaudron wrote: >>> >>> >>> On 19 Mar 2024, at 15:00, Ilya Maximets wrote: >>> On 3/19/24 14:41, Jakob Meng wrote: > > > On 19.03.24 13:22, Ilya Maximets

Re: [ovs-dev] [PATCH v10 0/2] debugging: Add a revalidator probe, and monitor script

On 5 Mar 2024, at 16:44, Aaron Conole wrote: > Resurrecting a feature from 2022, introduce a probe that indicates > why a particular flow may be selected for eviction during revalidation > and includes the flow information. > > The second patch tells fedora builds to include the USDT probe

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

On 19 Mar 2024, at 15:46, Ilya Maximets wrote: > On 3/19/24 15:17, Eelco Chaudron wrote: >> >> >> On 19 Mar 2024, at 15:00, Ilya Maximets wrote: >> >>> On 3/19/24 14:41, Jakob Meng wrote: On 19.03.24 13:22, Ilya Maximets wrote: > On 3/19/24 13:21, Ilya Maximets wrote: >>

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

On 3/19/24 15:17, Eelco Chaudron wrote: > > > On 19 Mar 2024, at 15:00, Ilya Maximets wrote: > >> On 3/19/24 14:41, Jakob Meng wrote: >>> >>> >>> On 19.03.24 13:22, Ilya Maximets wrote: On 3/19/24 13:21, Ilya Maximets wrote: > On 3/19/24 13:17, Eelco Chaudron wrote: >> >> On 19

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

On 19 Mar 2024, at 15:00, Ilya Maximets wrote: > On 3/19/24 14:41, Jakob Meng wrote: >> >> >> On 19.03.24 13:22, Ilya Maximets wrote: >>> On 3/19/24 13:21, Ilya Maximets wrote: On 3/19/24 13:17, Eelco Chaudron wrote: > > On 19 Mar 2024, at 13:11, Jakob Meng wrote: > >> Hi!

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

On 3/19/24 14:41, Jakob Meng wrote: > > > On 19.03.24 13:22, Ilya Maximets wrote: >> On 3/19/24 13:21, Ilya Maximets wrote: >>> On 3/19/24 13:17, Eelco Chaudron wrote: On 19 Mar 2024, at 13:11, Jakob Meng wrote: > Hi! > > On 15.03.24 11:19, Eelco Chaudron wrote: >>

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

On 19.03.24 13:22, Ilya Maximets wrote: > On 3/19/24 13:21, Ilya Maximets wrote: >> On 3/19/24 13:17, Eelco Chaudron wrote: >>> >>> On 19 Mar 2024, at 13:11, Jakob Meng wrote: >>> Hi! On 15.03.24 11:19, Eelco Chaudron wrote: > On 18 Jan 2024, at 16:26, jm...@redhat.com wrote:

Re: [ovs-dev] [PATCH v7 5/6] appctl: Add option '--pretty' for pretty-printing JSON output.

On 3/15/24 11:27, Eelco Chaudron wrote: > On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: > >> From: Jakob Meng >> diff --git a/lib/unixctl.h b/lib/unixctl.h >> index 35ef6a548..fe9160894 100644 >> --- a/lib/unixctl.h >> +++ b/lib/unixctl.h >> @@ -39,6 +39,7 @@ int unixctl_client_create(const

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

On 3/19/24 13:21, Ilya Maximets wrote: > On 3/19/24 13:17, Eelco Chaudron wrote: >> >> >> On 19 Mar 2024, at 13:11, Jakob Meng wrote: >> >>> Hi! >>> >>> On 15.03.24 11:19, Eelco Chaudron wrote: On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: > ... Thank for the patch! What a

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

On 3/19/24 13:17, Eelco Chaudron wrote: > > > On 19 Mar 2024, at 13:11, Jakob Meng wrote: > >> Hi! >> >> On 15.03.24 11:19, Eelco Chaudron wrote: >>> On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: >>> ... >>> Thank for the patch! What a beast to go trough ;) >> >> Thank you for doing it

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

On 19 Mar 2024, at 13:11, Jakob Meng wrote: > Hi! > > On 15.03.24 11:19, Eelco Chaudron wrote: >> On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: >> >>> ... >> Thank for the patch! What a beast to go trough ;) > > Thank you for doing it anyway ☺️ > >> I believe the current approach is

Re: [ovs-dev] [PATCH v7 2/6] python: Add global option for JSON output to Python tools.

On 19 Mar 2024, at 11:24, Jakob Meng wrote: > On 15.03.24 11:16, Eelco Chaudron wrote: >> Hi Jakob, >> >> See some comments below. >> >> //Eelco > > Thanks and comments below again  > > Cheers, > Jakob > >>> ... >>> --- a/tests/appctl.py >>> +++ b/tests/appctl.py >>> @@ -49,13 +49,30 @@ def

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

Hi! On 15.03.24 11:19, Eelco Chaudron wrote: > On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: > >> ... > Thank for the patch! What a beast to go trough ;) Thank you for doing it anyway ☺️ > I believe the current approach is acceptable. However, we could also > incorporate union callbacks: if

Re: [ovs-dev] [PATCH v7 1/6] Add global option for JSON output to ovs-appctl.

On 19 Mar 2024, at 11:09, Jakob Meng wrote: > On 15.03.24 11:15, Eelco Chaudron wrote: >> [...] >> Hi Jakob, >> >> >> Thank you for submitting this series; I believe it's a valuable addition to >> OVS! Apologies for the delayed response. I've reviewed the entire series, >> and most of the

Re: [ovs-dev] [PATCH ovn v4 2/2] tests: Address netcat 7.94 changes.

On 3/19/24 07:50, Ales Musil wrote: > Fedora received an update of netcat to version 7.94, this version > brings ability for UDP to accept multiple connections without closing > (-k/--keep-open) [0]. That had negative impact on the tests as the UDP > netcat server was closing sooner that expected.

Re: [ovs-dev] [PATCH ovn v4 1/2] tests: Add helper for tcpdump.

On 3/19/24 07:50, Ales Musil wrote: > The way how tcpdump was called in tests was inconsistent, > a lot fo the tests didn't even wait for the tcpdump to properly > start, some of them didn't redirect the stderr which could cause > leak into the test stderr and fail the test. > > To prevent that

Re: [ovs-dev] [PATCH ovn] tests: Ignore transaction errors in MAC Binding.

On 3/19/24 08:06, Ales Musil wrote: > On Fri, Mar 15, 2024 at 7:43 PM Xavier Simonart wrote: > >> Fixes: 65f9f010b426 ("tests: Check unit tests logs for errors.") >> Signed-off-by: Xavier Simonart >> --- >> tests/ovn-macros.at | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git

Re: [ovs-dev] [PATCH v7 2/6] python: Add global option for JSON output to Python tools.

On 15.03.24 11:16, Eelco Chaudron wrote: > Hi Jakob, > > See some comments below. > > //Eelco Thanks and comments below again  Cheers, Jakob >> ... >> --- a/tests/appctl.py >> +++ b/tests/appctl.py >> @@ -49,13 +49,30 @@ def main(): >> help="Arguments to the

Re: [ovs-dev] [PATCH v7 1/6] Add global option for JSON output to ovs-appctl.

On 15.03.24 11:15, Eelco Chaudron wrote: > [...] > Hi Jakob, > > > Thank you for submitting this series; I believe it's a valuable addition to > OVS! Apologies for the delayed response. I've reviewed the entire series, and > most of the comments are minor change requests. I'll hold off on

Re: [ovs-dev] OVN technical community meeting - March 19th (was February 19th)

Hi all, The next OVN technical community meeting is scheduled to happen today, at 4PM UTC. Feel free to add topics you might want to discuss today to the agenda doc below. I added the ones saw being mentioned in other settings (IRC meeting) and what I thought might also be relevant. Looking

Re: [ovs-dev] [RFC ovn] controller: Always populate prefix-length for IPv6 PD.

On Mon, Mar 18, 2024 at 10:12 PM Frode Nordahl wrote: > > The prefix we obtain is used to fill the ``ipv6_ra_prefixes`` > option for configuration of instances through SLAAC. > > As discussed in RFC 7421 the interface identifier is 64 bits long, > and client implementations refrain from

Re: [ovs-dev] [PATCH OVN v3 4/4] tests: DHCP Relay Agent support for overlay IPv4 subnets.

References: <20240319075458.49166-5-naveen.yerramn...@nutanix.com> Bleep bloop. Greetings Naveen Yerramneni, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am:

Re: [ovs-dev] [PATCH OVN v3 3/4] northd: DHCP Relay Agent support for overlay IPv4 subnets.

References: <20240319075458.49166-4-naveen.yerramn...@nutanix.com> Bleep bloop. Greetings Naveen Yerramneni, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is

[ovs-dev] [PATCH OVN v3 0/4] DHCP Relay Agent support for overlay subnets.

This patch contains changes to enable DHCP Relay Agent support for overlay subnets. USE CASE: -- - Enable IP address assignment for overlay subnets from the centralized DHCP server present in the underlay network. PREREQUISITES -- - Logical

[ovs-dev] [PATCH OVN v3 3/4] northd: DHCP Relay Agent support for overlay IPv4 subnets.

NB SCHEMA CHANGES - 1. New DHCP_Relay table "DHCP_Relay": { "columns": { "name": {"type": "string"}, "servers": {"type": {"key": "string", "min": 0,

[ovs-dev] [PATCH OVN v3 4/4] tests: DHCP Relay Agent support for overlay IPv4 subnets.

Added tests for DHCP Relay feature. Signed-off-by: Naveen Yerramneni --- tests/atlocal.in| 3 + tests/ovn-northd.at | 38 ++ tests/ovn.at| 293 +--- tests/system-ovn.at | 148 ++ 4 files changed, 462 insertions(+),

[ovs-dev] [PATCH OVN v3 1/4] controller: DHCP Relay Agent support for overlay IPv4 subnets.

Added changes in pinctrl to process DHCP Relay opcodes: - ACTION_OPCODE_DHCP_RELAY_REQ_CHK: For request packets - ACTION_OPCODE_DHCP_RELAY_RESP_CHK: For response packet Signed-off-by: Naveen Yerramneni --- controller/pinctrl.c | 596 ++- lib/ovn-l7.h

[ovs-dev] [PATCH OVN v3 2/4] actions: DHCP Relay Agent support for overlay IPv4 subnets.

NEW OVN ACTIONS --- 1. dhcp_relay_req_chk(, ) - This action executes on the source node on which the DHCP request originated. - This action relays the DHCP request coming from client to the server. Relay-ip is used to update GIADDR in the DHCP header. 2.

Re: [ovs-dev] [PATCH ovn] tests: Ignore transaction errors in MAC Binding.

On Fri, Mar 15, 2024 at 7:43 PM Xavier Simonart wrote: > Fixes: 65f9f010b426 ("tests: Check unit tests logs for errors.") > Signed-off-by: Xavier Simonart > --- > tests/ovn-macros.at | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at > index

Re: [ovs-dev] [PATCH 1/5] ovsdb: raft: Randomize leadership transfer.

On Mon, Mar 18, 2024 at 05:52:12PM +0100, Ilya Maximets wrote: > On 3/18/24 17:15, Felix Huettner wrote: > > On Fri, Mar 15, 2024 at 09:14:49PM +0100, Ilya Maximets wrote: > >> Each cluster member typically always transfers leadership to the same > >> other member, which is the first in their list

[ovs-dev] [PATCH ovn v4 1/2] tests: Add helper for tcpdump.

The way how tcpdump was called in tests was inconsistent, a lot fo the tests didn't even wait for the tcpdump to properly start, some of them didn't redirect the stderr which could cause leak into the test stderr and fail the test. To prevent that add macro that starts tcpdump and properly waits

[ovs-dev] [PATCH ovn v4 2/2] tests: Address netcat 7.94 changes.

Fedora received an update of netcat to version 7.94, this version brings ability for UDP to accept multiple connections without closing (-k/--keep-open) [0]. That had negative impact on the tests as the UDP netcat server was closing sooner that expected. Make sure that the server is alive when we