Re: [ovs-dev] [PATCH ovn] Do not reply on unicast arps for targets.

On Mon, Apr 22, 2024 at 2:54 AM Vasyl Saienko wrote: > > Reply only if target ethernet address is broadcast, if > address is specified explicitly do noting to let target > reply by itself. This technique allows to monitor target > aliveness with arping. Thanks for the patch. This patch does

Re: [ovs-dev] [PATCH ovn v2] controller: Fix an issue wrt cleanup of stale patch port.

On Mon, Apr 22, 2024 at 2:49 AM Priyankar Jain wrote: > > Issue: > Upon updating the network_name option of localnet port from one physical > bridge to another, ovn-controller fails to cleanup the peer localnet > patch port from the old bridge and ends up creating a duplicate peer > localnet

Re: [ovs-dev] [PATCH] ofproto-dpif-trace: Fix access to an out-of-scope stack memory.

On 5/3/24 11:29, Eelco Chaudron wrote: > > > On 3 May 2024, at 1:36, Ilya Maximets wrote: > >> While tracing NAT actions, pointer to the action may be stored in the >> recirculation node for future reference. However, while translating >> actions for the group bucket in xlate_group_bucket, the

Re: [ovs-dev] [PATCH v3] hash, jhash: Fix unaligned access to the hash remainder.

On 5/3/24 13:44, Simon Horman wrote: > On Fri, May 03, 2024 at 07:44:13AM +0200, Ales Musil wrote: >> Partially revert db5a101931c5, this was to avoid warning, however we >> shouldn't use pointer to "uint32_t" when the data are potentially >> unaligned [0]. Use pointer to "uint8_t" right from the

Re: [ovs-dev] [PATCH] sparse: Add additional define for sparse on GCC >= 14.

On 5/3/24 13:42, Simon Horman wrote: > On Thu, May 02, 2024 at 01:13:39PM +0200, Ales Musil wrote: >> GCC 14 renamed one of the AVX512 defines to have only single >> underscore instead of two [0]. Add the single underscore define to >> keep compatibility with multiple GCC versions. >> >> [0] >>

Re: [ovs-dev] [PATCH v3] docs: Document manual cluster recovery procedure.

On 5/3/24 00:42, Ihar Hrachyshka wrote: > On Thu, May 2, 2024 at 5:52 PM Ilya Maximets > wrote: > > On 4/26/24 18:54, Ihar Hrachyshka wrote: > > Remove the notion of cluster/leave --force since it was never > > implemented. Instead of these instructions,

Re: [ovs-dev] [PATCH v2] lib: Fix segfault for tunnel packet.

On Fri, May 3, 2024 at 6:22 AM Amit Prakash Shukla wrote: > > Add NULL check to UDP, TCP and SCTP checksum functions. This patch > also adds changes to populate inner_l3_ofs and inner_l4_ofs for the > tunneled packets received from ports other than vport which are > required by the protocol

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

Hi Simon, It seems that it[0] got archived, not sure how. I unticked the 'archived' box and it should again appear in the the list in OVS patchwork. Thanks for the review. Martin. [0] https://patchwork.ozlabs.org/project/openvswitch/patch/2024050043.357669-1-martin.kal...@canonical.com/ On

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

On 5/3/24 14:16, Simon Horman wrote: > On Wed, May 01, 2024 at 01:50:36PM +0100, Simon Horman wrote: >> On Wed, May 01, 2024 at 01:10:43PM +0200, Martin Kalcok wrote: >>> Help text for 'ovsdb-client dump' does not mention that it's capable >>> of dumping specific table's contents if user supplies

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

On Wed, May 01, 2024 at 01:50:36PM +0100, Simon Horman wrote: > On Wed, May 01, 2024 at 01:10:43PM +0200, Martin Kalcok wrote: > > Help text for 'ovsdb-client dump' does not mention that it's capable > > of dumping specific table's contents if user supplies table's name > > as a third positional

Re: [ovs-dev] [PATCH v2 1/2] test-conntrack: Add per zone benchmark tool.

On Wed, Apr 24, 2024 at 02:44:47PM +0200, Felix Huettner via dev wrote: > The current test-conntrack benchmark command runs with multiple threads > against a single conntrack zone. We now add a new benchmark-zones > command that allows us to check the performance between multiple zones. > > We in

Re: [ovs-dev] [PATCH v3] hash, jhash: Fix unaligned access to the hash remainder.

On Fri, May 03, 2024 at 07:44:13AM +0200, Ales Musil wrote: > Partially revert db5a101931c5, this was to avoid warning, however we > shouldn't use pointer to "uint32_t" when the data are potentially > unaligned [0]. Use pointer to "uint8_t" right from the start, this > requires us to use

Re: [ovs-dev] [PATCH] sparse: Add additional define for sparse on GCC >= 14.

On Thu, May 02, 2024 at 01:13:39PM +0200, Ales Musil wrote: > GCC 14 renamed one of the AVX512 defines to have only single > underscore instead of two [0]. Add the single underscore define to > keep compatibility with multiple GCC versions. > > [0] >

Re: [ovs-dev] [PATCH] Documentation: Update Pacemaker main page link.

On Wed, May 01, 2024 at 01:39:58PM +0200, Eelco Chaudron wrote: > > > On 1 May 2024, at 12:54, Simon Horman wrote: > > > Update link to pacemaker main page as the existing link is broken. > > Also, use HTTPS. > > > > Broken link flagged by make check-docs > > > > Signed-off-by: Simon Horman >

Re: [ovs-dev] [PATCH] utilities: Correct deletion reason in flow_reval_monitor.py.

On 5/2/24 12:11, Eelco Chaudron wrote: > The flow_reval_monitor.py script incorrectly reported the reasons for > FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped. > This patch rectifies the order. > > Fixes: 86b9e653ef22 ("revalidator: Add a USDT probe during flow deletion with

Re: [ovs-dev] [PATCH v2] lib: Fix segfault for tunnel packet.

On 5/3/24 12:21, Amit Prakash Shukla wrote: > Add NULL check to UDP, TCP and SCTP checksum functions. This patch > also adds changes to populate inner_l3_ofs and inner_l4_ofs for the > tunneled packets received from ports other than vport which are > required by the protocol specific checksum

[ovs-dev] [PATCH v2] lib: Fix segfault for tunnel packet.

Add NULL check to UDP, TCP and SCTP checksum functions. This patch also adds changes to populate inner_l3_ofs and inner_l4_ofs for the tunneled packets received from ports other than vport which are required by the protocol specific checksum function to parse the headers. Thread 22

Re: [ovs-dev] [PATCH net-next 6/8] net:openvswitch: add psample support

On 24 Apr 2024, at 15:50, Adrian Moreno wrote: > Add support for psample sampling via two new attributes to the > OVS_ACTION_ATTR_SAMPLE action. > > OVS_SAMPLE_ATTR_PSAMPLE_GROUP used to pass an integer psample group_id. > OVS_SAMPLE_ATTR_PSAMPLE_COOKIE used to pass a variable-length binary >

Re: [ovs-dev] [PATCH] ofproto-dpif-trace: Fix access to an out-of-scope stack memory.

On 3 May 2024, at 1:36, Ilya Maximets wrote: > While tracing NAT actions, pointer to the action may be stored in the > recirculation node for future reference. However, while translating > actions for the group bucket in xlate_group_bucket, the action list is > allocated temporarily on stack.

[ovs-dev] [PATCH] lib: Fix segfault for tunnel packet.

Add NULL check to UDP, TCP and SCTP checksum functions. This patch also adds changes to populate inner_l3_ofs and inner_l4_ofs for the tunneled packets received from ports other than vport which are required by the protocol specific checksum function to parse the headers. Signed-off-by: Amit

Re: [ovs-dev] [PATCH v3] hash, jhash: Fix unaligned access to the hash remainder.

On 3 May 2024, at 7:44, Ales Musil wrote: > Partially revert db5a101931c5, this was to avoid warning, however we > shouldn't use pointer to "uint32_t" when the data are potentially > unaligned [0]. Use pointer to "uint8_t" right from the start, this > requires us to use ALIGNED_CAST for the

[ovs-dev] [PATCH ovn v5 1/2] northd: Make `vxlan_mode` a global variable.

This simplifies code and subsequent commit to explicitely disable VXLAN mode is based on these changes. Also "VXLAN mode" term is introduced in ovn-architecture man page. Signed-off-by: Vladislav Odintsov --- northd/en-global-config.c | 4 +- northd/northd.c | 85

[ovs-dev] [PATCH ovn v5 2/2] northd: Add support for disabling vxlan mode.

Commit [1] introduced a "VXLAN mode" concept. It brought a limitation for available tunnel IDs because of lack of space in VXLAN VNI. In VXLAN mode OVN is limited by 4095 datapaths (LRs or non-transit LSs) and 2047 logical ports per datapath. Prior to this patch VXLAN mode was enabled

[ovs-dev] [PATCH ovn v5 0/2] Add support to disable VXLAN mode.

v5: - Addressed Ihar's review comments: 1. fixed errors after incorrect conflicts solving on rebase; 2. changed VXLAN mode naming to capitalized; 3. clarified VXLAN mode in ovn-architecture man page. v4: - Addressed Dumitru's and Ihar's review comments; - single patch was split

Re: [ovs-dev] [PATCH ovn 2/3] nb: Add support for match and priority in NAT.

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 408 characters long (recommended limit is 79) #374 FILE:

Re: [ovs-dev] [PATCH] utilities: Correct deletion reason in flow_reval_monitor.py.

On 5/2/24 12:11 PM, Eelco Chaudron wrote: The flow_reval_monitor.py script incorrectly reported the reasons for FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped. This patch rectifies the order. Fixes: 86b9e653ef22 ("revalidator: Add a USDT probe during flow deletion with

Re: [ovs-dev] [PATCH] ofproto-dpif-trace: Fix access to an out-of-scope stack memory.

On 5/3/24 1:36 AM, Ilya Maximets wrote: While tracing NAT actions, pointer to the action may be stored in the recirculation node for future reference. However, while translating actions for the group bucket in xlate_group_bucket, the action list is allocated temporarily on stack. So, in

[ovs-dev] [PATCH ovn 3/3] northd: Use the NAT match column.

Use the newly added NAT match and priority column in logical flows. This allows to differentiate between various scenarios and more fine-grained control over the resulting translation. The flows with the extra match have higher priority than regular flows as the flows without match are subset of

[ovs-dev] [PATCH ovn 2/3] nb: Add support for match and priority in NAT.

Add support for match and priority in NAT table. This allows to define NAT that has extra match condition to have more fine-grained control over the final NAT rule application. At the same time it allows for NAT rules that would be considered as duplicates otherwise e.g. multiple SNATs with same

[ovs-dev] [PATCH ovn 1/3] nothd: Unify the priority calculation for NAT flows.

The priority calculation was scattered in multiple places which could result in errors when the code is being updated. Move it to common function that makes it very clear how is the priority calculated. Signed-off-by: Ales Musil --- northd/northd.c | 82

[ovs-dev] [PATCH ovn 0/3] Arbitrary match for NAT

This series adds the ability to have extra match per NAT, this allows the CMS to have more fine-grained control over the NAT action. At the same time it allows to have "duplicate" NATs e.g. multiple SNATs for the same logical_ip as well as multiple DNATs for the same external_ip. There is also

Re: [ovs-dev] [PATCH ovn] northd, ic: Fix handling of ovn-appctl resume.

On Tue, Apr 23, 2024 at 2:44 PM Xavier Simonart wrote: > After ovn-appctl resume was issued for northd or ovn-ic, there was no > guarantee that northd or ovn-ic were waking up, potentially handling > changes received while they were paused.. > Usually, poll_block would be woken up by POLLHUP,

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Support for --config-file ovsdb-server option.

On Tue, Apr 23, 2024 at 6:43 PM Vladislav Odintsov wrote: > Since OVS 3.3.0 ovsdb-server accepts databases and remotes configuration > via JSON text file. This patch adds support for such option. > > Signed-off-by: Vladislav Odintsov > --- > NEWS | 1 + > utilities/ovn-ctl | 39