e original VIF.
Note that those flows is still needed as userspace datapath is not
capable of PMTUD yet.
Reported-at: https://issues.redhat.com/browse/FDP-620
Signed-off-by: Ales Musil
---
v2: Rebase on top of latest main.
Fix the typo in the test and add note into the commit message.
---
Add note into TODO that we should use PMTUD when it is supported
by all datapaths.
Signed-off-by: Ales Musil
---
TODO.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/TODO.rst b/TODO.rst
index 17d539ad6..ac4202f36 100644
--- a/TODO.rst
+++ b/TODO.rst
@@ -130,3 +130,6 @@ OVN To-do List
same time add support for ct_next in SNAT zone as ct_next
was assuming that the zone is always DNAT.
Fixes: 40136a2f2c84 ("northd: Fix direct access to SNAT network.")
Reported-at: https://issues.redhat.com/browse/FDP-744
Signed-off-by: Ales Musil
---
controller/chassis.c | 8 ++
On Wed, Aug 21, 2024 at 10:55 AM Ales Musil wrote:
> In order to get the direct SNAT access working we need to commit new
> connections so the reply is not marked as invalid. The CT state to
> determine if the connection should be committed was populated by
> ct_snat action, however
if_status_mgr took 4ms
Fixes: cdd8dea88b3d ("Track interface MTU in if-status-mgr")
Fixes: 7084cf437421 ("Always funnel multichassis port traffic through tunnels")
Co-authored-by: Ilya Maximets
Signed-off-by: Ilya Maximets
Signed-off-by: Ales Musil
---
controller/o
same time add support for ct_next in SNAT zone as ct_next
was assuming that the zone is always DNAT.
Fixes: 40136a2f2c84 ("northd: Fix direct access to SNAT network.")
Reported-at: https://issues.redhat.com/browse/FDP-744
Signed-off-by: Ales Musil
---
v2: Make sure we don't SN
ded to the cleanup script.
Fixes: d15b12da6fe6 ("northd: Add ACL Sampling.")
Signed-off-by: Ales Musil
---
tests/system-ovn.at | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 0831a2108..78020ecda 100644
--
iginal commit is applied to 24.03 onwards, so I will make sure it
gets
backported there. AFAIK 23.09 doesn't have this issue, not sure if anyone
tested
23.06 and 23.03.
>
> -Brian
>
> [0] https://review.opendev.org/c/openstack/neutron/+/926495
>
> On 8/27/24 4:52 AM, Al
The ICMPv6 code was set to 1 which is wrong for the packet too big
which is wrong, the code should always remain 0. This resulted in
wrong csum being computed. Set the code to 0 explicitly.
Reported-at: https://issues.redhat.com/browse/FDP-763
Signed-off-by: Ales Musil
---
controller/pinctrl.c
-at: https://issues.redhat.com/browse/FDP-763
Acked-by: Dumitru Ceara
Signed-off-by: Ales Musil
---
v2: Add missing dot for the subject.
Add missing fixes tag.
---
controller/pinctrl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/controller/pinctrl.c b/controller/pinctrl.c
index 7cbb0cf81.
On Thu, Aug 29, 2024 at 5:09 PM Dumitru Ceara wrote:
> Hi Ales,
>
> Nit: missing . at the end of the subject.
>
> On 8/29/24 17:00, Ales Musil wrote:
> > The ICMPv6 code was set to 1 which is wrong for the packet too big
> > which is wrong, the code should always
The MTU with SNAT test was overly complicated, simplify
it using ping to achieve the same result with more robust
checks. Also add IPv6 to make sure both protocols are covered.
Signed-off-by: Ales Musil
---
tests/system-ovn-kmod.at | 98 ++--
1 file changed
sist
> the
> +# same zone throughout.
> +
> +check ovs-vsctl set Open_vSwitch .
> external_ids:reserve_ct_zones=ls0-req-hv5
> +check ovn-nbctl lsp-add ls0 ls0-req-hv5
> +check ovs-vsctl -- add-port br-int hv5-vif5 -- \
> +set interface hv5-vif5 external-ids:iface-id=ls0-req-hv5
> +ct_zones=$(ovn-appctl -t ovn-controller ct-zone-list)
> +echo "$ct_zones"
> +req_port5_zone=$(get_zone_num "$ct_zones" ls0-req-hv5)
> +
> +check ovs-vsctl remove interface hv5-vif5 external_ids iface-id
> +echo "$ct_zones"
> +req_port5_zone_new=$(get_zone_num "$ct_zones" ls0-req-hv5)
> +
> +check test "req_port5_zone" -eq "req_port5_zone_new"
>
> OVS_WAIT_UNTIL([check_ovsdb_zone ls0-hv1 $port1_zone])
> OVS_WAIT_UNTIL([check_ovsdb_zone ls0-hv2 $port2_zone])
> OVS_WAIT_UNTIL([check_ovsdb_zone lr0_snat $snat_zone])
> +OVS_WAIT_UNTIL([check_ovsdb_zone ls0-req-hv3 $req_port3_zone])
>
> # Now create a conflict in the OVSDB and restart ovn-controller.
>
> --
> 2.22.3
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Thanks,
Ales
--
Ales Musil
Senior Software Engineer - OVN Core
Red Hat EMEA <https://www.redhat.com>
amu...@redhat.com
<https://red.ht/sig>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
poll_block() returns
right away without any further waiting.
Reported-at: https://issues.redhat.com/browse/FDP-753
Signed-off-by: Ales Musil
---
controller/ovn-controller.c | 1 +
northd/ovn-northd.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/controller/ovn-controller.c b
$ct_zones" ls0-req-hv4)
> +
> +check test "$req_port3_zone_new" -eq "$req_port3_zone_after_delete"
> +check test "$req_port4_zone_after_delete" == ""
> +
> +# Checks for case when a ct-zone is reserved it comes up on that chassis,
>
port3_zone_after_delete"
> +check test "$req_port4_zone_after_delete" == ""
> +
> +# Checks for case when a ct-zone is reserved it comes up on that chassis,
> and
> +# gets deleted, but its persisted in ovs_vswitch table, it should persist
> the
eq_port4_zone_after_delete" == ""
> +
> +# Checks for case when a ct-zone is reserved it comes up on that chassis,
> and
> +# gets deleted, but its persisted in ovs_vswitch table, it should persist
> the
> +# same zone throughout.
> +
> +check ovs-vsctl
tions.
Signed-off-by: Ales Musil
---
controller/physical.c | 14 ++--
controller/pinctrl.c | 181 +-
include/ovn/actions.h | 16
lib/actions.c | 44 +++---
tests/ovn.at | 10 +--
5 files changed, 152 insertions(+), 113 dele
On Tue, Dec 12, 2023 at 4:22 PM Ales Musil wrote:
> The fields that are not directly supported by OvS were encoded
> via additional controller action that changed the required value.
> This was most notably needed for ICMP need frag messages.
>
> Encode the field value loads
On Wed, Dec 6, 2023 at 11:19 AM Ales Musil wrote:
> The ICMP need frag could be generated after routing
> stage when the unSNAT already happened. Add flows
> that will ensure that we are keeping track of the CT
> state and do appropriate CT nat action later on.
>
> Because t
tions.
Signed-off-by: Ales Musil
---
v2: Fix the wrong checksum for the ICMP packet.
---
controller/physical.c | 14 ++--
controller/pinctrl.c | 183 +-
include/ovn/actions.h | 16
lib/actions.c | 44 +++---
tests/ovn.at | 10 +
uot;name"]]},
> "Gateway": {
> diff --git a/ovn-ic-sb.xml b/ovn-ic-sb.xml
> index f7e17e113..c3e7d2173 100644
> --- a/ovn-ic-sb.xml
> +++ b/ovn-ic-sb.xml
> @@ -69,6 +69,21 @@
>one row.
>
>
> +
> + This column allow a client to track the o
}
> +ovsdb_idl_wait(idl);
> +poll_block();
> +}
> +done: ;
>
This done label is strange, there goto done outside of this if block, we
could avoid the whole goto if we moved the logic above to a separate
function. In that funct
Fix a couple of small memory leaks that were reported by coverity
static analysis on ovn rpm package.
Signed-off-by: Ales Musil
---
controller-vtep/ovn-controller-vtep.c | 2 ++
controller/lflow.c| 1 +
controller/ovn-controller.c | 1 +
controller/pinctrl.c
On Thu, Jan 4, 2024 at 12:34 PM Dumitru Ceara wrote:
> On 1/3/24 13:32, Ales Musil wrote:
> > Fix a couple of small memory leaks that were reported by coverity
> > static analysis on ovn rpm package.
> >
> > Signed-off-by: Ales Musil
> > ---
>
> Thanks for
Fix a couple of small memory leaks that were reported by coverity
static analysis on ovn rpm package.
Signed-off-by: Ales Musil
---
v2: Rebase on top of current main.
Address comment from Dumitru:
- Update the pinctrl_handle_empty_lb_backends_opts() to have
only single point of
sizeof *hrl->row_locks * (lflows->mask
> + 1));
> hrl->mask = lflows->mask;
> for (i = 0; i <= lflows->mask; i++) {
> ovs_mutex_init(&hrl->row_locks[i]);
> diff --git a/northd/ipam.c b/northd/ipam.c
>
ct_commit_nat
that will perform this action in SNAT zone.
Ales Musil (2):
actions: Adjust the ct_commit_nat action
northd: Explicitly handle SNAT for ICMP need frag
controller/chassis.c | 8 ++
include/ovn/actions.h| 12 ++-
include/ovn/features.h | 1 +
include/ovn
the ct_commit_nat
without any arguments is the same as ct_commit_nat(dnat).
Signed-off-by: Ales Musil
---
v2: Rebase on top of current main.
Address comment from Dumitru:
- Make the ct_commit_nat to accept only snat/dnat parameter.
---
include/ovn/actions.h | 12 ++--
lib/actions.c
there is an update of northd to newer version before all
controllers are updated.
Fixes: 0e49f49c73d6 ("northd: Allow need frag to be SNATed")
Reported-at: https://issues.redhat.com/browse/FDP-134
Reported-at: https://issues.redhat.com/browse/FDP-159
Signed-off-by: Ales Musil
Acked-by: Dum
the daemon right away by calling show command. At the same time
ensure that there is only 1 mismatch after the whole process.
Signed-off-by: Ales Musil
---
tests/ovn-nbctl.at | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/ovn-nbctl.at b/tests/ovn-nbctl.at
index 2d74e9cc6
. For comparison, the test was failing
on ARM in ~1/5 of runs. After this change there wasn't single failure
in a loop with 100 runs.
Signed-off-by: Ales Musil
---
tests/system-ovn.at | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/system-ovn.at b/tests/s
b_idl) &&
> ovsdb_idl_has_ever_connected(ctx.ovnisb_idl)) {
> -ovn_db_run(&ctx);
> +const struct icsbrec_availability_zone *az = az_run(&ctx);
> +VLOG_DBG("Availability zone: %s", az ? az->name :
>
s]; c++) {
> if (c->syntax->postprocess) {
> @@ -884,6 +961,11 @@ do_ic_nbctl(const char *args, struct ctl_command
> *commands, size_t n_commands,
> shash_destroy_free_data(&c->options);
> }
> free(commands);
> +
1])
+OVS_WAIT_UNTIL([test $(ovn-ic-nbctl get ic_nb_global . nb_ic_cfg) -eq
$(ovn-ic-nbctl get ic_nb_global . sb_ic_cfg)])
+AT_CHECK([ovn-ic-nbctl get ic_nb_global . nb_ic_cfg], [0], [dnl
+1
+])
+AT_CHECK([ovn-ic-nbctl get ic_nb_global . sb_ic_cfg], [0], [dnl
+1
+])
OVN_CLEANUP_IC([az1])
AT_CLEANUP
-
> 9 files changed, 329 insertions(+), 12 deletions(-)
>
> --
> 2.34.3
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Hi Mohammad,
thank you for the series. This suggest
; +--private-key=$PKIDIR/testpki-test-privkey.pem \
> +--certificate=$PKIDIR/testpki-test-cert.pem \
> +--ca-cert=$PKIDIR/testpki-cacert.pem \
> +--ssl-ciphers='HIGH:!aNULL:!MD5:@SECLEVEL=1' \
> +
nline.
>
>
> Ali
>
> On Fri, Jan 12, 2024 at 8:11 AM aginwala wrote:
>
>> Thanks for review.
>>
>> On Fri, Jan 12, 2024 at 2:08 AM Ales Musil wrote:
>>
>>> On Thu, Jan 11, 2024 at 2:30 PM wrote:
>>>
>>> > From: Aliasgar
], [ignore])
> +AT_CHECK([ovn-sbctl --db=ssl:127.0.0.1:$TCP_PORT \
> +--private-key=$PKIDIR/testpki-test-privkey.pem \
> +--certificate=$PKIDIR/testpki-test-cert.pem \
> + --ca-cert=$PKIDIR/testpki-cacert.pem \
> +--ssl-ciphers='HIGH:!a
Replace and remove the ovn_smap_get_uint as smap_get_uint is avaiable in OvS
library since 7b2e999fd759 ("smap: Add smap_get_uint() helper function.").
Signed-off-by: Ales Musil
---
lib/ovn-util.c | 20
lib/ovn-util.h | 4
northd/northd.c | 6 +++--
There is no need to hold data in separate bitmap and simap as all the
zones that are already assigned are in the inc-engine sctructures.
Signed-off-by: Ales Musil
---
controller/ovn-controller.c | 22 +-
1 file changed, 5 insertions(+), 17 deletions(-)
diff --git a
n the check instead of source.
Fixes: 5e0cb03605ea ("northd: Add logical flow to skip GARP with LLA")
Reported-at: https://issues.redhat.com/browse/FDP-283
Signed-off-by: Ales Musil
---
northd/northd.c | 4 ++--
tests/ovn.at| 25 ++---
2 files changed, 24 insertions(
ac", "datapath", "timestamp"};
> >
> > diff --git a/ovn-sb.ovsschema b/ovn-sb.ovsschema
> > index 72e230b75..9cf91c8f7 100644
> > --- a/ovn-sb.ovsschema
> > +++ b/ovn-sb.ovsschema
> > @@ -1,7 +1,7 @@
> > {
> > "name": "OVN_Southbound",
&g
encodes as
> ct(commit,table=19,zone=NXM_NX_REG11[0..15],nat(src=192.168.1.2:1-3000))
> + encodes as
> ct(commit,table=19,zone=NXM_NX_REG11[0..15],nat(src=192.168.1.2:1
> -3000,random))
> has prereqs ip
>
> ct_snat_in_czone(192.168.1.2, 192.168.1.3);
> --
> 2.
> = xmalloc(sizeof *br_int->ports * br_int->n_ports);
> size_t n = 0;
> for (size_t i = 0; i < br_int->n_ports; i++) {
> -if (!smap_get(&br_int->ports[i]->external_ids, "ovn-chassis-id"))
> {
> +if (!smap_get(&br_int->ports[i]->external_ids, OVN_TUNNEL_ID)) {
> ports[n++] = br_int->ports[i];
> }
> }
> diff --git a/controller/ovn-controller.8.xml
> b/controller/ovn-controller.8.xml
> index 735bc1221ab2..efa65e3fd927 100644
> --- a/controller/ovn-controller.8.xml
> +++ b/controller/ovn-controller.8.xml
> @@ -178,7 +178,8 @@
>
> The IP address that a chassis should use to connect to this node
> using encapsulation types specified by
> -external_ids:ovn-encap-type.
> +external_ids:ovn-encap-type. Multiple encapsulation
> IPs
> +may be specified with a comma-separated list.
>
>
>external_ids:ovn-encap-df_default
> --
> 2.38.1
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Looks good to me, thanks.
Acked-by: Ales Musil
--
Ales Musil
Senior Software Engineer - OVN Core
Red Hat EMEA <https://www.redhat.com>
amu...@redhat.com
<https://red.ht/sig>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
hv2/ovn-controller.log
>
> # Stop ovn-controller on hv1
> check as hv1 ovn-appctl -t ovn-controller exit --restart
>
> # The tunnel should remain intact
> -check_tunnel_port hv1 br-int1 hv2@192.168.0.2
> -prev_id=$(ovs-vsctl --bare --columns _uuid find port
> external_ids:ovn-chassis-id="hv2@192.168.0.2")
> +check_tunnel_port hv1 br-int1 hv2@192.168.0.2%192.168.0.1
> +prev_id=$(ovs-vsctl --bare --columns _uuid find port
> external_ids:ovn-chassis-id="hv2@192.168.0.2%192.168.0.1")
>
> # Start the controller again
> start_daemon ovn-controller --verbose="encaps:dbg"
> check ovn-nbctl --wait=hv sync
> -check_tunnel_port hv1 br-int1 hv2@192.168.0.2
> -current_id=$(ovs-vsctl --bare --columns _uuid find port
> external_ids:ovn-chassis-id="hv2@192.168.0.2")
> +check_tunnel_port hv1 br-int1 hv2@192.168.0.2%192.168.0.1
> +current_id=$(ovs-vsctl --bare --columns _uuid find port
> external_ids:ovn-chassis-id="hv2@192.168.0.2%192.168.0.1")
>
> # The tunnel should be the same after restart
> check test "$current_id" = "$prev_id"
> @@ -36276,10 +36324,10 @@ check_tunnel_port() {
> AT_CHECK([ovs-vsctl --bare --columns ports find bridge name="$br" |
> grep -q "$tunnel_id"])
> }
>
> -check_tunnel_port hv1 br-int hv2@192.168.0.2
> -check_tunnel_port hv1 br-int-2 hv1@192.168.0.1
> -prev_id1=$(ovs-vsctl --bare --columns _uuid find port
> external_ids:ovn-chassis-id="hv1@192.168.0.1")
> -prev_id2=$(ovs-vsctl --bare --columns _uuid find port
> external_ids:ovn-chassis-id="hv2@192.168.0.2")
> +check_tunnel_port hv1 br-int hv2@192.168.0.2%192.168.0.1
> +check_tunnel_port hv1 br-int-2 hv1@192.168.0.1%192.168.0.2
> +prev_id1=$(ovs-vsctl --bare --columns _uuid find port
> external_ids:ovn-chassis-id="hv1@192.168.0.1%192.168.0.2")
> +prev_id2=$(ovs-vsctl --bare --columns _uuid find port
> external_ids:ovn-chassis-id="hv2@192.168.0.2%192.168.0.1")
>
> # The hv2 is running we can remove the override file
> rm -f ${OVN_SYSCONFDIR}/system-id-override
> @@ -36300,13 +36348,13 @@ start_daemon ovn-controller
> --verbose="encaps:dbg" \
>
> check ovn-nbctl --wait=hv sync
>
> -check_tunnel_port hv1 br-int hv2@192.168.0.2
> -check_tunnel_port hv1 br-int-2 hv1@192.168.0.1
> -current_id1=$(ovs-vsctl --bare --columns _uuid find port
> external_ids:ovn-chassis-id="hv1@192.168.0.1")
> -current_id2=$(ovs-vsctl --bare --columns _uuid find port
> external_ids:ovn-chassis-id="hv2@192.168.0.2")
> +check_tunnel_port hv1 br-int hv2@192.168.0.2%192.168.0.1
> +check_tunnel_port hv1 br-int-2 hv1@192.168.0.1%192.168.0.2
> +current_id1=$(ovs-vsctl --bare --columns _uuid find port
> external_ids:ovn-chassis-id="hv1@192.168.0.1%192.168.0.2")
> +current_id2=$(ovs-vsctl --bare --columns _uuid find port
> external_ids:ovn-chassis-id="hv2@192.168.0.2%192.168.0.1")
>
> # Check that restart of hv1 ovn-controller did not interfere with hv2
> -AT_CHECK([grep -q "Clearing old tunnel port \"ovn0-hv1-0\" (
> hv1@192.168.0.1) from bridge \"br-int-2\"" hv1/ovn-controller.log], [1])
> +AT_CHECK([grep -q "Clearing old tunnel port \"ovn0-hv1-0\" (
> hv1@192.168.0.1%192.168.0.2) from bridge \"br-int-2\""
> hv1/ovn-controller.log], [1])
> check test "$current_id1" = "$prev_id1"
> check test "$current_id2" = "$prev_id2"
>
> --
> 2.38.1
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Looks good to me, thanks.
Acked-by: Ales Musil
--
Ales Musil
Senior Software Engineer - OVN Core
Red Hat EMEA <https://www.redhat.com>
amu...@redhat.com
<https://red.ht/sig>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
EACH_NORTHD([
> -AT_SETUP([multiple encap ips tunnel creation])
> +AT_SETUP([multiple encap ips selection based on VIF's encap_ip])
> +AT_SKIP_IF([test $HAVE_SCAPY = no])
> ovn_start
> net_add n1
>
> +ovn-nbctl ls-add ls1
> +
> # 2 HVs, each with 2 encap-ips.
> +#
y on new actions for lb affinity")
Reported-at: https://issues.redhat.com/browse/FDP-290
Signed-off-by: Ales Musil
---
northd/northd.c | 14 +++-
tests/ofproto-macros.at | 4 ++--
tests/ovn-northd.at | 48 +++-
tests/system-ovn-kmod
d the test
> cases change as a separate patch, what do you think?
>
Separate series/patch is completely fine once this series is accepted.
Thanks,
Ales
>
> On Fri, Jan 12, 2024 at 11:14 AM Ales Musil wrote:
>
>>
>>
>> On Tue, Jan 9, 2024 at 2:29 PM Mohammad Heib
_idl_has_ever_connected(ctx.ovninb_idl) &&
> ovsdb_idl_has_ever_connected(ctx.ovnisb_idl)) {
> -ovn_db_run(&ctx);
> +const struct icsbrec_availability_zone *az = az_run(&ctx);
> +VLOG_DBG("Availability zone: %s", az ? az->name
l
> +1
> +])
> +
> +OVN_CLEANUP_IC([az1])
> +AT_CLEANUP
> +])
> --
> 2.34.3
>
> _______
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Looks good to me, t
t in the end the number of OpenFlows will remain the same.
Signed-off-by: Ales Musil
---
northd/northd.c | 75 +++--
1 file changed, 4 insertions(+), 71 deletions(-)
diff --git a/northd/northd.c b/northd/northd.c
index b8d738a42..da6d88d48 100644
---
On Fri, Jan 26, 2024 at 4:07 AM Han Zhou wrote:
>
>
> On Tue, Jan 23, 2024 at 5:29 AM Ales Musil wrote:
> >
> >
> >
> > On Wed, Jan 17, 2024 at 6:48 AM Han Zhou wrote:
> >>
> >> Commit dd527a283cd8 partially supported multiple encap IPs. It su
the ct_commit_nat
without any arguments is the same as ct_commit_nat(dnat).
Signed-off-by: Ales Musil
---
v3: Rebase on top of current main.
v2: Rebase on top of current main.
Address comment from Dumitru:
- Make the ct_commit_nat to accept only snat/dnat parameter.
---
include/ovn
ct_commit_nat
that will perform this action in SNAT zone.
Ales Musil (2):
actions: Adjust the ct_commit_nat action.
northd: Explicitly handle SNAT for ICMP need frag.
controller/chassis.c | 8 ++
include/ovn/actions.h| 12 ++-
include/ovn/features.h | 1 +
include
there is an update of northd to newer version before all
controllers are updated.
Fixes: 0e49f49c73d6 ("northd: Allow need frag to be SNATed")
Reported-at: https://issues.redhat.com/browse/FDP-134
Reported-at: https://issues.redhat.com/browse/FDP-159
Signed-off-by: Ales Musil
Acked-by:
On Fri, Jan 26, 2024 at 8:05 PM Han Zhou wrote:
>
>
> On Thu, Jan 25, 2024 at 10:54 PM Ales Musil wrote:
> >
> >
> >
> > On Fri, Jan 26, 2024 at 4:07 AM Han Zhou wrote:
> >>
> >>
> >>
> >> On Tue, Jan 23, 2024 at 5:29 AM Ale
The Fedora version of grep (grep (GNU grep) 3.11) complains
about the syntax grep "output\:": grep: warning: stray \ before :
Remove the \ which works also for Ubuntu grep version
(grep (GNU grep) 3.7).
Signed-off-by: Ales Musil
---
tests/ovn.at | 2 +-
1 file changed, 1 inser
On Tue, Jan 30, 2024 at 8:58 AM Ales Musil wrote:
> The Fedora version of grep (grep (GNU grep) 3.11) complains
> about the syntax grep "output\:": grep: warning: stray \ before :
>
> Remove the \ which works also for Ubuntu grep version
> (grep (GNU grep) 3.7).
>
>
-E "resubmit\(,[0-9]+\)" tests/*.at | wc -l
152
There are still some tests that use the direct number, those
are tests that reference the logical pipeline through OpenFlows.
Solution for those is not very straight forward and will be probably
addressed in future. Nevertheless the overall
Replace all usage of "sed 's/table=./table=?/' | sort"
with ovn_strip_lflows and adjust all table=? to be table=??.
Signed-off-by: Ales Musil
---
tests/ovn-northd.at | 564 ++--
1 file changed, 281 insertions(+), 283 deletions(-)
di
Add macro for OFTABLE_LOG_INGRESS_PIPELINE and replace all table=8
occurrences in OF with table=OFTABLE_LOG_INGRESS_PIPELINE.
Signed-off-by: Ales Musil
---
tests/ovn-controller-vtep.at | 4 ++--
tests/ovn-macros.at | 1 +
tests/ovn.at | 2 +-
3 files changed, 4
Replace all usage of "sort | sed 's/table=./table=?/'" or
'sort | sed 's/table=../table=??/' with ovn_strip_lflows.
Adjust all table=? to table=?? and re-sort the expected flows.
Signed-off-by: Ales Musil
---
tests/ovn-northd.at | 260 ++-
Add macro for OFTABLE_PHY_TO_LOG and replace all table=0
occurrences in OF with table=OFTABLE_PHY_TO_LOG.
Signed-off-by: Ales Musil
---
tests/ovn-controller-vtep.at | 10 ++---
tests/ovn-controller.at | 6 +--
tests/ovn-macros.at | 2 +
tests/ovn.at | 72
Add macro for OFTABLE_REMOTE_OUTPUT and replace all table=39
occurrences in OF with table=OFTABLE_REMOTE_OUTPUT.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 40
2 files changed, 21 insertions(+), 20 deletions(-)
diff
Add macro for OFTABLE_OUTPUT_LARGE_PKT_DETECT and replace all table=37
occurrences in OF with table=OFTABLE_OUTPUT_LARGE_PKT_DETECT.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 14 +++---
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a
Add macro for OFTABLE_LOG_TO_PHY and replace all table=65
occurrences in OF with table=OFTABLE_LOG_TO_PHY.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 28 ++--
2 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/tests/ovn
Add macro for OFTABLE_LOCAL_OUTPUT and replace all table=40
occurrences in OF with table=OFTABLE_LOCAL_OUTPUT.
Signed-off-by: Ales Musil
---
tests/ovn-controller.at | 6 +++---
tests/ovn-macros.at | 1 +
tests/ovn.at| 24
3 files changed, 16 insertions
Add macro for OFTABLE_MAC_LOOKUP and replace all table=67
occurrences in OF with table=OFTABLE_MAC_LOOKUP.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 26 +-
2 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/tests/ovn
Add macro for OFTABLE_CHK_LB_HAIRPIN and replace all table=68
occurrences in OF with table=OFTABLE_CHK_LB_HAIRPIN.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 316 ++--
2 files changed, 159 insertions(+), 158 deletions
Add macro for OFTABLE_CHK_OUT_PORT_SEC and replace all table=75
occurrences in OF with table=OFTABLE_CHK_OUT_PORT_SEC.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 121 ++--
2 files changed, 62 insertions(+), 60
Add macro for OFTABLE_MAC_BINDING and replace all table=66
occurrences in OF with table=OFTABLE_MAC_BINDING.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 12 ++--
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/tests/ovn-macros.at b
Replace all usage of "sed 's/table=./table=?/'" or
"sed 's/table=../table=??/' with ovn_strip_lflows.
Adjust all table=? to table=?? and re-sort the expected flows.
Signed-off-by: Ales Musil
---
tests/ovn-northd.at | 183 ++--
Add macro for OFTABLE_LOOKUP_FDB and replace all table=72
occurrences in OF with table=OFTABLE_LOOKUP_FDB.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 18 +-
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/tests/ovn-macros.at b
Add macro for OFTABLE_CHK_LB_HAIRPIN_REPLY and replace all table=69
occurrences in OF with table=OFTABLE_CHK_LB_HAIRPIN_REPLY.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 404 ++--
2 files changed, 203 insertions
Add macro for OFTABLE_CT_SNAT_HAIRPIN and replace all table=70
occurrences in OF with table=OFTABLE_CT_SNAT_HAIRPIN.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 206 ++--
2 files changed, 104 insertions(+), 103
Add macro for OFTABLE_CHK_IN_PORT_SEC_ND and replace all table=74
occurrences in OF with table=OFTABLE_CHK_IN_PORT_SEC_ND.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 151 ++--
2 files changed, 77 insertions(+), 75
Add macro for OFTABLE_GET_FDB and replace all table=71
occurrences in OF with table=OFTABLE_GET_FDB.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 16
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/tests/ovn-macros.at b/tests
Add macro for OFTABLE_CHK_IN_PORT_SEC and replace all table=73
occurrences in OF with table=OFTABLE_CHK_IN_PORT_SEC.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 112 ++--
2 files changed, 58 insertions(+), 55 deletions
Add macro for OFTABLE_ECMP_NH_MAC and replace all table=76
occurrences in OF with table=OFTABLE_ECMP_NH_MAC.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/system-ovn.at | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/ovn-macros.at b/tests/ovn
Add macro for OFTABLE_ECMP_NH and replace all table=77
occurrences in OF with table=OFTABLE_ECMP_NH.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/system-ovn.at | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at
Add macro for OFTABLE_CHK_LB_AFFINITY and replace all table=78
occurrences in OF with table=OFTABLE_CHK_LB_AFFINITY.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/system-ovn-kmod.at | 16
tests/system-ovn.at | 6 +++---
3 files changed, 12
To avoid issues with hardcoded table numbers in future add rule
into check patch. The rule is only warning because there are still
legitimate use cases and not everything can be abstracted.
Signed-off-by: Ales Musil
---
utilities/checkpatch.py | 12
1 file changed, 12 insertions
Add macro for OFTABLE_MAC_CACHE_USE and replace all table=79
occurrences in OF with table=OFTABLE_MAC_CACHE_USE.
Signed-off-by: Ales Musil
---
tests/ovn-macros.at | 1 +
tests/ovn.at| 12 ++--
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/tests/ovn-macros.at b
ned.
>
> Hopefully this makes sense.
>
Hi Mark,
yes this makes sense, I didn't consider the scenario of two datapaths
requesting the same SNAT zone. I'll mark this patch as deferred.
Thanks,
Ales
>
> On 1/18/24 03:07, Ales Musil wrote:
> > There is no need to hold d
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Looks good to me, thanks.
Acked-by: Ales Musil
--
Ales Musil
Senior Software Engineer - OVN Core
Red Hat EMEA <https://www.redhat.com>
amu...@redhat.com
<https://red.ht/sig>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
kout@v3
> + uses: actions/checkout@v4
> # Weekly runs test using the tip of the most recent stable OVS branch
> # instead of the submodule.
> - name: checkout OVS
>if: github.event_name == 'schedule'
> - uses: actions/checkout@v3
> +
; +AT_CLEANUP
> +])
> --
> 2.25.1
>
>
> --
>
>
>
>
> _'Esta mensagem é direcionada apenas para os endereços constantes no
> cabeçalho inicial. Se você não está listado nos endereços constantes no
> cabeçalho, pedimos-lhe que desconsidere completamente o
omputes of northd engine node
> # 1. missing handler for input NB_logical_router
> # 2. missing handler for input SB_ha_chassis_group
> --
> 2.43.0
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswi
ests/ovn.at b/tests/ovn.at
> index 28c6b6c34..c4e67e4f5 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
> @@ -22549,6 +22549,7 @@ send_igmp_v3_report hv2-vif1 hv2 00000002
> $(ip_to_hex 10 0 0 2) f9f9 \
>
> # Check that the IGMP Group is learned on both hv.
> wait_row_count IGMP_Group 2 address=239.0.1.68
> +wait_row
put_vport_bindings();
> +flush_put_vport_bindings(false);
> }
>
> /* Called with in the pinctrl_handler thread context. */
> @@ -6658,7 +6703,8 @@ pinctrl_handle_bind_vport(
> vpb->dp_key = dp_key;
> vpb->vport_key = vport_key;
> vpb->vport_parent_key = vpor
On Fri, Feb 2, 2024 at 12:19 PM Ales Musil wrote:
>
>
> On Tue, Jan 30, 2024 at 2:59 PM Mohammad Heib wrote:
>
>> ovn-controller immediately removes the vport_bindings requests that were
>> generated by VIFs after handling them locally, this approach is intended
>>
"src_mac": {"type": "string"},
> "src_ip": {"type": "string"},
> +"chassis_name": {"type": "string"},
> "status": {
>
> "columns": {
> > @@ -493,7 +493,8 @@
> > "ports": {"type": {"key": {"type": "uuid",
> > "refTable": "Port_Bindi
"value": "string",
> - "min": 0, "max": "unlimited"}}},
> + "min": 0, "max": "unlimited"}},
> +"chassis_name": {"type": "string"}},
>
-
>
>
>
>
> _'Esta mensagem é direcionada apenas para os endereços constantes no
> cabeçalho inicial. Se você não está listado nos endereços constantes no
> cabeçalho, pedimos-lhe que desconsidere completamente o conteúdo dessa
> mensagem e cuja cópia, encaminhamento e/ou execução das ações c
two onto single flow. This also reduces the logical flows
per ECMP reply from 6 to 1.
Reported-at: https://issues.redhat.com/browse/FDP-358
Suggested-by: Dumitru Ceara
Signed-off-by: Ales Musil
---
v2: Rebase on top of current main.
Use the original idea to reduce the number of flows as fix for
On Mon, Feb 5, 2024 at 10:47 AM Ales Musil wrote:
> There are 3 flows for matching ECMP symmetric reply that are different
> in a single match part that is the protocol (udp/tcp/sctp) for ct.new
> traffic and additional 3 flows (udp/tcp/sctp) for ct.est && !ct.rpl.
>
&
tions.
Signed-off-by: Ales Musil
---
v3: Rebase on top of current main.
Fix some cosmetic stuff pointed out by Dumitru.
Add back the handler for old way to keep the ICMP
error working during upgrade.
v2: Fix the wrong checksum for the ICMP packet.
---
controller/physical.c
On Mon, Feb 5, 2024 at 11:03 PM Dumitru Ceara wrote:
> On 12/14/23 16:29, Ales Musil wrote:
> > The fields that are not directly supported by OvS were encoded
> > via additional controller action that changed the required value.
> > This was most notably needed for IC
101 - 200 of 1603 matches
Mail list logo
