dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
The whole series looks good to me, thanks!
Acked-by: Ales Musil
--
Ales Musil
Senior Software Engineer - OVN Core
Red Hat EMEA <https://www.redhat.com>
amu...@redhat.comIM
s://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
I would suggest the following diff to the test to fix the mentioned
problems:
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
index ad398da0c..fb6dc9c88 100644
--- a/tests/ovn-northd.at
+++ b/tests/ovn-northd.at
@@ -202,13 +202,10 @@ wait_row_count nb:Logical_Router_Port 1 name=lrp1
options:hosting-chassis=ch1
# Now remove the chassis from the port binding record and assert that the
# hosting-chassis option was removed by northd
-ovn-sbctl clear Port_Binding cr-lrp1 chassis
-
-sleep 1
+check ovn-sbctl clear Port_Binding cr-lrp1 chassis
+check ovn-nbctl --wait=sb sync
-AT_CHECK([ovn-sbctl get Port_Binding cr-lrp1 options:hosting-chassis],
-[1], [], [ovn-sbctl: no key "hosting-chassis" in Port_Binding record
"cr-lrp1" column options
-])
+wait_row_count nb:Logical_Router_Port 0 name=lrp1
options:hosting-chassis=ch1
AT_CLEANUP
])
Thanks,
Ales
--
Ales Musil
Senior Software Engineer - OVN Core
Red Hat EMEA <https://www.redhat.com>
amu...@redhat.comIM: amusil
<https://red.ht/sig>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
bound to ch1
> +ch1_uuid=`ovn-sbctl --bare --columns _uuid find Chassis name="ch1"`
> +check ovn-sbctl set Port_Binding cr-lrp1 chassis=${ch1_uuid}
> +
> +check ovn-nbctl --wait=sb sync
> +
> +# Check for the hosting-chassis option being set by northd
> +wait_row_count nb:Logical_Router_P
ious run time capped by the
config option.
Signed-off-by: Ales Musil
---
NEWS | 2 ++
northd/inc-proc-northd.c | 23 ++-
northd/inc-proc-northd.h | 3 ++-
northd/ovn-northd.c | 9 +++--
ovn-nb.xml | 7 +++
5 files changed, 40 ins
ding
anything like this is that northd will be fast enough to process I-P
changes and
be able to sleep between the next batch update arrives from CMS. That
doesn't
seem to happen in very near future, one thing to keep in mind is that
testing
happened with Numan's I-P for LBs and lflows
Add support for setting CT zone limit via ovs-vswitchd
database CT_Zone entry. The limit is propagated
into corresponding datapath. In order to keep
backward compatibility the dpctl/ct-set-limits command
can overwrite the database settings.
Signed-off-by: Ales Musil
---
ofproto/ofproto-dpif.c
ncreased from P99 4s to P994.1s.
Signed-off-by: Ales Musil
---
NEWS | 2 ++
northd/inc-proc-northd.c | 23 ++-
northd/inc-proc-northd.h | 3 ++-
northd/ovn-northd.c | 9 +++--
ovn-nb.xml | 9 +
5 files changed, 42 ins
ake it use gateway routers. Like that the
> behavior is known to be correct and we can, at least, ensure it won't be
> broken in the future.
>
> CC: Vladislav Odintsov
> CC: Ales Musil
> CC: Han Zhou
> Signed-off-by: Dumitru Ceara
> ---
> tests/ovn.at | 16
our chassis record).
>
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2023-July/406201.html
> Reported-by: Vladislav Odintsov
> CC: Ales Musil
> CC: Han Zhou
> Signed-off-by: Dumitru Ceara
> ---
> controller/ovn-controller.c | 40
> +++
The port group name consists of DP key and NB PG name.
Use first PG that is avaiable to avoid flakes when
neither of the logical switches has DP key 2.
Signed-off-by: Ales Musil
---
tests/ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
The test was assuming that the DP key and Port keys are
always fixed. Make sure that we use proper values for the
flow check.
Signed-off-by: Ales Musil
---
tests/ovn.at | 67 +++-
1 file changed, 35 insertions(+), 32 deletions(-)
diff --git a
Make sure the CT entries are sorted, otherwise the check
sometimes fails depending on the order from OvS.
Signed-off-by: Ales Musil
---
tests/system-ovn.at | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index
Add various missing sync calls which caused the
tests to be flaky due to sometimes missed on various
checks or packets.
Signed-off-by: Ales Musil
---
tests/ovn-controller.at | 10 +-
tests/ovn-ic.at | 7 ---
tests/ovn-northd.at | 14 +-
tests/ovn.at
;> On 8/10/23 17:20, Han Zhou wrote:
> >>>>> On Thu, Aug 10, 2023 at 6:36 AM Dumitru Ceara
> > wrote:
> >>>>>>
> >>>>>> On 8/10/23 15:34, Han Zhou wrote:
> >>>>>>> On Thu, Aug 10, 2023 at 2:29 AM Dumitru
On Mon, Aug 14, 2023 at 10:02 PM Mark Michelson wrote:
> Hi Ales, I have a couple of notes below.
>
> On 8/14/23 05:21, Ales Musil wrote:
> > Add various missing sync calls which caused the
> > tests to be flaky due to sometimes missed on various
> > checks or pac
The test was assuming that the DP key and Port keys are
always fixed. Make sure that we use proper values for the
flow check.
Signed-off-by: Ales Musil
Acked-by: Mark Michelson
---
v2: Add ack from Mark.
---
tests/ovn.at | 67 +++-
1 file changed
to INT32_MAX as we don't expect the nb_cfg
to be updated more than that during the sync call.
Signed-off-by: Ales Musil
---
northd/ovn-northd.c | 4 +++-
utilities/ovn-nbctl.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/northd/ovn-northd.c b/northd/ovn-northd
The port group name consists of DP key and NB PG name.
Use first PG that is avaiable to avoid flakes when
neither of the logical switches has DP key 2.
Signed-off-by: Ales Musil
Acked-by: Mark Michelson
---
v2: Add ack from Mark.
---
tests/ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2
Make sure the CT entries are sorted, otherwise the check
sometimes fails depending on the order from OvS.
Signed-off-by: Ales Musil
Acked-by: Mark Michelson
---
v2: Add ack from Mark.
---
tests/system-ovn.at | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a
Add various missing sync calls which caused the
tests to be flaky due to sometimes missed on various
checks or packets.
Signed-off-by: Ales Musil
---
v2: Address comments from Mark:
- Add fix for the nb_cfg overflow test.
---
tests/ovn-controller.at | 2 +-
tests/ovn-ic.at | 7
aggregate CPU 6066% avg / 7689% max
northd was around 60% for the second half of the test.
One thing to note is that the overall latency was slightly
increased from P99 4s to P994.1s.
Signed-off-by: Ales Musil
---
NEWS | 2 ++
northd/inc-proc-northd.c | 23 ++
On Tue, Aug 15, 2023 at 5:17 PM Dumitru Ceara wrote:
> On 8/15/23 17:01, Ales Musil wrote:
> > Add config option called "northd-backoff-interval-ms" that allows
> > to delay northd engine runs capped by the config option.
> > When the config option is set to 0 or u
logical switch
> @@ -9183,6 +9184,22 @@ sleep 2
> OVN_CHECK_PACKETS_CONTAIN([hv2/snoopvif-tx.pcap], [arp_expected])
> OVN_CHECK_PACKETS([hv1/snoopvif-tx.pcap], [empty_expected])
>
> +# Temporarily remove lr0 chassis
> +AT_CHECK([ovn-nbctl remove logical_router lr0 options chassis])
&
/clear-stats
> # Add a lsp. northd and lflow engine should recompute since this is
> # the first lsp added after the router ports.
> check ovn-nbctl --wait=hv lsp-add ls0 lsp0-1 -- lsp-set-addresses lsp0-1
> "aa:aa:aa:00:00:01 192.168.0.11"
> -check_recompute_counter 1 1
> +check_re
3 files changed, 25 insertions(+), 22 deletions(-)
>
> --
> 2.40.1
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
The whole series looks good to me, thanks.
Acked-by: Ales
ec_port_group_table,
> &data->port_groups);
> -sync_meters(ovnsb_txn, input_data->nbrec_meter_table,
> -input_data->nbrec_acl_table,
> input_data->sbrec_meter_table,
> -&data->meter_groups);
> sync_mi
mode 100644 northd/en-meters.c
> create mode 100644 northd/en-meters.h
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Looks good to me, thanks!
Acked-by: Ales Musil
--
be related to fixing tests.
>
Hi Mark,
it actually fixes the "overflow the nb_cfg value across the tables" test.
> On 8/15/23 07:04, Ales Musil wrote:
> > We are correctly wrapping nb_cfg over when the value is LLONG_MAX.
> > However, the sync code is expecting the
value(as, item);
> }
> +}
>
> -for (; sb_index < sb_n; sb_index++) {
> -sbrec_address_set_update_addresses_delvalue(sb_as,
> sb_arr[sb_index]);
> -}
> +static void
> +update_sb_addr_set(struct sorted_array *nb_addresses,
> + c
&data->ls_ports);
> build_lrouter_groups(&data->lr_ports, &data->lr_list);
> build_ip_mcast(ovnsb_txn, input_data->sbrec_ip_multicast_table,
> input_data->sbrec_ip_mcast_by_dp,
> @@ -17615,7 +17603,7 @@ ovnnb_db_run(struct no
&data->ls_ports);
> build_lrouter_groups(&data->lr_ports, &data->lr_list);
> build_ip_mcast(ovnsb_txn, input_data->sbrec_ip_multicast_table,
> input_data->sbrec_ip_mcast_by_dp,
> @@ -17602,8 +17430,9 @@ ovnnb_db_run(stru
rec_static_mac_binding_table
> @@ -50,7 +49,6 @@ struct northd_input {
> const struct sbrec_fdb_table *sbrec_fdb_table;
> const struct sbrec_load_balancer_table *sbrec_load_balancer_table;
> const struct sbrec_service_monitor_table *sbrec_service_monitor_table;
> -const st
"${sw1_key}_pg2"
> +check_column "sw2.2 sw2.3" sb:Port_Group ports name="${sw2_key}_pg2"
> +
> +dnl The northd node should not recompute, it should handle nb_global
> update
> +dnl though, therefore "compute: 1".
> +AT_CHECK([as north
}
> -
> fatal_signal_create_wakeup_events();
>
> #ifdef _WIN32
> --
> 2.40.1
>
>
Hi Frode,
I wonder why the test fails on the debug message? Nevertheless I don't mind
dropping it whatsoever.
Acked-by: Ales Mu
aggregate CPU 6066% avg / 7689% max
northd was around 60% for the second half of the test.
One thing to note is that the overall latency was slightly
increased from P99 4s to P99 4.1s.
Signed-off-by: Ales Musil
---
v4: Skip the northd engine delay if there is more changes accumulated in the
IDL lo
On Wed, Aug 2, 2023 at 11:40 AM Ales Musil wrote:
> The SCTP protocol ports were excluded from
> the netlink encoding. Which resulted in the
> lookup failure in kernel, leading to the entry
> not being flushed. Allow the flush of SCTP protocol
> based on port numbers.
>
ow that is bigger than allowed size is OVN
bug, and it should be fixed.
Reported-at: https://bugzilla.redhat.com/1955167
Signed-off-by: Ales Musil
---
controller/ofctrl.c | 74 -
1 file changed, 53 insertions(+), 21 deletions(-)
diff --git a/controller/
tions=conjunction(1,1/2), conjunction(1,1/2)
Make sure that we add only conjunctions that are not present
in the already existing flow.
Reported-at: https://bugzilla.redhat.com/2175928
Signed-off-by: Ales Musil
---
controller/ofctrl.c | 56 -
1 file ch
On Tue, Aug 29, 2023 at 10:42 AM Ales Musil wrote:
> If the flow size is bigger than UINT16_MAX it doesn't
> fit into openflow message. Programming of such flow will
> fail which results in disconnect of ofctrl. After reconnect
> we program everything from scratch, in case th
ow that is bigger than allowed size is OVN
bug, and it should be fixed.
Reported-at: https://bugzilla.redhat.com/1955167
Signed-off-by: Ales Musil
---
v2: Fix the formatting error.
---
controller/ofctrl.c | 40
1 file changed, 36 insertions(+), 4 deletion
tions=conjunction(1,1/2), conjunction(1,1/2)
Make sure that we add only conjunctions that are not present
in the already existing flow.
Reported-at: https://bugzilla.redhat.com/2175928
Signed-off-by: Ales Musil
---
controller/ofctrl.c | 56 -
1 file ch
able);
> void pinctrl_wait(struct ovsdb_idl_txn *ovnsb_idl_txn);
> void pinctrl_destroy(void);
> void pinctrl_set_br_int_name(const char *br_int_name);
> diff --git a/tests/ovn.at b/tests/ovn.at
> index 2cf5d5169..1c8f8a340 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.
ovn-northd.at
> +++ b/tests/ovn-northd.at
> @@ -9512,6 +9512,29 @@ AT_CHECK([ovn-sbctl lflow-list sw | grep ls_out_pre_lb
> | grep priority=110 | gre
> AT_CLEANUP
> ])
>
> +
> +# This test checks the compute/recompute stats of sync_to_sb_lb engine node
> +OVN_FOR_EACH_NORTHD_N
stage, new binary is added called ovn-debug. The new binary provides
command that will translate stage name into OpenFlow table number.
Only test that is still hardcoded is "action parsing", because
it compares the direct output from the test binary.
Ales Musil (4):
tests: Remove ha
There were some comments left with hardcoded numbers. Even if it
wouldn't break any test table shift/change it would just leave the
comment outdated.
Signed-off-by: Ales Musil
Acked-by: Mark Michelson
---
v5: Rebase on top of main.
v4: Rebase on top of main.
Align the northd.at comment
To avoid issues with hardcoded table numbers in future add rule
into check patch. The rule is only warning because there are still
legitimate use cases and not everything can be abstracted.
Signed-off-by: Ales Musil
Acked-by: Mark Michelson
---
v5: Rebase on top of main.
v4: Rebase on top of
tage-to-oftable STAGE_NAME" that converts stage name into
OpenFlow table id.
For now it will be used in tests to get rid remaining hardcoded table
numbers.
Signed-off-by: Ales Musil
Acked-by: Mark Michelson
---
v5: Rebase on top current main.
v4: Rebase on top current main.
Address nit fro
Use the ovn-debug commands to determine OpenFlow table numbers
based on stage name. With this there is no need to hardcode them
and it should be future proof for stage shifts/updates.
Signed-off-by: Ales Musil
Acked-by: Mark Michelson
---
v5: Rebase on top of main.
v4: Rebase on top of main
expect it to and avoid
checking kill of server that might be already finished.
[0] https://github.com/nmap/nmap/issues/1223
Signed-off-by: Ales Musil
---
v4: Rebase on top of current main.
---
tests/system-ovn-kmod.at | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a
erly
waits for the "listening" state, at the same time redirects
the stderr into separate file.
Signed-off-by: Ales Musil
---
v4: Rebase on top of current main.
v3: Rebase on top of current main.
v2: Rebase on top of current main.
Address comment from Dumitru and rework the tcp
______
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Looks good to me, thanks.
Acked-by: Ales Musil
--
Ales Musil
Senior Software Engineer - OVN Core
Red Hat EMEA <https://www.redhat.com>
amu...@redhat.com
<https://red.ht/sig>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
The memory usage would be increased for size of sb_addrset_ref
struct, but decreased for the size of the struct + the name.
That would slowly lead to underflows in some cases.
Reported-at: https://issues.redhat.com/browse/FDP-507
Signed-off-by: Ales Musil
---
controller/ofctrl.c | 10
|| ip4.dst == $as2"
The memory impact should be minimal as there is only increase of 8 bytes
per the struct expr_constant.
Signed-off-by: Ales Musil
---
controller/lflow.c | 4 +-
include/ovn/actions.h | 2 +-
include/ovn/expr.h | 46 ++--
lib/actions.c |
On Tue, Mar 19, 2024 at 5:43 PM Ales Musil wrote:
> Instead of tracking address set per struct expr_constant_set track it
> per individual struct expr_constant. This allows more fine grained
> control for I-P processing of address sets in controller. It helps with
> scenarios like
On Tue, Mar 19, 2024 at 6:03 PM Ilya Maximets wrote:
> On 3/19/24 17:43, Ales Musil wrote:
> > Instead of tracking address set per struct expr_constant_set track it
> > per individual struct expr_constant. This allows more fine grained
> > control for I-P processing of addre
erly
waits for the "listening" state, at the same time redirects
the stderr into separate file.
Signed-off-by: Ales Musil
Signed-off-by: Dumitru Ceara
(cherry picked from commit e8ac18104df0bbd6579d8c62fd4282939631b878)
---
tests/system-common-macros.at | 25 +++--
tests/system-ov
erly
waits for the "listening" state, at the same time redirects
the stderr into separate file.
Signed-off-by: Ales Musil
Signed-off-by: Dumitru Ceara
(cherry picked from commit e8ac18104df0bbd6579d8c62fd4282939631b878)
---
tests/system-common-macros.at | 29 ++--
tests/system-ov
expect it to and avoid
checking kill of server that might be already finished.
[0] https://github.com/nmap/nmap/issues/1223
Signed-off-by: Ales Musil
Signed-off-by: Dumitru Ceara
(cherry picked from commit 0a35824093ddcd774544ec696dc8fe8c279fb603)
---
tests/system-ovn-kmod.at | 5 +++--
1 file
able Formatting Options in addition to the the
> +command-specific options.
>
>
>exit
> --
> 2.40.1
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
&
expect it to and avoid
checking kill of server that might be already finished.
[0] https://github.com/nmap/nmap/issues/1223
Signed-off-by: Ales Musil
Signed-off-by: Dumitru Ceara
(cherry picked from commit 0a35824093ddcd774544ec696dc8fe8c279fb603)
---
tests/system-ovn-kmod.at | 5 +++--
1 file
erly
waits for the "listening" state, at the same time redirects
the stderr into separate file.
Signed-off-by: Ales Musil
Signed-off-by: Dumitru Ceara
(cherry picked from commit e8ac18104df0bbd6579d8c62fd4282939631b878)
---
tests/system-common-macros.at | 29 ++--
tests/system-ov
gt; external_ids:ovn-installed` = '"true"'])
> +
> +# Create floating IP. SB should be read-only, so we should be enable to
> update MAC_Bindings now.
> +check ovn-nbctl --wait=sb lr-nat-add lr0 dnat_and_snat 172.24.4.100
> 10.0.0.10
> +
> +# Restarting upda
t);
> --
> 2.31.1
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Looks good to me, thanks.
Acked-by: Ales Musil
--
Ales Musil
Senior Software Engineer - OVN Core
t_commit { ct_mark=value[/mask];
>> };
>> ct_commit { ct_label=value[/mask];
>> };
>> ct_commit { ct_mark=value[/mask];
>> ct_label=value[/mask]; };
>> +ct_commit(snat);
>> +ct_commit(dnat);
>>
>>
>> Commit the flow to the connection tracking entry associated
>> with it
>> @@ -1421,6 +1423,14 @@
>> in order to have specific bits set.
>>
>>
>> +
>> +In Logical Router Datapath, parameters
>> ct_commit(snat)
>> +or ct_commit(dnat) can be used to explicitly
>> specify
>> +into which zone should be connection committed. Without this
>> +parameter, the connection is committed to the default zone
>> for the
>> +Datapath. These parameters have no effect in Logical Switch
>> Datapath.
>> +
>> +
>>
>> Note that if you want processing to continue in the next
>> table,
>> you must execute the next action after
>> diff --git a/tests/ovn.at b/tests/ovn.at
>> index d26c95054..11e6430ed 100644
>> --- a/tests/ovn.at
>> +++ b/tests/ovn.at
>> @@ -1349,6 +1349,13 @@ ct_commit(ct_label=18446744073709551615);
>> ct_commit(ct_label=18446744073709551616);
>> Decimal constants must be less than 2**64.
>>
>> +ct_commit(dnat);
>> +encodes as ct(commit,zone=NXM_NX_REG13[0..15])
>> +has prereqs ip
>> +ct_commit(snat);
>> +encodes as ct(commit,zone=NXM_NX_REG13[0..15])
>> +has prereqs ip
>> +
>> ct_mark = 12345
>> Field ct_mark is not modifiable.
>> ct_label = 0xcafe
>> --
>> 2.40.1
>>
>>
>
> --
> Best Regards,
> Martin Kalcok.
>
In general this patch looks fine, however there we still require to make
the decision around ct_commit_v1.
Thanks,
Ales
--
Ales Musil
Senior Software Engineer - OVN Core
Red Hat EMEA <https://www.redhat.com>
amu...@redhat.com
<https://red.ht/sig>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ct_snat | ovn_strip_lflows],
>>> [0], [dnl
>>> + table=??(lr_out_snat), priority=161 , match=(ip && ip4.dst
>>> == 20.0.0.10 && inport == "DR-S1" && is_chassis_resident("cr-DR-S1")),
>>> action=(ct_snat;
is a good reason that we should, I'm willing to hear it.
>
I think it's fine, I didn't realize the maintenance mode.
> On 3/20/24 06:13, Ales Musil wrote:
> > The way how tcpdump was called in tests was inconsistent,
> > a lot fo the tests didn't even w
t; +cd ovs
> >> ./boot.sh
> >> -cd _gcc
> >> -../configure --localstatedir="/var" --sysconfdir="/etc"
> >> --prefix="/usr" \
> >> +./configure --localstatedir="/var" --sysconfdir="/etc" --prefix="/us
the current user and group instead of the hardcoded root.
At the same time remove the ovs-user option as it was not used for
anything and might be confusing.
Reported-at: https://issues.redhat.com/browse/FDP-245
Signed-off-by: Ales Musil
---
utilities/ovn-ctl | 5 ++---
utilities/ovn-ctl.8
@ -10205,9 +10205,8 @@ check ovn-nbctl --wait=hv set QoS $qos_id
> bandwidth=rate=100
> # check at hv with a qos meter table
> AT_CHECK([as hv ovs-ofctl dump-meters br-int -O OpenFlow13 | grep
> rate=100 | wc -l], [0], [1
> ])
> -AT_CHECK([as hv ovs-ofctl dump-flows br-int -O OpenFlow13 | grep m
sleep_controller hv1
>
> --
> 2.42.0
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Thanks,
Ales
--
Ales Musil
Senior Software Engineer - OVN Core
Re
; +encodes as controller(userdata=00.00.00.07.00.00.00.00.03.06)
> log(verdict=bad_verdict, severity=info);
> Syntax error at `bad_verdict' unknown verdict.
> log(verdict=drop, severity=bad_severity);
> --
> 2.44.0
>
> __
On Tue, Mar 26, 2024 at 7:09 PM Mark Michelson wrote:
> On 3/25/24 05:09, Ales Musil wrote:
> >
> >
> > On Mon, Mar 25, 2024 at 9:47 AM Dumitru Ceara > <mailto:dce...@redhat.com>> wrote:
> >
> > On 3/22/24 19:34, Mark Michelson wrote:
>
On Wed, Mar 27, 2024 at 7:14 AM Han Zhou wrote:
>
>
> On Tue, Mar 19, 2024 at 9:45 AM Ales Musil wrote:
> >
> >
> >
> > On Tue, Mar 19, 2024 at 5:43 PM Ales Musil wrote:
> >>
> >> Instead of tracking address set per struct expr_constant_se
actions.
[0] c560f6ca3257 ("ofproto-dpif-xlate: Fix continuations with associated
metering.")
Reported-at: https://issues.redhat.com/browse/FDP-438
Signed-off-by: Ales Musil
---
controller/mac-learn.c | 30 +
controller/mac-learn.h | 9 ++--
controller/pinctr
> + DUMP_FLOWS([$sbox], [flows-$hv-2])
> + diff flows-$hv-1 flows-$hv-2 > flow-diff
> + AT_CHECK([test $(diff flows-$hv-1 flows-$hv-2 | wc -l) == 0])
> +fi
> +])
> +
> # OVN_CLEANUP_CONTROLLER(sbox)
> #
> # Gracefully terminate ovn-controller in the specified
> --
&g
; tests/ofproto-macros.at
>
> TESTSUITE_AT = \
> --
> 2.31.1
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Ran into this multiple times, but always forgot to fix it,
ity 0;
> policy accept; }'
> + nft add rule ip ovn-test INPUT tcp dport $TCP_PORT counter drop
> +}
>
nit: Missing new line.
> +restart_ovsdb_controller_updates() {
> + TCP_PORT=$1
> + echo Restarting updates from ovn-controller to ovsdb
> + nft list ruleset | grep $TC
; +# Create floating IP. SB should be read-only, so we should be enable to
> update MAC_Bindings now.
>
s/should/shouldn't/
> +check ovn-nbctl --wait=sb lr-nat-add lr0 dnat_and_snat 172.24.4.100
> 10.0.0.10
> +
> +# Restarting updates.
> +restart_ovsdb_controller_updates $TC
eq);
>
> latch_wait(&pctrl->pinctrl_thread_exit);
> --
> 2.31.1
>
>
Looks good to me, thanks.
Acked-by: Ales Musil
--
Ales Musil
Senior Software Engineer - OVN Core
Red Hat EMEA <https://www.redhat.com>
amu...@redhat.com
<https://red.ht/sig>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/browse/FDP-243
Signed-off-by: Ales Musil
---
NEWS| 6 +++
controller/ofctrl.c | 10 +
controller/ofctrl.h | 5 ++-
controller/ovn-controller.8.xml | 12 ++
controller/ovn-controller.c | 68 ++---
controller
org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Other than those minor things it looks good, let's wait with v3 as I think
maintainers might be willing to amend those changes in during merge.
Acked-by: Ales Musil
--
Ales Musil
Senior Software Engineer - OVN Co
os meter table
> AT_CHECK([as hv ovs-ofctl dump-meters br-int -O OpenFlow13 | grep
> rate=100 | wc -l], [0], [1
> ])
> -AT_CHECK([as hv ovs-ofctl dump-flows br-int -O OpenFlow13 | grep meter |
> wc -l], [0], [1
> +AT_CHECK([as hv ovs-ofctl dump-flows br-int -O OpenFlow13 | grep me
tion that doesn't
leave the host at all (container network). In those examples it should be
reliable enough, but in the end the user should know the best if and when
to use the probe.
> On 3/28/24 04:53, Ales Musil wrote:
> > The br-int connection is hardcoded to use unix socket, w
actions.
[0] c560f6ca3257 ("ofproto-dpif-xlate: Fix continuations with associated
metering.")
Reported-at: https://issues.redhat.com/browse/FDP-439
Signed-off-by: Ales Musil
Acked-by: Mark Michelson
---
v2: Fix the Jira link and add ack from Mark.
---
controller/mac-le
On Tue, Apr 2, 2024 at 2:47 PM Mark Michelson wrote:
> On 4/2/24 01:50, Ales Musil wrote:
> >
> >
> > On Mon, Apr 1, 2024 at 10:36 PM Mark Michelson > <mailto:mmich...@redhat.com>> wrote:
> >
> > Hi Ales,
> >
> > I have s
On Tue, Apr 2, 2024 at 3:02 PM Ilya Maximets wrote:
> On 3/28/24 09:53, Ales Musil wrote:
> > The br-int connection is hardcoded to use unix socket, which requires
> > for the socket to be visible for ovn-controller. This is achievable in
> > container by mounting the so
On Tue, Apr 2, 2024 at 4:03 PM Ilya Maximets wrote:
> On 4/2/24 15:36, Ales Musil wrote:
> >
> >
> > On Tue, Apr 2, 2024 at 3:02 PM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
> >
> > On 3/28/24 09:53, Ales Musil wrote:
> > > Th
On Tue, Apr 2, 2024 at 4:25 PM Ilya Maximets wrote:
> On 4/2/24 16:17, Ales Musil wrote:
> >
> >
> > On Tue, Apr 2, 2024 at 4:03 PM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
> >
> > On 4/2/24 15:36, Ales Musil wrote:
> > >
>
3[[0..15]],exec(set_field:0x16151413121110090807060504030201->ct_label))
> -has prereqs ip
> + Syntax error at `(' expecting `;'.
>
>
> ct_commit(ct_label=0x100/0x100);
> -encodes as
> ct(commit,zone=NXM_NX_REG13[[0..1
: https://issues.redhat.com/browse/FDP-243
Signed-off-by: Ales Musil
---
v2: Rebase on top of current main.
Make the probe interval accept milliseconds to be aligned with other probe
intervals.
Use external-ids instead of options for the ovn-controller.
---
NEWS
On Thu, Apr 4, 2024 at 9:56 PM Mark Michelson wrote:
> Hi Ales,
>
> The patch looks good to me except for one problem.
>
> On 4/3/24 04:53, Ales Musil wrote:
> > The br-int connection is hardcoded to use unix socket, which requires
> > for the socket to be visible
: https://issues.redhat.com/browse/FDP-243
Signed-off-by: Ales Musil
---
v3: Rebase on top of current main.
Fix the copy-paste error in ovn-controller documentation.
v2: Rebase on top of current main.
Make the probe interval accept milliseconds to be aligned with other probe
intervals
port ?
>
Hi Numan,
yes please, it should be backported to all supported branches if possible.
> Numan
>
>
>> On 3/25/24 06:40, Ales Musil wrote:
>> > The ovn-ctl utility was assuming that the user/group is always root,
>> > when not specified otherwise by the
On Fri, Apr 5, 2024 at 10:35 PM Numan Siddique wrote:
>
>
> On Tue, Apr 2, 2024 at 2:28 AM Ales Musil wrote:
>
>> The current packet injection loses ct_state in the process. When
>> the ct_state is lost we might commit to DNAT zone and perform
>> zero SNAT af
It might happen that the microflow doesn't have port specified or
the port is part of different datapath. In that case ovn-trace would
print warning and move to later crash on assert. Exit early instead
of crashing on assert.
Signed-off-by: Ales Musil
---
utilities/ovn-trace.c | 2 +-
1
There was recent switch in OvS from master to main branch.
Use main instead in ovn-fake-mutlinode tests.
Signed-off-by: Ales Musil
---
.github/workflows/ovn-fake-multinode-tests.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/ovn-fake-multinode
jobs using
ovn-fake-multinode.")
Signed-off-by: Ales Musil
---
.github/workflows/ovn-fake-multinode-tests.yml | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/.github/workflows/ovn-fake-multinode-tests.yml
b/.github/workflows/ovn-fake-multinode-tests.yml
iated
metering.")
Reported-at: https://issues.redhat.com/browse/FDP-439
Signed-off-by: Ales Musil
---
v4: Add flag to ensure that the paused action works during upgrade.
v3: Rebase on top of main.
v2: Fix the Jira link and add ack from Mark.
---
controller/lflow.c | 1 +
controll
On Tue, Apr 9, 2024 at 5:54 PM Numan Siddique wrote:
>
>
> On Tue, Apr 9, 2024, 7:46 AM Dumitru Ceara wrote:
>
>> On 4/8/24 09:19, Ales Musil wrote:
>> > On Fri, Apr 5, 2024 at 10:35 PM Numan Siddique wrote:
>> >
>> >>
>> >
There was recent switch in OvS from master to main branch.
Use main in all the references across OVN code base.
Signed-off-by: Ales Musil
---
v2: Add the missing two references.
---
.github/workflows/ovn-fake-multinode-tests.yml | 4 ++--
Documentation/tutorials/ovn-sandbox.rst| 2
601 - 700 of 1603 matches
Mail list logo
