Ilya, I'm not yet familiar with the test syntax in .at file, but the rest of
the series looks good.
Regards,
Asaf Penso
> -Original Message-
> From: Ilya Maximets
> Sent: Wednesday, February 20, 2019 2:47 PM
> To: ovs-dev@openvswitch.org; Ian Stokes
> Cc: Flavio Leitn
Looks good, I would consider adding a default case for the switch with an
appropriate message.
Regards,
Asaf Penso
> -Original Message-
> From: Ilya Maximets
> Sent: Wednesday, February 6, 2019 5:41 PM
> To: ovs-dev@openvswitch.org; Ian Stokes
> Cc: Asaf Penso ;
I see that now, thanks. I agree with you and I'm fine with this v2.
Regards,
Asaf Penso
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, February 19, 2019 12:54 PM
> To: Asaf Penso ; ovs-dev@openvswitch.org; Ian
> Stokes
> Cc: Roni Bar Yanai ; Ophir Mun
Regards,
Asaf Penso
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Flavio Leitner
> Sent: Friday, February 15, 2019 8:59 PM
> To: Ilya Maximets
> Cc: ovs-dev@openvswitch.org; Roni Bar Yanai
> Subject: Re: [o
Regards,
Asaf Penso
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Ilya Maximets
> Sent: Friday, February 15, 2019 3:07 PM
> To: ovs-dev@openvswitch.org; Ian Stokes
> Cc: Roni Bar Yanai ; Flavio Leitner
> ; Ily
Regards,
Asaf Penso
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, February 18, 2019 2:10 PM
> To: Asaf Penso ; ovs-dev@openvswitch.org; Ian
> Stokes
> Cc: Roni Bar Yanai ; Flavio Leitner
>
> Subject: Re: [ovs-dev] [PATCH v4 3/9] dp-packet:
of the result, the
rte_flow_item is being memset.
The patch moves the memset function only if the condition of the
wildcard is true, thus saving cycles of memset if not needed.
Signed-off-by: Asaf Penso
---
lib/netdev-dpdk.c | 28 ++--
1 file changed, 14 insertions(+), 14
Regards,
Asaf Penso
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, February 5, 2019 1:46 PM
> To: Asaf Penso ; ovs-dev@openvswitch.org
> Cc: Roni Bar Yanai ; Stokes, Ian
> ; Finn Christensen
> Subject: Re: [ovs-dev,v2] netdev-dpdk: Memset rte_flow_i
Regards,
Asaf Penso
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, February 4, 2019 5:41 PM
> To: Asaf Penso ; ovs-dev@openvswitch.org
> Cc: Roni Bar Yanai ; Stokes, Ian
>
> Subject: Re: [ovs-dev] netdev-dpdk: Memset rte_flow_item on a need basis.
>
of the result, the
rte_flow_item is being memset.
The patch moves the memset function only if the condition of the
wildcard is true, thus saving cycles of memset if not needed.
Signed-off-by: Asaf Penso
---
v2 update coding-style compliant for sizeof operator
---
lib/netdev-dpdk.c | 36
Regards,
Asaf Penso
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, February 4, 2019 4:14 PM
> To: Asaf Penso ; ovs-dev@openvswitch.org
> Cc: Roni Bar Yanai ; Stokes, Ian
>
> Subject: Re: [ovs-dev] netdev-dpdk: Memset rte_flow_item on a need basis.
>
11 matches
Mail list logo
